From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 07:38:57 2014 Received: (at submit) by debbugs.gnu.org; 1 Jan 2014 12:38:57 +0000 Received: from localhost ([127.0.0.1]:55818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VyL4Z-0002fK-Kb for submit@debbugs.gnu.org; Wed, 01 Jan 2014 07:38:56 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57398) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VyL4V-0002fA-Ic for submit@debbugs.gnu.org; Wed, 01 Jan 2014 07:38:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VyL4L-0003v7-Tw for submit@debbugs.gnu.org; Wed, 01 Jan 2014 07:38:51 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_FRT_PACKAGE autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57377) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VyL4L-0003v3-Qn for submit@debbugs.gnu.org; Wed, 01 Jan 2014 07:38:41 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59113) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VyL4E-0002Bc-EB for bug-gnu-emacs@gnu.org; Wed, 01 Jan 2014 07:38:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VyL46-0003t8-98 for bug-gnu-emacs@gnu.org; Wed, 01 Jan 2014 07:38:34 -0500 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.226]:33908 helo=cdptpa-oedge-vip.email.rr.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VyL46-0003sU-4D for bug-gnu-emacs@gnu.org; Wed, 01 Jan 2014 07:38:26 -0500 Received: from [75.87.81.6] ([75.87.81.6:50219] helo=TAKVER) by cdptpa-oedge02 (envelope-from ) (ecelerity 3.5.0.35861 r(Momo-dev:tip)) with ESMTP id 25/17-02681-E3C04C25; Wed, 01 Jan 2014 12:38:23 +0000 Date: Wed, 01 Jan 2014 06:38:19 -0600 Message-Id: <85mwjf5138.fsf@stephe-leake.org> From: stephen_leake@stephe-leake.org To: bug-gnu-emacs@gnu.org Subject: 24.3; package-delete does not update package-alist X-RR-Connecting-IP: 107.14.168.130:25 X-Cloudmark-Score: 0 X-detected-operating-system: by eggs.gnu.org: BaiduSpider X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) package-delete does not update package-alist This means that package-installed-p will still return true after package-delete deletes the package. In GNU Emacs 24.3.1 (i386-mingw-nt6.1.7601) of 2013-03-17 on MARVIN Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --with-gcc (4.7) --cflags -ID:/devel/emacs/libs/libXpm-3.5.8/include -ID:/devel/emacs/libs/libXpm-3.5.8/src -ID:/devel/emacs/libs/libpng-dev_1.4.3-1/include -ID:/devel/emacs/libs/zlib-dev_1.2.5-2/include -ID:/devel/emacs/libs/giflib-4.1.4-1/include -ID:/devel/emacs/libs/jpeg-6b-4/include -ID:/devel/emacs/libs/tiff-3.8.2-1/include -ID:/devel/emacs/libs/gnutls-3.0.9/include -ID:/devel/emacs/libs/libiconv-1.13.1-1-dev/include -ID:/devel/emacs/libs/libxml2-2.7.8/include/libxml2' Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: cp1252 default enable-multibyte-characters: t Major mode: Package Menu Minor modes in effect: shell-dirtrack-mode: t diff-auto-refine-mode: t display-time-mode: t delete-selection-mode: t tooltip-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Recent input: r s i o n - t o - l i s t SPC a d a - v e r s i o n ) C-SPC w i s i M-w C-SPC M-q a d a w i s i SPC . M-w g g ~ / e . e m . e l p a C-s p a c k a g e - i n s t a l l e d C-s C-s p a c k a e g e - d e l e t e C-u C-c p C-u C-c p n o C-s b u g C-SPC M-x C-h k U C-h k ~ M-x r e p o r t - b u p a c k a g e - e d e l e t e SPC d o e s SPC n o t SPC u p d a t e SPC C-r o n m s t a i n s t a l l e d - p C-r C-g M-x Recent messages: Go... string-equal: Wrong type argument: stringp, nil t Mark saved where search started [3 times] Mark set Saving file c:/home/stephe/.emacs.d/elpa/archives/test/archive-contents... Wrote c:/home/stephe/.emacs.d/elpa/archives/test/archive-contents 1 package can be upgraded; type `U' to mark it for upgrading. Type C-x 1 to delete the help window. Quit Load-path shadows: c:/Projects/emacs_stephe.work/emacs_stephe_site_lisp/vc-git hides c:/Apps/emacs-24.3/lisp/vc/vc-git c:/Projects/org.emacs.ada-mode.stephe-1/ada-mode hides c:/Apps/emacs-24.3/lisp/progmodes/ada-mode c:/Projects/emacs_stephe.work/emacs_stephe_site_lisp/nnnil hides c:/Apps/emacs-24.3/lisp/gnus/nnnil Features: (shadow sort mail-extr emacsbug message format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mailabbrev gmm-utils mailheader sendmail thingatpt browse-url info apropos texnfo-upd else-mode texinfo autoload tar-mode mail-utils network-stream starttls url-http tls mail-parse rfc2231 rfc2047 rfc2045 ietf-drums url-gw url-cache url-auth url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap finder-inf gnat-inspect ada-skel ada-skeletons skeleton ada-xref-tool ada-gnat-xref ada-compiler ada-gnat-compile gnat-core ada-indent-engine ada-wisi ada-indent-user-options ada-grammar-wy wisi-compile semantic/wisent/comp wisi wisi-parse semantic/wisent semantic/wisent/wisent semantic/util-modes semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local cedet ada-fix-error ada-build ada-mode which-func imenu align find-file dvc-state dvc-persistence xmtn-sync tabify man xgit-dvc xgit cus-edit xgit-annotate rect dvc-annotate xgit-log sh-script smie executable find-func xmtn-multi-status xmtn-revlist dvc-revlist warnings dvc-config copyright misearch multi-isearch make-mode shell pcomplete grep help-mode xmtn-dvc dvc-status dvc-diff dvc-fileinfo diff-mode xmtn-conflicts xmtn-ids xmtn-match xmtn-automate xmtn-compat parse-time xmtn-run xmtn-basic-io xmtn-base xgit-core bzr-core xmtn-minimal dvc-log log-edit pcvs-util vc vc-dispatcher ediff-merg ediff-diff ediff-wind ediff-help ediff-util ediff-mult ediff-init ediff add-log dvc-autoloads dvc-unified dvc-tips ffap url-parse auth-source eieio byte-opt bytecomp byte-compile cconv gnus-util mm-util mail-prsvr password-cache url-vars dvc-core edebug dvc-lisp dvc-buffers derived dvc-ui dvc-register dvc-utils dvc-emacs ewoc dvc-defs dvc-site uniquify advice help-fns advice-preload time delsel cus-start cus-load color-theme cl-macs gv edmacro kmacro wid-edit cl cl-lib noutline outline easy-mmode iswitchb whitespace dired-x easymenu dired-aux dired compile comint ansi-color ring ada-mode-autoloads wisi-autoloads package time-date tooltip ediff-hook vc-hooks lisp-float-type mwheel dos-w32 ls-lisp w32-common-fns disp-table w32-win w32-vars tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process w32 multi-tty emacs) From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 01 16:12:31 2014 Received: (at 16313) by debbugs.gnu.org; 1 Jan 2014 21:12:31 +0000 Received: from localhost ([127.0.0.1]:56593 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VyT5b-00085C-DU for submit@debbugs.gnu.org; Wed, 01 Jan 2014 16:12:31 -0500 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.225]:46194 helo=cdptpa-oedge-vip.email.rr.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VyT5a-000853-1z for 16313@debbugs.gnu.org; Wed, 01 Jan 2014 16:12:30 -0500 Received: from [75.87.81.6] ([75.87.81.6:51424] helo=TAKVER) by cdptpa-oedge03 (envelope-from ) (ecelerity 3.5.0.35861 r(Momo-dev:tip)) with ESMTP id 44/73-08839-CB484C25; Wed, 01 Jan 2014 21:12:29 +0000 From: Stephen Leake To: 16313@debbugs.gnu.org Subject: additional info Date: Wed, 01 Jan 2014 15:12:26 -0600 Message-ID: <85iou34dad.fsf@stephe-leake.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (windows-nt) MIME-Version: 1.0 Content-Type: text/plain X-RR-Connecting-IP: 107.14.168.142:25 X-Cloudmark-Score: 0 X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 16313 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) May be related to 15918 -- -- Stephe From debbugs-submit-bounces@debbugs.gnu.org Thu Jan 02 23:20:27 2014 Received: (at 16313) by debbugs.gnu.org; 3 Jan 2014 04:20:28 +0000 Received: from localhost ([127.0.0.1]:58971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VywFH-0004VQ-DT for submit@debbugs.gnu.org; Thu, 02 Jan 2014 23:20:27 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:53758) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VywFF-0004VI-7g for 16313@debbugs.gnu.org; Thu, 02 Jan 2014 23:20:25 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFsr+l6/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA2IQgbBLY1hgykDiGGJegOSHIFegxU X-IPAS-Result: Av4EABK/CFFsr+l6/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA2IQgbBLY1hgykDiGGJegOSHIFegxU X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="43831159" Received: from 108-175-233-122.dsl.teksavvy.com (HELO pastel.home) ([108.175.233.122]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 02 Jan 2014 23:20:24 -0500 Received: by pastel.home (Postfix, from userid 20848) id 47E146006A; Thu, 2 Jan 2014 23:20:24 -0500 (EST) From: Stefan Monnier To: stephen_leake@stephe-leake.org Subject: Re: bug#16313: 24.3; package-delete does not update package-alist Message-ID: References: <85mwjf5138.fsf@stephe-leake.org> Date: Thu, 02 Jan 2014 23:20:24 -0500 In-Reply-To: <85mwjf5138.fsf@stephe-leake.org> (stephen leake's message of "Wed, 01 Jan 2014 06:38:19 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 16313 Cc: 16313@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > package-delete does not update package-alist [...] > In GNU Emacs 24.3.1 (i386-mingw-nt6.1.7601) The package-delete code in Emacs's trunk includes: ;; Update package-alist. (let* ((name (package-desc-name pkg-desc))) (delete pkg-desc (assq name package-alist))) So I suspect that this bug is already fixed in the trunk. Can you check that it's indeed the case? And if it's not, please provide a recipe to reproduce the problem, Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 07 07:06:59 2014 Received: (at 16313-done) by debbugs.gnu.org; 7 Jan 2014 12:06:59 +0000 Received: from localhost ([127.0.0.1]:40306 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0VQx-0007XY-4J for submit@debbugs.gnu.org; Tue, 07 Jan 2014 07:06:59 -0500 Received: from mail-we0-f170.google.com ([74.125.82.170]:48723) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0VQu-0007X3-3N for 16313-done@debbugs.gnu.org; Tue, 07 Jan 2014 07:06:56 -0500 Received: by mail-we0-f170.google.com with SMTP id w61so53814wes.1 for <16313-done@debbugs.gnu.org>; Tue, 07 Jan 2014 04:06:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:date:references:user-agent :message-id:mime-version:content-type; bh=6H+TeY7umoIzz/C+2ypE72PpMOJMb4jI5w2IX708zxI=; b=oMNO37+OkKa1CHeR8sd+vzYjck8fczWVVcIGuTKj+4X6o8Oeq8ba0TeA24LUcpsaPO 2UbOUR4dWtHWOAZA3clHWwXllu4g9R5r9rs/CN7EjeK6MQQO3GG0hcVBLeOUSpcQnSVT 3gUYHmnwT00psAfzSp7FI2kR39r6a8m4jQGCtbgnJKh60oeuWuQD0+v7pEb6ZOUklqfd HU2EyP16bfQD7tJXdhpK7vTvXZ6lywapt62FdCyJrpdzRI1PZzhr3Lv7bTKjIIts2V6+ PlzBTGftv7Dsr+yaz4xeGluAZ4Xik05QDxsMlnriHpeMzQj72WaThmHNWr41WwhcIEgm Yxmw== X-Received: by 10.194.85.75 with SMTP id f11mr7771242wjz.47.1389096415382; Tue, 07 Jan 2014 04:06:55 -0800 (PST) Received: from bzg.localdomain (241-104-190-109.dsl.ovh.fr. [109.190.104.241]) by mx.google.com with ESMTPSA id y8sm11781732wje.12.2014.01.07.04.06.53 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Jan 2014 04:06:53 -0800 (PST) Received: by bzg.localdomain (Postfix, from userid 1000) id 2ACB41C2074B; Tue, 7 Jan 2014 13:06:52 +0100 (CET) From: Bastien Guerry To: Stefan Monnier Subject: Re: bug#16313: 24.3; package-delete does not update package-alist In-Reply-To: (Stefan Monnier's message of "Thu, 02 Jan 2014 23:20:24 -0500") Date: Tue, 07 Jan 2014 11:57:27 +0100 References: <85mwjf5138.fsf@stephe-leake.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) Message-ID: <87iotwhu77.fsf@bzg.ath.cx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 16313-done Cc: stephen_leake@stephe-leake.org, 16313-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Stefan Monnier writes: > The package-delete code in Emacs's trunk includes: > > ;; Update package-alist. > (let* ((name (package-desc-name pkg-desc))) > (delete pkg-desc (assq name package-alist))) > > So I suspect that this bug is already fixed in the trunk. > Can you check that it's indeed the case? I just checked, this is the case. Still, package-delete did not cleanly delete the package from package-alist, only its description. I pushed a fix to cleanly remove the package occurrence. Closing this bug. From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 07 17:08:40 2014 Received: (at 16313) by debbugs.gnu.org; 7 Jan 2014 22:08:40 +0000 Received: from localhost ([127.0.0.1]:41617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0epD-0004qk-T4 for submit@debbugs.gnu.org; Tue, 07 Jan 2014 17:08:40 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:42115) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0epC-0004qc-6f for 16313@debbugs.gnu.org; Tue, 07 Jan 2014 17:08:38 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1W0epB-0000nF-0N; Tue, 07 Jan 2014 17:08:37 -0500 From: Glenn Morris To: 16313@debbugs.gnu.org Subject: Re: bug#16313: 24.3; package-delete does not update package-alist References: <85mwjf5138.fsf@stephe-leake.org> <87iotwhu77.fsf@bzg.ath.cx> X-Spook: bootleg Steve Case AVN satellite imagery Watergate jihad X-Ran: ]/J"0r*l|bcTe6'bOU"_(QskXx|ls>#^qKj&]&uC@jh!ZV?/J%e)at~'S]Jx|afMKF\U\v X-Hue: cyan X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 07 Jan 2014 17:08:36 -0500 Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 16313 Cc: bzg@altern.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Bastien Guerry wrote: > Still, package-delete did not cleanly delete the package from > package-alist, only its description. _Should_ it remove the entire entry? It's not obvious to me, given eg the way package-installed-p works. > I pushed a fix to cleanly remove the package occurrence. - (delete pkg-desc (assq name package-alist))) + (delete (delete pkg-desc (assq name package-alist)) package-alist)) That doesn't work for the first item in the list. Why not the more obvious (setq package-alist (delete (assq name package-alist) package-alist)) From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 07 17:09:26 2014 Received: (at control) by debbugs.gnu.org; 7 Jan 2014 22:09:26 +0000 Received: from localhost ([127.0.0.1]:41621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0epy-0004sN-7b for submit@debbugs.gnu.org; Tue, 07 Jan 2014 17:09:26 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:42129) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0epv-0004sC-LH for control@debbugs.gnu.org; Tue, 07 Jan 2014 17:09:24 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1W0epv-0000qW-C0 for control@debbugs.gnu.org; Tue, 07 Jan 2014 17:09:23 -0500 Date: Tue, 07 Jan 2014 17:09:23 -0500 Message-Id: Subject: control message for bug 16313 To: X-Mailer: mail (GNU Mailutils 2.1) From: Glenn Morris X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) fixed 16313 24.4 From debbugs-submit-bounces@debbugs.gnu.org Tue Jan 07 18:08:18 2014 Received: (at 16313) by debbugs.gnu.org; 7 Jan 2014 23:08:18 +0000 Received: from localhost ([127.0.0.1]:41653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0fkw-0007fD-8E for submit@debbugs.gnu.org; Tue, 07 Jan 2014 18:08:18 -0500 Received: from mail-we0-f175.google.com ([74.125.82.175]:39291) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0fkt-0007f2-8u for 16313@debbugs.gnu.org; Tue, 07 Jan 2014 18:08:16 -0500 Received: by mail-we0-f175.google.com with SMTP id w62so773885wes.20 for <16313@debbugs.gnu.org>; Tue, 07 Jan 2014 15:08:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=SKLvC0HUrFu7nbbtQVODBWrrcU/Jwc4TF1Y0FeZFyaU=; b=Bi3rRIf5YArtROIu6AGXk1hTBROW4tt/comLtgKMKDRxLsBi0ZlHBC0ffxbS0/s7hn Fw91AboeOeDGFllj+pV6fLDaNGamaMIl/tPWyFQBc6Qri/kKCJwiiCRbw33r90fRuXLq 4oavK2zavhZPCPF08QQRd70Rz9QJSj9kmQ4W+Da06wW9aj6btfPdk4qnmZszvOvo0ln1 bbj8rAdYaG1WcIrnBEdyXltOKVaBvzEyDYPpkRSHNRyi9mk+X9CwF8yOHQNVm1nPdvZm r8ElBAWQcEBlmczbAisyVgEoFucpPt1KsSCyQtj2adej2k1stBWKLnpBn+bpyj3JZCJK QI/Q== X-Received: by 10.194.178.135 with SMTP id cy7mr24655297wjc.21.1389136094456; Tue, 07 Jan 2014 15:08:14 -0800 (PST) Received: from bzg.localdomain (mar75-2-81-56-68-112.fbx.proxad.net. [81.56.68.112]) by mx.google.com with ESMTPSA id po3sm46639489wjc.3.2014.01.07.15.08.12 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Jan 2014 15:08:13 -0800 (PST) Received: by bzg.localdomain (Postfix, from userid 1000) id A7E091C20717; Wed, 8 Jan 2014 00:08:09 +0100 (CET) From: Bastien To: Glenn Morris Subject: Re: bug#16313: 24.3; package-delete does not update package-alist In-Reply-To: (Glenn Morris's message of "Tue, 07 Jan 2014 17:08:36 -0500") References: <85mwjf5138.fsf@stephe-leake.org> <87iotwhu77.fsf@bzg.ath.cx> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) Date: Wed, 08 Jan 2014 00:08:09 +0100 Message-ID: <87bnzncrvq.fsf@bzg.ath.cx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 16313 Cc: Tom Tromey , 16313@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Glenn Morris writes: > Bastien Guerry wrote: > >> Still, package-delete did not cleanly delete the package from >> package-alist, only its description. > > _Should_ it remove the entire entry? It's not obvious to me, given eg > the way package-installed-p works. Tom may confirm or infirm this, but I think it should. The fact that package-installed-p checks for the description seems due to the min-version parameter, and indeed, IMO the function should be first checking for the package name before its description. >> I pushed a fix to cleanly remove the package occurrence. > > - (delete pkg-desc (assq name package-alist))) > + (delete (delete pkg-desc (assq name package-alist)) package-alist)) > > That doesn't work for the first item in the list. > Why not the more obvious > > (setq package-alist (delete (assq name package-alist) package-alist)) No reason, the above is better. Should I fix this or wait for Tom's feedback? -- Bastien From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 08 00:10:48 2014 Received: (at 16313) by debbugs.gnu.org; 8 Jan 2014 05:10:49 +0000 Received: from localhost ([127.0.0.1]:41925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0lPk-0004w9-N1 for submit@debbugs.gnu.org; Wed, 08 Jan 2014 00:10:48 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:56703) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0lPj-0004w1-5n for 16313@debbugs.gnu.org; Wed, 08 Jan 2014 00:10:47 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1W0lPg-0001HN-U6; Wed, 08 Jan 2014 00:10:44 -0500 From: Glenn Morris To: Bastien Subject: Re: bug#16313: 24.3; package-delete does not update package-alist References: <85mwjf5138.fsf@stephe-leake.org> <87iotwhu77.fsf@bzg.ath.cx> <87bnzncrvq.fsf@bzg.ath.cx> X-Spook: Ft. Knox War on Terrorism satellite imagery terrorist X-Ran: K8(H(0!S9mW>i/lxXnF;SRSmDR:yI6NO@fW4L^mk)./G1nke]qO@mzKm&w%l{t{t)nmR/8 X-Hue: red X-Debbugs-No-Ack: yes X-Attribution: GM Date: Wed, 08 Jan 2014 00:10:44 -0500 In-Reply-To: <87bnzncrvq.fsf@bzg.ath.cx> (Bastien's message of "Wed, 08 Jan 2014 00:08:09 +0100") Message-ID: <4o38kzqcrv.fsf@fencepost.gnu.org> User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 16313 Cc: Tom Tromey , 16313@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Bastien wrote: > Should I fix this or wait for Tom's feedback? I don't know why you are asking someone who hasn't changed the file in 3.5 years. You should wait for Stefan to answer, since he authored the most recent changes to package-delete, has already commented on this bug, and obviously knows how to delete an element from an alist. From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 08 03:44:46 2014 Received: (at 16313) by debbugs.gnu.org; 8 Jan 2014 08:44:46 +0000 Received: from localhost ([127.0.0.1]:42001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0oko-0002im-4I for submit@debbugs.gnu.org; Wed, 08 Jan 2014 03:44:46 -0500 Received: from mail-wi0-f170.google.com ([209.85.212.170]:64500) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0okl-0002iX-1m for 16313@debbugs.gnu.org; Wed, 08 Jan 2014 03:44:43 -0500 Received: by mail-wi0-f170.google.com with SMTP id hq4so5030491wib.1 for <16313@debbugs.gnu.org>; Wed, 08 Jan 2014 00:44:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:date:references:user-agent :message-id:mime-version:content-type; bh=ba9Si6VX28rnUtduwp6GoJr3VOgrBlf/ZmFu9hbhSus=; b=g1pw7qESpvT/cUW0bKBBz5mHnJo+B5Q2DPiNNkEEktL6YyyFvNCHIEqrGaQYr0KNTF G20sYOg6ewu+7u8VVd0dztmgEWh/0Oqw06emTCjg4Hc06fl3dI/RYMpSsPnRYLQs2TCg V2n+4vGSEWOKZCI15wrow6wCXqSMHl69Mah6uMiQMPHd5DRHLPBGEtmpOBxGMMDV9uO5 4AcovbpiTDsH5X90415B6Hc2DARcJSil3tMycWuMatCM0miPI5+5I4AE23kyvzghXkuN 2fxZi96iG0k2gwx7Htanb5/ueY9Lv+QKLUETJgLtD078mNAKRak779l52vKjxhvEMtdq AtQQ== X-Received: by 10.180.188.175 with SMTP id gb15mr2191721wic.50.1389170682191; Wed, 08 Jan 2014 00:44:42 -0800 (PST) Received: from bzg.localdomain ([78.250.115.166]) by mx.google.com with ESMTPSA id gz5sm1275233wib.10.2014.01.08.00.44.40 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Jan 2014 00:44:40 -0800 (PST) Received: by bzg.localdomain (Postfix, from userid 1000) id 52E991C20744; Wed, 8 Jan 2014 09:44:38 +0100 (CET) From: Bastien To: Glenn Morris Subject: Re: bug#16313: 24.3; package-delete does not update package-alist In-Reply-To: <4o38kzqcrv.fsf@fencepost.gnu.org> (Glenn Morris's message of "Wed, 08 Jan 2014 00:10:44 -0500") Date: Wed, 08 Jan 2014 09:41:04 +0100 References: <85mwjf5138.fsf@stephe-leake.org> <87iotwhu77.fsf@bzg.ath.cx> <87bnzncrvq.fsf@bzg.ath.cx> <4o38kzqcrv.fsf@fencepost.gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) Message-ID: <87vbxuvp55.fsf@bzg.ath.cx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 16313 Cc: Tom Tromey , 16313@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Glenn Morris writes: > Bastien wrote: > >> Should I fix this or wait for Tom's feedback? > > I don't know why you are asking someone who hasn't changed the file in > 3.5 years. Obviously because I didn't check :) > You should wait for Stefan to answer, since he authored the > most recent changes to package-delete, has already commented on this > bug, and obviously knows how to delete an element from an alist. I'll practise (delete 'bzg emacs-contributors) in the Rate Evict Programmers Loop for a while, and see if my Emacs karma gets better. Joke aside, I'll fix this myself later on today. -- Bastien From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 08 03:44:51 2014 Received: (at 16313) by debbugs.gnu.org; 8 Jan 2014 08:44:52 +0000 Received: from localhost ([127.0.0.1]:42004 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0okt-0002jD-N6 for submit@debbugs.gnu.org; Wed, 08 Jan 2014 03:44:51 -0500 Received: from mail-we0-f179.google.com ([74.125.82.179]:47294) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0okk-0002iW-Qa for 16313@debbugs.gnu.org; Wed, 08 Jan 2014 03:44:46 -0500 Received: by mail-we0-f179.google.com with SMTP id q59so1121054wes.24 for <16313@debbugs.gnu.org>; Wed, 08 Jan 2014 00:44:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:date:references:user-agent :message-id:mime-version:content-type; bh=xjZTTL7Eyzz83D+OrWXolEN/GDNG5jsU6sTBwm6ci4w=; b=crTdyCAUESZWE0w8fVP9/QtgEzk38HQNXcAJmkNeB0Htbu+zSRe75T5k0zTiYPB8Iu TmOS94fyCXlZf161VnMg4fH6QvP4Isd07Ngj25wP+R9bX+0Nnk1DmFt5wDiRkEdf9neP QnEceUVumuueNCwDtzqImzwAdff28fFVhOSZZ0K9+tMw+CpbLxft2s8Q/qRrzRTsHqhz kWANtDMFBfqO8+bVTlmpiYxIgguVYjFdddAqNyk+abV7ZBbDFsyQp04lj9noBQuDJkUu 7IeQ6KJaj23Q7JjcKFjIMEmYEDBEYeXNgg1nMYaAMJ814omaFR2GLfoxHVKhZe0W0A+j zo3w== X-Received: by 10.194.186.140 with SMTP id fk12mr9766055wjc.77.1389170681821; Wed, 08 Jan 2014 00:44:41 -0800 (PST) Received: from bzg.localdomain ([78.250.115.166]) by mx.google.com with ESMTPSA id hv3sm1287636wib.5.2014.01.08.00.44.39 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Jan 2014 00:44:40 -0800 (PST) Received: by bzg.localdomain (Postfix, from userid 1000) id C8DED1C20717; Wed, 8 Jan 2014 09:44:37 +0100 (CET) From: Bastien To: Glenn Morris Subject: Re: bug#16313: 24.3; package-delete does not update package-alist In-Reply-To: (Glenn Morris's message of "Tue, 07 Jan 2014 17:08:36 -0500") Date: Wed, 08 Jan 2014 09:38:20 +0100 References: <85mwjf5138.fsf@stephe-leake.org> <87iotwhu77.fsf@bzg.ath.cx> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) Message-ID: <871u0ix3pm.fsf@bzg.ath.cx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 16313 Cc: 16313@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Glenn Morris writes: > Bastien Guerry wrote: > >> Still, package-delete did not cleanly delete the package from >> package-alist, only its description. > > _Should_ it remove the entire entry? It's not obvious to me, given eg > the way package-installed-p works. I've read through the code and I think package-delete should remove the entire entry. The docstring of package-alist also suggests so. Let me know if I'm wrong. -- Bastien From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 08 06:35:54 2014 Received: (at 16313-done) by debbugs.gnu.org; 8 Jan 2014 11:35:55 +0000 Received: from localhost ([127.0.0.1]:42067 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0rQQ-0007eF-GV for submit@debbugs.gnu.org; Wed, 08 Jan 2014 06:35:54 -0500 Received: from mail-wi0-f174.google.com ([209.85.212.174]:39877) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0rQO-0007e6-4F for 16313-done@debbugs.gnu.org; Wed, 08 Jan 2014 06:35:52 -0500 Received: by mail-wi0-f174.google.com with SMTP id z2so5383737wiv.7 for <16313-done@debbugs.gnu.org>; Wed, 08 Jan 2014 03:35:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=MpxN9nK6hTl5xFqUGRzWTvTpTmUr4Pp4VpFRQyqz4Ig=; b=lqlULDHnl3VXlYv+a/BI9JHlbMVAgZe6ZzlVLd5uoLq5LsniZU2rYgAFZmGaTMT0S5 MYwlZa9cBuJ9EjJ/RAomb7WWPa/0Ba07DCSQPxgmEOH40yHMkNw8uxzcquYFi+4FfRZ3 Q5hSUNizdHHWq9/Yvr+k/FlHmmW9J1v2glV9DB9N5F6cRJ/y4//W5K6uz0Bz2mgysKh/ hwFem8s7eDSRJRxjMrZTNpM4Xtr3hbSS7zYmgcuFRSosET8QapwCC4VGS/Rv+DVI+1MW 3uw5Iagu0KQr5IOh/B12Sod9UP2yz2CaFkvVA2mX3Lq4FZA9gbrtV96f5IY9wuCGDC5Y 7GzA== X-Received: by 10.194.80.137 with SMTP id r9mr1211893wjx.88.1389180951011; Wed, 08 Jan 2014 03:35:51 -0800 (PST) Received: from bzg.localdomain ([78.250.161.9]) by mx.google.com with ESMTPSA id cy10sm47770373wjb.6.2014.01.08.03.35.48 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 08 Jan 2014 03:35:49 -0800 (PST) Received: by bzg.localdomain (Postfix, from userid 1000) id 12B461C20717; Wed, 8 Jan 2014 12:35:46 +0100 (CET) From: Bastien To: Glenn Morris Subject: Re: bug#16313: 24.3; package-delete does not update package-alist In-Reply-To: <4o38kzqcrv.fsf@fencepost.gnu.org> (Glenn Morris's message of "Wed, 08 Jan 2014 00:10:44 -0500") References: <85mwjf5138.fsf@stephe-leake.org> <87iotwhu77.fsf@bzg.ath.cx> <87bnzncrvq.fsf@bzg.ath.cx> <4o38kzqcrv.fsf@fencepost.gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) Date: Wed, 08 Jan 2014 12:35:46 +0100 Message-ID: <87ppo2u2nh.fsf@bzg.ath.cx> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 16313-done Cc: 16313-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Glenn Morris writes: > Bastien wrote: > >> Should I fix this or wait for Tom's feedback? > > I don't know why you are asking someone who hasn't changed the file in > 3.5 years. You should wait for Stefan to answer, since he authored the > most recent changes to package-delete, has already commented on this > bug, and obviously knows how to delete an element from an alist. I've now fixed this in revno 115918, closing the bug. -- Bastien From debbugs-submit-bounces@debbugs.gnu.org Wed Jan 08 09:08:58 2014 Received: (at 16313) by debbugs.gnu.org; 8 Jan 2014 14:08:58 +0000 Received: from localhost ([127.0.0.1]:42083 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0toX-0004o4-Ne for submit@debbugs.gnu.org; Wed, 08 Jan 2014 09:08:58 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:38917) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1W0toV-0004nv-DU for 16313@debbugs.gnu.org; Wed, 08 Jan 2014 09:08:55 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFFxKG9/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GwS2RCgOIYYl6A5IcgV6DFQ X-IPAS-Result: Av4EABK/CFFFxKG9/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLNBIUGA0kiB4GwS2RCgOIYYl6A5IcgV6DFQ X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="44462990" Received: from 69-196-161-189.dsl.teksavvy.com (HELO pastel.home) ([69.196.161.189]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 08 Jan 2014 09:08:54 -0500 Received: by pastel.home (Postfix, from userid 20848) id 78922606B5; Wed, 8 Jan 2014 09:08:54 -0500 (EST) From: Stefan Monnier To: Bastien Subject: Re: bug#16313: 24.3; package-delete does not update package-alist Message-ID: References: <85mwjf5138.fsf@stephe-leake.org> <87iotwhu77.fsf@bzg.ath.cx> <871u0ix3pm.fsf@bzg.ath.cx> Date: Wed, 08 Jan 2014 09:08:54 -0500 In-Reply-To: <871u0ix3pm.fsf@bzg.ath.cx> (Bastien's message of "Wed, 08 Jan 2014 09:38:20 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 16313 Cc: Glenn Morris , 16313@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > I've read through the code and I think package-delete should remove > the entire entry. The docstring of package-alist also suggests so. > Let me know if I'm wrong. I don't have time to look at it now, but it sounds right, thank you, Stefan From unknown Sun Jun 15 08:51:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 06 Feb 2014 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator