From unknown Fri Jun 20 07:11:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16296: subword.el regexps shouldn't be constants Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 29 Dec 2013 23:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16296 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 16296@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.138836071418343 (code B ref -1); Sun, 29 Dec 2013 23:46:02 +0000 Received: (at submit) by debbugs.gnu.org; 29 Dec 2013 23:45:14 +0000 Received: from localhost ([127.0.0.1]:50950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VxQ2j-0004lm-Ts for submit@debbugs.gnu.org; Sun, 29 Dec 2013 18:45:14 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41608) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VxQ2g-0004lY-7L for submit@debbugs.gnu.org; Sun, 29 Dec 2013 18:45:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VxQ2V-0003Vz-St for submit@debbugs.gnu.org; Sun, 29 Dec 2013 18:45:09 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40078) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VxQ2V-0003Vv-Q0 for submit@debbugs.gnu.org; Sun, 29 Dec 2013 18:44:59 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43309) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VxQ2N-0001Xb-ND for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2013 18:44:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VxQ2F-0003UZ-LD for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2013 18:44:51 -0500 Received: from nctlincom01.orcon.net.nz ([60.234.4.69]:54192) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VxQ2F-0003S1-4T for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2013 18:44:43 -0500 Received: from mx7.orcon.net.nz (mx7.orcon.net.nz [219.88.242.57]) by nctlincom01.orcon.net.nz (8.14.3/8.14.3/Debian-9.4) with ESMTP id rBTNvMMv019676 for ; Mon, 30 Dec 2013 12:57:22 +1300 Received: from Debian-exim by mx7.orcon.net.nz with local (Exim 4.69) (envelope-from ) id 1VxQ1k-0003R4-HK for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2013 12:44:12 +1300 Received: from [121.99.80.47] (helo=[10.1.1.3]) by mx7.orcon.net.nz with esmtpa (Exim 4.69) (envelope-from ) id 1VxQ1k-0003QY-Cx for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2013 12:44:12 +1300 Message-ID: <52C0B38E.4040401@orcon.net.nz> Date: Mon, 30 Dec 2013 12:43:10 +1300 From: Phil Sainty User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-DSPAM-Check: by mx7.orcon.net.nz on Mon, 30 Dec 2013 12:44:12 +1300 X-DSPAM-Result: Spam X-DSPAM-Processed: Mon Dec 30 12:44:12 2013 X-DSPAM-Confidence: 0.4654 X-DSPAM-Probability: 0.9983 X-Bayes-Prob: 0.0008 (Score 0, tokens from: @@RPTN, default) X-CanIt-Geo: ip=121.99.80.47; country=NZ; region=E7; city=Auckland; latitude=-36.8667; longitude=174.7667; http://maps.google.com/maps?q=-36.8667,174.7667&z=6 X-CanItPRO-Stream: base:default X-Canit-Stats-ID: 06L7zVmVL - 57113625996d - 20131230 X-Scanned-By: CanIt (www . roaringpenguin . com) on 172.16.100.174 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) I notice that a recent(ish) change in subword.el changed the two regexps (subword-forward-regexp and subword-backward-regexp) into constants. The reason for splitting them out into variables in the first place was to help make subword-mode easily adaptable to other situations where similar functionality was needed, but for different definitions of 'subword'. For the situation where the normal subword-forward/backward-function values are fine and you simply need buffer-local overrides for the regexps, this newer change would seem to be counter-productive. Can we please revert it? -Phil From unknown Fri Jun 20 07:11:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16296: subword.el regexps shouldn't be constants Resent-From: Ted Zlatanov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Jan 2014 18:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16296 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Phil Sainty Cc: 16296@debbugs.gnu.org Received: via spool by 16296-submit@debbugs.gnu.org id=B16296.138877292220345 (code B ref 16296); Fri, 03 Jan 2014 18:16:02 +0000 Received: (at 16296) by debbugs.gnu.org; 3 Jan 2014 18:15:22 +0000 Received: from localhost ([127.0.0.1]:60305 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vz9HG-0005I2-2K for submit@debbugs.gnu.org; Fri, 03 Jan 2014 13:15:22 -0500 Received: from mail-qc0-f169.google.com ([209.85.216.169]:60070) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vz9HD-0005Hu-5U for 16296@debbugs.gnu.org; Fri, 03 Jan 2014 13:15:20 -0500 Received: by mail-qc0-f169.google.com with SMTP id r5so15440081qcx.0 for <16296@debbugs.gnu.org>; Fri, 03 Jan 2014 10:15:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=TRSGASD4YoAnpE3T/8JIk0OECUzgBAmlP09Q3ZkdYBE=; b=FPMh1ZH9u3wdtztHyu+A6ZtWmDuHdU+O+7ulJzcKWhCcMPSRNwqYCkthtbzjTJxT6d RdVYgGGCYJLK7jrzQhrp+h5h7roVY5ihcfKE606is2TGAkfAZr/snD/h56kghkdjZ0dY +UzqQ/cwexC+mV3KcHoDFLyOtIoRh4pC2wpDQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=TRSGASD4YoAnpE3T/8JIk0OECUzgBAmlP09Q3ZkdYBE=; b=NBFrDnDt/QPMEeF2Vr1NcX6DngPLFGYhwUgEB2WZjyQqHbnFlkVmvvzXXOH666jcFL W7edmYGCX2mGoyBUeBuy1ZXytoILUD+4ZEY2a40ZUzJ5EtWAQp6mOHEjlVPY60/IHLKR Wxuej4x4EIKBHiS31rfJEOPq4U9f/Et5NwDF5jkXLM55n5tQBvXW1uTIuIuSBgKBIzAf 8IvhlgRcNF3EllCp0fdAu3/ENV7yEeXOl2deLm4Gwdb13rOrn7d9HitWiu49E+H/WW5/ Ql/McEHXQJUAsvYZeQ+a0ARMDGuNeEPlpf//ySBdHA1RMcRIxLOQa6KriV5wRBVe33Q2 0ddw== X-Gm-Message-State: ALoCoQlwRe8j48mpMFpIq4NEoP6NfaJK6UBOl5LmDadTIGVxeTk8OeGIwjJ6XLXJprzG8BfoNRRO X-Received: by 10.224.45.137 with SMTP id e9mr41495097qaf.19.1388772918762; Fri, 03 Jan 2014 10:15:18 -0800 (PST) Received: from flea.lifelogs.com (c-98-229-61-72.hsd1.ma.comcast.net. [98.229.61.72]) by mx.google.com with ESMTPSA id g1sm80722318qec.9.2014.01.03.10.15.18 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 03 Jan 2014 10:15:18 -0800 (PST) From: Ted Zlatanov Organization: =?UTF-8?Q?=D0=A2=D0=B5=D0=BE=D0=B4=D0=BE=D1=80_?= =?UTF-8?Q?=D0=97=D0=BB=D0=B0=D1=82=D0=B0=D0=BD=D0=BE=D0=B2?= @ Cienfuegos References: <52C0B38E.4040401@orcon.net.nz> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Fri, 03 Jan 2014 13:16:54 -0500 In-Reply-To: <52C0B38E.4040401@orcon.net.nz> (Phil Sainty's message of "Mon, 30 Dec 2013 12:43:10 +1300") Message-ID: <87mwjdgcbt.fsf@flea.lifelogs.com> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Mon, 30 Dec 2013 12:43:10 +1300 Phil Sainty wrote: PS> I notice that a recent(ish) change in subword.el changed the two PS> regexps (subword-forward-regexp and subword-backward-regexp) into PS> constants. PS> The reason for splitting them out into variables in the first PS> place was to help make subword-mode easily adaptable to other PS> situations where similar functionality was needed, but for different PS> definitions of 'subword'. PS> For the situation where the normal subword-forward/backward-function PS> values are fine and you simply need buffer-local overrides for the PS> regexps, this newer change would seem to be counter-productive. PS> Can we please revert it? For reference, you mean this commit? revno: 113492 fixes bug: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13758 committer: Stefan Monnier branch nick: trunk timestamp: Mon 2013-07-22 12:25:32 -0400 message: * lisp/progmodes/subword.el: Fix boundary case. (subword-forward-regexp): Make it a constant. Wrap optional \\W in its own group. (subword-backward-regexp): Make it a constant. (subword-forward-internal): Don't treat a trailing capital as the beginning of a word. * test/automated/subword-tests.el: New file. From unknown Fri Jun 20 07:11:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16296: subword.el regexps shouldn't be constants Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 03 Jan 2014 22:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16296 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Phil Sainty Cc: 16296@debbugs.gnu.org Received: via spool by 16296-submit@debbugs.gnu.org id=B16296.138878689113136 (code B ref 16296); Fri, 03 Jan 2014 22:09:01 +0000 Received: (at 16296) by debbugs.gnu.org; 3 Jan 2014 22:08:11 +0000 Received: from localhost ([127.0.0.1]:60601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzCuZ-0003Pl-3U for submit@debbugs.gnu.org; Fri, 03 Jan 2014 17:08:11 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:59405) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzCuX-0003Pe-CM for 16296@debbugs.gnu.org; Fri, 03 Jan 2014 17:08:09 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFG4rwsm/2dsb2JhbABEvw4Xc4IfAQVWIxALDiYSFBgNJIgkwS2RCgOIYZwZgV6DFQ X-IPAS-Result: Av4EABK/CFG4rwsm/2dsb2JhbABEvw4Xc4IfAQVWIxALDiYSFBgNJIgkwS2RCgOIYZwZgV6DFQ X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="43920378" Received: from 184-175-11-38.dsl.teksavvy.com (HELO pastel.home) ([184.175.11.38]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 03 Jan 2014 17:08:09 -0500 Received: by pastel.home (Postfix, from userid 20848) id C7D7C6013A; Fri, 3 Jan 2014 17:08:08 -0500 (EST) From: Stefan Monnier Message-ID: References: <52C0B38E.4040401@orcon.net.nz> <87mwjdgcbt.fsf@flea.lifelogs.com> Date: Fri, 03 Jan 2014 17:08:08 -0500 In-Reply-To: <87mwjdgcbt.fsf@flea.lifelogs.com> (Ted Zlatanov's message of "Fri, 03 Jan 2014 13:16:54 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > (subword-forward-regexp): Make it a constant. Wrap optional \\W in its > own group. > (subword-backward-regexp): Make it a constant. If there are reasons for users to change them, then feel free to revert them to defvars. Stefan From unknown Fri Jun 20 07:11:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16296: subword.el regexps shouldn't be constants Resent-From: Phil Sainty Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 04 Jan 2014 12:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16296 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 16296@debbugs.gnu.org Received: via spool by 16296-submit@debbugs.gnu.org id=B16296.138883936522818 (code B ref 16296); Sat, 04 Jan 2014 12:43:01 +0000 Received: (at 16296) by debbugs.gnu.org; 4 Jan 2014 12:42:45 +0000 Received: from localhost ([127.0.0.1]:33187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzQYu-0005vv-6B for submit@debbugs.gnu.org; Sat, 04 Jan 2014 07:42:44 -0500 Received: from nctlincom02.orcon.net.nz ([60.234.4.76]:45502) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzQYq-0005vh-1R for 16296@debbugs.gnu.org; Sat, 04 Jan 2014 07:42:41 -0500 Received: from mx1.orcon.net.nz (mx1.orcon.net.nz [219.88.242.51]) by nctlincom02.orcon.net.nz (8.14.3/8.14.3/Debian-9.4) with ESMTP id s04CoP8j009902 for <16296@debbugs.gnu.org>; Sun, 5 Jan 2014 01:50:25 +1300 Received: from Debian-exim by mx1.orcon.net.nz with local (Exim 4.69) (envelope-from ) id 1VzPT3-00011S-CQ for 16296@debbugs.gnu.org; Sun, 05 Jan 2014 00:32:37 +1300 Received: from [121.99.80.47] (helo=[10.1.1.3]) by mx1.orcon.net.nz with esmtpa (Exim 4.69) (envelope-from ) id 1VzPT3-00010i-3d for 16296@debbugs.gnu.org; Sun, 05 Jan 2014 00:32:37 +1300 Message-ID: <52C7F149.40504@orcon.net.nz> Date: Sun, 05 Jan 2014 00:32:25 +1300 From: Phil Sainty User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 References: <52C0B38E.4040401@orcon.net.nz> <87mwjdgcbt.fsf@flea.lifelogs.com> In-Reply-To: <87mwjdgcbt.fsf@flea.lifelogs.com> Content-Type: multipart/mixed; boundary="------------080300040000090605000502" X-DSPAM-Check: by mx1.orcon.net.nz on Sun, 05 Jan 2014 00:32:37 +1300 X-DSPAM-Result: Innocent X-DSPAM-Processed: Sun Jan 5 00:32:37 2014 X-DSPAM-Confidence: 0.6185 X-DSPAM-Probability: 0.0000 X-Bayes-Prob: 0.0001 (Score 0, tokens from: @@RPTN, default) X-Spam-Score: -3.00 () [Hold at 4.00] CC(NZ:-3) X-CanIt-Geo: ip=121.99.80.47; country=NZ; region=E7; city=Auckland; latitude=-36.8667; longitude=174.7667; http://maps.google.com/maps?q=-36.8667,174.7667&z=6 X-CanItPRO-Stream: base:default X-Canit-Stats-ID: 05L9MOpkC - 6c27bf9a8a5d - 20140105 X-Scanned-By: CanIt (www . roaringpenguin . com) on 172.16.100.175 X-Spam-Score: -0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) This is a multi-part message in MIME format. --------------080300040000090605000502 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit On 4/01/2014 11:08, Stefan Monnier wrote: > If there are reasons for users to change them, then feel free > to revert them to defvars. Great, thank you. On 4/01/2014 07:16, Ted Zlatanov wrote: > For reference, you mean this commit? > > revno: 113492 > fixes bug: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=13758 > committer: Stefan Monnier > branch nick: trunk > timestamp: Mon 2013-07-22 12:25:32 -0400 > message: > * lisp/progmodes/subword.el: Fix boundary case. > (subword-forward-regexp): Make it a constant. Wrap optional \\W in its > own group. > (subword-backward-regexp): Make it a constant. > (subword-forward-internal): Don't treat a trailing capital as the > beginning of a word. > * test/automated/subword-tests.el: New file. Yes, that's the one (although note that I'm not suggesting reverting that entire commit; just the defvar -> defconst changes). I've attached a patch. -Phil --------------080300040000090605000502 Content-Type: text/plain; charset=windows-1252; name="subword-regexp-vars.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="subword-regexp-vars.patch" diff --git a/lisp/progmodes/subword.el b/lisp/progmodes/subword.el index f45b9d1..f9efa37 100644 --- a/lisp/progmodes/subword.el +++ b/lisp/progmodes/subword.el @@ -93,11 +93,11 @@ (defvar subword-backward-function 'subword-backward-internal "Function to call for backward subword movement.") -(defconst subword-forward-regexp +(defvar subword-forward-regexp "\\W*\\(\\([[:upper:]]*\\(\\W\\)?\\)[[:lower:][:digit:]]*\\)" "Regexp used by `subword-forward-internal'.") -(defconst subword-backward-regexp +(defvar subword-backward-regexp "\\(\\(\\W\\|[[:lower:][:digit:]]\\)\\([[:upper:]]+\\W*\\)\\|\\W\\w+\\)" "Regexp used by `subword-backward-internal'.") --------------080300040000090605000502-- From unknown Fri Jun 20 07:11:59 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Phil Sainty Subject: bug#16296: closed (Re: subword.el regexps shouldn't be constants) Message-ID: References: <52C8F29C.9060605@cs.ucla.edu> <52C0B38E.4040401@orcon.net.nz> X-Gnu-PR-Message: they-closed 16296 X-Gnu-PR-Package: emacs Reply-To: 16296@debbugs.gnu.org Date: Sun, 05 Jan 2014 05:51:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1388901062-11318-1" This is a multi-part message in MIME format... ------------=_1388901062-11318-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #16296: subword.el regexps shouldn't be constants which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 16296@debbugs.gnu.org. --=20 16296: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D16296 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1388901062-11318-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 16296-done) by debbugs.gnu.org; 5 Jan 2014 05:50:26 +0000 Received: from localhost ([127.0.0.1]:34989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzgbS-0002vP-7F for submit@debbugs.gnu.org; Sun, 05 Jan 2014 00:50:26 -0500 Received: from smtp.cs.ucla.edu ([131.179.128.62]:57887) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VzgbO-0002vC-3i for 16296-done@debbugs.gnu.org; Sun, 05 Jan 2014 00:50:22 -0500 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 9E4B739E80FF for <16296-done@debbugs.gnu.org>; Sat, 4 Jan 2014 21:50:21 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Nyb42wiNlBv7 for <16296-done@debbugs.gnu.org>; Sat, 4 Jan 2014 21:50:21 -0800 (PST) Received: from [192.168.1.9] (pool-108-0-233-62.lsanca.fios.verizon.net [108.0.233.62]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 4282139E8008 for <16296-done@debbugs.gnu.org>; Sat, 4 Jan 2014 21:50:21 -0800 (PST) Message-ID: <52C8F29C.9060605@cs.ucla.edu> Date: Sat, 04 Jan 2014 21:50:20 -0800 From: Paul Eggert Organization: UCLA Computer Science Department User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: 16296-done@debbugs.gnu.org Subject: Re: subword.el regexps shouldn't be constants Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 16296-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) I installed that patch; thanks. ------------=_1388901062-11318-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 29 Dec 2013 23:45:14 +0000 Received: from localhost ([127.0.0.1]:50950 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VxQ2j-0004lm-Ts for submit@debbugs.gnu.org; Sun, 29 Dec 2013 18:45:14 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41608) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VxQ2g-0004lY-7L for submit@debbugs.gnu.org; Sun, 29 Dec 2013 18:45:10 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VxQ2V-0003Vz-St for submit@debbugs.gnu.org; Sun, 29 Dec 2013 18:45:09 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40078) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VxQ2V-0003Vv-Q0 for submit@debbugs.gnu.org; Sun, 29 Dec 2013 18:44:59 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43309) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VxQ2N-0001Xb-ND for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2013 18:44:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VxQ2F-0003UZ-LD for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2013 18:44:51 -0500 Received: from nctlincom01.orcon.net.nz ([60.234.4.69]:54192) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VxQ2F-0003S1-4T for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2013 18:44:43 -0500 Received: from mx7.orcon.net.nz (mx7.orcon.net.nz [219.88.242.57]) by nctlincom01.orcon.net.nz (8.14.3/8.14.3/Debian-9.4) with ESMTP id rBTNvMMv019676 for ; Mon, 30 Dec 2013 12:57:22 +1300 Received: from Debian-exim by mx7.orcon.net.nz with local (Exim 4.69) (envelope-from ) id 1VxQ1k-0003R4-HK for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2013 12:44:12 +1300 Received: from [121.99.80.47] (helo=[10.1.1.3]) by mx7.orcon.net.nz with esmtpa (Exim 4.69) (envelope-from ) id 1VxQ1k-0003QY-Cx for bug-gnu-emacs@gnu.org; Mon, 30 Dec 2013 12:44:12 +1300 Message-ID: <52C0B38E.4040401@orcon.net.nz> Date: Mon, 30 Dec 2013 12:43:10 +1300 From: Phil Sainty User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: subword.el regexps shouldn't be constants Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-DSPAM-Check: by mx7.orcon.net.nz on Mon, 30 Dec 2013 12:44:12 +1300 X-DSPAM-Result: Spam X-DSPAM-Processed: Mon Dec 30 12:44:12 2013 X-DSPAM-Confidence: 0.4654 X-DSPAM-Probability: 0.9983 X-Bayes-Prob: 0.0008 (Score 0, tokens from: @@RPTN, default) X-CanIt-Geo: ip=121.99.80.47; country=NZ; region=E7; city=Auckland; latitude=-36.8667; longitude=174.7667; http://maps.google.com/maps?q=-36.8667,174.7667&z=6 X-CanItPRO-Stream: base:default X-Canit-Stats-ID: 06L7zVmVL - 57113625996d - 20131230 X-Scanned-By: CanIt (www . roaringpenguin . com) on 172.16.100.174 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) I notice that a recent(ish) change in subword.el changed the two regexps (subword-forward-regexp and subword-backward-regexp) into constants. The reason for splitting them out into variables in the first place was to help make subword-mode easily adaptable to other situations where similar functionality was needed, but for different definitions of 'subword'. For the situation where the normal subword-forward/backward-function values are fine and you simply need buffer-local overrides for the regexps, this newer change would seem to be counter-productive. Can we please revert it? -Phil ------------=_1388901062-11318-1--