GNU bug report logs - #16285
24.3.50; [PATCH] shr: handle <a> tag with blank error.

Previous Next

Full log

View this message in rfc822 format

From: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>, 16285 <at> debbugs.gnu.org
Subject: bug#16285: 24.3.50; [PATCH] shr: handle <a> tag with blank error.
Date: Sun, 05 Jan 2014 20:47:12 +0900

> I've now fixed this in a different manner.  Your patch would have bugged
> out if the empty anchor was the first element in the buffer, so I just
> made it insert a "*" if we have an empty anchor.

Thanks!

> The anchoring mechanism should perhaps be implemented in a different
> way -- markers instead of text properties, for instance?  That way

The markers is good idea. Inserting "*" is not bad,
but if it is possible, markers is good.

Kenjiro

larsi <at> gnus.org writes:

> Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com> writes:
>
>>           * net/eww.el (shr-descend): Handle <a> tag with blank error.
>
> I've now fixed this in a different manner.  Your patch would have bugged
> out if the empty anchor was the first element in the buffer, so I just
> made it insert a "*" if we have an empty anchor.
>
> The anchoring mechanism should perhaps be implemented in a different
> way -- markers instead of text properties, for instance?  That way
> zero-length anchors would be no problem.  Rewriting it in that way
> should probably wait until after the feature freeze, though.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.