From unknown Sat Jun 21 03:03:16 2025
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.509 (Entity 5.509)
Content-Type: text/plain; charset=utf-8
From: bug#16285 <16285@debbugs.gnu.org>
To: bug#16285 <16285@debbugs.gnu.org>
Subject: Status: 24.3.50; [PATCH] shr: handle tag with blank error.
Reply-To: bug#16285 <16285@debbugs.gnu.org>
Date: Sat, 21 Jun 2025 10:03:16 +0000
retitle 16285 24.3.50; [PATCH] shr: handle tag with blank error.
reassign 16285 emacs
submitter 16285 Kenjiro NAKAYAMA
severity 16285 minor
tag 16285 fixed patch
thanks
From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 29 08:08:46 2013
Received: (at submit) by debbugs.gnu.org; 29 Dec 2013 13:08:46 +0000
Received: from localhost ([127.0.0.1]:50030 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.80)
(envelope-from )
id 1VxG6n-00085d-69
for submit@debbugs.gnu.org; Sun, 29 Dec 2013 08:08:45 -0500
Received: from eggs.gnu.org ([208.118.235.92]:58840)
by debbugs.gnu.org with esmtp (Exim 4.80)
(envelope-from ) id 1VxG6m-00085Q-0b
for submit@debbugs.gnu.org; Sun, 29 Dec 2013 08:08:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from ) id 1VxG6d-00028v-AI
for submit@debbugs.gnu.org; Sun, 29 Dec 2013 08:08:43 -0500
X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org
X-Spam-Level:
X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM,
T_DKIM_INVALID autolearn=disabled version=3.3.2
Received: from lists.gnu.org ([2001:4830:134:3::11]:51007)
by eggs.gnu.org with esmtp (Exim 4.71)
(envelope-from ) id 1VxG6d-00028q-7D
for submit@debbugs.gnu.org; Sun, 29 Dec 2013 08:08:35 -0500
Received: from eggs.gnu.org ([2001:4830:134:3::10]:60519)
by lists.gnu.org with esmtp (Exim 4.71)
(envelope-from ) id 1VxG6U-0000QY-Jx
for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2013 08:08:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
(envelope-from ) id 1VxG6M-00025z-0L
for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2013 08:08:26 -0500
Received: from mail-pa0-x235.google.com ([2607:f8b0:400e:c03::235]:40336)
by eggs.gnu.org with esmtp (Exim 4.71)
(envelope-from ) id 1VxG6L-00025s-PD
for bug-gnu-emacs@gnu.org; Sun, 29 Dec 2013 08:08:17 -0500
Received: by mail-pa0-f53.google.com with SMTP id hz1so10747057pad.40
for ; Sun, 29 Dec 2013 05:08:16 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
h=user-agent:from:to:subject:date:message-id:mime-version
:content-type; bh=XwX97kDlu6xWYEhVlwZCxU3LXLDu5BkNMdxr6AYidnk=;
b=BgrMvQ6YNHyWcP1t18aaX5EltuDGrcymib0/mhqZLt3FpjutIlw+5o4ZQp0TZ9uGqf
kQUwZCiHReYbwoeUU4wNtyziXoTQF8Qm8FTjBh4WUsrd56KJg73/QVtmV8cGFCZ01Kg2
g5y+ON8Cjylf7xfdjt8mqERE5eIwZgtmwPsxycvzgaPmk8Iqvitkuiv8HBhOHAlhXJxF
Pkqx45gR51trbjMYmUsbj+n/NWCoIvBxtskj8NVWIK82wVuCSYa/jMkUe21z3JGvWqPa
EYq5g9ZlUygeyWZZR7JlcQqttcDH//XoW6t5mgn6h2sqgpVRx2E7p/mpavn7rTaXf/6T
fWdw==
X-Received: by 10.68.139.228 with SMTP id rb4mr61831599pbb.15.1388322495983;
Sun, 29 Dec 2013 05:08:15 -0800 (PST)
Received: from dhcp-193-97.nrt.redhat.com (nat-pool-nrt-t1.redhat.com.
[66.187.238.10])
by mx.google.com with ESMTPSA id vf7sm74854262pbc.5.2013.12.29.05.08.13
for
(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Sun, 29 Dec 2013 05:08:14 -0800 (PST)
User-agent: mu4e 0.9.9.6pre2; emacs 24.3.50.2
From: Kenjiro NAKAYAMA
To: bug-gnu-emacs@gnu.org
Subject: 24.3.50; [PATCH] shr: handle tag with blank error.
Date: Sun, 29 Dec 2013 22:08:04 +0900
Message-ID: <877ganst3f.fsf@dhcp-193-97.nrt.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain
X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address
(bad octet value).
X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address
(bad octet value).
X-Received-From: 2001:4830:134:3::11
X-Spam-Score: -4.0 (----)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit"
X-Spam-Score: -4.0 (----)
If there is tag with blank, the internal link will fail.
Please reproduce the bug by following HTML.
(Internal link "section1" can not jump to internal link.)
I am not sure following patch is the best fix. Please review and
install it to the official tree if appreciated.
~~~~~~~~~~~~~~~
INTERNAL LINK TEST
section1
--- TEST ---
link test
~~~~~~~~~~~~~~~
Signed-off-by: Kenjiro NAKAYAMA
* net/eww.el (shr-descend): Handle tag with blank error.
---
lisp/net/shr.el | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/lisp/net/shr.el b/lisp/net/shr.el
index 1604ebb..20dd31f 100644
--- a/lisp/net/shr.el
+++ b/lisp/net/shr.el
@@ -380,7 +380,11 @@ size, and full-buffer size."
(shr-generic (cdr dom)))
(when (and shr-target-id
(equal (cdr (assq :id (cdr dom))) shr-target-id))
- (put-text-property start (1+ start) 'shr-target-id shr-target-id))
+ (let ((result (ignore-errors
+ (put-text-property start (1+ start) 'shr-target-id shr-target-id)
+ t)))
+ (unless result
+ (put-text-property start (1- start) 'shr-target-id shr-target-id))))
;; If style is set, then this node has set the color.
(when style
(shr-colorize-region start (point)
--
1.8.3.1
From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 05 04:48:40 2014
Received: (at 16285) by debbugs.gnu.org; 5 Jan 2014 09:48:40 +0000
Received: from localhost ([127.0.0.1]:35212 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.80)
(envelope-from )
id 1VzkJz-0002i8-78
for submit@debbugs.gnu.org; Sun, 05 Jan 2014 04:48:39 -0500
Received: from hermes.netfonds.no ([80.91.224.195]:46196)
by debbugs.gnu.org with esmtp (Exim 4.80)
(envelope-from ) id 1VzkJs-0002hl-Va
for 16285@debbugs.gnu.org; Sun, 05 Jan 2014 04:48:34 -0500
Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58]
helo=stories.gnus.org)
by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
(Exim 4.72) (envelope-from )
id 1VzkJe-0002W1-Kz; Sun, 05 Jan 2014 10:48:18 +0100
From: Lars Magne Ingebrigtsen
To: Kenjiro NAKAYAMA
Subject: Re: bug#16285: 24.3.50; [PATCH] shr: handle tag with blank error.
References: <877ganst3f.fsf@dhcp-193-97.nrt.redhat.com>
X-Now-Playing: Barbara Morgenstern's _Vermona ET 6-1_: "Ein Tag auf dem Balkon"
X-Hashcash: 1:23:140105:16285@debbugs.gnu.org::cb3a56hxdu62jSOy:0000000000000000000000000000000000000000B5R0
X-Hashcash: 1:23:140105:nakayamakenjiro@gmail.com::9AwS2zM6DCKwlU5H:000000000000000000000000000000000000stjL
Date: Sun, 05 Jan 2014 10:48:18 +0100
In-Reply-To: <877ganst3f.fsf@dhcp-193-97.nrt.redhat.com> (Kenjiro NAKAYAMA's
message of "Sun, 29 Dec 2013 22:08:04 +0900")
Message-ID:
User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-MailScanner-ID: 1VzkJe-0002W1-Kz
X-Netfonds-MailScanner: Found to be clean
X-Netfonds-MailScanner-From: larsi@gnus.org
MailScanner-NULL-Check: 1389520099.40333@AFIJmm/VU5JepH3kucwaAg
X-Spam-Status: No
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 16285
Cc: 16285@debbugs.gnu.org
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit"
X-Spam-Score: 0.0 (/)
Kenjiro NAKAYAMA writes:
> * net/eww.el (shr-descend): Handle tag with blank error.
I've now fixed this in a different manner. Your patch would have bugged
out if the empty anchor was the first element in the buffer, so I just
made it insert a "*" if we have an empty anchor.
The anchoring mechanism should perhaps be implemented in a different
way -- markers instead of text properties, for instance? That way
zero-length anchors would be no problem. Rewriting it in that way
should probably wait until after the feature freeze, though.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 05 04:48:39 2014
Received: (at control) by debbugs.gnu.org; 5 Jan 2014 09:48:39 +0000
Received: from localhost ([127.0.0.1]:35210 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.80)
(envelope-from )
id 1VzkJy-0002i4-FN
for submit@debbugs.gnu.org; Sun, 05 Jan 2014 04:48:38 -0500
Received: from hermes.netfonds.no ([80.91.224.195]:46201)
by debbugs.gnu.org with esmtp (Exim 4.80)
(envelope-from ) id 1VzkJu-0002hn-Cd
for control@debbugs.gnu.org; Sun, 05 Jan 2014 04:48:34 -0500
Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58]
helo=stories.gnus.org)
by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16)
(Exim 4.72) (envelope-from ) id 1VzkJh-0002WA-2Q
for control@debbugs.gnu.org; Sun, 05 Jan 2014 10:48:21 +0100
Date: Sun, 05 Jan 2014 10:48:20 +0100
Message-Id:
To: control@debbugs.gnu.org
From: Lars Magne Ingebrigtsen
Subject: control message for bug #16285
X-MailScanner-ID: 1VzkJh-0002WA-2Q
X-Netfonds-MailScanner: Found to be clean
X-Netfonds-MailScanner-From: larsi@gnus.org
MailScanner-NULL-Check: 1389520101.31797@ug6uQ7uCbaiIHNOKVv+Jvw
X-Spam-Status: No
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit"
X-Spam-Score: 0.0 (/)
tags 16285 fixed
close 16285 24.4
From debbugs-submit-bounces@debbugs.gnu.org Sun Jan 05 06:47:42 2014
Received: (at 16285) by debbugs.gnu.org; 5 Jan 2014 11:47:42 +0000
Received: from localhost ([127.0.0.1]:35376 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.80)
(envelope-from )
id 1VzmB4-000054-TP
for submit@debbugs.gnu.org; Sun, 05 Jan 2014 06:47:40 -0500
Received: from mail-pa0-f54.google.com ([209.85.220.54]:47780)
by debbugs.gnu.org with esmtp (Exim 4.80)
(envelope-from ) id 1VzmAo-0008Vh-BE
for 16285@debbugs.gnu.org; Sun, 05 Jan 2014 06:47:24 -0500
Received: by mail-pa0-f54.google.com with SMTP id rd3so17523768pab.13
for <16285@debbugs.gnu.org>; Sun, 05 Jan 2014 03:47:17 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
h=references:user-agent:from:to:cc:subject:in-reply-to:date
:message-id:mime-version:content-type;
bh=5/1b8U/R4qnyCDOSPBsPWo61h6pbwtRjJ8LcRusXDOo=;
b=BkUK6aM0R3XXQ1a0/0f+3WAN7Q2mnrNRGdi45hqDFTW3WOLT9j8AKdwwuy74T7peMB
mJF1HKUESERNmCOEVPDzfi33BeaJ2zQh4i7XXXFKjh92/YIwhbAjrFrFOGIMMuWbmFCU
h5OpQhN58o1xeB+R20lZQJIJaokxY/FAIEv6whKLgpPO8uuMTk76IcirJ4ZBLbG7dWDs
fjBEHkL3R7x6kjYTamnlCf7AgRZfwK3mrFB4G7jOd/kMQKetQxTPLRJhuLpnCSSFP0Zd
lBIpjlPp4wlebIpnLYu0+mcr8LkfJISJPop+E4hRj5XxDfL63Mcbp7owmLt0eBmmmZRb
Gsjg==
X-Received: by 10.68.87.98 with SMTP id w2mr50870497pbz.2.1388922437126;
Sun, 05 Jan 2014 03:47:17 -0800 (PST)
Received: from dhcp-193-97.nrt.redhat.com (nat-pool-nrt-t1.redhat.com.
[66.187.238.10])
by mx.google.com with ESMTPSA id iu7sm121429681pbc.45.2014.01.05.03.47.14
for
(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
Sun, 05 Jan 2014 03:47:16 -0800 (PST)
References: <877ganst3f.fsf@dhcp-193-97.nrt.redhat.com>
User-agent: mu4e 0.9.9.6pre2; emacs 24.3.50.3
From: Kenjiro NAKAYAMA
To: Lars Magne Ingebrigtsen
Subject: Re: bug#16285: 24.3.50; [PATCH] shr: handle tag with blank error.
In-reply-to:
Date: Sun, 05 Jan 2014 20:47:12 +0900
Message-ID: <87eh4m1whr.fsf@dhcp-193-97.nrt.redhat.com>
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 16285
Cc: Kenjiro NAKAYAMA , 16285@debbugs.gnu.org
X-BeenThere: debbugs-submit@debbugs.gnu.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id:
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: debbugs-submit-bounces@debbugs.gnu.org
Sender: "Debbugs-submit"
X-Spam-Score: -0.7 (/)
> I've now fixed this in a different manner. Your patch would have bugged
> out if the empty anchor was the first element in the buffer, so I just
> made it insert a "*" if we have an empty anchor.
Thanks!
> The anchoring mechanism should perhaps be implemented in a different
> way -- markers instead of text properties, for instance? That way
The markers is good idea. Inserting "*" is not bad,
but if it is possible, markers is good.
Kenjiro
larsi@gnus.org writes:
> Kenjiro NAKAYAMA writes:
>
>> * net/eww.el (shr-descend): Handle tag with blank error.
>
> I've now fixed this in a different manner. Your patch would have bugged
> out if the empty anchor was the first element in the buffer, so I just
> made it insert a "*" if we have an empty anchor.
>
> The anchoring mechanism should perhaps be implemented in a different
> way -- markers instead of text properties, for instance? That way
> zero-length anchors would be no problem. Rewriting it in that way
> should probably wait until after the feature freeze, though.
From unknown Sat Jun 21 03:03:16 2025
Received: (at fakecontrol) by fakecontrolmessage;
To: internal_control@debbugs.gnu.org
From: Debbugs Internal Request
Subject: Internal Control
Message-Id: bug archived.
Date: Sun, 02 Feb 2014 12:24:06 +0000
User-Agent: Fakemail v42.6.9
# This is a fake control message.
#
# The action:
# bug archived.
thanks
# This fakemail brought to you by your local debbugs
# administrator