GNU bug report logs - #16280
24.3.50; [PATCH] eww: Add new function to clean browser histories.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16280 in the body.
You can then email your comments to 16280 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; [PATCH] eww: Add new function to clean browser histories.
Date: Sun, 29 Dec 2013 00:32:12 +0900

I think this function is simple but sufficient. 
Please review and install it to the official tree if appreciated, after Feature freeze.

Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>

          * net/eww.el (eww-mode-map): Add new key map and easy-menu to
            clean up browser histories.
            (eww-history-cleanup): New function to cleanup browser histories.

---
 lisp/net/eww.el | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 25309d1..11fcbf1 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -428,6 +428,7 @@ word(s) will be searched for via `eww-search-prefix'."
     (define-key map "C" 'url-cookie-list)
     (define-key map "v" 'eww-view-source)
     (define-key map "H" 'eww-list-histories)
+    (define-key map [(meta c)] 'eww-history-cleanup)

     (define-key map "b" 'eww-add-bookmark)
     (define-key map "B" 'eww-list-bookmarks)
@@ -448,6 +449,8 @@ word(s) will be searched for via `eww-search-prefix'."
        ["View page source" eww-view-source]
        ["Copy page URL" eww-copy-page-url t]
        ["List histories" eww-list-histories t]
+       ["Clean histories" eww-history-cleanup
+        :active (not (zerop (length eww-history)))]
        ["Add bookmark" eww-add-bookmark t]
        ["List bookmarks" eww-list-bookmarks t]
        ["List cookies" url-cookie-list t]))
@@ -1091,6 +1094,13 @@ Differences in #targets are ignored."
        (setq count (1+ count)))
       (expand-file-name file directory)))

+(defun eww-history-cleanup ()
+  (interactive)
+  (if (y-or-n-p "clean up browser histories? ")
+      (progn
+       (setq-local eww-history nil)
+       (setq-local eww-history-position 0))))
+
 ;;; Bookmarks code

 (defvar eww-bookmarks nil)
-- 
1.8.3.1

Regards,

Kenji

Message #8 received at 16280 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
Cc: 16280 <at> debbugs.gnu.org
Subject: Re: bug#16280: 24.3.50;
 [PATCH] eww: Add new function to clean browser histories.
Date: Wed, 01 Jan 2014 21:43:50 -0500

>             (eww-history-cleanup): New function to cleanup browser histories.

FWIW, I think this should explicitly encompass "all traces", including,
cookies, URL history, etc...


        Stefan

Message #11 received at 16280 <at> debbugs.gnu.org (full text, mbox):

From: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 16280 <at> debbugs.gnu.org, Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
Subject: Re: bug#16280: 24.3.50;
 [PATCH] eww: Add new function to clean browser histories.
Date: Sun, 05 Jan 2014 11:23:32 +0900

> FWIW, I think this should explicitly encompass "all traces", including,
> cookies, URL history, etc...

Yes, You are right.
But since all traces are only cookies and histories, I think it should
encompass separately "Clean ALL", "Clean Cookies" and "Clean Histories".

Kenjiro


monnier <at> iro.umontreal.ca writes:

>>             (eww-history-cleanup): New function to cleanup browser histories.
>
> FWIW, I think this should explicitly encompass "all traces", including,
> cookies, URL history, etc...
>
>
>         Stefan

Message #14 received at 16280 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
Cc: 16280 <at> debbugs.gnu.org
Subject: Re: bug#16280: 24.3.50;
 [PATCH] eww: Add new function to clean browser histories.
Date: Sun, 05 Jan 2014 10:32:58 +0100

Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com> writes:

> +(defun eww-history-cleanup ()
> +  (interactive)
> +  (if (y-or-n-p "clean up browser histories? ")
> +      (progn
> +       (setq-local eww-history nil)
> +       (setq-local eww-history-position 0))))

I'm not sure this is useful.  The history is only a local buffer
variable, isn't it?  The normal way to make stuff "go away" in Emacs is
to kill the buffer, and that should do the trick for the history, too.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #17 received at 16280 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 16280 <at> debbugs.gnu.org, Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
Subject: Re: bug#16280: 24.3.50;
 [PATCH] eww: Add new function to clean browser histories.
Date: Sun, 05 Jan 2014 10:35:10 +0100

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

> FWIW, I think this should explicitly encompass "all traces", including,
> cookies, URL history, etc...

There's a cookie editor in url.el.  It should probably have a command to
delete all cookies instead of just individual cookies, too.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #20 received at 16280 <at> debbugs.gnu.org (full text, mbox):

From: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
To: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Cc: 16280 <at> debbugs.gnu.org, Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
Subject: Re: bug#16280: 24.3.50;
 [PATCH] eww: Add new function to clean browser histories.
Date: Sun, 05 Jan 2014 20:07:41 +0900

> I'm not sure this is useful.  The history is only a local buffer
> variable, isn't it?  The normal way to make stuff "go away" in Emacs is
> to kill the buffer, and that should do the trick for the history, too.

Yes, that's right. I agree with you.
This function is not necessary.

Kenjiro

larsi <at> gnus.org writes:

> Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com> writes:
>
>> +(defun eww-history-cleanup ()
>> +  (interactive)
>> +  (if (y-or-n-p "clean up browser histories? ")
>> +      (progn
>> +       (setq-local eww-history nil)
>> +       (setq-local eww-history-position 0))))
>
> I'm not sure this is useful.  The history is only a local buffer
> variable, isn't it?  The normal way to make stuff "go away" in Emacs is
> to kill the buffer, and that should do the trick for the history, too.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.