GNU bug report logs - #16277
24.3.50; [PATCH] eww: Cannot use double/single quote for search words.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16277 in the body.
You can then email your comments to 16277 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; [PATCH] eww: Cannot use double/single quote for search words.
Date: Sat, 28 Dec 2013 20:36:55 +0900

This report includes a patch to the bug. Please, review and install it
to the official tree if appreciated.

* Reproduce the bug.
step 1. M-x eww
step 2. input "eww.el" to mini-buffer. (eg. sEnter URL or keywords: "eww.el")
(Result)-> Error will occure (eg. error "eww.el/80 Name or service not known").

The cause is that eww cannot treat double quote or single quote.
(Therefore, eww cannot search the word which has "." dot like eww.el.)

I send the patch to fix it.

Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>

        * net/eww.el (eww):  Support single/double quote for search.

---
 lisp/net/eww.el | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 25309d1..578032b 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -157,8 +157,9 @@ word(s) will be searched for via `eww-search-prefix'."
          (user-error "FTP is not supported."))
         (t
          (if (and (= (length (split-string url)) 1)
-                  (or (> (length (split-string url "\\.")) 1)
-                      (string-match eww-local-regex url)))
+                 (or (and (not (string-match-p "\\`[\"\'].*[\"\']\\'" url))
+                          (> (length (split-string url "\\.")) 1))
+                     (string-match eww-local-regex url)))
              (progn
                (unless (string-match-p "\\`[a-zA-Z][-a-zA-Z0-9+.]*://" url)
                  (setq url (concat "http://" url)))
-- 
1.8.3.1

Regards,

Kenjiro

Message #8 received at 16277 <at> debbugs.gnu.org (full text, mbox):

From: Lars Magne Ingebrigtsen <larsi <at> gnus.org>
To: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
Cc: 16277 <at> debbugs.gnu.org
Subject: Re: bug#16277: 24.3.50;
 [PATCH] eww: Cannot use double/single quote for search words.
Date: Sun, 05 Jan 2014 10:25:22 +0100

Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com> writes:

>         * net/eww.el (eww):  Support single/double quote for search.

Thanks; applied.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.