Subject: bug#16254: 24.3.50; bzr error on emacs trunk using vc-print-log

From: Lars Ingebrigtsen <[email-masked]>
Date: Wed, 09 Sep 2020 15:01:45 +0200

Christoph <[email-masked]> writes:

> The following patch adds detection (and filtering) of unregistered members to
> vc-dired-deduce-fileset.
> If the marked files have any unregistered files among them, the unregistered files
> are filtered out. 
> If all files are unregistered, an error is shown. This also covers the main case of
> selecting just one unregistered file/directory.

[...]

>  (defun vc-dired-deduce-fileset ()
> -  (let ((backend (vc-responsible-backend default-directory)))
> -    (unless backend (error "Directory not under VC"))
> -    (list backend
> -          (dired-map-over-marks (dired-get-filename nil t) nil))))
> +  "Deduce a set of files and a backend to which to apply an
> +operation from all the marked items in a dired buffer. Resulting
> +fileset only includes items that are version controlled."
> +  (let ((backend (vc-responsible-backend default-directory))
> +        (fileset
> +         (delq nil (mapcar
> +                    (lambda (x) (if (not (equal (vc-backend x) nil)) x))
> +                    (dired-map-over-marks
> +                     (dired-get-filename nil t)
> +                     nil)))))

The code in question has changed substantially since this patch was
proposed six years ago.  It's now:

(defun dired-vc-deduce-fileset (&optional state-model-only-files not-state-changing)
  (let ((backend (vc-responsible-backend default-directory))
        (files (dired-get-marked-files nil nil nil nil t))
        only-files-list
        state
        model)

If I'm reading it correctly, it...  more or less covers the same things
that this patch was supposed to do (but in a totally different way?), so
I guess this patch is no longer necessary.

So I'm closing this bug report.  If there still is something here that
needs fixing, please respond to the debbugs address, and we'll reopen.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no