From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 25 12:26:16 2013 Received: (at submit) by debbugs.gnu.org; 25 Dec 2013 17:26:16 +0000 Received: from localhost ([127.0.0.1]:41596 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VvsDn-0005Y3-JQ for submit@debbugs.gnu.org; Wed, 25 Dec 2013 12:26:15 -0500 Received: from eggs.gnu.org ([208.118.235.92]:44507) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VvsDl-0005Xv-3j for submit@debbugs.gnu.org; Wed, 25 Dec 2013 12:26:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VvsDk-00031D-39 for submit@debbugs.gnu.org; Wed, 25 Dec 2013 12:26:12 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.6 required=5.0 tests=BAYES_00, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:38620) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvsDj-000319-WA for submit@debbugs.gnu.org; Wed, 25 Dec 2013 12:26:12 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46229) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvsDj-00021z-3a for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2013 12:26:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VvsDi-00030v-7u for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2013 12:26:11 -0500 Received: from mail-bk0-x232.google.com ([2a00:1450:4008:c01::232]:64432) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvsDi-00030j-1R for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2013 12:26:10 -0500 Received: by mail-bk0-f50.google.com with SMTP id e11so2662326bkh.9 for ; Wed, 25 Dec 2013 09:26:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=8XJ5mBox//onLZm7S5N2HxDaNXyK5VsPnD7sIxCLp6Q=; b=edVmgTmspZlqfkEI8j3IBb3DfnPB9WqxRSbMWJtF2cfUhmKN/oENZvpnVRd2Nt0H5y VnVwtsZuwFDWS7nR0iwd09kP9wMNlATycbp9ziUPkHC/L0hb1edeoW5lCpZkd0S7h2KU y2wt51ehPkEpzHNkv/z0o0fWxqftnA345muccRX3V9tFF82sCstgeXLXKfnOXEvmWi0q AovqX09DzlAC3o2AGjGwHG7hDeMisr1ZmQfcoVpBOyEr7q/7WAj+z+sPpO59ruLCpFe0 lLloYK20oFFqgiSymmPvBoRhNRMR72sffucgjtHgo0sWIWQnZtGmaAd2jSYvZ0/IsRWL yLaw== X-Received: by 10.204.200.201 with SMTP id ex9mr37329bkb.75.1387992368211; Wed, 25 Dec 2013 09:26:08 -0800 (PST) Received: from marvin ([2601:1:8b00:519:1515:d40e:92b5:66f8]) by mx.google.com with ESMTPSA id bg1sm4966101bkc.4.2013.12.25.09.26.06 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Wed, 25 Dec 2013 09:26:07 -0800 (PST) From: Christoph To: bug-gnu-emacs@gnu.org Subject: 24.3.50; bzr error on emacs trunk using vc-print-log Date: Wed, 25 Dec 2013 10:25:28 -0700 Message-ID: <87d2kk4zcn.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) Running `vc-print-log` on a directory containing the Emacs trunk gives the following error: bzr: ERROR: Path unknown at end or start of revision range: aclocal.m4 In GNU Emacs 24.3.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2) of 2013-12-14 on marvin Bzr revision: 115528 tzz@lifelogs.com-20131214195519-pi759t6a59vg9b1i Windowing system distributor `The X.Org Foundation', version 11.0.11103000 System Description: Linux Mint 13 Maya From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 25 12:54:56 2013 Received: (at submit) by debbugs.gnu.org; 25 Dec 2013 17:54:56 +0000 Received: from localhost ([127.0.0.1]:41651 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VvsfX-0006Tl-Um for submit@debbugs.gnu.org; Wed, 25 Dec 2013 12:54:56 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47931) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VvsfT-0006TY-Mc for submit@debbugs.gnu.org; Wed, 25 Dec 2013 12:54:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VvsfS-0001sb-MA for submit@debbugs.gnu.org; Wed, 25 Dec 2013 12:54:51 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_05, FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:58780) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvsfS-0001sX-IY for submit@debbugs.gnu.org; Wed, 25 Dec 2013 12:54:50 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49648) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvsfR-0007Be-LQ for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2013 12:54:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VvsfQ-0001sE-K4 for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2013 12:54:49 -0500 Received: from mail-la0-x234.google.com ([2a00:1450:4010:c03::234]:57344) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvsfQ-0001s6-BO for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2013 12:54:48 -0500 Received: by mail-la0-f52.google.com with SMTP id y1so3335003lam.39 for ; Wed, 25 Dec 2013 09:54:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=4ENWhpjmMH7OI9igLc/EsyADLNwxnVlKa4Shs467FMM=; b=mB7qgMYzvTGqx1NQE+vB5aMN3WZkNxGjqzmFPOA2l2zseRUEfy2Toby3QwzR0kktX+ 0dKfi8v+Lv3A0MELxImxafGumVE3gorWALNPzK6prrUEioPC3qP0TJXf9xZKnQRHIHDz yqIm8xr59pLzNOfiP4thLgliV+ea/J44ooWqfbBrQLllwiggWNU7wp531Pme+WTd/kgX Oh42GcEvLaS8B30UYykIxf1penD18M2kjw1L7hbE6LDhpU7vAatJp6+6If4K7gCuQZg4 oPgkHVQeZEE2aEB/kPsslf7QwMdmurVrm7sCoy2myuWUJgWenViz4+kJ4r1tixBz9CsB MjOQ== MIME-Version: 1.0 X-Received: by 10.112.133.232 with SMTP id pf8mr120550lbb.69.1387994087163; Wed, 25 Dec 2013 09:54:47 -0800 (PST) Received: by 10.152.133.66 with HTTP; Wed, 25 Dec 2013 09:54:47 -0800 (PST) In-Reply-To: <87d2kk4zcn.fsf@gmail.com> References: <87d2kk4zcn.fsf@gmail.com> Date: Wed, 25 Dec 2013 10:54:47 -0700 Message-ID: Subject: Re: 24.3.50; bzr error on emacs trunk using vc-print-log From: Christoph To: bug-gnu-emacs@gnu.org Content-Type: multipart/alternative; boundary=047d7b3a81ce840a9c04ee5f8e23 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -3.8 (---) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.8 (---) --047d7b3a81ce840a9c04ee5f8e23 Content-Type: text/plain; charset=ISO-8859-1 Some more information on this issue: `vc-print-log` works find in a sub-directory of the tree, e.g. admin. It looks like aclocal.m4 is ignored via .bzrignore and it is the first file in the root tree (after running configure and such). I seem to remember we had a similar problem before that was fixed at some point. On Wed, Dec 25, 2013 at 10:25 AM, Christoph wrote: > > Running `vc-print-log` on a directory containing the Emacs trunk gives > the following error: > > bzr: ERROR: Path unknown at end or start of revision range: aclocal.m4 > > > > In GNU Emacs 24.3.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2) > of 2013-12-14 on marvin > Bzr revision: 115528 tzz@lifelogs.com-20131214195519-pi759t6a59vg9b1i > Windowing system distributor `The X.Org Foundation', version 11.0.11103000 > System Description: Linux Mint 13 Maya > --047d7b3a81ce840a9c04ee5f8e23 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
Some more information on this issue:=A0

`vc-print-log` works find in a sub-directory of the tree, e.g. admin.
= It looks like aclocal.m4 is ignored via .bzrignore and it is the first file= in the root tree (after running configure and such).

I seem to remember we had a similar problem before that= was fixed at some point.
<= br>
On Wed, Dec 25, 2013 at 10:25 AM, Christo= ph <cschol2112@gmail.com> wrote:

Running `vc-print-log` on a directory containing the Emacs trunk gives
the following error:

bzr: ERROR: Path unknown at end or start of revision range: aclocal.m4



In GNU Emacs 24.3.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2)
=A0of 2013-12-14 on marvin
Bzr revision: 115528 tzz@lifelogs.com-20131214195519-pi759t6a59vg9b1i
Windowing system distributor `The X.Org Foundation', version 11.0.11103= 000
System Description: =A0 =A0 Linux Mint 13 Maya

--047d7b3a81ce840a9c04ee5f8e23-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 25 13:22:45 2013 Received: (at 16254) by debbugs.gnu.org; 25 Dec 2013 18:22:45 +0000 Received: from localhost ([127.0.0.1]:41696 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vvt6S-0007Lr-Lz for submit@debbugs.gnu.org; Wed, 25 Dec 2013 13:22:45 -0500 Received: from mail-la0-f44.google.com ([209.85.215.44]:51598) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vvt6Q-0007Lj-IM for 16254@debbugs.gnu.org; Wed, 25 Dec 2013 13:22:43 -0500 Received: by mail-la0-f44.google.com with SMTP id ep20so3438418lab.31 for <16254@debbugs.gnu.org>; Wed, 25 Dec 2013 10:22:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=jGuh7ct1u3w0bAvSOWKQ/Vor43+kBl2wLgnA80UCj34=; b=bWphJTMPTP30LcfP8rlM6SpToo3AfejkxM7zjTNf9RH2zReM6SPlzcYbAeuALEponp eWPcLvw3K5hvpdYbs3FqzpZt5u2LZTTqz42gbQFOr76fGZu8sfYor7SVkUAZoiXBdru0 ubaBfnwxCEaF+R3l9s1++pIJ0DZMcoofliqenphnMfqyFBEZwp024jZiYAIR4bL3+wtU Sm+PVUi+lwPA2Tw46dpT9/HzGZTykVPD3HkBfAq6GOGIuwLgQzFy2R3p1xaTigJxyzoc YA3LecyWFyMCpiomLwpBEPMfmTFF2huosn8/vPrbAKS3Z+TxTJho1G7TkYyb+BaImsxC sn3Q== MIME-Version: 1.0 X-Received: by 10.112.135.67 with SMTP id pq3mr600624lbb.65.1387995761361; Wed, 25 Dec 2013 10:22:41 -0800 (PST) Received: by 10.152.133.66 with HTTP; Wed, 25 Dec 2013 10:22:41 -0800 (PST) In-Reply-To: References: <87d2kk4zcn.fsf@gmail.com> Date: Wed, 25 Dec 2013 11:22:41 -0700 Message-ID: Subject: Re: bug#16254: 24.3.50; bzr error on emacs trunk using vc-print-log From: Christoph To: 16254@debbugs.gnu.org, Stefan Monnier Content-Type: multipart/alternative; boundary=089e011827f64e475504ee5ff2b0 X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 16254 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) --089e011827f64e475504ee5ff2b0 Content-Type: text/plain; charset=ISO-8859-1 vc-print-log was executed from a dired buffer when this happened. vc-print-root-log works correctly and prints the Emacs bzr logs. vc.el has the following code in vc-print-log: (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t? --Stef (backend (car vc-fileset)) (files (cadr vc-fileset)) ;; (working-revision (or working-revision (vc-working-revision (car files)))) ) (vc-print-log-internal backend files working-revision nil limit))) The t in vc-decude-fileset allows unregistered files per the documentation. To follow Stefan's questions, why would we want unregistered files to be included in the fileset for the log command? I think this should be changed to disallow unregistered files. Christoph On Wed, Dec 25, 2013 at 10:54 AM, Christoph wrote: > Some more information on this issue: > > `vc-print-log` works find in a sub-directory of the tree, e.g. admin. > It looks like aclocal.m4 is ignored via .bzrignore and it is the first > file in the root tree (after running configure and such). > > I seem to remember we had a similar problem before that was fixed at some > point. > > > On Wed, Dec 25, 2013 at 10:25 AM, Christoph wrote: > >> >> Running `vc-print-log` on a directory containing the Emacs trunk gives >> the following error: >> >> bzr: ERROR: Path unknown at end or start of revision range: aclocal.m4 >> >> >> >> In GNU Emacs 24.3.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2) >> of 2013-12-14 on marvin >> Bzr revision: 115528 tzz@lifelogs.com-20131214195519-pi759t6a59vg9b1i >> Windowing system distributor `The X.Org Foundation', version 11.0.11103000 >> System Description: Linux Mint 13 Maya >> > > --089e011827f64e475504ee5ff2b0 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
vc-print-log was executed from a dired buffer when this ha= ppened. vc-print-root-log works correctly and prints the Emacs bzr logs.
vc.el has the following code in vc-print-log:

=A0 (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t?= --Stef
(back= end (car vc-fileset))
= (files (cadr vc-fileset))
;; (working-revisio= n (or working-revision (vc-working-revision (car files))))
=A0 = =A0 =A0 =A0 =A0)
=A0 =A0 (vc-print-log-internal backend files wor= king-revision nil limit)))

The t in vc-decude-fileset = allows unregistered files per the documentation. To follow Stefan's que= stions, why would we want unregistered files to be included in the fileset = for the log command?

I think thi= s should be changed to disallow unregistered files.

Christoph


On Wed, Dec 25, 2013 at 10:54 AM, Christ= oph <cschol2112@gmail.com> wrote:
Some more information on this issue:=A0

`vc-print-log` works find in a sub-directory of the tree, e.g. admin.
= It looks like aclocal.m4 is ignored via .bzrignore and it is the first file= in the root tree (after running configure and such).

I seem to remember we had a similar problem before that= was fixed at some point.
<= br>
On Wed, Dec 25, 2013 at 10:25 AM, Christo= ph <cschol2112@gmail.com> wrote:

Running `vc-print-log` on a directory containing the Emacs trunk gives
the following error:

bzr: ERROR: Path unknown at end or start of revision range: aclocal.m4



In GNU Emacs 24.3.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2)
=A0of 2013-12-14 on marvin
Bzr revision: 115528 tzz@lifelogs.com-20131214195519-pi759t6a59vg9b1i
Windowing system distributor `The X.Org Foundation', version 11.0.11103= 000
System Description: =A0 =A0 Linux Mint 13 Maya


--089e011827f64e475504ee5ff2b0-- From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 25 13:35:31 2013 Received: (at 16254) by debbugs.gnu.org; 25 Dec 2013 18:35:31 +0000 Received: from localhost ([127.0.0.1]:41720 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VvtIp-0007n1-Ad for submit@debbugs.gnu.org; Wed, 25 Dec 2013 13:35:31 -0500 Received: from mail-lb0-f182.google.com ([209.85.217.182]:49236) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VvtIm-0007mi-Rv for 16254@debbugs.gnu.org; Wed, 25 Dec 2013 13:35:29 -0500 Received: by mail-lb0-f182.google.com with SMTP id l4so3443512lbv.27 for <16254@debbugs.gnu.org>; Wed, 25 Dec 2013 10:35:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=8KisYbKJQwh2rwNCpaRdnnwLCeNTB+qhLSu6Wy4NRCU=; b=nWTcNRHCF5iOURU5HGOOwgBvUVWnOvm9XaIRf5HvUC5CGWGX3jRcYnIZNpzKJS9N+u WeAiOwdDvXV8JLtTalVfbbR12dlzXFYGN1vCGb9OveYD1gOQR94uKiKhXjh3sw2BKhWq l6IxpFX5vUb4IXPh+5/ioYysMRQJNlAuSkMeiB+lw5aYnoWL8ohIBN/M8Ja7IIeJHEgc 3nxVaOXCqbP6WzEFk8ofS71XOkUGes2tGCDs6zOzUxrbPoC4sTbFsOqAS+T+O7rmt4K5 Y1htuLGdk2cm1pWU8bVbIN9iBI/GFX7ZW8TSz32ZYXpb+6T0BQfcMDjhUtb3R5GQJwmw DNdg== MIME-Version: 1.0 X-Received: by 10.112.128.194 with SMTP id nq2mr11146lbb.84.1387996527606; Wed, 25 Dec 2013 10:35:27 -0800 (PST) Received: by 10.152.133.66 with HTTP; Wed, 25 Dec 2013 10:35:27 -0800 (PST) In-Reply-To: References: <87d2kk4zcn.fsf@gmail.com> Date: Wed, 25 Dec 2013 11:35:27 -0700 Message-ID: Subject: Re: bug#16254: 24.3.50; bzr error on emacs trunk using vc-print-log From: Christoph To: 16254@debbugs.gnu.org, Stefan Monnier Content-Type: multipart/alternative; boundary=047d7b3441fafa41f104ee601fd7 X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 16254 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) --047d7b3441fafa41f104ee601fd7 Content-Type: text/plain; charset=ISO-8859-1 I was wrong. The t argument in vc-deduce-fileset does something else. Sorry for the noise. On Wed, Dec 25, 2013 at 11:22 AM, Christoph wrote: > vc-print-log was executed from a dired buffer when this happened. > vc-print-root-log works correctly and prints the Emacs bzr logs. > > vc.el has the following code in vc-print-log: > > (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t? --Stef > (backend (car vc-fileset)) > (files (cadr vc-fileset)) > ;; (working-revision (or working-revision (vc-working-revision (car > files)))) > ) > (vc-print-log-internal backend files working-revision nil limit))) > > The t in vc-decude-fileset allows unregistered files per the > documentation. To follow Stefan's questions, why would we want unregistered > files to be included in the fileset for the log command? > > I think this should be changed to disallow unregistered files. > > Christoph > > > On Wed, Dec 25, 2013 at 10:54 AM, Christoph wrote: > >> Some more information on this issue: >> >> `vc-print-log` works find in a sub-directory of the tree, e.g. admin. >> It looks like aclocal.m4 is ignored via .bzrignore and it is the first >> file in the root tree (after running configure and such). >> >> I seem to remember we had a similar problem before that was fixed at some >> point. >> >> >> On Wed, Dec 25, 2013 at 10:25 AM, Christoph wrote: >> >>> >>> Running `vc-print-log` on a directory containing the Emacs trunk gives >>> the following error: >>> >>> bzr: ERROR: Path unknown at end or start of revision range: aclocal.m4 >>> >>> >>> >>> In GNU Emacs 24.3.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2) >>> of 2013-12-14 on marvin >>> Bzr revision: 115528 tzz@lifelogs.com-20131214195519-pi759t6a59vg9b1i >>> Windowing system distributor `The X.Org Foundation', version >>> 11.0.11103000 >>> System Description: Linux Mint 13 Maya >>> >> >> > --047d7b3441fafa41f104ee601fd7 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
I was wrong. The t argument in vc-deduce-fileset does some= thing else.=A0Sorry for the noise.



On Wed, Dec 25, 2013 at 11:22 AM,= Christoph <cschol2112@gmail.com> wrote:
vc-print-log was executed f= rom a dired buffer when this happened. vc-print-root-log works correctly an= d prints the Emacs bzr logs.

vc.el has the following code in vc-print-log:

=A0 (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t?= --Stef
(backend (c= ar vc-fileset))
(fi= les (cadr vc-fileset))
;; (working-revision (or = working-revision (vc-working-revision (car files))))
=A0 =A0 =A0 = =A0 =A0)
=A0 =A0 (vc-print-log-internal backend files working-rev= ision nil limit)))

The t in vc-decude-fileset = allows unregistered files per the documentation. To follow Stefan's que= stions, why would we want unregistered files to be included in the fileset = for the log command?

I think thi= s should be changed to disallow unregistered files.

Christoph


On Wed, Dec 25, 2013 at 10:54 AM, Christ= oph <cschol2112@gmail.com> wrote:
Some more information on this issue:=A0

`vc-print-log` works find in a sub-directory of the tree, e.g. admin.
= It looks like aclocal.m4 is ignored via .bzrignore and it is the first file= in the root tree (after running configure and such).

I seem to remember we had a similar problem before that= was fixed at some point.
<= br>
On Wed, Dec 25, 2013 at 10:25 AM, Christo= ph <cschol2112@gmail.com> wrote:

Running `vc-print-log` on a directory containing the Emacs trunk gives
the following error:

bzr: ERROR: Path unknown at end or start of revision range: aclocal.m4



In GNU Emacs 24.3.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2)
=A0of 2013-12-14 on marvin
Bzr revision: 115528 tzz@lifelogs.com-20131214195519-pi759t6a59vg9b1i
Windowing system distributor `The X.Org Foundation', version 11.0.11103= 000
System Description: =A0 =A0 Linux Mint 13 Maya



--047d7b3441fafa41f104ee601fd7-- From debbugs-submit-bounces@debbugs.gnu.org Thu Dec 26 21:47:12 2013 Received: (at 16254) by debbugs.gnu.org; 27 Dec 2013 02:47:12 +0000 Received: from localhost ([127.0.0.1]:45006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VwNSB-0003L8-Su for submit@debbugs.gnu.org; Thu, 26 Dec 2013 21:47:12 -0500 Received: from mail-lb0-f182.google.com ([209.85.217.182]:53454) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VwNS8-0003Kz-LD for 16254@debbugs.gnu.org; Thu, 26 Dec 2013 21:47:09 -0500 Received: by mail-lb0-f182.google.com with SMTP id l4so3927637lbv.41 for <16254@debbugs.gnu.org>; Thu, 26 Dec 2013 18:47:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; bh=UmKyyxjq6tJxxOpGJAzh6ZMH32ZetwPHycFcNZcEmz4=; b=0v8nMlwF8p4bUBoTEBuiwn7KgiEewXe4LTXUpDzx2tQ3xs+Zd16Pm0LUUiWLfsZUuZ WFKa7/vPE8em3cktpxlG2ISAqwTz49QzUZaNKa8pF5suJDbGxMMPu8zicywE+lm5c3x+ 6ny++GfJaUxDmHZSrf/JL6uPUcI0/AJZ6F/5HhT22zH4F1cPhBmKLj/xbRPUk1ZQ80DN 1FwPDxrSJQo3kGaOW4la2l5UzLZoUVdhbsLhYxwOHp2KA/Ry02jIGGoLjj31y8myQlRo uLH60u2lRb6l749zOu7xc/5blOpToFLuCQ/EiFvX/2OVXoHJOZNh6kCuw6U+SPXXQLaT dyPA== MIME-Version: 1.0 X-Received: by 10.152.6.201 with SMTP id d9mr7566925laa.25.1388112427432; Thu, 26 Dec 2013 18:47:07 -0800 (PST) Received: by 10.152.133.66 with HTTP; Thu, 26 Dec 2013 18:47:07 -0800 (PST) In-Reply-To: References: <87d2kk4zcn.fsf@gmail.com> Date: Thu, 26 Dec 2013 19:47:07 -0700 Message-ID: Subject: Re: bug#16254: 24.3.50; bzr error on emacs trunk using vc-print-log From: Christoph To: 16254@debbugs.gnu.org, Stefan Monnier Content-Type: multipart/alternative; boundary=089e013d1a94253f3404ee7b1c24 X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 16254 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) --089e013d1a94253f3404ee7b1c24 Content-Type: text/plain; charset=ISO-8859-1 This issue seems to be that when deducing the fileset in dired mode, the code does not distinguish between files that are under version control and files that aren't. The following patch adds detection (and filtering) of unregistered members to vc-dired-deduce-fileset. If the marked files have any unregistered files among them, the unregistered files are filtered out. If all files are unregistered, an error is shown. This also covers the main case of selecting just one unregistered file/directory. Thoughts? === modified file 'lisp/vc/vc.el' --- lisp/vc/vc.el 2013-11-26 19:17:55 +0000 +++ lisp/vc/vc.el 2013-12-27 02:40:38 +0000 @@ -1014,10 +1014,19 @@ (t (error "File is not under version control"))))) (defun vc-dired-deduce-fileset () - (let ((backend (vc-responsible-backend default-directory))) - (unless backend (error "Directory not under VC")) - (list backend - (dired-map-over-marks (dired-get-filename nil t) nil)))) + "Deduce a set of files and a backend to which to apply an +operation from all the marked items in a dired buffer. Resulting +fileset only includes items that are version controlled." + (let ((backend (vc-responsible-backend default-directory)) + (fileset + (delq nil (mapcar + (lambda (x) (if (not (equal (vc-backend x) nil)) x)) + (dired-map-over-marks + (dired-get-filename nil t) + nil))))) + (if (not fileset) + (error "Marked fileset is not under version control") + (list backend fileset)))) (defun vc-ensure-vc-buffer () "Make sure that the current buffer visits a version-controlled file." On Wed, Dec 25, 2013 at 11:35 AM, Christoph wrote: > I was wrong. The t argument in vc-deduce-fileset does something > else. Sorry for the noise. > > > > On Wed, Dec 25, 2013 at 11:22 AM, Christoph wrote: > >> vc-print-log was executed from a dired buffer when this happened. >> vc-print-root-log works correctly and prints the Emacs bzr logs. >> >> vc.el has the following code in vc-print-log: >> >> (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t? --Stef >> (backend (car vc-fileset)) >> (files (cadr vc-fileset)) >> ;; (working-revision (or working-revision (vc-working-revision (car >> files)))) >> ) >> (vc-print-log-internal backend files working-revision nil limit))) >> >> The t in vc-decude-fileset allows unregistered files per the >> documentation. To follow Stefan's questions, why would we want unregistered >> files to be included in the fileset for the log command? >> >> I think this should be changed to disallow unregistered files. >> >> Christoph >> >> >> On Wed, Dec 25, 2013 at 10:54 AM, Christoph wrote: >> >>> Some more information on this issue: >>> >>> `vc-print-log` works find in a sub-directory of the tree, e.g. admin. >>> It looks like aclocal.m4 is ignored via .bzrignore and it is the first >>> file in the root tree (after running configure and such). >>> >>> I seem to remember we had a similar problem before that was fixed at >>> some point. >>> >>> >>> On Wed, Dec 25, 2013 at 10:25 AM, Christoph wrote: >>> >>>> >>>> Running `vc-print-log` on a directory containing the Emacs trunk gives >>>> the following error: >>>> >>>> bzr: ERROR: Path unknown at end or start of revision range: aclocal.m4 >>>> >>>> >>>> >>>> In GNU Emacs 24.3.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2) >>>> of 2013-12-14 on marvin >>>> Bzr revision: 115528 tzz@lifelogs.com-20131214195519-pi759t6a59vg9b1i >>>> Windowing system distributor `The X.Org Foundation', version >>>> 11.0.11103000 >>>> System Description: Linux Mint 13 Maya >>>> >>> >>> >> > --089e013d1a94253f3404ee7b1c24 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
This issue seems to be that when deducing the fileset in d= ired mode, the code does not distinguish between files that are under versi= on control and files that aren't.

The following patc= h adds detection (and filtering) of unregistered members to vc-dired-deduce= -fileset.
If the marked files have any unregistered files among them, the unregi= stered files are filtered out.=A0
If all files are unregistered, = an error is shown. This also covers the main case of selecting just one unr= egistered file/directory.

Thoughts?

=3D=3D=3D modif= ied file 'lisp/vc/vc.el'
--- lisp/vc/vc.el 2013-11-26 19:17:55 +0000
+++= lisp/vc/vc.el 2013-12-27= 02:40:38 +0000
@@ -1014,10 +1014,19 @@
=A0 =A0 =A0 (t (error "File is = not under version control")))))
=A0
=A0(defun vc-d= ired-deduce-fileset ()
- =A0(let ((backend (vc-responsible-backen= d default-directory)))
- =A0 =A0(unless backend (error "Directory not under VC"))
- =A0 =A0(list backend
- =A0 =A0 =A0 =A0 =A0(dired-map-o= ver-marks (dired-get-filename nil t) nil))))
+ =A0"Deduce a = set of files and a backend to which to apply an
+operation from all the marked items in a dired buffer. Resulting
+fileset only includes items that are version controlled."
=
+ =A0(let ((backend (vc-responsible-backend default-directory))
+ =A0 =A0 =A0 =A0(fileset
+ =A0 =A0 =A0 =A0 (delq nil (mapca= r
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(lambda (x) (if (not (= equal (vc-backend x) nil)) x))
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0(dired-map-over-marks
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 (dired-get-filename nil t)
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 nil)))))
+ =A0 =A0= (if (not fileset)
+ =A0 =A0 =A0 =A0(error "Marked fileset is= not under version control")
+ =A0 =A0 =A0(list backend file= set))))
=A0
=A0(defun vc-ensure-vc-buffer ()
=A0 =A0"Make sure that the current buffer visits a version-contro= lled file."



On Wed, Dec 25, 2013 at 11:35 AM, Chris= toph <cschol2112@gmail.com> wrote:
I was wrong. The t argument= in vc-deduce-fileset does something else.=A0Sorry for the noise.

<= /div>


On Wed,= Dec 25, 2013 at 11:22 AM, Christoph <cschol2112@gmail.com> wrote:
vc-print-log was executed f= rom a dired buffer when this happened. vc-print-root-log works correctly an= d prints the Emacs bzr logs.

vc.el has the following code in vc-print-log:

=A0 (let* ((vc-fileset (vc-deduce-fileset t)) ;FIXME: Why t?= --Stef
(backend (c= ar vc-fileset))
(fi= les (cadr vc-fileset))
;; (working-revision (or = working-revision (vc-working-revision (car files))))
=A0 =A0 =A0 = =A0 =A0)
=A0 =A0 (vc-print-log-internal backend files working-rev= ision nil limit)))

The t in vc-decude-fileset = allows unregistered files per the documentation. To follow Stefan's que= stions, why would we want unregistered files to be included in the fileset = for the log command?

I think thi= s should be changed to disallow unregistered files.

Christoph


On Wed, Dec 25, 2013 at 10:54 AM, Christ= oph <cschol2112@gmail.com> wrote:
Some more information on this issue:=A0

`vc-print-log` works find in a sub-directory of the tree, e.g. admin.
= It looks like aclocal.m4 is ignored via .bzrignore and it is the first file= in the root tree (after running configure and such).

I seem to remember we had a similar problem before that= was fixed at some point.
<= br>
On Wed, Dec 25, 2013 at 10:25 AM, Christo= ph <cschol2112@gmail.com> wrote:

Running `vc-print-log` on a directory containing the Emacs trunk gives
the following error:

bzr: ERROR: Path unknown at end or start of revision range: aclocal.m4



In GNU Emacs 24.3.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.4.2)
=A0of 2013-12-14 on marvin
Bzr revision: 115528 tzz@lifelogs.com-20131214195519-pi759t6a59vg9b1i
Windowing system distributor `The X.Org Foundation', version 11.0.11103= 000
System Description: =A0 =A0 Linux Mint 13 Maya




--089e013d1a94253f3404ee7b1c24-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 30 10:53:45 2013 Received: (at 16254) by debbugs.gnu.org; 30 Dec 2013 15:53:46 +0000 Received: from localhost ([127.0.0.1]:52727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VxfA0-0004IX-CD for submit@debbugs.gnu.org; Mon, 30 Dec 2013 10:53:45 -0500 Received: from mail-lb0-f182.google.com ([209.85.217.182]:45032) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vxf9w-0004IK-Uq for 16254@debbugs.gnu.org; Mon, 30 Dec 2013 10:53:42 -0500 Received: by mail-lb0-f182.google.com with SMTP id l4so5530533lbv.41 for <16254@debbugs.gnu.org>; Mon, 30 Dec 2013 07:53:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=1LdFxvAU3VdKh/b5aqHqWBgjC5wb+6Lhany0dtuZ9gg=; b=fhKx4QRNw/jOmV/ES0ASN49zTFSZGv+kI1leSvvxI6KwRbCjS2yNhd6Osdtl6+iWP9 PVf3suLIGnDZu0ZgfASo0qYpiRmEGTt+Jw25AiBY9qzt6PbKO8LU1SCYtcM2m6YNRxCW 3M9Qtmeow70T32TnUNCBpmvWvjz8qtj98trlQ88mFjGTIkH85spzSlrfKitobIdM3H/d Z4ZfGnxRR5TDIo66i5DUiUfQEe0XqZEwJRq66N3vNo9k44rfX9NFQPoEz6EDafOewN4G sqr/q6hT47f07n4bXJnOmeHottxm35TcDkDRc+Vwcx1uxeU60sR7veXOaLgri7G5O0H3 VnLQ== MIME-Version: 1.0 X-Received: by 10.112.135.67 with SMTP id pq3mr1584284lbb.65.1388418819512; Mon, 30 Dec 2013 07:53:39 -0800 (PST) Received: by 10.152.133.66 with HTTP; Mon, 30 Dec 2013 07:53:39 -0800 (PST) Date: Mon, 30 Dec 2013 08:53:39 -0700 Message-ID: Subject: Re: bug#16254: 24.3.50; [PATCH] bzr error on emacs trunk using vc-print-log From: Christoph To: 16254@debbugs.gnu.org, Stefan Monnier Content-Type: multipart/alternative; boundary=089e011827f6895d3d04eec27260 X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 16254 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) --089e011827f6895d3d04eec27260 Content-Type: text/plain; charset=ISO-8859-1 It would be nice if a fix for this issue made it into 24.4. Or do you think that this is too intrusive of a change? I'll add Changelog entries etc. and commit it if someone can look it over. Thanks. On Thu, Dec 26, 2013 at 7:47 PM, Christoph wrote: > This issue seems to be that when deducing the fileset in dired mode, the > code does not distinguish between files that are under version control and > files that aren't. > > The following patch adds detection (and filtering) of unregistered members > to vc-dired-deduce-fileset. > If the marked files have any unregistered files among them, the > unregistered files are filtered out. > If all files are unregistered, an error is shown. This also covers the > main case of selecting just one unregistered file/directory. > > Thoughts? > > === modified file 'lisp/vc/vc.el' > --- lisp/vc/vc.el 2013-11-26 19:17:55 +0000 > +++ lisp/vc/vc.el 2013-12-27 02:40:38 +0000 > @@ -1014,10 +1014,19 @@ > (t (error "File is not under version control"))))) > > (defun vc-dired-deduce-fileset () > - (let ((backend (vc-responsible-backend default-directory))) > - (unless backend (error "Directory not under VC")) > - (list backend > - (dired-map-over-marks (dired-get-filename nil t) nil)))) > + "Deduce a set of files and a backend to which to apply an > +operation from all the marked items in a dired buffer. Resulting > +fileset only includes items that are version controlled." > + (let ((backend (vc-responsible-backend default-directory)) > + (fileset > + (delq nil (mapcar > + (lambda (x) (if (not (equal (vc-backend x) nil)) x)) > + (dired-map-over-marks > + (dired-get-filename nil t) > + nil))))) > + (if (not fileset) > + (error "Marked fileset is not under version control") > + (list backend fileset)))) > > (defun vc-ensure-vc-buffer () > "Make sure that the current buffer visits a version-controlled file." > --089e011827f6895d3d04eec27260 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
It would be nice if a fix for this issue made it into 24.4= . Or do you think that this is too intrusive of a change?

I'll add Changelog entries etc. and commit it if someone can look it = over.

Thanks.

On Thu, Dec 26, 2013 at 7:47 PM, Christoph <= cschol2112@gmail.= com> wrote:
This issue seems to be that= when deducing the fileset in dired mode, the code does not distinguish bet= ween files that are under version control and files that aren't.

The following patch adds detection (and filtering) of unregi= stered members to vc-dired-deduce-fileset.
If the marked files have any unregistered files among them, the unregi= stered files are filtered out.=A0
If all files are unregistered, = an error is shown. This also covers the main case of selecting just one unr= egistered file/directory.

Thoughts?

=3D=3D=3D modif= ied file 'lisp/vc/vc.el'
--- lisp/vc/vc.el 2013-11-26 19:17:55 +0000
+++ lisp/= vc/vc.el 2013-12-27 02:40:38 +0= 000
@@ -1014,10 +1014,19 @@
=A0 =A0 =A0 (t (error "File is = not under version control")))))
=A0
=A0(defun vc-d= ired-deduce-fileset ()
- =A0(let ((backend (vc-responsible-backen= d default-directory)))
- =A0 =A0(unless backend (error "Directory not under VC"))
- =A0 =A0(list backend
- =A0 =A0 =A0 =A0 =A0(dired-map-o= ver-marks (dired-get-filename nil t) nil))))
+ =A0"Deduce a = set of files and a backend to which to apply an
+operation from all the marked items in a dired buffer. Resulting
+fileset only includes items that are version controlled."
=
+ =A0(let ((backend (vc-responsible-backend default-directory))
+ =A0 =A0 =A0 =A0(fileset
+ =A0 =A0 =A0 =A0 (delq nil (mapca= r
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(lambda (x) (if (not (= equal (vc-backend x) nil)) x))
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0(dired-map-over-marks
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 = =A0 =A0 (dired-get-filename nil t)
+ =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 nil)))))
+ =A0 =A0= (if (not fileset)
+ =A0 =A0 =A0 =A0(error "Marked fileset is= not under version control")
+ =A0 =A0 =A0(list backend file= set))))
=A0
=A0(defun vc-ensure-vc-buffer ()
=A0 =A0"Make sure that the current buffer visits a version-contro= lled file."
--089e011827f6895d3d04eec27260-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 30 13:41:36 2013 Received: (at 16254) by debbugs.gnu.org; 30 Dec 2013 18:41:37 +0000 Received: from localhost ([127.0.0.1]:53034 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VxhmS-0004ja-Mu for submit@debbugs.gnu.org; Mon, 30 Dec 2013 13:41:36 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:35247) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VxhmQ-0004jS-RV for 16254@debbugs.gnu.org; Mon, 30 Dec 2013 13:41:35 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1VxhmQ-0004ma-5y; Mon, 30 Dec 2013 13:41:34 -0500 From: Glenn Morris To: Christoph Subject: Re: bug#16254: 24.3.50; [PATCH] bzr error on emacs trunk using vc-print-log References: <87d2kk4zcn.fsf@gmail.com> X-Spook: BROMURE Juiliett Class Submarine quiche Bletchley Park X-Ran: *:}|n4IkA+5f]nR/v}fCvJssZdfG1V!?.k:JfQ,pDU"P4uk,Rn(|.Jt~pDQ&zx1a{Phr}0 X-Hue: white X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 30 Dec 2013 13:41:34 -0500 In-Reply-To: (Christoph's message of "Mon, 30 Dec 2013 08:53:39 -0700") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.1 (-----) X-Debbugs-Envelope-To: 16254 Cc: 16254@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.1 (-----) Christoph wrote: > It would be nice if a fix for this issue made it into 24.4. Or do you think > that this is too intrusive of a change? 24.4 is still some way off. BTW, it does not work correctly in 23.4 or 24.1, so it does not seem that urgent to me. It works fine from a vc-dir buffer, just not a dired buffer. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 30 14:03:57 2013 Received: (at 16254) by debbugs.gnu.org; 30 Dec 2013 19:03:57 +0000 Received: from localhost ([127.0.0.1]:53070 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vxi84-0005QX-BK for submit@debbugs.gnu.org; Mon, 30 Dec 2013 14:03:56 -0500 Received: from mail-lb0-f169.google.com ([209.85.217.169]:42124) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vxi81-0005QP-Vc for 16254@debbugs.gnu.org; Mon, 30 Dec 2013 14:03:54 -0500 Received: by mail-lb0-f169.google.com with SMTP id u14so5868730lbd.0 for <16254@debbugs.gnu.org>; Mon, 30 Dec 2013 11:03:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=E8s3gnix3gnwOM2Mjm97Exz51X33TgFRlSn2abX380E=; b=KpV5mn5Sfawy8aiNC+JEqB1igyx8N1J7tQJWJSiiaJu2jl91u3aVhBN3HBWCXOef/Y 03YVmdacRvlOm4NOEBVzr2LOhQfAQkhxycmuMbKvyzTrrNX7m817/7uOIJU4BAX9Q3WX fxXC3iDySSGivZeGvYaI1YeTejsPgTcl0HxuyKT0FT2foA5u7kZQkhw9pxhHqfAFo0rs AB/wIElpKvuhLRKEiQTJDunTry7PpAXtfp7U8e+Q00I0rkjvYK9tCAxnxZ22vnaU2tcr UihuZ9RKMhZFUO0ARUKTzNv//mRWReMFSmbLbuso/ubtsysQZjUr9B0XNgZq/veXh3gZ BAXQ== MIME-Version: 1.0 X-Received: by 10.112.144.69 with SMTP id sk5mr12019423lbb.44.1388430232813; Mon, 30 Dec 2013 11:03:52 -0800 (PST) Received: by 10.152.133.66 with HTTP; Mon, 30 Dec 2013 11:03:52 -0800 (PST) In-Reply-To: References: <87d2kk4zcn.fsf@gmail.com> Date: Mon, 30 Dec 2013 12:03:52 -0700 Message-ID: Subject: Re: bug#16254: 24.3.50; [PATCH] bzr error on emacs trunk using vc-print-log From: Christoph To: Glenn Morris Content-Type: multipart/alternative; boundary=047d7b3432f4d285b504eec51a81 X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 16254 Cc: 16254@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.4 (/) --047d7b3432f4d285b504eec51a81 Content-Type: text/plain; charset=ISO-8859-1 OK. I has bugged me long enough though that I finally sat down to work out a fix. It does work in vc-dir for edited files. vc-dir is not really an equivalent use case though since it does not allow to show a full listing of (up-to-date) files and hence to see their logs. Or am I missing something? On Mon, Dec 30, 2013 at 11:41 AM, Glenn Morris wrote: > Christoph wrote: > > > It would be nice if a fix for this issue made it into 24.4. Or do you > think > > that this is too intrusive of a change? > > 24.4 is still some way off. BTW, it does not work correctly in 23.4 or > 24.1, so it does not seem that urgent to me. It works fine from a vc-dir > buffer, just not a dired buffer. > --047d7b3432f4d285b504eec51a81 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
OK. I has bugged me long enough though that I finally sat = down to work out a fix.

It does work in vc-dir for edite= d files. vc-dir is not really an equivalent use case though since it does n= ot allow to show a full listing of (up-to-date) files and hence to see thei= r logs. Or am I missing something?


On Mon,= Dec 30, 2013 at 11:41 AM, Glenn Morris <rgm@gnu.org> wrote:
Christoph wrote:

> It would be nice if a fix for this issue made it into 24.4. Or do you = think
> that this is too intrusive of a change?

24.4 is still some way off. BTW, it does not work correctly in 23.4 or
24.1, so it does not seem that urgent to me. It works fine from a vc-dir buffer, just not a dired buffer.

--047d7b3432f4d285b504eec51a81-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 09 09:02:06 2020 Received: (at 16254) by debbugs.gnu.org; 9 Sep 2020 13:02:07 +0000 Received: from localhost ([127.0.0.1]:57764 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFzji-0006rA-JY for submit@debbugs.gnu.org; Wed, 09 Sep 2020 09:02:06 -0400 Received: from quimby.gnus.org ([95.216.78.240]:53850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFzjf-0006qG-PA for 16254@debbugs.gnu.org; Wed, 09 Sep 2020 09:02:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yxodHLWJ8AbsYFqn4/3Jb33mFGuXOoZb70/bFvaGhfI=; b=D1GEuDbQZHqZd1hoXLtBI7xTNh NerWWa3JyusVWYUDoI/hGsSwqMQAy58gimm3ohcLylZbhiTKlT3s7O4sb5OvQME9unIlAvjig5dQI mC4zkVV1Ygu87wanMJXnaqG3KXEdiLDJJDOVEPCpn1kFmhkAWoA1yk4CetW6LPRpX2Vk=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFzjO-0002mI-Kk; Wed, 09 Sep 2020 15:01:56 +0200 From: Lars Ingebrigtsen To: Christoph Subject: Re: bug#16254: 24.3.50; bzr error on emacs trunk using vc-print-log References: <87d2kk4zcn.fsf@gmail.com> X-Now-Playing: LCD Soundsystem's _Freak Out Starry Eyes_: "Freak Out Starry Eyes" Date: Wed, 09 Sep 2020 15:01:45 +0200 In-Reply-To: (Christoph's message of "Thu, 26 Dec 2013 19:47:07 -0700") Message-ID: <87tuw79k92.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Christoph writes: > The following patch adds detection (and filtering) of unregistered members to > vc-dired-deduce-fileset. > If the marked files have any unregistered files among them, the unregistered files > are fi [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 16254 Cc: 16254@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Christoph writes: > The following patch adds detection (and filtering) of unregistered members to > vc-dired-deduce-fileset. > If the marked files have any unregistered files among them, the unregistered files > are filtered out. > If all files are unregistered, an error is shown. This also covers the main case of > selecting just one unregistered file/directory. [...] > (defun vc-dired-deduce-fileset () > - (let ((backend (vc-responsible-backend default-directory))) > - (unless backend (error "Directory not under VC")) > - (list backend > - (dired-map-over-marks (dired-get-filename nil t) nil)))) > + "Deduce a set of files and a backend to which to apply an > +operation from all the marked items in a dired buffer. Resulting > +fileset only includes items that are version controlled." > + (let ((backend (vc-responsible-backend default-directory)) > + (fileset > + (delq nil (mapcar > + (lambda (x) (if (not (equal (vc-backend x) nil)) x)) > + (dired-map-over-marks > + (dired-get-filename nil t) > + nil))))) The code in question has changed substantially since this patch was proposed six years ago. It's now: (defun dired-vc-deduce-fileset (&optional state-model-only-files not-state-changing) (let ((backend (vc-responsible-backend default-directory)) (files (dired-get-marked-files nil nil nil nil t)) only-files-list state model) If I'm reading it correctly, it... more or less covers the same things that this patch was supposed to do (but in a totally different way?), so I guess this patch is no longer necessary. So I'm closing this bug report. If there still is something here that needs fixing, please respond to the debbugs address, and we'll reopen. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 09 09:02:15 2020 Received: (at control) by debbugs.gnu.org; 9 Sep 2020 13:02:15 +0000 Received: from localhost ([127.0.0.1]:57767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFzjq-0006rW-Tw for submit@debbugs.gnu.org; Wed, 09 Sep 2020 09:02:15 -0400 Received: from quimby.gnus.org ([95.216.78.240]:53866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kFzjp-0006rJ-Em for control@debbugs.gnu.org; Wed, 09 Sep 2020 09:02:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=1k7yF3GBWVHXn4N/6jvuCHXWwzPBu7cjFhvsiwAseUc=; b=h7ZqVhu4rhRx7jep5Bafo3Q9Ao EQb8jhYyxMY5rZcOV7FcudeORmrS8sFOanE+yx1Lh2lWrd6Kb3ScbtTnpNts7KCjzSYxRfPO6d1NR co13gWLdRFqIQqD35n7tW52etTU3HYN3s/YHQo3r8jCcBxGqO3mCWB+g9uvS8DBDnQN0=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kFzjd-0002mQ-Pi for control@debbugs.gnu.org; Wed, 09 Sep 2020 15:02:07 +0200 Date: Wed, 09 Sep 2020 15:02:00 +0200 Message-Id: <87sgbr9k8n.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #16254 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 16254 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 16254 quit From unknown Sat Aug 16 10:43:07 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 08 Oct 2020 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator