From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 25 00:58:43 2013 Received: (at submit) by debbugs.gnu.org; 25 Dec 2013 05:58:43 +0000 Received: from localhost ([127.0.0.1]:40293 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VvhUQ-0006Kl-TF for submit@debbugs.gnu.org; Wed, 25 Dec 2013 00:58:43 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53644) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VvhUL-0006KW-JY for submit@debbugs.gnu.org; Wed, 25 Dec 2013 00:58:38 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VvhUB-0001YV-9R for submit@debbugs.gnu.org; Wed, 25 Dec 2013 00:58:37 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_40 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54466) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvhUB-0001YR-6T for submit@debbugs.gnu.org; Wed, 25 Dec 2013 00:58:27 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55350) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvhU2-0007Pl-H9 for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2013 00:58:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VvhTt-0001Xz-VT for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2013 00:58:18 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:33801) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VvhTt-0001Xv-Nl for bug-gnu-emacs@gnu.org; Wed, 25 Dec 2013 00:58:09 -0500 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id rBP5w7ud032477 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 25 Dec 2013 05:58:08 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rBP5w613022699 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Wed, 25 Dec 2013 05:58:07 GMT Received: from ubhmt101.oracle.com (ubhmt101.oracle.com [156.151.24.6]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rBP5w6qG020024 for ; Wed, 25 Dec 2013 05:58:06 GMT MIME-Version: 1.0 Message-ID: <497ebd3d-d69b-4ac4-9d8c-ca2f4a1a2ac1@default> Date: Tue, 24 Dec 2013 21:58:04 -0800 (PST) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 24.3.50; `icomplete-mode' breaks my file opening now X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) [The build noted below is the one this bug report is for. But I'm sending this using an older build than the one noted below, because of another new bug, which prevents using `report-emacs-bug'] Just a preliminary heads up for now. Hope to add more info later, when I get some time. I downloaded this build, and when `icomplete-mode' is on, with my setup it takes several seconds to gather the list of file candidates in my usual directory. With a build from two days ago, this does not happen. And if I turn off icomplete mode it also does not happen. It seems that something was changed in the icomplete mode code recently that breaks at least my file-finding code. With emacs -Q I do not notice the problem (well, maybe a slight delay). I see that C-x C-f now shows completions immediately, without my typing any prefix. That is not true in the build from 2 days ago. In GNU Emacs 24.3.50.1 (i686-pc-mingw32) of 2013-12-24 on ODIEONE Bzr revision: 115738 cyd@gnu.org-20131225030511-ru56hhc243pxja04 Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D/c/Devel/emacs/binary --enable-checking=3Dyes,glyphs 'CFLAGS=3D-O0 -g3' LDFLAGS=3D-Lc:/Devel/emacs/lib CPPFLAGS=3D-Ic:/Devel/emacs/include' From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 25 02:04:20 2013 Received: (at 16251) by debbugs.gnu.org; 25 Dec 2013 07:04:20 +0000 Received: from localhost ([127.0.0.1]:40410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VviVv-00007n-Gt for submit@debbugs.gnu.org; Wed, 25 Dec 2013 02:04:20 -0500 Received: from mail-pa0-f47.google.com ([209.85.220.47]:35632) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VvhpM-00074j-MO for 16251@debbugs.gnu.org; Wed, 25 Dec 2013 01:20:21 -0500 Received: by mail-pa0-f47.google.com with SMTP id kq14so7180903pab.20 for <16251@debbugs.gnu.org>; Tue, 24 Dec 2013 22:20:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=a313LFDCn49aar0vjfoYJLpJB3Ce7um4i9o5oO7gHN4=; b=r1965ebNCqRrsQ1nCqMRvs+TeBT8ruPRzxl0Atv4q63Yz/xHiOyySxe7lLwZuwnMvU ACSutzmreQcaXtpNqCTh+t3J4JS1Uwpw6o+iQ3fJ8ErhiSBJhbCsRaOvYZArIGvd0FXg DVEwIHLe7WR6bwhbY6K9YyFl/B7U3BTcK8WNsQWgLfphKOACoyRuZSnxuGp433mObQWd b2KC/2g03meknq2g2k164SaT6VOu7tA6Jy0cUudxjRpCuXunlww9HNNfqid8KGiSxfLn sVWSVvlE/R+tjp5lpcubnr0MgvY6NOx5LhH9d70v5mG2E1+1Q0SErAxnemF37TS83Cix Sk+A== X-Received: by 10.66.139.100 with SMTP id qx4mr19495453pab.141.1387952419548; Tue, 24 Dec 2013 22:20:19 -0800 (PST) Received: from debian-6.05 ([101.63.186.242]) by mx.google.com with ESMTPSA id vh3sm45990553pbc.8.2013.12.24.22.20.16 for (version=TLSv1.1 cipher=RC4-SHA bits=128/128); Tue, 24 Dec 2013 22:20:18 -0800 (PST) From: Jambunathan K To: Drew Adams Subject: Re: bug#16251: 24.3.50; `icomplete-mode' breaks my file opening now References: <497ebd3d-d69b-4ac4-9d8c-ca2f4a1a2ac1@default> Date: Wed, 25 Dec 2013 11:48:40 +0530 In-Reply-To: <497ebd3d-d69b-4ac4-9d8c-ca2f4a1a2ac1@default> (Drew Adams's message of "Tue, 24 Dec 2013 21:58:04 -0800 (PST)") Message-ID: <87wqit1min.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 16251 X-Mailman-Approved-At: Wed, 25 Dec 2013 02:04:18 -0500 Cc: 16251@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Drew Adams writes: > It seems that something was changed in the icomplete mode code recently > that breaks at least my file-finding code. What happens if you turn this off: icomplete-show-matches-on-no-input From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 25 03:30:18 2013 Received: (at 16251) by debbugs.gnu.org; 25 Dec 2013 08:30:18 +0000 Received: from localhost ([127.0.0.1]:40515 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vvjr6-0002sO-IW for submit@debbugs.gnu.org; Wed, 25 Dec 2013 03:30:17 -0500 Received: from dancol.org ([96.126.100.184]:47345) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vvjr2-0002sA-BR for 16251@debbugs.gnu.org; Wed, 25 Dec 2013 03:30:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Subject:To:MIME-Version:From:Date:Message-ID; bh=8x7VQNIG9Gu8uXvkA5kR1AjT1rXJkh5gIPUV9KoDK6U=; b=eWh+G1qZFJ5EN4XOZmEycMQbZs8oP73Q4fJ06DGlQuGWSsBMxRaZHTMRgHvp0+S9PguEqUqfmKSECToJAzdYN8tlDDJFhii7xUsPjR/hRmhXRrRDMm8Ojp2clHP4+x7kvxqG/+Z7Xaal6qjwJn/58PcSCLUJezDr1wsFuNFM7p9MD0MYcYPkyPhcayii9O7TCkrpNwGbzabrxVINd8ACSE6kokPKGUFfVt8XsmFULfdcO1NzJCYFswCw7tHiyA6U1qSAzWWwq+xZzNz2TGmsj69v6tGgWwiS+uhOTaet7FYFKdO5ielbNfou88dTVWkq7bH/poheDrnIZpbYRgrPRg==; Received: from c-76-22-66-162.hsd1.wa.comcast.net ([76.22.66.162] helo=[192.168.1.100]) by dancol.org with esmtpsa (TLS1.0:DHE_RSA_CAMELLIA_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1Vvjr0-00015v-Nh; Wed, 25 Dec 2013 00:30:10 -0800 Message-ID: <52BA978F.4010804@dancol.org> Date: Wed, 25 Dec 2013 00:30:07 -0800 From: Daniel Colascione User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.2.0 MIME-Version: 1.0 To: Drew Adams , 16251@debbugs.gnu.org Subject: Re: bug#16251: 24.3.50; `icomplete-mode' breaks my file opening now References: <497ebd3d-d69b-4ac4-9d8c-ca2f4a1a2ac1@default> In-Reply-To: <497ebd3d-d69b-4ac4-9d8c-ca2f4a1a2ac1@default> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.5 (/) X-Debbugs-Envelope-To: 16251 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On 12/24/2013 09:58 PM, Drew Adams wrote: > [The build noted below is the one this bug report is for. But I'm > sending this using an older build than the one noted below, because of > another new bug, which prevents using `report-emacs-bug'] > > > Just a preliminary heads up for now. Hope to add more info later, when > I get some time. > > I downloaded this build, and when `icomplete-mode' is on, with my setup > it takes several seconds to gather the list of file candidates in my > usual directory. With a build from two days ago, this does not happen. > And if I turn off icomplete mode it also does not happen. > > It seems that something was changed in the icomplete mode code recently > that breaks at least my file-finding code. > > With emacs -Q I do not notice the problem (well, maybe a slight delay). > I see that C-x C-f now shows completions immediately, without my typing > any prefix. That is not true in the build from 2 days ago. Mea culpa: I committed a change that caused icomplete to try to show completions right away by default. As Jambunathan mentions, setting icomplete-show-matches-on-no-input to nil should restore the old behavior. The old behavior isn't optimal, though, and icomplete isn't a replacement for iswitchb without the feature I added. Maybe we can change icomplete-show-matches-on-no-input to a command list --- this way, we could show completions early for buffer switching, but not for finding files. Why is finding the list of files so slow for you? Don't you experience the same performance problem after typing a character and forcing completions to show up? We call the completion function inside while-no-input, so we should abort the "several seconds" of work as soon as you start typing. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 25 12:17:56 2013 Received: (at 16251) by debbugs.gnu.org; 25 Dec 2013 17:17:56 +0000 Received: from localhost ([127.0.0.1]:41587 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vvs5j-0005IC-Jq for submit@debbugs.gnu.org; Wed, 25 Dec 2013 12:17:55 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:45891) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vvs5g-0005I1-TQ for 16251@debbugs.gnu.org; Wed, 25 Dec 2013 12:17:53 -0500 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id rBPHHoqi029792 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 25 Dec 2013 17:17:50 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rBPHHnd9024514 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 25 Dec 2013 17:17:50 GMT Received: from ubhmt101.oracle.com (ubhmt101.oracle.com [156.151.24.6]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rBPHHnSn008548; Wed, 25 Dec 2013 17:17:49 GMT MIME-Version: 1.0 Message-ID: <225906ba-52b0-4100-bd6e-11b3e0bf07bb@default> Date: Wed, 25 Dec 2013 09:17:46 -0800 (PST) From: Drew Adams To: Jambunathan K Subject: RE: bug#16251: 24.3.50; `icomplete-mode' breaks my file opening now References: <497ebd3d-d69b-4ac4-9d8c-ca2f4a1a2ac1@default> <87wqit1min.fsf@gmail.com> In-Reply-To: <87wqit1min.fsf@gmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 16251 Cc: 16251@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) > > It seems that something was changed in the icomplete mode code recently > > that breaks at least my file-finding code. >=20 > What happens if you turn this off: icomplete-show-matches-on-no-input Yes, thank you! That removes the problem. Any idea (without knowing my code) why this makes a huge difference with my code but not a huge difference with emacs -Q? IOW, is there something particular in the new icomplete code to be aware of here? From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 25 12:23:38 2013 Received: (at 16251) by debbugs.gnu.org; 25 Dec 2013 17:23:38 +0000 Received: from localhost ([127.0.0.1]:41591 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VvsBD-0005T7-KH for submit@debbugs.gnu.org; Wed, 25 Dec 2013 12:23:36 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:44461) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VvsBA-0005Sw-GN for 16251@debbugs.gnu.org; Wed, 25 Dec 2013 12:23:33 -0500 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id rBPHNI7g010703 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 25 Dec 2013 17:23:19 GMT Received: from userz7021.oracle.com (userz7021.oracle.com [156.151.31.85]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rBPHNHfA013803 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 25 Dec 2013 17:23:18 GMT Received: from ubhmt101.oracle.com (ubhmt101.oracle.com [156.151.24.6]) by userz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rBPHNH0Z021078; Wed, 25 Dec 2013 17:23:17 GMT MIME-Version: 1.0 Message-ID: <28ae7ba4-fea2-44ae-8cc9-3e026e6b72fb@default> Date: Wed, 25 Dec 2013 09:23:15 -0800 (PST) From: Drew Adams To: Daniel Colascione , 16251@debbugs.gnu.org Subject: RE: bug#16251: 24.3.50; `icomplete-mode' breaks my file opening now References: <497ebd3d-d69b-4ac4-9d8c-ca2f4a1a2ac1@default> <52BA978F.4010804@dancol.org> In-Reply-To: <52BA978F.4010804@dancol.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 16251 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) > Why is finding the list of files so slow for you? I don't know. And I don't have time right now to track it down. But I'll try to take a look later some time. > Don't you experience the same performance problem after typing > a character and forcing completions to show up? No, absolutely not. > We call the completion function inside while-no-input, so we > should abort the "several seconds" of work as soon as you start > typing. I didn't start typing. In Icicles it often makes sense to show all initial completions from the outset, either automatically or on demand. While waiting for better understanding of the problem, and possibly a fix if there is in fact a bug and solution, I will automatically turn off `icomplete-show-matches-on-no-input' when Icicle mode is turned on. BTW, there is no such problem with using IswitchB with Icicles, AFAIK. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 25 13:02:47 2013 Received: (at 16251) by debbugs.gnu.org; 25 Dec 2013 18:02:47 +0000 Received: from localhost ([127.0.0.1]:41659 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vvsn9-0006k5-Cr for submit@debbugs.gnu.org; Wed, 25 Dec 2013 13:02:47 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]:41130) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vvsn6-0006jl-EM for 16251@debbugs.gnu.org; Wed, 25 Dec 2013 13:02:45 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MYD00H00JFRB800@a-mtaout20.012.net.il> for 16251@debbugs.gnu.org; Wed, 25 Dec 2013 20:02:34 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MYD00HYCJG9A010@a-mtaout20.012.net.il>; Wed, 25 Dec 2013 20:02:34 +0200 (IST) Date: Wed, 25 Dec 2013 20:02:33 +0200 From: Eli Zaretskii Subject: Re: bug#16251: 24.3.50; `icomplete-mode' breaks my file opening now In-reply-to: <52BA978F.4010804@dancol.org> X-012-Sender: halo1@inter.net.il To: Daniel Colascione Message-id: <83iouc6c7a.fsf@gnu.org> References: <497ebd3d-d69b-4ac4-9d8c-ca2f4a1a2ac1@default> <52BA978F.4010804@dancol.org> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 16251 Cc: 16251@debbugs.gnu.org, drew.adams@oracle.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Wed, 25 Dec 2013 00:30:07 -0800 > From: Daniel Colascione > > Why is finding the list of files so slow for you? Don't you experience > the same performance problem after typing a character and forcing > completions to show up? We call the completion function inside > while-no-input, so we should abort the "several seconds" of work as soon > as you start typing. Maybe because input on Windows is not signal-driven, and therefore while-no-input relies on the Lisp code paying frequent attention to QUIT. I tried just now enabling icomplete-mode in "emacs -Q", and can confirm that "C-x C-f" becomes painfully slow to react to typing in a large directory, especially with a cold cache. From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 27 07:59:56 2013 Received: (at 16251-done) by debbugs.gnu.org; 27 Dec 2013 12:59:56 +0000 Received: from localhost ([127.0.0.1]:45656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VwX19-0005xs-V8 for submit@debbugs.gnu.org; Fri, 27 Dec 2013 07:59:56 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]:60712) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VwX18-0005xi-AN for 16251-done@debbugs.gnu.org; Fri, 27 Dec 2013 07:59:55 -0500 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id rBRCxoTA017384; Fri, 27 Dec 2013 07:59:51 -0500 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 3320CAE27C; Fri, 27 Dec 2013 07:59:51 -0500 (EST) From: Stefan Monnier To: Drew Adams Subject: Re: bug#16251: 24.3.50; `icomplete-mode' breaks my file opening now Message-ID: References: <497ebd3d-d69b-4ac4-9d8c-ca2f4a1a2ac1@default> Date: Fri, 27 Dec 2013 07:59:51 -0500 In-Reply-To: <497ebd3d-d69b-4ac4-9d8c-ca2f4a1a2ac1@default> (Drew Adams's message of "Tue, 24 Dec 2013 21:58:04 -0800 (PST)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4804=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4804> : inlines <364> : streams <1097742> : uri <1636417> X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 16251-done Cc: 16251-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) > I downloaded this build, and when `icomplete-mode' is on, with my setup > it takes several seconds to gather the list of file candidates in my > usual directory. I just reverted icomplete-show-matches-on-no-input to nil, which I think is the right default. That it can take a long time to get the completions is not in itself a bug. There are 2 potential bugs left, tho: - hitting a key should interrupt the completions processing (so that the long wait should not prevent you from getting work done). If it doesn't, then we have a bug. Please report it separately, with as much details as possible to reproduce it (it's probably a problem in the C code). - ideally completion should never take that long, so we probably have a performance bug somewhere. Of course, that might also be in your local code (.emacs, icicles, ...). -- Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 27 19:55:23 2013 Received: (at 16251-done) by debbugs.gnu.org; 28 Dec 2013 00:55:23 +0000 Received: from localhost ([127.0.0.1]:47394 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VwiBW-0003sq-GJ for submit@debbugs.gnu.org; Fri, 27 Dec 2013 19:55:22 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:42199) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VwiBS-0003sb-V2 for 16251-done@debbugs.gnu.org; Fri, 27 Dec 2013 19:55:19 -0500 Received: from acsinet22.oracle.com (acsinet22.oracle.com [141.146.126.238]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id rBS0tGTp006315 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 28 Dec 2013 00:55:17 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by acsinet22.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rBS0tFro019743 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 28 Dec 2013 00:55:16 GMT Received: from ubhmt101.oracle.com (ubhmt101.oracle.com [156.151.24.6]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rBS0tFCW018186; Sat, 28 Dec 2013 00:55:15 GMT MIME-Version: 1.0 Message-ID: <818df3a7-a5fa-4871-86e1-0bd5d8e4a5fc@default> Date: Fri, 27 Dec 2013 16:55:11 -0800 (PST) From: Drew Adams To: Stefan Monnier Subject: RE: bug#16251: 24.3.50; `icomplete-mode' breaks my file opening now References: <497ebd3d-d69b-4ac4-9d8c-ca2f4a1a2ac1@default> In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet22.oracle.com [141.146.126.238] X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 16251-done Cc: 16251-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) > > I downloaded this build, and when `icomplete-mode' is on, with my > > setup it takes several seconds to gather the list of file candidates > > in my usual directory. This was my bad. I was passing this to `cl-delete-if': (regexp-opt completion-ignored-extensions). Taking that calculation out of the loop saved 13 seconds! (99% of the total time). FWIW, here are some times (now) of various parts (with my code, with my find-file replacement, in my typical startup directory, about 2400 files): completion-all-completions: 680 ms deleting duplicates: 70 ms sorting: 470 ms Of course, sorting depends on the sort predicate. This was with a directories-first-then-alphabetical sort. > I just reverted icomplete-show-matches-on-no-input to nil, which > I think is the right default. Thx. > That it can take a long time to get the completions is not in itself > a bug. There are 2 potential bugs left, tho: > > - hitting a key should interrupt the completions processing (so that > the long wait should not prevent you from getting work done). > If it doesn't, then we have a bug. Please report it separately, with > as much details as possible to reproduce it (it's probably a problem > in the C code). That seems to work OK (as before). > - ideally completion should never take that long, so we probably have > a performance bug somewhere. Of course, that might also be in your > local code (.emacs, icicles, ...). See , above. A problem I do notice now (not sure why now) is that sometimes keys that I hit are "lost" instead of appearing in the input. AFAICT, this happens only when Icomplete is on. It can make completing input painful, to say the least. I don't have a handle yet on just what the behavior is or what causes it. Just mentioning it now in case someone happens to notice it also for vanilla Emacs. --- FWIW - One other thing is somewhat unfortunate in my context, so far: When you cycle among completion candidates (Icicles cycling, not Icomplete cycling), or when there is a sole matching candidate, by default Icicles shows info about the current (or the sole) candidate in the (*Completions*) mode line, for N sec. Hitting a key interrupts this, of course - it is done using `sit-for'. But of course `post-command-hook' actions do not take place until that delay is over. This means that icompletions do not show up until the mode-line display is finished. I guess I should instead show the info until some timer gets rid of it, so that it stays visible even when `post-command-hook' is run. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 28 03:51:41 2013 Received: (at 16251) by debbugs.gnu.org; 28 Dec 2013 08:51:41 +0000 Received: from localhost ([127.0.0.1]:47799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VwpcT-0001TP-Iu for submit@debbugs.gnu.org; Sat, 28 Dec 2013 03:51:41 -0500 Received: from mtaout20.012.net.il ([80.179.55.166]:46925) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VwpcR-0001TG-Aa for 16251@debbugs.gnu.org; Sat, 28 Dec 2013 03:51:40 -0500 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0MYI00H00DOM8P00@a-mtaout20.012.net.il> for 16251@debbugs.gnu.org; Sat, 28 Dec 2013 10:51:38 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MYI00HN9DY12F70@a-mtaout20.012.net.il>; Sat, 28 Dec 2013 10:51:38 +0200 (IST) Date: Sat, 28 Dec 2013 10:51:21 +0200 From: Eli Zaretskii Subject: Re: bug#16251: 24.3.50; `icomplete-mode' breaks my file opening now In-reply-to: <818df3a7-a5fa-4871-86e1-0bd5d8e4a5fc@default> X-012-Sender: halo1@inter.net.il To: Drew Adams Message-id: <83y5352wae.fsf@gnu.org> References: <497ebd3d-d69b-4ac4-9d8c-ca2f4a1a2ac1@default> <818df3a7-a5fa-4871-86e1-0bd5d8e4a5fc@default> X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 16251 Cc: 16251@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) > Date: Fri, 27 Dec 2013 16:55:11 -0800 (PST) > From: Drew Adams > Cc: 16251-done@debbugs.gnu.org > > completion-all-completions: 680 ms > deleting duplicates: 70 ms > sorting: 470 ms > > Of course, sorting depends on the sort predicate. This was with a > directories-first-then-alphabetical sort. How much time does sorting take if you request just alphabetical, without directories-first? It should take zero on Windows; if it doesn't, our sorting algorithm should be improved. From debbugs-submit-bounces@debbugs.gnu.org Sat Dec 28 11:02:07 2013 Received: (at 16251) by debbugs.gnu.org; 28 Dec 2013 16:02:07 +0000 Received: from localhost ([127.0.0.1]:48662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VwwL0-00089a-RS for submit@debbugs.gnu.org; Sat, 28 Dec 2013 11:02:07 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:48626) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VwwKy-00089S-Ae for 16251@debbugs.gnu.org; Sat, 28 Dec 2013 11:02:04 -0500 Received: from acsinet21.oracle.com (acsinet21.oracle.com [141.146.126.237]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id rBSG22MJ002432 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Sat, 28 Dec 2013 16:02:03 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by acsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rBSG21x6027511 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 28 Dec 2013 16:02:02 GMT Received: from abhmp0016.oracle.com (abhmp0016.oracle.com [141.146.116.22]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rBSG21nO009354; Sat, 28 Dec 2013 16:02:01 GMT MIME-Version: 1.0 Message-ID: Date: Sat, 28 Dec 2013 08:01:55 -0800 (PST) From: Drew Adams To: Eli Zaretskii Subject: RE: bug#16251: 24.3.50; `icomplete-mode' breaks my file opening now References: <<497ebd3d-d69b-4ac4-9d8c-ca2f4a1a2ac1@default>> <> <<818df3a7-a5fa-4871-86e1-0bd5d8e4a5fc@default>> <<83y5352wae.fsf@gnu.org>> In-Reply-To: <<83y5352wae.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: acsinet21.oracle.com [141.146.126.237] X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 16251 Cc: 16251@debbugs.gnu.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) > > completion-all-completions: 680 ms > > deleting duplicates: 70 ms > > sorting: 470 ms > > > > Of course, sorting depends on the sort predicate. This was with > > a directories-first-then-alphabetical sort. >=20 > How much time does sorting take if you request just alphabetical, > without directories-first? It should take zero on Windows; if it > doesn't, our sorting algorithm should be improved. I no longer have the debugging set up for this (calls to `message' etc., since it is impossible to use the debugger with Icomplete). =20 But IIRC it was not very different from that. But this the sorting I use here is the Icicles sorting, so the efficiency of its implementation should be irrelevant to emacs -Q. That is, if Icicle mode is on, I use the current Icicles sort function. From unknown Tue Aug 19 18:07:59 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 26 Jan 2014 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator