GNU bug report logs - #16243
24.3.50; shr-visit-file doesn't set the buffer's default-directory

Previous Next

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 16243 <at> debbugs.gnu.org
Subject: bug#16243: 24.3.50; shr-visit-file doesn't set the buffer's default-directory
Date: Tue, 24 Dec 2013 21:14:58 +0100

Eli Zaretskii <eliz <at> gnu.org> writes:

> Why is this a problem?  Because shr.el binds keys to commands that
> expect the buffer's directory to be set correctly.  For example, RET
> is bound to shr-browse-url, which (at least on Windows) needs to
> expand the linked file name relative to the directory of the file that
> is displayed in the buffer.

`shr-visit-file' was a half-assed command I added before I did eww, and
it should probably be removed.  It's not very useful any more.

But if we keep the command, then it should be altered to pass the
directory in as the HTTP base URL, which would make the URLs point to
the right thing without altering default-directory.

But setting default-directory might also be nice -- do "special mode"
buffers usually do so or not?

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.