GNU bug report logs - #16236
24.3.50; [PATCH] eww: Don't set local value.

Previous Next

Full log

View this message in rfc822 format

From: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
To: 16236 <at> debbugs.gnu.org
Subject: bug#16236: 24.3.50; [PATCH] eww: Don't set local value. 
Date: Tue, 24 Dec 2013 16:37:50 +0900

This report includes a patch to the bug. Please, review and install it
to the official tree if appreciated.

Now, eww-history-mode does not work well.
eww-history and eww-history-position should not be local value, since eww will
use them in eww-history-mode.

Or, just deleting two lines will work well.

-  (setq-local eww-history nil)
-  (setq-local eww-history-position 0)

Kenjiro

Signed-off-by: Kenjiro NAKAYAMA <knakayam <at> redhat.com>

        * net/eww.el (eww-mode): Don't set local value to eww-history and eww-history-position.

Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
---
 lisp/net/eww.el | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 89a7eb9..fdf5aca 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -467,8 +467,8 @@ word(s) will be searched for via `eww-search-prefix'."
   (setq-local eww-current-source nil)
   (setq-local browse-url-browser-function 'eww-browse-url)
   (setq-local after-change-functions 'eww-process-text-input)
-  (setq-local eww-history nil)
-  (setq-local eww-history-position 0)
+  (setq eww-history nil)
+  (setq eww-history-position 0)
   (when (boundp 'tool-bar-map)
    (setq-local tool-bar-map eww-tool-bar-map))
   (buffer-disable-undo)
-- 
1.8.3.1

Kenjiro NAKAYAMA

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.