GNU bug report logs - #16232
[PATCH] grep: make --ignore-case (-i) faster (sometimes 10x) in multibyte locales

Previous Next

Package: grep;

Reported by: Jim Meyering <jim <at> meyering.net>

Date: Mon, 23 Dec 2013 22:40:02 UTC

Severity: normal

Tags: patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log

Message #77 received at 16232 <at> debbugs.gnu.org (full text, mbox):

From: arnold <at> skeeve.com
To: jim <at> meyering.net, eggert <at> cs.ucla.edu
Cc: 16232 <at> debbugs.gnu.org
Subject: Re: bug#16232: [PATCH] grep: make --ignore-case (-i) faster
 (sometimes 10x) in multibyte locales
Date: Thu, 20 Feb 2014 10:22:49 -0700

Jim Meyering <jim <at> meyering.net> wrote:

> Hi Paul,
>
> In case your bug fix looks safe/small, and is ready, ...
>
> I'm hoping to release 2.18 today, with the attached commits.
> Changes since yesterday: comment/log tweaks, and I've hoisted the using_utf8
> test in trivial_case_ignore to precede the two memchr tests.

Hi Jim.

Why copy the using_utf8() routine out of dfa.c?  Why not just link
to it instead?  If it's static, make it extern... That way if the
logic ever changes then it only has to be changed in one place.

Just a thought. :-)

Arnold
This bug report was last modified 11 years and 82 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.