GNU bug report logs - #16231
[PATCH] Fix loop labels

Previous Next

Full log

View this message in rfc822 format

From: "Brian C. Lane" <bcl <at> redhat.com>
To: Phillip Susi <psusi <at> ubuntu.com>
Cc: 16231 <at> debbugs.gnu.org
Subject: bug#16231: [PATCH 0/9] Refactored loop fixes
Date: Thu, 22 May 2014 12:01:42 -0700

On Thu, May 22, 2014 at 09:32:33AM -0400, Phillip Susi wrote:
> On 5/21/2014 8:42 PM, Brian C. Lane wrote:
> > The problem is that the ntfs probe has a fixed 512b buffer and
> > tries to read a whole sector into it. The fat probes may also have
> > similar issues.
> 
> You must be using an out of date tree; commit 80678bdd957cf4 fixed that:
> 
>  static PedGeometry*
>  ntfs_probe (PedGeometry* geom)
>  {
> -       char    buf[512];
> +       char    *buf = alloca (geom->dev->sector_size);
> +       PedGeometry *newg = NULL;
> 

Sure enough, I was missing that one. Looks good, and passes all tests
on all arches.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.