GNU bug report logs - #16231
[PATCH] Fix loop labels

Previous Next

Package: parted;

Reported by: Phillip Susi <psusi <at> ubuntu.com>

Date: Mon, 23 Dec 2013 20:54:02 UTC

Severity: normal

Tags: patch

Done: Phillip Susi <psusi <at> ubuntu.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Phillip Susi <psusi <at> ubuntu.com>
To: 16231 <at> debbugs.gnu.org
Subject: bug#16231: [PATCH] Fix loop labels
Date: Sun, 29 Dec 2013 00:25:30 -0500
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

On 12/23/2013 03:17 PM, Phillip Susi wrote:
> Loop labels were incorrectly identifying the device for the
> fictional partition as $dev1 instead of just $dev. This caused
> other programs like gparted to be confused, and caused parted to
> fail to identify the partition as busy due to the fact that it was
> looking for the wrong device. Parted also actually created the
> partition device so your raw fs on $dev gained an alias as $dev1.

I had to tweak this patch just a bit more to get it fully working.  It
used to let you create a loop label, which had no partition, then when
you created a partition, it wiped out the loop signature.  Now it
implicitly creates the loop partition if you either have the loop
label signature, or a raw filesystem signature, and thus, has to leave
the signature intact, even if you have a partition, which may or may
not have a valid filesystem signature, depending on whether or not you
actually format a filesystem.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.14 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBCgAGBQJSv7JKAAoJEI5FoCIzSKrwrnQIAJJ0lRnELDG+RUeB4JknkkPU
YfkCeQXONrQ0/VUiIeCedA3PbLvPCo0T1aIHd7URp5T/Im4p2LAt4DqF98m7ih2f
xbWkrMo7Tww5y06qneOphazzCOHx0/o95z2NSCNu6bDDZ+QLL/MXrOXkFhId3yR8
BFbOvUQBfMP/9oRNirvwDBRxCO9ZdZDP23tPRlrdsvau7hvZCiSWRlQVeUHHtdD7
k4LvHMlHSDIdwc5a2+Eehblb0C2KS+H2f7QUeO26glxmNNvhf1mNEWRE7l9T4Phq
54g9UDaF+Bny4qJoN1bTrKJVdj9y4wRigAZ40QPhTWgNmoPfcvxPFnZCsb/Cfpw=
=yO/a
-----END PGP SIGNATURE-----




This bug report was last modified 11 years and 6 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.