GNU bug report logs - #16231
[PATCH] Fix loop labels

Previous Next

Full log

View this message in rfc822 format

From: "Brian C. Lane" <bcl <at> redhat.com>
To: Phillip Susi <psusi <at> ubuntu.com>
Cc: 16231 <at> debbugs.gnu.org
Subject: bug#16231: [PATCH 0/9] Refactored loop fixes
Date: Wed, 7 May 2014 15:49:13 -0700

On Fri, May 02, 2014 at 09:50:42PM -0400, Phillip Susi wrote:
> I have refactored the loop fixes making them cleaner, and breaking them out
> into separate patches for easier review.
> 
> Phillip Susi (9):
>   libparted: don't detect fat and ntfs boot sectors as dos MBR
>   libparted: remove old partitions *first* before adding new ones
>   libparted: remove all old partitions, even if new label allows less
>   libparted: fix loop labels to not vanish
>   libparted: don't create partition on loop label
>   partprobe: do not skip loop labels
>   libparted: give correct partition device name on loop labels
>   libparted: don't trash filesystem when writing loop label
>   tests: test loop labels
> 
>  NEWS                                    |  22 +++++++
>  libparted/arch/linux.c                  |  67 ++++++++++++--------
>  libparted/fs/ntfs/ntfs.c                |   2 +-
>  libparted/labels/dos.c                  |  29 +++++++++
>  libparted/labels/loop.c                 |  54 ++++++++---------
>  partprobe/partprobe.c                   |   4 +-
>  tests/Makefile.am                       |   2 +
>  tests/t1102-loop-label.sh               | 104 ++++++++++++++++++++++++++++++++
>  tests/t1104-remove-and-add-partition.sh |  50 +++++++++++++++
>  9 files changed, 275 insertions(+), 59 deletions(-)
>  create mode 100644 tests/t1102-loop-label.sh
>  create mode 100644 tests/t1104-remove-and-add-partition.sh
> 
> -- 
> 1.9.1
> 

NAK. These make a pile of the tests fail:

==========================================
   GNU parted 3.1: tests/test-suite.log
   ==========================================
   # TOTAL: 77
   # PASS:  27
   # SKIP:  35
   # XFAIL: 0
   # FAIL:  15
   # XPASS: 0
   # ERROR: 0
   .. contents:: :depth: 2

looks like at least one core dump in the mix.

-- 
Brian C. Lane | Anaconda Team | IRC: bcl #anaconda | Port Orchard, WA (PST8PDT)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.