GNU bug report logs - #16231
[PATCH] Fix loop labels

Previous Next

Full log

Message #44 received at 16231 <at> debbugs.gnu.org (full text, mbox):

From: Phillip Susi <psusi <at> ubuntu.com>
To: 16231 <at> debbugs.gnu.org
Cc: bcl <at> redhat.com
Subject: [PATCH 6/9] partprobe: do not skip loop labels
Date: Fri,  2 May 2014 21:50:48 -0400

Partprobe was not syncing loop labels.  This resulted it failing to remove
existing partitions when switching to a loop label.
---
 NEWS                  | 3 +++
 partprobe/partprobe.c | 4 +---
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/NEWS b/NEWS
index 385a120..f99c6fe 100644
--- a/NEWS
+++ b/NEWS
@@ -23,6 +23,9 @@ GNU parted NEWS                                    -*- outline -*-
 
 ** Bug Fixes
 
+  partprobe: when called on a disk that has become a loop label,
+  remove any partitions left over from a previous label.
+
   libparted: The loop label represents an unpartitioned disk, but creates
   a dummy partition to represent the whole disk.  This dummy partition
   was actually being loaded into the kernel.  Don't do that.
diff --git a/partprobe/partprobe.c b/partprobe/partprobe.c
index 4da4fb7..8b744b5 100644
--- a/partprobe/partprobe.c
+++ b/partprobe/partprobe.c
@@ -106,9 +106,7 @@ process_dev (PedDevice* dev)
 	PedDisk*	disk;
 
 	disk_type = ped_disk_probe (dev);
-	if (disk_type && !strcmp (disk_type->name, "loop"))
-		return 1;
-	else if (!disk_type) {
+	if (!disk_type) {
 		/* Partition table not found, so create dummy,
 		   empty one */
 		disk_type = ped_disk_type_get("msdos");
-- 
1.9.1

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.