GNU bug report logs - #16226
[patch] icomplete can't display completions on initial display

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16226 in the body.
You can then email your comments to 16226 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Colascione <dancol <at> dancol.org>
To: bug-emacs <bug-gnu-emacs <at> gnu.org>
Subject: [patch] icomplete can't display completions on initial display
Date: Mon, 23 Dec 2013 07:47:09 -0800

[Message part 1 (text/plain, inline)]

This patch allows icomplete to work a bit more like iswitchb and show a 
list of completions when first entering a completion task.

[compl.patch (text/x-patch, attachment)]

Message #8 received at 16226 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Daniel Colascione <dancol <at> dancol.org>
Cc: 16226 <at> debbugs.gnu.org
Subject: Re: bug#16226: [patch] icomplete can't display completions on initial
 display
Date: Mon, 23 Dec 2013 22:32:14 -0500

> +(defcustom icomplete-show-matches-on-no-input t
> +  "When non-nil, show completions when first prompting for input."
> +  :type 'boolean
> +  :version "24.4"
> +  :group 'icomplete)

The ":group 'icomplete" is redundant (I know it's there in the other
defcustoms, and yes, it's also redundant there).

> +      (if (and (or (> (icomplete--field-end) (icomplete--field-beg))
> +                   (and icomplete-show-matches-on-no-input
> +                        (= (icomplete--field-end) (icomplete--field-beg))))

The (= (icomplete--field-end) (icomplete--field-beg)) condition is
redundant as well.  Other than that, please install it.


        Stefan

Message #11 received at 16226 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Colascione <dancol <at> dancol.org>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: 16226 <at> debbugs.gnu.org
Subject: Re: bug#16226: [patch] icomplete can't display completions on initial
 display
Date: Mon, 23 Dec 2013 19:53:05 -0800

On 12/23/2013 07:32 PM, Stefan Monnier wrote:
> The (= (icomplete--field-end) (icomplete--field-beg)) condition is
> redundant as well.  Other than that, please install it.

Done. Thanks.

The next problem for me is the obnoxious prompt: when icomplete is 
enabled, the default choice is readily apparent. switch-to-buffer, 
however, still enthusiastically displays the "default" choice in the 
prompt, and this hint becomes stale once we start cycling through 
completions. Right now, I'm using minibuf-eldef to kill that part of the 
prompt, but there must be a better way. Would you be opposed to a C 
level variable that stopped completions functions from adding the 
default choice bit to the prompt in the first place?

Message #14 received at 16226 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
To: Daniel Colascione <dancol <at> dancol.org>
Cc: 16226 <at> debbugs.gnu.org
Subject: Re: bug#16226: [patch] icomplete can't display completions on initial
 display
Date: Tue, 24 Dec 2013 09:45:42 -0500

> The next problem for me is the obnoxious prompt: when icomplete is enabled,
> the default choice is readily apparent. switch-to-buffer, however, still
> enthusiastically displays the "default" choice in the prompt, and this hint
> becomes stale once we start cycling through completions. Right now, I'm
> using minibuf-eldef to kill that part of the prompt, but there must
> be a better way.

I think minibuf-eldef is the way to go, yes.

> Would you be opposed to a C level variable that stopped completions
> functions from adding the default choice bit to the prompt in the
> first place?

That wouldn't work, since the default is added "by hand" at
tens/hundreds of places.


        Stefan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.