From unknown Sun Jun 22 07:56:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16225: 24.3.50; [PATCH] eww: machinery to set character encoding. Resent-From: Kenjiro NAKAYAMA Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 23 Dec 2013 15:39:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 16225@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.138781313114169 (code B ref -1); Mon, 23 Dec 2013 15:39:03 +0000 Received: (at submit) by debbugs.gnu.org; 23 Dec 2013 15:38:51 +0000 Received: from localhost ([127.0.0.1]:36015 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vv7aj-0003gS-LO for submit@debbugs.gnu.org; Mon, 23 Dec 2013 10:38:51 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33175) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vv7ad-0003gC-Ic for submit@debbugs.gnu.org; Mon, 23 Dec 2013 10:38:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vv7aU-0000Dj-TH for submit@debbugs.gnu.org; Mon, 23 Dec 2013 10:38:43 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57342) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vv7aU-0000Dd-QN for submit@debbugs.gnu.org; Mon, 23 Dec 2013 10:38:34 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34767) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vv7aL-0006XP-Vz for bug-gnu-emacs@gnu.org; Mon, 23 Dec 2013 10:38:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vv7aD-00008d-DL for bug-gnu-emacs@gnu.org; Mon, 23 Dec 2013 10:38:25 -0500 Received: from mail-pd0-x232.google.com ([2607:f8b0:400e:c02::232]:41072) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vv7aD-00008N-17 for bug-gnu-emacs@gnu.org; Mon, 23 Dec 2013 10:38:17 -0500 Received: by mail-pd0-f178.google.com with SMTP id y10so5238620pdj.23 for ; Mon, 23 Dec 2013 07:38:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=user-agent:from:to:subject:date:message-id:mime-version :content-type; bh=wVO43tWo04rloFjY24RNb3sl3yCqjb30TfeaCBlNdCQ=; b=xX+xiACU8PkwyUBeALC5EjDhMZPpiKUt+JHd/XMR+ONvVONHwKI9iFRuE27nN9A9nu Kbruf25Mf5kXTRbJcONMQomqdmlwhzDXrBtweAen51RhlOvAecX42Tua5fGrMeuGqJ9E kLOkyZnb27bwkuLrbYfqfknTgvmLvmFzKwIk6/JYvK99T2qu7dancskm7K9FDMLOpx9M 0rdwV0WS9WPXjEBpTm5v4SOBjIpkgDBwi+IrFBYcsvb8/b54XLTNJGCqHNqNQI49YKuH Uuko3QB+Pm1brJrUQI1Nxs8D759uO7XajkRSCRX6B7VwMZZT56E60wgy+++zBhRJWHeR m0Gw== X-Received: by 10.66.165.4 with SMTP id yu4mr10331218pab.88.1387813095168; Mon, 23 Dec 2013 07:38:15 -0800 (PST) Received: from dhcp-193-97.nrt.redhat.com (nat-pool-nrt-t1.redhat.com. [66.187.238.10]) by mx.google.com with ESMTPSA id lh13sm45956116pab.4.2013.12.23.07.38.12 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Dec 2013 07:38:14 -0800 (PST) User-agent: mu4e 0.9.9.6pre2; emacs 24.3.50.3 From: Kenjiro NAKAYAMA Date: Tue, 24 Dec 2013 00:38:07 +0900 Message-ID: <87eh53h928.fsf@dhcp-193-97.nrt.redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) This report includes a patch to the bug. Please, review and install it to the official tree if appreciated. The user can't change encoding type. This patch is to fix it. Signed-off-by: Kenjiro NAKAYAMA * net/eww.el (eww-character-encoding): Default value of encoding type. (eww-display-html,eww-display-raw): Change to enable to set encoding type. (eww-mode-map): New key map and easy-menu to set encoding type. (eww-set-character-encoding): New funtion to set encoding type. --- lisp/net/eww.el | 33 +++++++++++++++++++++++++++------ 1 file changed, 27 insertions(+), 6 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 89a7eb9..9353b6e 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -129,6 +129,7 @@ See also `eww-form-checkbox-selected-symbol'." (defvar eww-home-url nil) (defvar eww-start-url nil) (defvar eww-contents-url nil) +(defvar eww-character-encoding 'utf-8) (defvar eww-local-regex "localhost" "When this regex is found in the URL, it's not a keyword but an address.") @@ -189,7 +190,7 @@ word(s) will be searched for via `eww-search-prefix'." (or (cdr (assq 'charset (cdr content-type))) (eww-detect-charset (equal (car content-type) "text/html")) - "utf8")))) + "utf-8")))) (data-buffer (current-buffer))) (unwind-protect (progn @@ -243,9 +244,9 @@ word(s) will be searched for via `eww-search-prefix'." (defun eww-display-html (charset url &optional document point) (or (fboundp 'libxml-parse-html-region) (error "This function requires Emacs to be compiled with libxml2")) - (unless (eq charset 'utf8) + (unless (eq charset eww-character-encoding) (condition-case nil - (decode-coding-region (point) (point-max) charset) + (decode-coding-region (point) (point-max) eww-character-encoding) (coding-system-error nil))) (let ((document (or document @@ -364,7 +365,12 @@ word(s) will be searched for via `eww-search-prefix'." (let ((data (buffer-substring (point) (point-max)))) (eww-setup-buffer) (let ((inhibit-read-only t)) - (insert data)) + (insert data) + (unless (eq eww-character-encoding 'utf-8) + (encode-coding-region (point-min) (1+ (length data)) 'utf-8) + (condition-case nil + (decode-coding-region (point-min) (1+ (length data)) eww-character-encoding) + (coding-system-error nil)))) (goto-char (point-min)))) (defun eww-display-image () @@ -417,6 +423,7 @@ word(s) will be searched for via `eww-search-prefix'." (define-key map "C" 'url-cookie-list) (define-key map "v" 'eww-view-source) (define-key map "H" 'eww-list-histories) + (define-key map "E" 'eww-set-character-encoding) (define-key map "b" 'eww-add-bookmark) (define-key map "B" 'eww-list-bookmarks) @@ -439,7 +446,8 @@ word(s) will be searched for via `eww-search-prefix'." ["List histories" eww-list-histories t] ["Add bookmark" eww-add-bookmark t] ["List bookmarks" eww-list-bookmarks t] - ["List cookies" url-cookie-list t])) + ["List cookies" url-cookie-list t] + ["Character Encoding" eww-set-character-encoding])) map)) (defvar eww-tool-bar-map @@ -1029,7 +1037,7 @@ If EXTERNAL, browse the URL using `shr-external-browser'." ((and (url-target (url-generic-parse-url url)) (eww-same-page-p url eww-current-url)) (eww-save-history) - (eww-display-html 'utf8 url eww-current-dom)) + (eww-display-html eww-character-encoding url eww-current-dom)) (t (eww-browse-url url))))) @@ -1080,6 +1088,19 @@ Differences in #targets are ignored." (setq count (1+ count))) (expand-file-name file directory))) +(defun eww-set-character-encoding (encode) + "Set character encoding." + (interactive "sSet Character Encoding (default utf-8): ") + (cond ((zerop (length encode)) + (setq eww-character-encoding 'utf-8) + (message "The change will take effect next load.")) + (t + (if (not (coding-system-p (car (read-from-string encode)))) + (user-error "Invalid encodeing type.") + (setq eww-character-encoding (car (read-from-string encode))) + (message "The change will take effect next load.") + )))) + ;;; Bookmarks code (defvar eww-bookmarks nil) -- 1.8.3.1 From unknown Sun Jun 22 07:56:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16225: 24.3.50; [PATCH] eww: machinery to set character encoding. Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Dec 2013 08:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Kenjiro NAKAYAMA Cc: 16225@debbugs.gnu.org Received: via spool by 16225-submit@debbugs.gnu.org id=B16225.13878719458506 (code B ref 16225); Tue, 24 Dec 2013 08:00:02 +0000 Received: (at 16225) by debbugs.gnu.org; 24 Dec 2013 07:59:05 +0000 Received: from localhost ([127.0.0.1]:37574 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VvMtM-0002D6-8c for submit@debbugs.gnu.org; Tue, 24 Dec 2013 02:59:04 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:43054) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VvMtI-0002Cd-V6 for 16225@debbugs.gnu.org; Tue, 24 Dec 2013 02:59:01 -0500 Received: from 77.18.245.69.tmi.telenormobil.no ([77.18.245.69] helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1VvMt4-0007sW-7P; Tue, 24 Dec 2013 08:58:46 +0100 From: Lars Ingebrigtsen References: <87eh53h928.fsf@dhcp-193-97.nrt.redhat.com> Date: Tue, 24 Dec 2013 08:52:51 +0100 In-Reply-To: <87eh53h928.fsf@dhcp-193-97.nrt.redhat.com> (Kenjiro NAKAYAMA's message of "Tue, 24 Dec 2013 00:38:07 +0900") Message-ID: <87ob46y9bg.fsf@building.gnus.org> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1VvMt4-0007sW-7P X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1388476727.93691@Mmbx+nOSFqjtDtHgYsXE/g X-Spam-Status: No X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Kenjiro NAKAYAMA writes: > This report includes a patch to the bug. Please, review and install it > to the official tree if appreciated. > > The user can't change encoding type. This patch is to fix it. Allowing the user to alter the encoding seems like a good idea. However, the implementation doesn't seem ideal. The best way to handle this would be to have the `E' command prompt for the charset, and then re-render the page immediately without setting any global variables. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From unknown Sun Jun 22 07:56:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16225: 24.3.50; [PATCH] eww: machinery to set character encoding. Resent-From: Kenjiro NAKAYAMA Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Dec 2013 07:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: Kenjiro NAKAYAMA , 16225@debbugs.gnu.org Received: via spool by 16225-submit@debbugs.gnu.org id=B16225.13879567924061 (code B ref 16225); Wed, 25 Dec 2013 07:34:02 +0000 Received: (at 16225) by debbugs.gnu.org; 25 Dec 2013 07:33:12 +0000 Received: from localhost ([127.0.0.1]:40433 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vvixn-00013H-MV for submit@debbugs.gnu.org; Wed, 25 Dec 2013 02:33:12 -0500 Received: from mail-pd0-f175.google.com ([209.85.192.175]:61606) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vvixg-00012c-9F for 16225@debbugs.gnu.org; Wed, 25 Dec 2013 02:33:05 -0500 Received: by mail-pd0-f175.google.com with SMTP id w10so6998392pde.20 for <16225@debbugs.gnu.org>; Tue, 24 Dec 2013 23:32:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-type; bh=fmAbg5KF5d4MQUX1rWVz2EeCald26wth+NfAdZVZ8Yk=; b=rnXxiPxAVgMrwBE+m/zVSV/SqqMxHe0tPvWMPug03aRNKjZb6pwYJxn7oldjtGE6dE 4TZC8YRUkVAvq3J6vpvSQ/JtpnwsZVFDbFplXllfTh93IDAgQHjQk7zB6A72KvERsyEC c934wcZeW6Qeal7/PwNBRnJh0dU4I4nNgz5cJ37mMSJfiOCzRp8T94FDrf9bcUy4NkyD ZaC6J5xCoMkpZdcb27vLQ7nD5mJHwPkfQNGtCaRituIjm09L9UdEL3kbFXTZ7wisBFP2 jgg0SOxjvBfzsvV2BkK/2B5hVgjZdmYfD8+beWy0p5VBYhnCQUfYPNZOTRxc2rjdH3wg mnwQ== X-Received: by 10.68.211.39 with SMTP id mz7mr36874157pbc.90.1387956778949; Tue, 24 Dec 2013 23:32:58 -0800 (PST) Received: from dhcp-193-97.nrt.redhat.com (nat-pool-nrt-u1.redhat.com. [66.187.238.11]) by mx.google.com with ESMTPSA id y9sm60698514pas.10.2013.12.24.23.32.56 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 24 Dec 2013 23:32:57 -0800 (PST) References: <87eh53h928.fsf@dhcp-193-97.nrt.redhat.com> <87ob46y9bg.fsf@building.gnus.org> User-agent: mu4e 0.9.9.6pre2; emacs 24.3.50.2 From: Kenjiro NAKAYAMA In-reply-to: <87ob46y9bg.fsf@building.gnus.org> Date: Wed, 25 Dec 2013 16:32:51 +0900 Message-ID: <87ioudtmfw.fsf@dhcp-193-97.nrt.redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > However, the implementation doesn't seem ideal. The best way to handle > this would be to have the `E' command prompt for the charset, and then > re-render the page immediately without setting any global variables. Thank you Lars, I fixed it. Can you please review again? I send the patch again. Signed-off-by: Kenjiro NAKAYAMA * net/eww.el (eww-display-html,eww-display-raw): Change to enable to set encoding type. (eww-mode-map): New key map and easy-menu to set encoding type. (eww-set-character-encoding): New funtion to set encoding type. --- lisp/net/eww.el | 43 ++++++++++++++++++++++++++++++------------- 1 file changed, 30 insertions(+), 13 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 02c93a0..8fbf94d 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -172,7 +172,7 @@ word(s) will be searched for via `eww-search-prefix'." "/") (expand-file-name file)))) -(defun eww-render (status url &optional point) +(defun eww-render (status url &optional point encode) (let ((redirect (plist-get status :redirect))) (when redirect (setq url redirect))) @@ -192,7 +192,7 @@ word(s) will be searched for via `eww-search-prefix'." (or (cdr (assq 'charset (cdr content-type))) (eww-detect-charset (equal (car content-type) "text/html")) - "utf8")))) + "utf-8")))) (data-buffer (current-buffer))) (unwind-protect (progn @@ -203,12 +203,12 @@ word(s) will be searched for via `eww-search-prefix'." (car content-type))) (eww-browse-with-external-browser url)) ((equal (car content-type) "text/html") - (eww-display-html charset url nil point)) + (eww-display-html charset url nil point encode)) ((string-match-p "\\`image/" (car content-type)) (eww-display-image) (eww-update-header-line-format)) (t - (eww-display-raw) + (eww-display-raw encode) (eww-update-header-line-format))) (setq eww-current-url url eww-history-position 0)) @@ -243,12 +243,12 @@ word(s) will be searched for via `eww-search-prefix'." (declare-function libxml-parse-html-region "xml.c" (start end &optional base-url)) -(defun eww-display-html (charset url &optional document point) +(defun eww-display-html (charset url &optional document point encode) (or (fboundp 'libxml-parse-html-region) (error "This function requires Emacs to be compiled with libxml2")) - (unless (eq charset 'utf8) + (unless (eq charset encode) (condition-case nil - (decode-coding-region (point) (point-max) charset) + (decode-coding-region (point) (point-max) encode) (coding-system-error nil))) (let ((document (or document @@ -363,11 +363,16 @@ word(s) will be searched for via `eww-search-prefix'." (list :background (car new-colors)) t)))))) -(defun eww-display-raw () +(defun eww-display-raw (&optional encode) (let ((data (buffer-substring (point) (point-max)))) (eww-setup-buffer) (let ((inhibit-read-only t)) - (insert data)) + (insert data) + (unless (eq encode 'utf-8) + (encode-coding-region (point-min) (1+ (length data)) 'utf-8) + (condition-case nil + (decode-coding-region (point-min) (1+ (length data)) encode) + (coding-system-error nil)))) (goto-char (point-min)))) (defun eww-display-image () @@ -420,6 +425,7 @@ word(s) will be searched for via `eww-search-prefix'." (define-key map "C" 'url-cookie-list) (define-key map "v" 'eww-view-source) (define-key map "H" 'eww-list-histories) + (define-key map "E" 'eww-set-character-encoding) (define-key map "b" 'eww-add-bookmark) (define-key map "B" 'eww-list-bookmarks) @@ -442,7 +448,8 @@ word(s) will be searched for via `eww-search-prefix'." ["List histories" eww-list-histories t] ["Add bookmark" eww-add-bookmark t] ["List bookmarks" eww-list-bookmarks t] - ["List cookies" url-cookie-list t])) + ["List cookies" url-cookie-list t] + ["Character Encoding" eww-set-character-encoding])) map)) (defvar eww-tool-bar-map @@ -552,11 +559,11 @@ appears in a or tag." (eww-browse-url (shr-expand-url best-url eww-current-url)) (user-error "No `top' for this page")))) -(defun eww-reload () +(defun eww-reload (&optional encode) "Reload the current page." (interactive) (url-retrieve eww-current-url 'eww-render - (list eww-current-url (point)))) + (list eww-current-url (point) encode))) ;; Form support. @@ -1032,7 +1039,7 @@ If EXTERNAL, browse the URL using `shr-external-browser'." ((and (url-target (url-generic-parse-url url)) (eww-same-page-p url eww-current-url)) (eww-save-history) - (eww-display-html 'utf8 url eww-current-dom)) + (eww-display-html 'utf-8 url eww-current-dom)) (t (eww-browse-url url))))) @@ -1083,6 +1090,16 @@ Differences in #targets are ignored." (setq count (1+ count))) (expand-file-name file directory))) +(defun eww-set-character-encoding (encode) + "Set character encoding." + (interactive "sSet Character Encoding (default utf-8): ") + (cond ((zerop (length encode)) + (eww-reload 'utf-8)) + (t + (if (not (coding-system-p (intern encode))) + (user-error "Invalid encodeing type.") + (eww-reload (intern encode)))))) + ;;; Bookmarks code (defvar eww-bookmarks nil) -- 1.8.3.1 Regards, Kenjiro larsi@gnus.org writes: > Kenjiro NAKAYAMA writes: > >> This report includes a patch to the bug. Please, review and install it >> to the official tree if appreciated. >> >> The user can't change encoding type. This patch is to fix it. > > Allowing the user to alter the encoding seems like a good idea. > However, the implementation doesn't seem ideal. The best way to handle > this would be to have the `E' command prompt for the charset, and then > re-render the page immediately without setting any global variables. From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 25 04:03:46 2013 Received: (at control) by debbugs.gnu.org; 25 Dec 2013 09:03:46 +0000 Received: from localhost ([127.0.0.1]:40554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VvkNW-0003t6-Gw for submit@debbugs.gnu.org; Wed, 25 Dec 2013 04:03:46 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:56076) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VvkNU-0003sy-PB for control@debbugs.gnu.org; Wed, 25 Dec 2013 04:03:45 -0500 Received: from 46.156.155.141.tmi.telenormobil.no ([46.156.155.141] helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1VvkNH-0003NL-Jt for control@debbugs.gnu.org; Wed, 25 Dec 2013 10:03:31 +0100 Date: Wed, 25 Dec 2013 09:57:38 +0100 Message-Id: <87d2kll33x.fsf@building.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #16225 X-MailScanner-ID: 1VvkNH-0003NL-Jt X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1388567012.01496@s0p1l3xa90lugUQTxI4W2g X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 16225 pending From unknown Sun Jun 22 07:56:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16225: 24.3.50; [PATCH] eww: machinery to set character encoding. Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 25 Dec 2013 09:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: pending patch To: Kenjiro NAKAYAMA Cc: 16225@debbugs.gnu.org Received: via spool by 16225-submit@debbugs.gnu.org id=B16225.138796226915065 (code B ref 16225); Wed, 25 Dec 2013 09:05:02 +0000 Received: (at 16225) by debbugs.gnu.org; 25 Dec 2013 09:04:29 +0000 Received: from localhost ([127.0.0.1]:40559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VvkOC-0003uv-R8 for submit@debbugs.gnu.org; Wed, 25 Dec 2013 04:04:29 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:56085) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VvkOA-0003uh-E6 for 16225@debbugs.gnu.org; Wed, 25 Dec 2013 04:04:26 -0500 Received: from 46.156.155.141.tmi.telenormobil.no ([46.156.155.141] helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1VvkNv-0003Ny-NF; Wed, 25 Dec 2013 10:04:11 +0100 From: Lars Ingebrigtsen References: <87eh53h928.fsf@dhcp-193-97.nrt.redhat.com> <87ob46y9bg.fsf@building.gnus.org> <87ioudtmfw.fsf@dhcp-193-97.nrt.redhat.com> Date: Wed, 25 Dec 2013 09:58:16 +0100 In-Reply-To: <87ioudtmfw.fsf@dhcp-193-97.nrt.redhat.com> (Kenjiro NAKAYAMA's message of "Wed, 25 Dec 2013 16:32:51 +0900") Message-ID: <878uv9l32v.fsf@building.gnus.org> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1VvkNv-0003Ny-NF X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1388567053.15825@9xwYJGxW4b1UTsP57vyNMA X-Spam-Status: No X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Kenjiro NAKAYAMA writes: > I fixed it. Can you please review again? I send the patch again. Looks good. It's new functionality, though, so it'll have to wait until the feature freeze is over to be installed. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From unknown Sun Jun 22 07:56:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16225: 24.3.50; [PATCH] eww: machinery to set character encoding. Resent-From: Lars Magne Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Nov 2014 21:40:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: pending patch To: Kenjiro NAKAYAMA Cc: 16225@debbugs.gnu.org Received: via spool by 16225-submit@debbugs.gnu.org id=B16225.141565559316333 (code B ref 16225); Mon, 10 Nov 2014 21:40:03 +0000 Received: (at 16225) by debbugs.gnu.org; 10 Nov 2014 21:39:53 +0000 Received: from localhost ([127.0.0.1]:56417 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xnwgf-0004FG-0L for submit@debbugs.gnu.org; Mon, 10 Nov 2014 16:39:52 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:40738) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XnwgZ-0004Et-Ep for 16225@debbugs.gnu.org; Mon, 10 Nov 2014 16:39:47 -0500 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1XnwgF-0001pu-I6; Mon, 10 Nov 2014 22:39:23 +0100 From: Lars Magne Ingebrigtsen References: <87eh53h928.fsf@dhcp-193-97.nrt.redhat.com> <87ob46y9bg.fsf@building.gnus.org> <87ioudtmfw.fsf@dhcp-193-97.nrt.redhat.com> <878uv9l32v.fsf@building.gnus.org> X-Now-Playing: The Cure's _Kiss Me, Kiss Me, Kiss Me_ X-Hashcash: 1:23:141110:nakayamakenjiro@gmail.com::QEdM0XYIyL38GDkp:000000000000000000000000000000000000KOnY X-Hashcash: 1:23:141110:16225@debbugs.gnu.org::EZp9TA4AhVIhARyY:0000000000000000000000000000000000000000ZjB5 Date: Mon, 10 Nov 2014 22:39:23 +0100 In-Reply-To: <878uv9l32v.fsf@building.gnus.org> (Lars Ingebrigtsen's message of "Wed, 25 Dec 2013 09:58:16 +0100") Message-ID: User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1XnwgF-0001pu-I6 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1416260363.9555@7+CiPdObNATaIXCftPNEBA X-Spam-Status: No X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Lars Ingebrigtsen writes: > Kenjiro NAKAYAMA writes: > >> I fixed it. Can you please review again? I send the patch again. > > Looks good. It's new functionality, though, so it'll have to wait until > the feature freeze is over to be installed. Sorry; I forgot to go through these pending patches before I started fixing bugs that didn't have pending patches. So this patch doesn't apply any longer. Could you re-spin it and resubmit? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 07:56:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16225: 24.3.50; [PATCH] eww: machinery to set character encoding. Resent-From: Nakayama Kenjiro Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Nov 2014 17:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: pending patch To: Lars Magne Ingebrigtsen Cc: 16225@debbugs.gnu.org Received: via spool by 16225-submit@debbugs.gnu.org id=B16225.14166771541381 (code B ref 16225); Sat, 22 Nov 2014 17:26:01 +0000 Received: (at 16225) by debbugs.gnu.org; 22 Nov 2014 17:25:54 +0000 Received: from localhost ([127.0.0.1]:41937 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XsERS-0000M6-OR for submit@debbugs.gnu.org; Sat, 22 Nov 2014 12:25:54 -0500 Received: from mail-wg0-f48.google.com ([74.125.82.48]:51368) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XsERM-0000Lu-KL for 16225@debbugs.gnu.org; Sat, 22 Nov 2014 12:25:48 -0500 Received: by mail-wg0-f48.google.com with SMTP id y19so9302973wgg.35 for <16225@debbugs.gnu.org>; Sat, 22 Nov 2014 09:25:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=2zEtFVO/3MskK9fmbhzsyQSF0D5k8giETU36ucNlDIM=; b=IHOsy2WpZqvbBrqdpbPm2ile5ldZwhtbHzMMyqQj9rM6Kwix6qFSwwEsXCtCVp9JEt FGYCKaWoH5236aJ+qevlebWy/L26Fv6/wlU/OeVIju43Ca0sLafwV1aEWn/VlLeGIavh +q+M5fkjIwjzC2mXHpq09DAmTW9Uxf4CewzbgMeoc9TPKq1nfS/YPYZQZ5TJq24l+SnY sg8U1Dj8T/0BpXcXY0q4uiYRq872HmYec45dGDUn4L5G+lv2p0wr/UhHNxKco0TBQWDQ K4BSAdpLW3dtSXrhH1L88atmNInXfnHhamZaDlhisyn6s/x3lSdndYHJcQo/nkOzpV88 +/og== MIME-Version: 1.0 X-Received: by 10.180.99.1 with SMTP id em1mr7258980wib.29.1416677143884; Sat, 22 Nov 2014 09:25:43 -0800 (PST) Received: by 10.180.150.244 with HTTP; Sat, 22 Nov 2014 09:25:43 -0800 (PST) In-Reply-To: References: <87eh53h928.fsf@dhcp-193-97.nrt.redhat.com> <87ob46y9bg.fsf@building.gnus.org> <87ioudtmfw.fsf@dhcp-193-97.nrt.redhat.com> <878uv9l32v.fsf@building.gnus.org> Date: Sun, 23 Nov 2014 02:25:43 +0900 Message-ID: From: Nakayama Kenjiro Content-Type: multipart/alternative; boundary=f46d0418258aec3a5c050875d9db X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --f46d0418258aec3a5c050875d9db Content-Type: text/plain; charset=UTF-8 Sure. I will resubmit this patch soon. Regards, Kenjiro On Tue, Nov 11, 2014 at 6:39 AM, Lars Magne Ingebrigtsen wrote: > Lars Ingebrigtsen writes: > > > Kenjiro NAKAYAMA writes: > > > >> I fixed it. Can you please review again? I send the patch again. > > > > Looks good. It's new functionality, though, so it'll have to wait until > > the feature freeze is over to be installed. > > Sorry; I forgot to go through these pending patches before I started > fixing bugs that didn't have pending patches. > > So this patch doesn't apply any longer. Could you re-spin it and > resubmit? > > -- > (domestic pets only, the antidote for overdose, milk.) > bloggy blog: http://lars.ingebrigtsen.no > -- Kenjiro NAKAYAMA GPG Key fingerprint = ED8F 049D E67A 727D 9A44 8E25 F44B E208 C946 5EB9 --f46d0418258aec3a5c050875d9db Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Sure.
I will resubmit this patch soon.

Regards,
Kenjiro

On Tue, Nov 11, 2014 at 6:39 AM, Lars Magne Ingebr= igtsen <larsi@gnus.org> wrote:
Lars Ingebrigtsen <= larsi@gnus.org> writes:

> Kenjiro NAKAYAMA <naka= yamakenjiro@gmail.com> writes:
>
>> I fixed it. Can you please review again? I send the patch again. >
> Looks good. It's new functionality, though, so it'll have to w= ait until
> the feature freeze is over to be installed.

Sorry; I forgot to go through these pending patches before I started=
fixing bugs that didn't have pending patches.

So this patch doesn't apply any longer.=C2=A0 Could you re-spin it and<= br> resubmit?

--
(domestic pets only, the antidote for overdose, milk.)
=C2=A0 =C2=A0bloggy blog: http://lars.ingebrigtsen.no



--
--f46d0418258aec3a5c050875d9db-- From unknown Sun Jun 22 07:56:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16225: [PATCH]eww: machinery to set character encoding References: <87eh53h928.fsf@dhcp-193-97.nrt.redhat.com> In-Reply-To: <87eh53h928.fsf@dhcp-193-97.nrt.redhat.com> Resent-From: Kenjiro Nakayama Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Nov 2014 17:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: pending patch To: 16225@debbugs.gnu.org Cc: larsi@gnus.org, Kenjiro Nakayama Received: via spool by 16225-submit@debbugs.gnu.org id=B16225.14166778262484 (code B ref 16225); Sat, 22 Nov 2014 17:38:02 +0000 Received: (at 16225) by debbugs.gnu.org; 22 Nov 2014 17:37:06 +0000 Received: from localhost ([127.0.0.1]:41941 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XsEcL-0000dp-Ma for submit@debbugs.gnu.org; Sat, 22 Nov 2014 12:37:06 -0500 Received: from mail-pa0-f54.google.com ([209.85.220.54]:62460) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XsEcJ-0000cy-CL for 16225@debbugs.gnu.org; Sat, 22 Nov 2014 12:37:04 -0500 Received: by mail-pa0-f54.google.com with SMTP id fb1so6934037pad.41 for <16225@debbugs.gnu.org>; Sat, 22 Nov 2014 09:37:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=/w4gWkQDQ1IzkMRX3WOkpgyXQ7taDXCLpm3pTEjzDGQ=; b=mMFFVYRR1m5196GbWGIK1az2+x8jdgAcUfOCbkQSvCbx8Bx37zhRb98NYctPwB+s1Y Gf0YgcAhxxr/7AnykUfQRRj2diknHmqYDlmAFYMqQGW9RmBV0rzQ+ZUkdhbwbbZXcFg5 x2bYnG5lD1d3fvwj93X908zEBlCp3dju6tmiw3H12PAUhGdXAYbskogIQMJKyyJKacP0 CRYGQgpuDp2+WlGaKT0orjqQZc9E2xEw7kfMtoWXFN2V7uvtzNITkfKgVpdsoxX0TGlj LtvNlKys7zVzt6Bb2HWwm1CrjQPV3nSzrj0hF2aZIQYWFb2175xLvqE7cI7SOduXk1Th oKoA== X-Received: by 10.66.162.37 with SMTP id xx5mr18444165pab.10.1416677822374; Sat, 22 Nov 2014 09:37:02 -0800 (PST) Received: from localhost.localdomain.com (nat-pool-nrt-t1.redhat.com. [118.238.28.209]) by mx.google.com with ESMTPSA id oq6sm7960012pdb.45.2014.11.22.09.36.59 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 22 Nov 2014 09:37:01 -0800 (PST) From: Kenjiro Nakayama Date: Sun, 23 Nov 2014 02:36:27 +0900 Message-Id: <1416677787-30698-1-git-send-email-nakayamakenjiro@gmail.com> X-Mailer: git-send-email 1.9.3 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) This patch makes users possible to change the encoding on eww. Signed-off-by: Kenjiro Nakayama * net/eww.el (eww-display-html,eww-display-raw): Change to enable to set encoding type. (eww-mode-map): New key map and easy-menu to set encoding type. (eww-set-character-encoding): New funtion to set encoding type. --- lisp/net/eww.el | 41 +++++++++++++++++++++++++++++------------ 1 file changed, 29 insertions(+), 12 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 6746668..3c1621c 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -241,7 +241,7 @@ See the `eww-search-prefix' variable for the search engine used." (interactive "r") (eww (buffer-substring beg end))) -(defun eww-render (status url &optional point buffer) +(defun eww-render (status url &optional point buffer encode) (let ((redirect (plist-get status :redirect))) (when redirect (setq url redirect))) @@ -255,7 +255,7 @@ See the `eww-search-prefix' variable for the search engine used." (or (cdr (assq 'charset (cdr content-type))) (eww-detect-charset (equal (car content-type) "text/html")) - "utf8")))) + "utf-8")))) (data-buffer (current-buffer))) (unwind-protect (progn @@ -265,14 +265,14 @@ See the `eww-search-prefix' variable for the search engine used." (car content-type))) (eww-browse-with-external-browser url)) ((equal (car content-type) "text/html") - (eww-display-html charset url nil point buffer)) + (eww-display-html charset url nil point buffer encode)) ((equal (car content-type) "application/pdf") (eww-display-pdf)) ((string-match-p "\\`image/" (car content-type)) (eww-display-image buffer) (eww-update-header-line-format)) (t - (eww-display-raw buffer) + (eww-display-raw buffer encode) (eww-update-header-line-format))) (plist-put eww-data :url url) (setq eww-history-position 0) @@ -308,7 +308,7 @@ See the `eww-search-prefix' variable for the search engine used." (declare-function libxml-parse-html-region "xml.c" (start end &optional base-url)) -(defun eww-display-html (charset url &optional document point buffer) +(defun eww-display-html (charset url &optional document point buffer encode) (or (fboundp 'libxml-parse-html-region) (error "This function requires Emacs to be compiled with libxml2")) ;; There should be a better way to abort loading images @@ -319,9 +319,9 @@ See the `eww-search-prefix' variable for the search engine used." (list 'base (list (cons 'href url)) (progn - (unless (eq charset 'utf-8) + (unless (eq charset encode) (condition-case nil - (decode-coding-region (point) (point-max) charset) + (decode-coding-region (point) (point-max) encode) (coding-system-error nil))) (libxml-parse-html-region (point) (point-max)))))) (source (and (null document) @@ -429,11 +429,16 @@ See the `eww-search-prefix' variable for the search engine used." (shr-generic cont) (shr-colorize-region start (point) fgcolor bgcolor))) -(defun eww-display-raw (&optional buffer) +(defun eww-display-raw (&optional buffer encode) (let ((data (buffer-substring (point) (point-max)))) (eww-setup-buffer buffer) (let ((inhibit-read-only t)) - (insert data)) + (insert data) + (unless (eq encode 'utf-8) + (encode-coding-region (point-min) (1+ (length data)) 'utf-8) + (condition-case nil + (decode-coding-region (point-min) (1+ (length data)) encode) + (coding-system-error nil)))) (goto-char (point-min)))) (defun eww-display-image (&optional buffer) @@ -567,6 +572,7 @@ the like." (define-key map "v" 'eww-view-source) (define-key map "R" 'eww-readable) (define-key map "H" 'eww-list-histories) + (define-key map "E" 'eww-set-character-encoding) (define-key map "b" 'eww-add-bookmark) (define-key map "B" 'eww-list-bookmarks) @@ -589,7 +595,8 @@ the like." ["List histories" eww-list-histories t] ["Add bookmark" eww-add-bookmark t] ["List bookmarks" eww-list-bookmarks t] - ["List cookies" url-cookie-list t])) + ["List cookies" url-cookie-list t] + ["Character Encoding" eww-set-character-encoding])) map)) (defvar eww-tool-bar-map @@ -700,12 +707,12 @@ appears in a or tag." (eww-browse-url (shr-expand-url best-url (plist-get eww-data :url))) (user-error "No `top' for this page")))) -(defun eww-reload () +(defun eww-reload (&optional encode) "Reload the current page." (interactive) (let ((url (plist-get eww-data :url))) (url-retrieve url 'eww-render - (list url (point) (current-buffer))))) + (list url (point) (current-buffer) encode)))) ;; Form support. @@ -1307,6 +1314,16 @@ Differences in #targets are ignored." (setq count (1+ count))) (expand-file-name file directory))) +(defun eww-set-character-encoding (encode) + "Set character encoding." + (interactive "sSet Character Encoding (default utf-8): ") + (cond ((zerop (length encode)) + (eww-reload 'utf-8)) + (t + (if (not (coding-system-p (intern encode))) + (user-error "Invalid encodeing type.") + (eww-reload (intern encode)))))) + ;;; Bookmarks code (defvar eww-bookmarks nil) -- 1.9.3 From unknown Sun Jun 22 07:56:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16225: [PATCH]eww: machinery to set character encoding Resent-From: Lars Magne Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Nov 2014 15:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: pending patch To: Kenjiro Nakayama Cc: 16225@debbugs.gnu.org Received: via spool by 16225-submit@debbugs.gnu.org id=B16225.14167566851088 (code B ref 16225); Sun, 23 Nov 2014 15:32:02 +0000 Received: (at 16225) by debbugs.gnu.org; 23 Nov 2014 15:31:25 +0000 Received: from localhost ([127.0.0.1]:42752 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XsZ8G-0000HS-Hk for submit@debbugs.gnu.org; Sun, 23 Nov 2014 10:31:24 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:59182) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XsZ8D-0000HJ-L8 for 16225@debbugs.gnu.org; Sun, 23 Nov 2014 10:31:22 -0500 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1XsZ7v-0005cT-Jl; Sun, 23 Nov 2014 16:31:03 +0100 From: Lars Magne Ingebrigtsen References: <87eh53h928.fsf@dhcp-193-97.nrt.redhat.com> <1416677787-30698-1-git-send-email-nakayamakenjiro@gmail.com> X-Now-Playing: Missy "Misdemeanor" Elliott's _Da Real World_: "Crazy Feelings (Featuring Beyonce)" X-Hashcash: 1:23:141123:nakayamakenjiro@gmail.com::gAbGje/8U9mKdIMa:000000000000000000000000000000000000Fcfk X-Hashcash: 1:23:141123:16225@debbugs.gnu.org::C5E0frw/6fTzD/ZA:0000000000000000000000000000000000000000YCSm Date: Sun, 23 Nov 2014 16:31:03 +0100 In-Reply-To: <1416677787-30698-1-git-send-email-nakayamakenjiro@gmail.com> (Kenjiro Nakayama's message of "Sun, 23 Nov 2014 02:36:27 +0900") Message-ID: User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1XsZ7v-0005cT-Jl X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1417361463.74356@MVj9C6IxVtjYpPmWkTUl0w X-Spam-Status: No X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Kenjiro Nakayama writes: > This patch makes users possible to change the encoding on eww. > > Signed-off-by: Kenjiro Nakayama > > * net/eww.el (eww-display-html,eww-display-raw): Change to > enable to set encoding type. > (eww-mode-map): New key map and easy-menu to set encoding type. > (eww-set-character-encoding): New funtion to set encoding type. Thanks; applied. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 23 10:31:28 2014 Received: (at control) by debbugs.gnu.org; 23 Nov 2014 15:31:28 +0000 Received: from localhost ([127.0.0.1]:42755 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XsZ8J-0000Hj-Sm for submit@debbugs.gnu.org; Sun, 23 Nov 2014 10:31:28 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:59188) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XsZ8G-0000HT-Q8 for control@debbugs.gnu.org; Sun, 23 Nov 2014 10:31:25 -0500 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1XsZ7y-0005ca-QD for control@debbugs.gnu.org; Sun, 23 Nov 2014 16:31:06 +0100 Date: Sun, 23 Nov 2014 16:31:06 +0100 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #16225 X-MailScanner-ID: 1XsZ7y-0005ca-QD X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1417361467.63988@gqgMdIfY9fck8kYDaZ+PAA X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 16225 fixed close 16225 25.1 From unknown Sun Jun 22 07:56:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16225: eww: machinery to set character encoding Resent-From: Ivan Shmakov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Nov 2014 18:26:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch To: 16225@debbugs.gnu.org, 16225-submitter@debbugs.gnu.org Received: via spool by 16225-submit@debbugs.gnu.org id=B16225.14167671095147 (code B ref 16225); Sun, 23 Nov 2014 18:26:01 +0000 Received: (at 16225) by debbugs.gnu.org; 23 Nov 2014 18:25:09 +0000 Received: from localhost ([127.0.0.1]:42939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XsbqP-0001Ks-Hb for submit@debbugs.gnu.org; Sun, 23 Nov 2014 13:25:09 -0500 Received: from fely.am-1.org ([78.47.74.50]:42036) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XsbqI-0001KZ-Kd; Sun, 23 Nov 2014 13:25:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=FRCZvd63Nm+Dvovrx+XNb1ACur7rtWBfPiIx4UEwSjw=; b=HoTJjRB7i6qRzd8jBIBBR5x5n8qNIOJk9Pt6P259iPWZ3wHgljna/qz7Bry4+Fu19PTOXFvOz7h61CMNXt759yYKDGvkAbp6jVgxTcPz4nPayk8zNxXjmS6Ds8x5k5msNvHcUhvgBPujESB7F9icMaKphVJCkavrwX6T3ynzLHc=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XsbqH-0008TB-D1; Sun, 23 Nov 2014 18:25:01 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XsbqA-0005Qf-CC; Mon, 24 Nov 2014 01:24:54 +0700 From: Ivan Shmakov References: <87eh53h928.fsf@dhcp-193-97.nrt.redhat.com> <1416677787-30698-1-git-send-email-nakayamakenjiro@gmail.com> Date: Sun, 23 Nov 2014 18:24:53 +0000 In-Reply-To: <1416677787-30698-1-git-send-email-nakayamakenjiro@gmail.com> (Kenjiro Nakayama's message of "Sun, 23 Nov 2014 02:36:27 +0900") Message-ID: <873899vkp6.fsf_-_@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) >>>>> Kenjiro Nakayama writes: > @@ -1307,6 +1314,16 @@ Differences in #targets are ignored." > (setq count (1+ count))) > (expand-file-name file directory))) > +(defun eww-set-character-encoding (encode) > + "Set character encoding." > + (interactive "sSet Character Encoding (default utf-8): ") Could this please be changed to use read-coding-system, just like the rest of Emacs (say, universal-coding-system-argument)? TIA. > + (cond ((zerop (length encode)) > + (eww-reload 'utf-8)) > + (t > + (if (not (coding-system-p (intern encode))) > + (user-error "Invalid encodeing type.") > + (eww-reload (intern encode)))))) > + > ;;; Bookmarks code > (defvar eww-bookmarks nil) --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A From unknown Sun Jun 22 07:56:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16225: eww: machinery to set character encoding Resent-From: Lars Magne Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Nov 2014 16:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16225 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch To: Ivan Shmakov Cc: 16225@debbugs.gnu.org Received: via spool by 16225-submit@debbugs.gnu.org id=B16225.141684483214162 (code B ref 16225); Mon, 24 Nov 2014 16:01:02 +0000 Received: (at 16225) by debbugs.gnu.org; 24 Nov 2014 16:00:32 +0000 Received: from localhost ([127.0.0.1]:44080 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xsw40-0003gL-5f for submit@debbugs.gnu.org; Mon, 24 Nov 2014 11:00:32 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:50837) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xsw3u-0003g3-4j for 16225@debbugs.gnu.org; Mon, 24 Nov 2014 11:00:29 -0500 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Xsw3U-0001bR-9Y; Mon, 24 Nov 2014 17:00:00 +0100 From: Lars Magne Ingebrigtsen References: <87eh53h928.fsf@dhcp-193-97.nrt.redhat.com> <1416677787-30698-1-git-send-email-nakayamakenjiro@gmail.com> <873899vkp6.fsf_-_@violet.siamics.net> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAGFBMVEVuc3EWExY8PkSVnZRK TVEyLzkmIy1ZXV4nyH3dAAACKUlEQVQ4jU2TwWorMQxFDVOYdTbzAcJ+3RbyA0Xo4b2pve8De22K wb//rmQn6YSQic5c6UrWOHfc73fn5uDc0qfrDtcKPQG16g/3Au5+4O8U9n9resfd1LgqDgWDWThn P2fvCj5U+aECL34QeZnT3Q10Z5mYEA3Zx2kCpJrmYwhRYs5QdIsfbpqPSTklDyrjUdsETkLImeAs xv4bTIDyz8tgie7+G/yE0jKxiI/HMmU1+uRcWk3wuk0p6Nosl9Za8nNsUwqmfim3qyV+KpDmDfFT qLSrJn6117VGn0Lt+6ap+hqtKk584BbgquTjAh94/jyRCeAGkJ6jOqfr55xxgaYzRLbDFDAyBpVv VRhYuaCYJ451AY3HB4BimbrBFsBWwNN8gylVLInYCVrnMqz27QLQ1nV6Wh7FJajg1tqXNjxQRyeO OIeywDvA2W2zXJQZKRu4atSu1sa5T1NYqguuhl9n7aAYP5wX+CIcesfKoHs3Y+QNGpY3jjjI8+fh RhSxiSj5isJwPwa6wa/f4EoBVcSSiQPlDbAOiIugeyGHG94TaTmQYFxYbgJgz6Fthe6iPABq7/4a DkQ0A+LJ4ZbCbjzn5PVpSoEcfrCeS5Gx2BbXVMQU/rTVRlXAeBnCUuT6vWtUPIsSIakiUHqkqiog vCm4HGAuj1FVzbYuKMIGFxa+5SdIOa9MRixWDNQXaOsqJnSllvoLVCV1Kcqa1K6hQbhQRdvgkcqE +T+VjQqyDOdlyAAAAABJRU5ErkJggg== X-Now-Playing: Ital's _Endgame_: "Beacon" X-Hashcash: 1:23:141124:ivan@siamics.net::JXUv98hLWi+w+ejo:00FU2 X-Hashcash: 1:23:141124:16225-submitter@debbugs.gnu.org::V39M8ft1vsWSiI3j:000000000000000000000000000000UGPI X-Hashcash: 1:23:141124:16225@debbugs.gnu.org::m1b/Xi0bdhIKMazw:0000000000000000000000000000000000000002I0pm Date: Mon, 24 Nov 2014 16:59:59 +0100 In-Reply-To: <873899vkp6.fsf_-_@violet.siamics.net> (Ivan Shmakov's message of "Sun, 23 Nov 2014 18:24:53 +0000") Message-ID: User-Agent: Gnus/5.130012 (Ma Gnus v0.12) Emacs/25.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1Xsw3U-0001bR-9Y X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1417449601.71501@6vt/Ad3op1oEIdPn/6sjuw X-Spam-Status: No X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Ivan Shmakov writes: > Could this please be changed to use read-coding-system, just > like the rest of Emacs (say, universal-coding-system-argument)? Fixed on trunk. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no