GNU bug report logs - #16220
url-http.el: Not conforming to HTTP spec

Previous Next

Package: emacs;

Reported by: Jarosław Rzeszótko <sztywny <at> gmail.com>

Date: Sun, 22 Dec 2013 20:53:01 UTC

Severity: normal

Tags: patch

Done: Paul Eggert <eggert <at> cs.ucla.edu>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Jarosław Rzeszótko <sztywny <at> gmail.com>
Cc: 16220 <at> debbugs.gnu.org, Lars Magne Ingebrigtsen <larsi <at> gnus.org>
Subject: bug#16220: url-http.el: Not conforming to HTTP spec
Date: Wed, 08 Jan 2014 13:29:54 -0500
> Is there any chance my patch gets committed or at least that the extra
> "\r\n" finally gets removed?

I installed the patch below.
Thank you very much,


        Stefan


=== modified file 'lisp/url/ChangeLog'
--- lisp/url/ChangeLog	2014-01-01 07:43:34 +0000
+++ lisp/url/ChangeLog	2014-01-08 18:05:12 +0000
@@ -1,3 +1,8 @@
+2014-01-08  Jarosław Rzeszótko  <sztywny <at> gmail.com>
+
+	* url-http.el (url-http-create-request): Don't add extra \r\n after
+	http data (bug#16220).
+
 2013-12-28  Glenn Morris  <rgm <at> gnu.org>
 
 	* url-history.el (url-history-track):

=== modified file 'lisp/url/url-http.el'
--- lisp/url/url-http.el	2014-01-01 07:43:34 +0000
+++ lisp/url/url-http.el	2014-01-08 18:03:55 +0000
@@ -356,9 +356,7 @@
              ;; End request
              "\r\n"
              ;; Any data
-             url-http-data
-	     ;; If `url-http-data' is nil, avoid two CRLFs (Bug#8931).
-	     (if url-http-data "\r\n")))
+             url-http-data))
            ""))
     (url-http-debug "Request is: \n%s" request)
     request))





This bug report was last modified 11 years and 122 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.