GNU bug report logs - #16198
24.3.50; [PATCH 1/2] eww: Does not support file upload.

Previous Next

Full log

Message #11 received at 16198 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
Cc: 16198 <at> debbugs.gnu.org
Subject: Re: bug#16198: 24.3.50; [PATCH 1/2] eww: Does not support file upload.
Date: Tue, 24 Dec 2013 08:32:56 +0100

Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com> writes:

> This report includes a patch to eww file upload. Please, review and
> install it to the official tree if appreciated.

It sounds like useful functionality, but Emacs went into feature freeze
yesterday, so it'll have to wait until Emacs thaws again.

Comment about the code:

> +                           (concat
> +                            "Content-Disposition: form-data;name=" (car data) "\r\n\r\n"
> +                            (concat (mm-url-form-encode-xwfu (cdr data))
> +                                    )))
> +                          ))

This is not the Emacs parenthesis style.  All the closing parentheses
should be on the same line.  And there's a superfluous `concat' there...

-- 
(domestic pets only, the antidote for overdose, milk.)
  bloggy blog http://lars.ingebrigtsen.no/

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.