GNU bug report logs - #16194
24.3.50; [PATCH] eww: Support text form with disabled and readonly attributes.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ted Zlatanov <tzz <at> lifelogs.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#16194: closed (24.3.50; [PATCH] eww: Support text form with
 disabled and readonly attributes.)
Date: Sat, 21 Dec 2013 20:42:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 21 Dec 2013 15:42:52 -0500
with message-id <87ppoqc4vn.fsf <at> flea.lifelogs.com>
and subject line Re: bug#16194: 24.3.50; [PATCH] eww: Support text form with disabled and readonly attributes.
has caused the debbugs.gnu.org bug report #16194,
regarding 24.3.50; [PATCH] eww: Support text form with disabled and readonly attributes.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
16194: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16194
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50;
 [PATCH] eww: Support text form with disabled and readonly attributes.
Date: Fri, 20 Dec 2013 09:31:27 +0900

The "disabled" and "readonly" attibutes of text form should be readonly.

example.1
 <input type="text" name="example" value="test" disabled>
example.2
 <input type="text" name="example" value="test" readonly>

Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>

        * net/eww.el (eww-form-text): Support text form with disabled
          and readonly attributes.

---
 lisp/net/eww.el | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index a4cec26..8fb6d2d 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -679,13 +679,17 @@ appears in a <link> or <a> tag."
        (value (or (cdr (assq :value cont)) ""))
        (width (string-to-number
                (or (cdr (assq :size cont))
-                   "40"))))
+                   "40")))
+       (readonly (or (cdr (assq :disabled cont))
+                     (cdr (assq :readonly cont)))))
     (insert value)
     (when (< (length value) width)
       (insert (make-string (- width (length value)) ? )))
     (put-text-property start (point) 'face 'eww-form-text)
     (put-text-property start (point) 'local-map eww-text-map)
-    (put-text-property start (point) 'inhibit-read-only t)
+    (if readonly
+       (put-text-property start (point) 'read-only t)
+      (put-text-property start (point) 'inhibit-read-only t))
     (put-text-property start (point) 'eww-form
                       (list :eww-form eww-form
                             :value value
-- 
1.8.3.1

[Message part 3 (message/rfc822, inline)]

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>
Cc: 16194-done <at> debbugs.gnu.org
Subject: Re: bug#16194: 24.3.50;
 [PATCH] eww: Support text form with disabled and readonly attributes.
Date: Sat, 21 Dec 2013 15:42:52 -0500

On Fri, 20 Dec 2013 09:31:27 +0900 Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com> wrote: 

KN> The "disabled" and "readonly" attibutes of text form should be readonly.
KN> example.1
KN>  <input type="text" name="example" value="test" disabled>
KN> example.2
KN>  <input type="text" name="example" value="test" readonly>

Applied, thank you.

Ted

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.