Subject: bug#16194: closed (Re: bug#16194: 24.3.50; [PATCH] eww: Support text form with disabled and readonly attributes.)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 21 Dec 2013 20:42:03 +0000

Your bug report

#16194: 24.3.50; [PATCH] eww: Support text form with disabled and readonly attributes.

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
16194: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16194
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#16194: 24.3.50; [PATCH] eww: Support text form with disabled and readonly attributes.
From: Ted Zlatanov <[email-masked]>
To: Kenjiro NAKAYAMA <[email-masked]>
Cc: [email-masked]
Date: Sat, 21 Dec 2013 15:42:52 -0500
List-Id: <debbugs-submit.debbugs.gnu.org>

On Fri, 20 Dec 2013 09:31:27 +0900 Kenjiro NAKAYAMA <[email-masked]> wrote: 

KN> The "disabled" and "readonly" attibutes of text form should be readonly.
KN> example.1
KN>  <input type="text" name="example" value="test" disabled>
KN> example.2
KN>  <input type="text" name="example" value="test" readonly>

Applied, thank you.

Ted

Subject: 24.3.50; [PATCH] eww: Support text form with disabled and readonly attributes.
From: Kenjiro NAKAYAMA <[email-masked]>
To: [email-masked]
Date: Fri, 20 Dec 2013 09:31:27 +0900
List-Id: <debbugs-submit.debbugs.gnu.org>

The "disabled" and "readonly" attibutes of text form should be readonly.

example.1
 <input type="text" name="example" value="test" disabled>
example.2
 <input type="text" name="example" value="test" readonly>

Signed-off-by: Kenjiro NAKAYAMA <[email-masked]>

        * net/eww.el (eww-form-text): Support text form with disabled
          and readonly attributes.

---
 lisp/net/eww.el | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index a4cec26..8fb6d2d 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -679,13 +679,17 @@ appears in a <link> or <a> tag."
        (value (or (cdr (assq :value cont)) ""))
        (width (string-to-number
                (or (cdr (assq :size cont))
-                   "40"))))
+                   "40")))
+       (readonly (or (cdr (assq :disabled cont))
+                     (cdr (assq :readonly cont)))))
     (insert value)
     (when (< (length value) width)
       (insert (make-string (- width (length value)) ? )))
     (put-text-property start (point) 'face 'eww-form-text)
     (put-text-property start (point) 'local-map eww-text-map)
-    (put-text-property start (point) 'inhibit-read-only t)
+    (if readonly
+       (put-text-property start (point) 'read-only t)
+      (put-text-property start (point) 'inhibit-read-only t))
     (put-text-property start (point) 'eww-form
                       (list :eww-form eww-form
                             :value value
-- 
1.8.3.1