From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 16 12:52:28 2013 Received: (at submit) by debbugs.gnu.org; 16 Dec 2013 17:52:28 +0000 Received: from localhost ([127.0.0.1]:54285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VscLD-0006an-Bv for submit@debbugs.gnu.org; Mon, 16 Dec 2013 12:52:28 -0500 Received: from eggs.gnu.org ([208.118.235.92]:54027) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VscL9-0006aY-RT for submit@debbugs.gnu.org; Mon, 16 Dec 2013 12:52:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VscKz-0001Bz-OW for submit@debbugs.gnu.org; Mon, 16 Dec 2013 12:52:23 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53992) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VscKz-0001Bv-LB for submit@debbugs.gnu.org; Mon, 16 Dec 2013 12:52:13 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VscKr-0004eg-23 for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2013 12:52:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VscKi-00011Q-5c for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2013 12:52:04 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:20130) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VscKi-0000zO-0D for bug-gnu-emacs@gnu.org; Mon, 16 Dec 2013 12:51:56 -0500 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id rBGHpsll003824 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 16 Dec 2013 17:51:54 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rBGHpqSl000806 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 16 Dec 2013 17:51:53 GMT Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rBGHppK1006692 for ; Mon, 16 Dec 2013 17:51:51 GMT MIME-Version: 1.0 Message-ID: <83e15b06-f550-4e34-94af-d7646abd45ea@default> Date: Mon, 16 Dec 2013 09:51:51 -0800 (PST) From: Drew Adams To: bug-gnu-emacs@gnu.org Subject: 24.3.50; isearch.el regression between 2013-12-05 and 2013-12-08 X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) There are only 3 lines of code that were changed in isearch.el to introduce this regression. I don't understand the code well enough to suggest what's wrong, and I don't yet have a simple recipe from emacs -Q. But with my setup, when I do C-a from within Isearch it no longer exits Isearch. Maybe that description will ring a bell? Here is a diff between the two isearch.el versions (from 12-05 and 12-08): *************** *** 637,642 **** --- 637,644 ---- ;; isearch is invoked. (defvar isearch-input-method-local-p nil) =20 + (defvar isearch--saved-overriding-local-map nil) +=20 ;; Minor-mode-alist changes - kind of redundant with the ;; echo area, but if isearching in multiple windows, it can be useful. =20 *************** *** 904,909 **** --- 906,914 ---- =20 (setq overriding-terminal-local-map isearch-mode-map) (run-hooks 'isearch-mode-hook) + ;; Remember the initial map possibly modified + ;; by external packages in isearch-mode-hook. (Bug#16035) + (setq isearch--saved-overriding-local-map overriding-terminal-local-map= ) =20 ;; Pushing the initial state used to be before running isearch-mode-hoo= k, ;; but a hook might set `isearch-push-state-function' used in *************** *** 2235,2241 **** (cond ;; Don't exit Isearch if we're in the middle of some ;; set-temporary-overlay-map thingy like universal-argument--mode. ! ((not (eq overriding-terminal-local-map isearch-mode-map))) ;; Don't exit Isearch for isearch key bindings. ((commandp (lookup-key isearch-mode-map key nil))) ;; Optionally edit the search string instead of exiting. --- 2240,2246 ---- (cond ;; Don't exit Isearch if we're in the middle of some ;; set-temporary-overlay-map thingy like universal-argument--mode. ! ((not (eq overriding-terminal-local-map isearch--saved-overriding-lo= cal-map))) ;; Don't exit Isearch for isearch key bindings. ((commandp (lookup-key isearch-mode-map key nil))) ;; Optionally edit the search string instead of exiting. I'm guessing that it will take someone familiar with the isearch.el code (e.g. Juri) much less time to figure out what is wrong here than it will for me to try to understand the code and narrow things down in my setup to figure it out. And if you can offer suggestions wrt things to check I'll be glad to do so. There might be other differences as well, but so far I haven't noticed any. I haven't tried much, though, and there is a lot to try, since the code has been altered in fundamental ways since the end of September. The good news is that at least simple, superficial use of Isearch in my setup does not show other breakage. Hoping you can enlighten me a bit about this - what to check etc. Or that if there is an Emacs bug perhaps you can recognize it, given only the info provided here. Thx. In GNU Emacs 24.3.50.1 (i686-pc-mingw32) of 2013-12-08 on ODIEONE Bzr revision: 115426 jan.h.d@swipnet.se-20131208125914-y6dc16jem2hg3tao Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --prefix=3D/c/Devel/emacs/binary --enable-checking=3Dyes,glyphs 'CFLAGS=3D-O0 -g3' LDFLAGS=3D-Lc:/Devel/emacs/lib CPPFLAGS=3D-Ic:/Devel/emacs/include' From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 16 15:34:12 2013 Received: (at 16169) by debbugs.gnu.org; 16 Dec 2013 20:34:13 +0000 Received: from localhost ([127.0.0.1]:54488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vserk-0002bD-1x for submit@debbugs.gnu.org; Mon, 16 Dec 2013 15:34:12 -0500 Received: from [69.163.184.122] (port=58269 helo=ps18281.dreamhostps.com) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vseri-0002ay-C9 for 16169@debbugs.gnu.org; Mon, 16 Dec 2013 15:34:10 -0500 Received: from localhost.jurta.org (ps18281.dreamhostps.com [69.163.184.122]) by ps18281.dreamhostps.com (Postfix) with ESMTP id 3825234CB016AB; Mon, 16 Dec 2013 12:34:09 -0800 (PST) From: Juri Linkov To: Drew Adams Subject: Re: bug#16169: 24.3.50; isearch.el regression between 2013-12-05 and 2013-12-08 Organization: JURTA References: <83e15b06-f550-4e34-94af-d7646abd45ea@default> Date: Mon, 16 Dec 2013 22:22:19 +0200 In-Reply-To: <83e15b06-f550-4e34-94af-d7646abd45ea@default> (Drew Adams's message of "Mon, 16 Dec 2013 09:51:51 -0800 (PST)") Message-ID: <87k3f4bl6s.fsf@mail.jurta.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > There are only 3 lines of code that were changed in isearch.el to > introduce this regression. I don't understand the code well enough to > suggest what's wrong, and I don't yet have a simple recipe from emacs > -Q. > > But with my setup, when I do C-a from within Isearch it no longer exits > Isearch. Maybe that description will ring a bell? [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS X-Debbugs-Envelope-To: 16169 Cc: 16169@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has identified this incoming email as possible spam. The original message has been attached to this so you can view it (if it isn't spam) or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: > There are only 3 lines of code that were changed in isearch.el to > introduce this regression. I don't understand the code well enough to > suggest what's wrong, and I don't yet have a simple recipe from emacs > -Q. > > But with my setup, when I do C-a from within Isearch it no longer exits > Isearch. Maybe that description will ring a bell? [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 1.3 RDNS_NONE Delivered to internal network by a host with no rDNS > There are only 3 lines of code that were changed in isearch.el to > introduce this regression. I don't understand the code well enough to > suggest what's wrong, and I don't yet have a simple recipe from emacs > -Q. > > But with my setup, when I do C-a from within Isearch it no longer exits > Isearch. Maybe that description will ring a bell? Yes, it rings a bell to you. In your isearch+.el set isearch--saved-overriding-local-map to overriding-terminal-local-map in isearch-mode that you replaced with your own implementation. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 16 16:47:19 2013 Received: (at 16169) by debbugs.gnu.org; 16 Dec 2013 21:47:19 +0000 Received: from localhost ([127.0.0.1]:54558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vsg0V-0004ay-0h for submit@debbugs.gnu.org; Mon, 16 Dec 2013 16:47:19 -0500 Received: from aserp1040.oracle.com ([141.146.126.69]:27922) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vsg0S-0004an-Kj for 16169@debbugs.gnu.org; Mon, 16 Dec 2013 16:47:17 -0500 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by aserp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id rBGLlEDe030054 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Mon, 16 Dec 2013 21:47:15 GMT Received: from aserz7022.oracle.com (aserz7022.oracle.com [141.146.126.231]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rBGLlDtg021534 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 16 Dec 2013 21:47:14 GMT Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserz7022.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rBGLlDEa013760; Mon, 16 Dec 2013 21:47:13 GMT MIME-Version: 1.0 Message-ID: <2eecca6f-a32d-47b0-9eeb-191b86d20350@default> Date: Mon, 16 Dec 2013 13:47:12 -0800 (PST) From: Drew Adams To: Juri Linkov Subject: RE: bug#16169: 24.3.50; isearch.el regression between 2013-12-05 and 2013-12-08 References: <83e15b06-f550-4e34-94af-d7646abd45ea@default> <87k3f4bl6s.fsf@mail.jurta.org> In-Reply-To: <87k3f4bl6s.fsf@mail.jurta.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 16169 Cc: 16169@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) > > There are only 3 lines of code that were changed in isearch.el to > > introduce this regression. I don't understand the code well enough to > > suggest what's wrong, and I don't yet have a simple recipe from emacs > > -Q. > > > > But with my setup, when I do C-a from within Isearch it no longer exits > > Isearch. Maybe that description will ring a bell? >=20 > Yes, it rings a bell to you. In your isearch+.el set > isearch--saved-overriding-local-map to overriding-terminal-local-map > in isearch-mode that you replaced with your own implementation. Thanks, Juri. That was not so obvious (for me). The problem I noticed appears also in builds (e.g. in October) that do not even have `isearch--saved-overriding-local-map'. Diffing the introduction of this regression (in October) did not help me see what needed to be done. I will close this bug. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 16 16:48:52 2013 Received: (at control) by debbugs.gnu.org; 16 Dec 2013 21:48:52 +0000 Received: from localhost ([127.0.0.1]:54562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vsg1z-0004dQ-PC for submit@debbugs.gnu.org; Mon, 16 Dec 2013 16:48:52 -0500 Received: from userp1040.oracle.com ([156.151.31.81]:22233) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vsg1x-0004dG-W0 for control@debbugs.gnu.org; Mon, 16 Dec 2013 16:48:50 -0500 Received: from ucsinet21.oracle.com (ucsinet21.oracle.com [156.151.31.93]) by userp1040.oracle.com (Sentrion-MTA-4.3.1/Sentrion-MTA-4.3.1) with ESMTP id rBGLmm7W023249 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 16 Dec 2013 21:48:48 GMT Received: from aserz7021.oracle.com (aserz7021.oracle.com [141.146.126.230]) by ucsinet21.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rBGLmlq0025892 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 16 Dec 2013 21:48:48 GMT Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserz7021.oracle.com (8.14.4+Sun/8.14.4) with ESMTP id rBGLmlSK027172 for ; Mon, 16 Dec 2013 21:48:47 GMT MIME-Version: 1.0 Message-ID: <81d9ff6c-0a44-4369-81da-d510d5f97324@default> Date: Mon, 16 Dec 2013 13:48:46 -0800 (PST) From: Drew Adams To: control@debbugs.gnu.org Subject: close 16169 X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.8 (707110) [OL 12.0.6680.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Source-IP: ucsinet21.oracle.com [156.151.31.93] X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) close 16169 thanks From unknown Wed Jun 25 09:10:54 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 14 Jan 2014 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator