GNU bug report logs - #16159
[PATCH] Better paragraph separation for sh-mode

Previous Next

Package: emacs;

Reported by: Daniel Colascione <dancol <at> dancol.org>

Date: Mon, 16 Dec 2013 10:51:01 UTC

Severity: minor

Tags: patch

Fixed in version 24.4

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16159 in the body.
You can then email your comments to 16159 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#16159; Package emacs. (Mon, 16 Dec 2013 10:51:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to Daniel Colascione <dancol <at> dancol.org>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 16 Dec 2013 10:51:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Colascione <dancol <at> dancol.org>
To: bug-emacs <bug-gnu-emacs <at> gnu.org>
Subject: [PATCH] Better paragraph separation for sh-mode
Date: Mon, 16 Dec 2013 02:49:32 -0800

This change should make sure that M-q doesn't combine a comment line 
with the initial shebang of a shell script.

$ bzr diff
=== modified file 'lisp/progmodes/sh-script.el'
--- lisp/progmodes/sh-script.el	2013-11-09 10:49:42 +0000
+++ lisp/progmodes/sh-script.el	2013-12-16 10:46:04 +0000
@@ -1589,7 +1589,7 @@
 	      (lambda () (or (eolp) (newline) (indent-relative))))

   (setq-local paragraph-start (concat page-delimiter "\\|$"))
-  (setq-local paragraph-separate paragraph-start)
+  (setq-local paragraph-separate (concat paragraph-start "\\|#!/"))
   (setq-local comment-start "# ")
   (setq-local comment-start-skip "#+[\t ]*")
   (setq-local local-abbrev-table sh-mode-abbrev-table)
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#16159; Package emacs. (Wed, 18 Dec 2013 07:54:02 GMT) Full text and rfc822 format available.

Message #8 received at 16159 <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: Daniel Colascione <dancol <at> dancol.org>
Cc: 16159 <at> debbugs.gnu.org
Subject: Re: bug#16159: [PATCH] Better paragraph separation for sh-mode
Date: Wed, 18 Dec 2013 02:53:26 -0500

Daniel Colascione wrote:

> -  (setq-local paragraph-separate paragraph-start)
> +  (setq-local paragraph-separate (concat paragraph-start "\\|#!/"))

Looks ok to me; please apply.
Reply sent to Glenn Morris <rgm <at> gnu.org>:
You have taken responsibility. (Sun, 22 Dec 2013 23:27:01 GMT) Full text and rfc822 format available.
Notification sent to Daniel Colascione <dancol <at> dancol.org>:
bug acknowledged by developer. (Sun, 22 Dec 2013 23:27:05 GMT) Full text and rfc822 format available.

Message #13 received at 16159-done <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: 16159-done <at> debbugs.gnu.org
Subject: Re: bug#16159: [PATCH] Better paragraph separation for sh-mode
Date: Sun, 22 Dec 2013 18:26:17 -0500

Version: 24.4

Thanks for applying it. Next time please close the associated bug as
well, which you do simply by mailing ###-done <at> debbugs. You may also wish
to refer to the bug number in the ChangeLog entry.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 20 Jan 2014 12:24:06 GMT) Full text and rfc822 format available.
This bug report was last modified 11 years and 157 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.