GNU bug report logs - #16151
margin does not respect face-remapping-alist. no margin face.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#16151: closed (margin does not respect face-remapping-alist. 
 no margin face.)
Date: Sun, 15 Dec 2013 17:05:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 15 Dec 2013 19:03:39 +0200
with message-id <83wqj6dp1w.fsf <at> gnu.org>
and subject line Re: bug#16151: margin does not respect face-remapping-alist. no margin	face.
has caused the debbugs.gnu.org bug report #16151,
regarding margin does not respect face-remapping-alist.  no margin face.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
16151: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16151
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: David Reitter <david.reitter <at> gmail.com>
To: Bug-Gnu-Emacs <bug-gnu-emacs <at> gnu.org>
Subject: margin does not respect face-remapping-alist.  no margin face.
Date: Sat, 14 Dec 2013 17:30:17 -0500

[Message part 3 (text/plain, inline)]

Emacs -Q

Then:

(linum-mode 1)
(setq face-remapping-alist '((default . custom-invalid)))

Observe that the empty space in the left margin is white, rather than red.  See attached screenshot.

The left (and presumably right) margins seem to use the default face, but fail to take `face-remapping-alist' into account.

It would not hurt to have a `margins' face,  but even then, remapping should be observed.


This is an up to date build.



In GNU Emacs 24.3.50.4 (x86_64-apple-darwin13.0.0, NS apple-appkit-1265.00)
 of 2013-12-14 on momo
Windowing system distributor `Apple', version 10.3.1265
Configured using:
 `configure --with-ns'

[Message part 4 (text/html, inline)]

[Screen Shot 2013-12-14 at 5.09.07 PM.png (image/png, inline)]

[Message part 6 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: David Reitter <david.reitter <at> gmail.com>
Cc: 16151-done <at> debbugs.gnu.org
Subject: Re: bug#16151: margin does not respect face-remapping-alist. no
 margin	face.
Date: Sun, 15 Dec 2013 19:03:39 +0200

> From: David Reitter <david.reitter <at> gmail.com>
> Date: Sat, 14 Dec 2013 17:30:17 -0500
> 
> Emacs -Q
> 
> Then:
> 
> (linum-mode 1)
> (setq face-remapping-alist '((default . custom-invalid)))

(I'm guessing this wasn't exactly "emacs -Q", because custom-invalid
face is not known in 'emacs -Q", at least on my system.)

> Observe that the empty space in the left margin is white, rather than red.  See attached screenshot.
> 
> The left (and presumably right) margins seem to use the default face, but fail to take `face-remapping-alist' into account.

No, they do take the face remapping into account.  Otherwise, how
could you have the correct face where the line numbers _are_ written
in the margin, as clearly seen in your screenshots?

The problem was that the empty margin area was not filled with the
background of the default face, whether remapped or not, like we do
with the text area.  This was never supported in Emacs, the code to do
that was simply never written.

Now this works, starting from trunk revision 115535.

> It would not hurt to have a `margins' face

??? What is shown in the margins is display strings which have to be
hand-crafted anyway, so you can have any face you want there, just
propertize the string accordingly.  Why do we need another face?

Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.