GNU bug report logs - #16145
ERC disregards data to be logged when reconnecting

Previous Next

Full log

View this message in rfc822 format

From: Ivan Shmakov <ivan <at> siamics.net>
To: 16145 <at> debbugs.gnu.org
Subject: bug#16145: ERC disregards data to be logged when reconnecting 
Date: Sat, 14 Dec 2013 14:43:35 +0000

	Upon reconnecting to the server, erc-connect-pre-hook is run,
	which, by default, results in erc-initialize-log-marker being
	called, and the erc-last-saved-position marker reinitialized.

	The problem is that no calls to erc-save-buffer-in-logs are made
	when the connection is closed, resulting in the entire previous
	ERC session silently disregarded, and never saved in the logs.

	Presuming that erc-initialize-log-marker was really meant to
	only initialize erc-last-saved-position when there’s none, my
	suggestion would be for it to be amended with an appropriate
	‘unless’ guard.

	Alternatively (or perhaps complementarily), a call to
	erc-log-save-all-buffers may be added to the
	erc-disconnected-hook’s default value.  (Please note that this
	alone, however, may be less reliable a measure.)

-- 
FSF associate member #7257

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.