From unknown Sat Jun 21 12:18:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16145: ERC disregards data to be logged when reconnecting Resent-From: Ivan Shmakov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Dec 2013 14:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16145 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 16145@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.138703224921744 (code B ref -1); Sat, 14 Dec 2013 14:45:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Dec 2013 14:44:09 +0000 Received: from localhost ([127.0.0.1]:49470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VrqRs-0005ec-CU for submit@debbugs.gnu.org; Sat, 14 Dec 2013 09:44:08 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53820) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VrqRo-0005eP-Dh for submit@debbugs.gnu.org; Sat, 14 Dec 2013 09:44:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VrqRi-0001TK-Dn for submit@debbugs.gnu.org; Sat, 14 Dec 2013 09:44:03 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrqRi-0001TG-AD for submit@debbugs.gnu.org; Sat, 14 Dec 2013 09:43:58 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55522) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrqRd-0005dv-ED for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 09:43:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VrqRY-0001ST-IK for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 09:43:53 -0500 Received: from fely.am-1.org ([78.47.74.50]:57515) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrqRY-0001SG-B5 for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 09:43:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:Sender:Subject:To:From; bh=4GbibIBKD6Lfy8om1Fnf/M7KOZye1X55k66VYTvYFT0=; b=Q/lfsTUHWyb3pTL9+VktqMkskNzjgHMAAJByJQAEaiQhYulJIgvkiNVXDPN+Wtvwwf/cSokg741AEHTESBEI1KtTJHjvQHA+bdbguEhGd5C8uwy2htdODkNhGEQ/XzfnUkdetUE+NLCN3UDOLXAkF9X6R/j3cpDajVywbjlvq00=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1VrqRV-00068w-DV for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 14:43:45 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1VrqRM-0003PQ-W5 for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 21:43:37 +0700 From: Ivan Shmakov Date: Sat, 14 Dec 2013 14:43:35 +0000 Message-ID: <87sitvxzl4.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) Upon reconnecting to the server, erc-connect-pre-hook is run, which, by default, results in erc-initialize-log-marker being called, and the erc-last-saved-position marker reinitialized. The problem is that no calls to erc-save-buffer-in-logs are made when the connection is closed, resulting in the entire previous ERC session silently disregarded, and never saved in the logs. Presuming that erc-initialize-log-marker was really meant to only initialize erc-last-saved-position when there=E2=80=99s none, my suggestion would be for it to be amended with an appropriate =E2=80=98unless=E2=80=99 guard. Alternatively (or perhaps complementarily), a call to erc-log-save-all-buffers may be added to the erc-disconnected-hook=E2=80=99s default value. (Please note that this alone, however, may be less reliable a measure.) --=20 FSF associate member #7257 From unknown Sat Jun 21 12:18:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16145: ERC disregards data to be logged when reconnecting Resent-From: Ivan Shmakov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Oct 2014 11:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16145 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 16145@debbugs.gnu.org, control@debbugs.gnu.org Received: via spool by 16145-submit@debbugs.gnu.org id=B16145.141250816131024 (code B ref 16145); Sun, 05 Oct 2014 11:23:02 +0000 Received: (at 16145) by debbugs.gnu.org; 5 Oct 2014 11:22:41 +0000 Received: from localhost ([127.0.0.1]:33500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xajtg-00084I-On for submit@debbugs.gnu.org; Sun, 05 Oct 2014 07:22:41 -0400 Received: from fely.am-1.org ([78.47.74.50]:35158) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xajtb-00083y-W0; Sun, 05 Oct 2014 07:22:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=xs7lW7tVMVvzZoaycEGW6SA/5TX6RDIyRfruMb0tLw8=; b=mUCGU8ej3o34lIDZVBceTkoKu66Uazy2lTWwzX+qCfuMXuCTlP0w4aDujWjkrXW1tzl4pbMCNfkjXI2mUISf6cNe70ShdR0erhR/INMLSeY5ZHNffX0VuzqHJugv1oGbvyhb78dizNAkY67AuHdU9qjJWvrrHcs07nBERwEihUY=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Xajta-0006O0-CH; Sun, 05 Oct 2014 11:22:34 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1XajtS-000182-JU; Sun, 05 Oct 2014 18:22:26 +0700 From: Ivan Shmakov References: <87sitvxzl4.fsf@violet.siamics.net> Date: Sun, 05 Oct 2014 11:22:25 +0000 In-Reply-To: <87sitvxzl4.fsf@violet.siamics.net> (Ivan Shmakov's message of "Sat, 14 Dec 2013 14:43:35 +0000") Message-ID: <877g0e7ocu.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable tag 16145 + patch thanks I hereby suggest the patch MIMEd. (In the same spirit as the one for Bug#18599.) 2014-10-05 Ivan Shmakov * erc.el (erc-initialize-log-marker): Only initialize erc-last-saved-position if not already a marker. (Closes #16145.) --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A --=-=-= Content-Type: text/plain Content-Disposition: inline --- a/lisp/erc/erc.el +++ b/lisp/erc/erc.el @@ -2052,9 +2052,10 @@ defun erc-initialize-log-marker (buffer) "Initialize the `erc-last-saved-position' marker to a sensible position. BUFFER is the current buffer." (with-current-buffer buffer - (setq erc-last-saved-position (make-marker)) - (move-marker erc-last-saved-position - (1- (marker-position erc-insert-marker))))) + (unless (markerp erc-last-saved-position) + (setq erc-last-saved-position (make-marker)) + (move-marker erc-last-saved-position + (1- (marker-position erc-insert-marker)))))) ;; interactive startup --=-=-=-- From unknown Sat Jun 21 12:18:45 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Ivan Shmakov Subject: bug#16145: closed (Re: bug#16145: ERC disregards data to be logged when reconnecting ) Message-ID: References: <87wq6owdu1.fsf@violet.siamics.net> <87sitvxzl4.fsf@violet.siamics.net> X-Gnu-PR-Message: they-closed 16145 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 16145@debbugs.gnu.org Date: Fri, 21 Nov 2014 19:32:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1416598322-19510-1" This is a multi-part message in MIME format... ------------=_1416598322-19510-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #16145: ERC disregards data to be logged when reconnecting=20 which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 16145@debbugs.gnu.org. --=20 16145: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D16145 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1416598322-19510-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 16145-done) by debbugs.gnu.org; 21 Nov 2014 19:31:54 +0000 Received: from localhost ([127.0.0.1]:41222 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xrtvq-000540-MH for submit@debbugs.gnu.org; Fri, 21 Nov 2014 14:31:54 -0500 Received: from fely.am-1.org ([78.47.74.50]:41763) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Xrtvj-00053a-Vx for 16145-done@debbugs.gnu.org; Fri, 21 Nov 2014 14:31:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:Sender:References:Subject:To:From; bh=sqZ7YeE6UjIwK2oWAUR0XwadPUCEigYqmIs4A8b0jxU=; b=ZBISNPO9o6IlBzou0CcG5TSVK9Tqs4mJNPvItztUfFQ+VGB/bKRQoudTSEptmYY9mCUq4IHQbua5we6WMZOLB5kSj8nUG1zt/Ljw7QE1fdyiIaMM3GqFsKbeRo8tV0ATO2RHvtcAOk04sMaQxzGbLyU5wl2DZmEkVkFdPkU5jj4=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.2:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Xrtvi-0003kN-KK for 16145-done@debbugs.gnu.org; Fri, 21 Nov 2014 19:31:43 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.80) (envelope-from ) id 1Xrtv4-0007vO-NJ for 16145-done@debbugs.gnu.org; Sat, 22 Nov 2014 02:31:02 +0700 From: Ivan Shmakov To: 16145-done@debbugs.gnu.org Subject: Re: bug#16145: ERC disregards data to be logged when reconnecting References: <87sitvxzl4.fsf@violet.siamics.net> <877g0e7ocu.fsf@violet.siamics.net> Date: Fri, 21 Nov 2014 19:31:02 +0000 In-Reply-To: <877g0e7ocu.fsf@violet.siamics.net> (Ivan Shmakov's message of "Sun, 05 Oct 2014 11:22:25 +0000") Message-ID: <87wq6owdu1.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 16145-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) Version: 24.5 I no longer observe the issue (as of 2014-11-18 build, cb4f666ade76.) Per my reading of the Git log, it was fixed in Git master back this October: commit 43f52995ea9d4846c84f81d64107314a6577e595 Author: Ivan Shmakov AuthorDate: Fri Oct 10 09:16:12 2014 -0400 Commit: Kelvin White CommitDate: Fri Oct 10 09:16:12 2014 -0400 Only initialize erc-last-saved-position if not already a marker. =20=20=20=20 Fixes: debbugs:16145 In emacs-24, this bug was fixed as part of the following =E2=80=9Cbackport=E2=80=9D change: commit d1036d288de1e047f7f6043188a1063f0d6b044d Author: l3thal AuthorDate: Sat Nov 8 20:51:43 2014 -0500 Commit: l3thal CommitDate: Sat Nov 8 20:51:43 2014 -0500 backport: erc bugfixes --=20 FSF associate member #7257 http://boycottsystemd.org/ =E2=80=A6 3013 B6A0= 230E 334A ------------=_1416598322-19510-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Dec 2013 14:44:09 +0000 Received: from localhost ([127.0.0.1]:49470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VrqRs-0005ec-CU for submit@debbugs.gnu.org; Sat, 14 Dec 2013 09:44:08 -0500 Received: from eggs.gnu.org ([208.118.235.92]:53820) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VrqRo-0005eP-Dh for submit@debbugs.gnu.org; Sat, 14 Dec 2013 09:44:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VrqRi-0001TK-Dn for submit@debbugs.gnu.org; Sat, 14 Dec 2013 09:44:03 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51772) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrqRi-0001TG-AD for submit@debbugs.gnu.org; Sat, 14 Dec 2013 09:43:58 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55522) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrqRd-0005dv-ED for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 09:43:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VrqRY-0001ST-IK for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 09:43:53 -0500 Received: from fely.am-1.org ([78.47.74.50]:57515) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrqRY-0001SG-B5 for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 09:43:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:Sender:Subject:To:From; bh=4GbibIBKD6Lfy8om1Fnf/M7KOZye1X55k66VYTvYFT0=; b=Q/lfsTUHWyb3pTL9+VktqMkskNzjgHMAAJByJQAEaiQhYulJIgvkiNVXDPN+Wtvwwf/cSokg741AEHTESBEI1KtTJHjvQHA+bdbguEhGd5C8uwy2htdODkNhGEQ/XzfnUkdetUE+NLCN3UDOLXAkF9X6R/j3cpDajVywbjlvq00=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1VrqRV-00068w-DV for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 14:43:45 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1VrqRM-0003PQ-W5 for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 21:43:37 +0700 From: Ivan Shmakov To: bug-gnu-emacs@gnu.org Subject: ERC disregards data to be logged when reconnecting Date: Sat, 14 Dec 2013 14:43:35 +0000 Message-ID: <87sitvxzl4.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.3 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.3 (----) Upon reconnecting to the server, erc-connect-pre-hook is run, which, by default, results in erc-initialize-log-marker being called, and the erc-last-saved-position marker reinitialized. The problem is that no calls to erc-save-buffer-in-logs are made when the connection is closed, resulting in the entire previous ERC session silently disregarded, and never saved in the logs. Presuming that erc-initialize-log-marker was really meant to only initialize erc-last-saved-position when there=E2=80=99s none, my suggestion would be for it to be amended with an appropriate =E2=80=98unless=E2=80=99 guard. Alternatively (or perhaps complementarily), a call to erc-log-save-all-buffers may be added to the erc-disconnected-hook=E2=80=99s default value. (Please note that this alone, however, may be less reliable a measure.) --=20 FSF associate member #7257 ------------=_1416598322-19510-1--