From unknown Sun Jun 22 07:55:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16141: 24.3.50; [PATCH] eww: added text-property to jump to next select field. Resent-From: Nakayama Kenjiro Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Dec 2013 12:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16141 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 16141@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.13870227511254 (code B ref -1); Sat, 14 Dec 2013 12:06:01 +0000 Received: (at submit) by debbugs.gnu.org; 14 Dec 2013 12:05:51 +0000 Received: from localhost ([127.0.0.1]:49342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vrnyg-0000K9-Fc for submit@debbugs.gnu.org; Sat, 14 Dec 2013 07:05:51 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59565) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vrnyc-0000Jz-Mq for submit@debbugs.gnu.org; Sat, 14 Dec 2013 07:05:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vrnyb-0001o9-I0 for submit@debbugs.gnu.org; Sat, 14 Dec 2013 07:05:46 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53651) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vrnyb-0001o1-EM for submit@debbugs.gnu.org; Sat, 14 Dec 2013 07:05:45 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vrnya-0004qE-BA for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 07:05:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VrnyX-0001lv-PF for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 07:05:44 -0500 Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:65427) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrnyX-0001lV-FC for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 07:05:41 -0500 Received: by mail-wg0-f42.google.com with SMTP id a1so331383wgh.5 for ; Sat, 14 Dec 2013 04:05:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=i0lh7E9rJFC6eKliUccGlwaApGJYEcne//xD9PGeBII=; b=IodChTLB5WsJOb0Y7UD4Wblro1w2YIiVXwCjN7igVkK1ThpOfZ/7j54qnr1qUi7Iia OmjVwE2PrYXSiu46VX2vfOdxhsUThmjIYZjQ4nofd8h58zeZAu/9lemw59aPa03D/n+F TetktkEIbfDZ+eycIKjY7rlJebKZrlUYHepN0N6u7KLYebvEQy9WGWJtMX8KT4A8aM77 WZPilEh5B3yBkD5WoiIcKjGGw9a3OTmR/BD2+dRSRg0/6kIAIVMnGsh3iVrQwOdXEzj2 g92VSRWizqE0bFqJSvfu6GZnTfd4aXAu2DpddWdw2GsFLfSULaLxLeOhNpvcVTvXaqVL biXQ== MIME-Version: 1.0 X-Received: by 10.194.120.164 with SMTP id ld4mr6104620wjb.47.1387022740691; Sat, 14 Dec 2013 04:05:40 -0800 (PST) Received: by 10.180.38.76 with HTTP; Sat, 14 Dec 2013 04:05:40 -0800 (PST) Date: Sat, 14 Dec 2013 21:05:40 +0900 Message-ID: From: Nakayama Kenjiro Content-Type: text/plain; charset=ISO-8859-1 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) It is useful, if we can jump to next select fiedld with tab commadn. Signed-off-by: Kenjiro NAKAYAMA * net/eww.el (eww-tag-select): added text-property to jump to next select field. --- lisp/net/eww.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 1693e74..0264174 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -841,7 +841,8 @@ See URL `https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input'.") (put-text-property start (point) 'eww-form menu) (add-face-text-property start (point) 'eww-form-select) (put-text-property start (point) 'keymap eww-select-map) - (put-text-property start (1+ start) 'help-echo "select field") + (unless (= start (point)) + (put-text-property start (1+ start) 'help-echo "select field")) (shr-ensure-paragraph)))) (defun eww-select-display (select) -- 1.8.3.1 Kenjiro From unknown Sun Jun 22 07:55:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16141: 24.3.50; [PATCH] eww: added text-property to jump to next select field. Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Dec 2013 14:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16141 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Nakayama Kenjiro Cc: 16141@debbugs.gnu.org Received: via spool by 16141-submit@debbugs.gnu.org id=B16141.138703097619669 (code B ref 16141); Sat, 14 Dec 2013 14:23:02 +0000 Received: (at 16141) by debbugs.gnu.org; 14 Dec 2013 14:22:56 +0000 Received: from localhost ([127.0.0.1]:49457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vrq7L-00057B-Eh for submit@debbugs.gnu.org; Sat, 14 Dec 2013 09:22:55 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]:58738) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vrq7J-000573-Ia for 16141@debbugs.gnu.org; Sat, 14 Dec 2013 09:22:53 -0500 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id rBEEMpwh022971; Sat, 14 Dec 2013 09:22:52 -0500 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id B44B3AE358; Sat, 14 Dec 2013 09:22:50 -0500 (EST) From: Stefan Monnier Message-ID: References: Date: Sat, 14 Dec 2013 09:22:50 -0500 In-Reply-To: (Nakayama Kenjiro's message of "Sat, 14 Dec 2013 21:05:40 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.7 X-NAI-Spam-Rules: 3 Rules triggered NUMBER_22_28=0.5, NOFROM_SGMAIL=0.2, RV4792=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4792> : inlines <324> : streams <1090735> : uri <1623771> X-Spam-Score: -1.8 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) > It is useful, if we can jump to next select fiedld with tab commadn. > Signed-off-by: Kenjiro NAKAYAMA Thank you for your patch. I'll let the EWW maintainers decide what to do with it, but I just wanted to point out: > * net/eww.el (eww-tag-select): added text-property to jump to > next select field. Such comments should describe what the change *does* rather than what it *did*, i.e. use the present tense (and capitalize the word after the colon since it starts a sentence). Stefan From unknown Sun Jun 22 07:55:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16141: 24.3.50; [PATCH] eww: added text-property to jump to next select field. Resent-From: Kenjiro NAKAYAMA Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 14 Dec 2013 16:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16141 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Monnier Cc: Nakayama Kenjiro , 16141@debbugs.gnu.org Received: via spool by 16141-submit@debbugs.gnu.org id=B16141.138703794531984 (code B ref 16141); Sat, 14 Dec 2013 16:20:02 +0000 Received: (at 16141) by debbugs.gnu.org; 14 Dec 2013 16:19:05 +0000 Received: from localhost ([127.0.0.1]:50214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vrrvk-0008Jn-Ds for submit@debbugs.gnu.org; Sat, 14 Dec 2013 11:19:05 -0500 Received: from mail-pb0-f47.google.com ([209.85.160.47]:51046) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vrrvg-0008JL-Ns for 16141@debbugs.gnu.org; Sat, 14 Dec 2013 11:19:01 -0500 Received: by mail-pb0-f47.google.com with SMTP id um1so3787992pbc.20 for <16141@debbugs.gnu.org>; Sat, 14 Dec 2013 08:18:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-type; bh=cxYiGhJ2Opw2t+aCf6sHqGXCGx2tvC5echEkrjYBqAo=; b=lCp2a4W/DV0zRNMt8fXYnXwQfEKDLNzgNe5t8djVUoswKC5tHptX6CIPxlLXZn9NCg CwCiHbYwQwP4AMe+jL4pQnoA3jvkU19j5/iL/amK+2nMreEcD9oCpqph4+l2iylV+LRW oo1RsoYXosZXKTbiFTIDrTngr4uTT8YQ2doWhc3YudI3rGT0IzcqeIQ2WceKgqd/Dnnv vxqChx/MrsfWX8LU2EmQPzmU2bkX+eU7BrrwN0uEiw7Gdv1fhXScMQJwfOhw9onmKFnm WRPCbFPpg+AE/9HCzpSVqWRpU9MNE/rq7NdXxwDUcd/ME+Lf2Q7El1SDzXxB7jL+eyEn uRRg== X-Received: by 10.68.173.132 with SMTP id bk4mr1109701pbc.169.1387037939725; Sat, 14 Dec 2013 08:18:59 -0800 (PST) Received: from dhcp-193-97.nrt.redhat.com (nat-pool-nrt-t1.redhat.com. [66.187.238.10]) by mx.google.com with ESMTPSA id gv10sm13357429pbd.0.2013.12.14.08.18.57 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 14 Dec 2013 08:18:58 -0800 (PST) References: User-agent: mu4e 0.9.9.6pre2; emacs 24.3.50.2 From: Kenjiro NAKAYAMA In-reply-to: Date: Sun, 15 Dec 2013 01:18:54 +0900 Message-ID: <87y53ncsnl.fsf@dhcp-193-97.nrt.redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) > Such comments should describe what the change *does* rather than what it > *did*, i.e. use the present tense (and capitalize the word after the > colon since it starts a sentence). Thank you Stefan. I resend patch with a fixed comment. Signed-off-by: Kenjiro NAKAYAMA * net/eww.el (eww-tag-select): Add text-property to jump to next select field. --- lisp/net/eww.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 1693e74..0264174 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -841,7 +841,8 @@ See URL `https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input[1]'.") (put-text-property start (point) 'eww-form menu) (add-face-text-property start (point) 'eww-form-select) (put-text-property start (point) 'keymap eww-select-map) - (put-text-property start (1+ start) 'help-echo "select field") + (unless (= start (point)) + (put-text-property start (1+ start) 'help-echo "select field")) (shr-ensure-paragraph)))) (defun eww-select-display (select) -- 1.8.3.1 monnier@IRO.UMontreal.CA writes: >> It is useful, if we can jump to next select fiedld with tab commadn. >> Signed-off-by: Kenjiro NAKAYAMA > > Thank you for your patch. I'll let the EWW maintainers decide what to > do with it, but I just wanted to point out: > >> * net/eww.el (eww-tag-select): added text-property to jump to >> next select field. > > Such comments should describe what the change *does* rather than what it > *did*, i.e. use the present tense (and capitalize the word after the > colon since it starts a sentence). > > > Stefan From unknown Sun Jun 22 07:55:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16141: 24.3.50; [PATCH] eww: added text-property to jump to next select field. Resent-From: Ted Zlatanov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 21 Dec 2013 20:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16141 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Kenjiro NAKAYAMA , Lars Magne Ingebrigtsen Cc: 16141@debbugs.gnu.org, Stefan Monnier Received: via spool by 16141-submit@debbugs.gnu.org id=B16141.138765883214325 (code B ref 16141); Sat, 21 Dec 2013 20:48:01 +0000 Received: (at 16141) by debbugs.gnu.org; 21 Dec 2013 20:47:12 +0000 Received: from localhost ([127.0.0.1]:33669 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VuTS3-0003iy-Dr for submit@debbugs.gnu.org; Sat, 21 Dec 2013 15:47:11 -0500 Received: from mail-qc0-f180.google.com ([209.85.216.180]:64193) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VuTS0-0003in-CX for 16141@debbugs.gnu.org; Sat, 21 Dec 2013 15:47:09 -0500 Received: by mail-qc0-f180.google.com with SMTP id w7so3508340qcr.25 for <16141@debbugs.gnu.org>; Sat, 21 Dec 2013 12:47:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=3E0jyb2GBjTFoCDR2Dr4Dt0fwgeL0OUpDdKwho0bCgc=; b=IRfSy9pjp8BDCVKYawDDqiOQ0YNEyLfXLFV4UAVNzifp44bsUwBVZ+1cucOSOYwNhP /BsMHvPx7iRUcBTi2w32qtIQIkw8RHfbgZSiNbbc0GKkl4V9k2ZQXzdhp8YOU+Ycfqmg WXXNNL8vlCCVrS7rhqV1rpsWzgeYjuYRKu29w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=3E0jyb2GBjTFoCDR2Dr4Dt0fwgeL0OUpDdKwho0bCgc=; b=htq4DAKU3JSBKbKTaD65x+D9Sbsu6cZA7O7SMjODXvnQq1ueXd//uWzkAe9LxWV4wL 1ePgctfhBmf9gGmzt2KJOqh9Ed/okjCuifUnLcY/Ocy3XldYjBlVkoO/9tsAIxwJonDh 5qT0UpGtYcK8NvyH6GrXzgWJN/491ubqyWQdDSM8/jsWN5NgrzNuacHY2sSz9KWd1oGc +iNNOkQXlObb1z2L3HaSDYuOQJDJKjsKHw/OwL3QecJYZtNa+k4sIPmr/tVFqUKBSBA6 hU5DBPoODH8+hF3W1KY/AipmNOTRgVHw3ktFjV/zuTzHKXx7pdtpuDKF5Qmdlh1pnGJm I1Kw== X-Gm-Message-State: ALoCoQl1IZJpUM44NBQCuTLXWN1pKJkDs8Jt21AtZODj9oLp8kybO4HDfnO6s2JbO69mPJ1rcva/ X-Received: by 10.224.88.202 with SMTP id b10mr27454705qam.85.1387658827808; Sat, 21 Dec 2013 12:47:07 -0800 (PST) Received: from flea.lifelogs.com (c-98-229-61-72.hsd1.ma.comcast.net. [98.229.61.72]) by mx.google.com with ESMTPSA id m7sm13568743qer.16.2013.12.21.12.47.06 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Dec 2013 12:47:07 -0800 (PST) From: Ted Zlatanov Organization: =?UTF-8?Q?=D0=A2=D0=B5=D0=BE=D0=B4=D0=BE=D1=80_?= =?UTF-8?Q?=D0=97=D0=BB=D0=B0=D1=82=D0=B0=D0=BD=D0=BE=D0=B2?= @ Cienfuegos References: <87y53ncsnl.fsf@dhcp-193-97.nrt.redhat.com> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Sat, 21 Dec 2013 15:48:28 -0500 In-Reply-To: <87y53ncsnl.fsf@dhcp-193-97.nrt.redhat.com> (Kenjiro NAKAYAMA's message of "Sun, 15 Dec 2013 01:18:54 +0900") Message-ID: <87d2kqc4mb.fsf@flea.lifelogs.com> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sun, 15 Dec 2013 01:18:54 +0900 Kenjiro NAKAYAMA wrote: >> Such comments should describe what the change *does* rather than what it >> *did*, i.e. use the present tense (and capitalize the word after the >> colon since it starts a sentence). KN> Thank you Stefan. KN> I resend patch with a fixed comment. KN> Signed-off-by: Kenjiro NAKAYAMA KN> * net/eww.el (eww-tag-select): Add text-property to jump to KN> next select field. It doesn't apply cleanly anymore, sorry. Can you rebase and resend? Thanks Ted From unknown Sun Jun 22 07:55:20 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16141: 24.3.50; [PATCH] eww: added text-property to jump to next select field. Resent-From: Kenjiro NAKAYAMA Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Dec 2013 01:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16141 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Ted Zlatanov Cc: Lars Magne Ingebrigtsen , Kenjiro NAKAYAMA , 16141@debbugs.gnu.org, Stefan Monnier Received: via spool by 16141-submit@debbugs.gnu.org id=B16141.138767743222596 (code B ref 16141); Sun, 22 Dec 2013 01:58:02 +0000 Received: (at 16141) by debbugs.gnu.org; 22 Dec 2013 01:57:12 +0000 Received: from localhost ([127.0.0.1]:33805 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VuYI4-0005sM-40 for submit@debbugs.gnu.org; Sat, 21 Dec 2013 20:57:12 -0500 Received: from mail-pd0-f171.google.com ([209.85.192.171]:33111) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VuYI2-0005sD-1x for 16141@debbugs.gnu.org; Sat, 21 Dec 2013 20:57:10 -0500 Received: by mail-pd0-f171.google.com with SMTP id z10so3968789pdj.30 for <16141@debbugs.gnu.org>; Sat, 21 Dec 2013 17:57:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-type; bh=8cG7ocUiZuq0PLAeuptc5P7ypPvKFWkB12tDbVOrmwA=; b=xOmlwUF5N8okbHAoE7NIfjkszTBUdwQ3lnq80GL74ho7Jwy5A4MtkcEMaXZbRuDGgr Sl21Va5GiWiMgJC3rt36Atyz8Zysq+qIl5MGpb2qUmiPxX9n7TwXqX2hxJcFNaTrVIEO bE0XE7MVQ1nAmJQn6jMt+TqUzza78v962tKM4ldeQR9xZRxTnBSEmuvz2m3INYhjHjdb xuVpPnAY59d//J6CL099CrxddaeAX1cS+9HXaerZ23Ib5/7gg6/yVU8NElQIpQXl+jc2 Q5PUtooeK5qM1LqY0lYUqQC8NXPiHhYzX7akCNyotgreNFTgIbnCgxXpPMuY0Lu8VcE9 W+4Q== X-Received: by 10.66.136.71 with SMTP id py7mr18022439pab.2.1387677428835; Sat, 21 Dec 2013 17:57:08 -0800 (PST) Received: from dhcp-193-97.nrt.redhat.com (nat-pool-nrt-t1.redhat.com. [66.187.238.10]) by mx.google.com with ESMTPSA id ko10sm11948373pbd.38.2013.12.21.17.57.05 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 21 Dec 2013 17:57:07 -0800 (PST) References: <87y53ncsnl.fsf@dhcp-193-97.nrt.redhat.com> <87d2kqc4mb.fsf@flea.lifelogs.com> User-agent: mu4e 0.9.9.6pre2; emacs 24.3.50.1 From: Kenjiro NAKAYAMA In-reply-to: <87d2kqc4mb.fsf@flea.lifelogs.com> Date: Sun, 22 Dec 2013 10:56:53 +0900 Message-ID: <87sitlir6i.fsf@dhcp-193-97.nrt.redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) > It doesn't apply cleanly anymore, sorry. Can you rebase and resend? Sorry, it's my mistake. This is proper patch. Signed-off-by: Kenjiro NAKAYAMA * net/eww.el (eww-tag-select): Add text-property to jump to next select field. --- diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 15bb2c0..cd59380 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -847,6 +847,8 @@ See URL `https://developer.mozilla.org/en-US/docs/Web/HTML/Element/ (put-text-property start (point) 'eww-form menu) (add-face-text-property start (point) 'eww-form-select) (put-text-property start (point) 'keymap eww-select-map) + (unless (= start (point)) + (put-text-property start (1+ start) 'help-echo "select field")) (shr-ensure-paragraph)))) (defun eww-select-display (select) -- Kenjiro NAKAYAMA tzz@lifelogs.com writes: > On Sun, 15 Dec 2013 01:18:54 +0900 Kenjiro NAKAYAMA wrote: > >>> Such comments should describe what the change *does* rather than what it >>> *did*, i.e. use the present tense (and capitalize the word after the >>> colon since it starts a sentence). > > KN> Thank you Stefan. > > KN> I resend patch with a fixed comment. > > KN> Signed-off-by: Kenjiro NAKAYAMA > > KN> * net/eww.el (eww-tag-select): Add text-property to jump to > KN> next select field. > > It doesn't apply cleanly anymore, sorry. Can you rebase and resend? > > Thanks > Ted From unknown Sun Jun 22 07:55:20 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Nakayama Kenjiro Subject: bug#16141: closed (Re: bug#16141: 24.3.50; [PATCH] eww: added text-property to jump to next select field.) Message-ID: References: <87ob48bjay.fsf@flea.lifelogs.com> X-Gnu-PR-Message: they-closed 16141 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 16141@debbugs.gnu.org Date: Sun, 22 Dec 2013 22:40:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1387752003-14159-1" This is a multi-part message in MIME format... ------------=_1387752003-14159-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #16141: 24.3.50; [PATCH] eww: added text-property to jump to next select fi= eld. which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 16141@debbugs.gnu.org. --=20 16141: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D16141 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1387752003-14159-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 16141-done) by debbugs.gnu.org; 22 Dec 2013 22:39:50 +0000 Received: from localhost ([127.0.0.1]:34972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vurgb-0003fp-TM for submit@debbugs.gnu.org; Sun, 22 Dec 2013 17:39:50 -0500 Received: from mail-qe0-f50.google.com ([209.85.128.50]:35376) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VurgZ-0003fe-OT for 16141-done@debbugs.gnu.org; Sun, 22 Dec 2013 17:39:48 -0500 Received: by mail-qe0-f50.google.com with SMTP id 1so4484241qec.23 for <16141-done@debbugs.gnu.org>; Sun, 22 Dec 2013 14:39:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=VQnR4fV9jvsEgSr4IMJ1v5hc7Qx6fqxxqiry1Q/7UgE=; b=c92jxOWqIehpwpm2Uz5ZUj3OZj0xTg6Cf66MOkm/61NPdchavFshfAk1LbSFayOS+1 cGJoqiGm6G6ujY7vjfDn/Mps8QjN4xcxOYM3NdCT52iAk0mO7SjN37rAZaqaTSjjdtSb fPihVdeG4fM+U293UTg47s7GqW8MFWZanrlrs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=VQnR4fV9jvsEgSr4IMJ1v5hc7Qx6fqxxqiry1Q/7UgE=; b=O4e1WN5+JOFWexI2w9cNpUo5Ix3ghlPBiFGo7JDv5KDhSxmrq312223xBgc5e9HGno 8n09reCAQcO6kM5zq1XxTdz40YOS3k6vJrEPipCur0yyPAhyNE21UqI+NFeWPztTRTaK 2ocaaPcX659XWjxNbXTRcoBlbLk+UZxbldNCFiW9I86pk9wxXEM8M7+3nOxj4l6vRuVa gtVxMK1V/YsdjupDj0Ft50A/kDVvkFCzS3aCpLCDHYXgwcrxhVCywy6lu6K3aljWyOpm tCVJnDcJToc7vjwN4s1r36+iGlzhhtOylhTizCdgMVgAbKZuqgv6gU3VP0m8jjpvXZIm hFPw== X-Gm-Message-State: ALoCoQkH09huCnTdfpkTM9hyEynncEpwp9RM8hjlBBMAwOi6CU4HXqE8HYJ5k7b4ZIjgVNseAbW/ X-Received: by 10.224.147.75 with SMTP id k11mr36342802qav.22.1387751987215; Sun, 22 Dec 2013 14:39:47 -0800 (PST) Received: from flea.lifelogs.com (c-98-229-61-72.hsd1.ma.comcast.net. [98.229.61.72]) by mx.google.com with ESMTPSA id i7sm29616749qeo.7.2013.12.22.14.39.46 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 22 Dec 2013 14:39:46 -0800 (PST) From: Ted Zlatanov To: Kenjiro NAKAYAMA Subject: Re: bug#16141: 24.3.50; [PATCH] eww: added text-property to jump to next select field. Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <87y53ncsnl.fsf@dhcp-193-97.nrt.redhat.com> <87d2kqc4mb.fsf@flea.lifelogs.com> <87sitlir6i.fsf@dhcp-193-97.nrt.redhat.com> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Sun, 22 Dec 2013 17:41:09 -0500 In-Reply-To: <87sitlir6i.fsf@dhcp-193-97.nrt.redhat.com> (Kenjiro NAKAYAMA's message of "Sun, 22 Dec 2013 10:56:53 +0900") Message-ID: <87ob48bjay.fsf@flea.lifelogs.com> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 16141-done Cc: Lars Magne Ingebrigtsen , 16141-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Sun, 22 Dec 2013 10:56:53 +0900 Kenjiro NAKAYAMA wrote: >> It doesn't apply cleanly anymore, sorry. Can you rebase and resend? KN> Sorry, it's my mistake. This is proper patch. KN> Signed-off-by: Kenjiro NAKAYAMA KN> * net/eww.el (eww-tag-select): Add text-property to jump to KN> next select field. Applied, thank you. Ted ------------=_1387752003-14159-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Dec 2013 12:05:51 +0000 Received: from localhost ([127.0.0.1]:49342 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vrnyg-0000K9-Fc for submit@debbugs.gnu.org; Sat, 14 Dec 2013 07:05:51 -0500 Received: from eggs.gnu.org ([208.118.235.92]:59565) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vrnyc-0000Jz-Mq for submit@debbugs.gnu.org; Sat, 14 Dec 2013 07:05:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vrnyb-0001o9-I0 for submit@debbugs.gnu.org; Sat, 14 Dec 2013 07:05:46 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:53651) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vrnyb-0001o1-EM for submit@debbugs.gnu.org; Sat, 14 Dec 2013 07:05:45 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33008) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vrnya-0004qE-BA for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 07:05:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VrnyX-0001lv-PF for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 07:05:44 -0500 Received: from mail-wg0-x22a.google.com ([2a00:1450:400c:c00::22a]:65427) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VrnyX-0001lV-FC for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 07:05:41 -0500 Received: by mail-wg0-f42.google.com with SMTP id a1so331383wgh.5 for ; Sat, 14 Dec 2013 04:05:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:date:message-id:subject:from:to:content-type; bh=i0lh7E9rJFC6eKliUccGlwaApGJYEcne//xD9PGeBII=; b=IodChTLB5WsJOb0Y7UD4Wblro1w2YIiVXwCjN7igVkK1ThpOfZ/7j54qnr1qUi7Iia OmjVwE2PrYXSiu46VX2vfOdxhsUThmjIYZjQ4nofd8h58zeZAu/9lemw59aPa03D/n+F TetktkEIbfDZ+eycIKjY7rlJebKZrlUYHepN0N6u7KLYebvEQy9WGWJtMX8KT4A8aM77 WZPilEh5B3yBkD5WoiIcKjGGw9a3OTmR/BD2+dRSRg0/6kIAIVMnGsh3iVrQwOdXEzj2 g92VSRWizqE0bFqJSvfu6GZnTfd4aXAu2DpddWdw2GsFLfSULaLxLeOhNpvcVTvXaqVL biXQ== MIME-Version: 1.0 X-Received: by 10.194.120.164 with SMTP id ld4mr6104620wjb.47.1387022740691; Sat, 14 Dec 2013 04:05:40 -0800 (PST) Received: by 10.180.38.76 with HTTP; Sat, 14 Dec 2013 04:05:40 -0800 (PST) Date: Sat, 14 Dec 2013 21:05:40 +0900 Message-ID: Subject: 24.3.50; [PATCH] eww: added text-property to jump to next select field. From: Nakayama Kenjiro To: bug-gnu-emacs@gnu.org Content-Type: text/plain; charset=ISO-8859-1 X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) It is useful, if we can jump to next select fiedld with tab commadn. Signed-off-by: Kenjiro NAKAYAMA * net/eww.el (eww-tag-select): added text-property to jump to next select field. --- lisp/net/eww.el | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 1693e74..0264174 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -841,7 +841,8 @@ See URL `https://developer.mozilla.org/en-US/docs/Web/HTML/Element/Input'.") (put-text-property start (point) 'eww-form menu) (add-face-text-property start (point) 'eww-form-select) (put-text-property start (point) 'keymap eww-select-map) - (put-text-property start (1+ start) 'help-echo "select field") + (unless (= start (point)) + (put-text-property start (1+ start) 'help-echo "select field")) (shr-ensure-paragraph)))) (defun eww-select-display (select) -- 1.8.3.1 Kenjiro ------------=_1387752003-14159-1--