GNU bug report logs - #16138
24.3; skeleton-end-hook not run

Previous Next

Package: emacs;

Reported by: Leo Liu <sdl.web <at> gmail.com>

Date: Sat, 14 Dec 2013 07:22:02 UTC

Severity: minor

Found in version 24.3

Fixed in version 24.4

Done: Leo Liu <sdl.web <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Leo Liu <sdl.web <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#16138: closed (24.3; skeleton-end-hook not run)
Date: Fri, 20 Dec 2013 00:43:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Fri, 20 Dec 2013 08:41:56 +0800
with message-id <m1mwjwjquj.fsf <at> gmail.com>
and subject line Re: bug#16138: 24.3; skeleton-end-hook not run
has caused the debbugs.gnu.org bug report #16138,
regarding 24.3; skeleton-end-hook not run
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
16138: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16138
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Leo Liu <sdl.web <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3; skeleton-end-hook not run
Date: Sat, 14 Dec 2013 15:20:32 +0800
I had to make use of skeleton-end-hook and was surprised to find that it
actually doesn't work.

1. Emacs -q
2. (setq skeleton-pair t)
3. (global-set-key "(" 'skeleton-pair-insert-maybe)
4. (add-hook 'skeleton-end-hook (lambda () (error "bomb!!!")))

now try ( to trigger skeleton-pair-insert-maybe in some buffer and
nothing should happen.

Leo


[Message part 3 (message/rfc822, inline)]
From: Leo Liu <sdl.web <at> gmail.com>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: Glenn Morris <rgm <at> gnu.org>, 16138-done <at> debbugs.gnu.org
Subject: Re: bug#16138: 24.3; skeleton-end-hook not run
Date: Fri, 20 Dec 2013 08:41:56 +0800
Version: 24.4

On 2013-12-19 21:38 +0800, Stefan Monnier wrote:
> Because the default value inserts a newline, which is not desired for
> paren-pairs.

I fix it by let-binding skeleton-end-newline to nil instead. It is odd
that skeleton-end-hook is not called at all.

Leo


This bug report was last modified 11 years and 157 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.