GNU bug report logs - #16116
24.3.50; smie-indent-close aligns inner closing paren with the outer opening paren

Previous Next

Package: emacs;

Reported by: Dmitry Gutov <dgutov <at> yandex.ru>

Date: Thu, 12 Dec 2013 01:58:02 UTC

Severity: minor

Tags: patch

Found in version 24.3.50

Done: Dmitry Gutov <dgutov <at> yandex.ru>

Bug is archived. No further changes may be made.

Full log


Message #20 received at 16116 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: 16116 <at> debbugs.gnu.org, Steve Purcell <steve <at> sanityinc.com>
Subject: Re: bug#16116: 24.3.50;
 smie-indent-close aligns inner closing paren with the outer opening
 paren
Date: Sat, 14 Dec 2013 17:04:47 +0200
Stefan Monnier <monnier <at> IRO.UMontreal.CA> writes:

> No need to convince anyone here.  I was just pointing out that what is
> right will depend

Sorry, I didn't get that.

> so the right fix is to let the rules-function
> control it, rather than to replace one hard-coded choice with another.

That won't work. ruby-smie-rules is never called because
smie-indent-close doesn't use smie-indent--rule, and it goes before the
functions that do in smie-indent-functions. Unless you're suggesting to
change either of those points.

I thought rather to add a defvar to switch between the two behaviors in
smie-indent-close, or make smie-indent-functions buffer-local and
replace smie-indent-close there with a modified implementation.

Still inclined toward the latter.




This bug report was last modified 11 years and 155 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.