GNU bug report logs - #16111
(erc-current-logfile buf) behavior differs to with-current-buffer buf

Previous Next

Full log

Message #8 received at 16111 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Ivan Shmakov <ivan <at> siamics.net>
Cc: 16111 <at> debbugs.gnu.org
Subject: Re: bug#16111: (erc-current-logfile buf) behavior differs to
 with-current-buffer buf
Date: Sun, 27 Dec 2015 22:01:20 +0100

Ivan Shmakov <ivan <at> siamics.net> writes:

> Package:  emacs
> Severity: minor
>
> 	My guess is that the results of (erc-current-logfile buffer) and
> 	(with-current-buffer buffer (erc-current-logfile)) were intended
> 	to be the same.  However, as the function references the session
> 	buffer-local variables (erc-session-server, erc-session-port,
> 	and, indirectly, erc-server-current-nick and erc-server-process)
> 	/without/ switching to the buffer given, the results are
> 	somewhat undefined.
>
> (defun erc-current-logfile (&optional buffer)
>   "Return the logfile to use for BUFFER.
> If BUFFER is nil, the value of `current-buffer' is used.
> This is determined by `erc-generate-log-file-name-function'.
> The result is converted to lowercase, as IRC is case-insensitive"
>   (unless buffer (setq buffer (current-buffer)))
>   (let ((target (or (buffer-name buffer) (erc-default-target)))
> 	(nick (erc-current-nick))
> 	(server erc-session-server)
> 	(port erc-session-port))
>     …))
>
> 	(There, it may make sense to enclose the most part of the code
> 	within a with-current-buffer form.)

Do you have a patch for this?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.