From unknown Fri Jun 20 05:37:41 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#16111 <16111@debbugs.gnu.org> To: bug#16111 <16111@debbugs.gnu.org> Subject: Status: (erc-current-logfile buf) behavior differs to with-current-buffer buf Reply-To: bug#16111 <16111@debbugs.gnu.org> Date: Fri, 20 Jun 2025 12:37:41 +0000 retitle 16111 (erc-current-logfile buf) behavior differs to with-current-bu= ffer buf reassign 16111 emacs submitter 16111 Ivan Shmakov severity 16111 minor tag 16111 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 11 08:41:32 2013 Received: (at submit) by debbugs.gnu.org; 11 Dec 2013 13:41:32 +0000 Received: from localhost ([127.0.0.1]:43044 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vqk2e-0005nQ-EG for submit@debbugs.gnu.org; Wed, 11 Dec 2013 08:41:32 -0500 Received: from fely.am-1.org ([78.47.74.50]:55506) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vqk2b-0005nE-Ow for submit@debbugs.gnu.org; Wed, 11 Dec 2013 08:41:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=siamics.net; s=a2013295; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID:Date:Sender:Subject:To:From; bh=Wc8WU9DIcWQY8hcytK++f/nGtavZSer0U8mlir6m4JM=; b=mwt20CRofQFb7b2QtwVZnRp3pNHwWSDzJqvJ8aH8MkfoiQ8Uc0JRMPGq69LDf7KXZkf/ajcAFNwz1KQtMMbhmpa3+B8PfFae0PtOjJ/6puU1WDskszSX+AkrcSzZUB2ab9XoIfPn3jKdOUpIGwj+7+LYMQnzpkNWKo4LHusB1hs=; Received: from [2a02:2560:6d4:26ca::1:1d] (helo=violet.siamics.net) by fely.am-1.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1Vqk2Z-0000Fe-Io for submit@debbugs.gnu.org; Wed, 11 Dec 2013 13:41:28 +0000 Received: from localhost ([::1] helo=violet.siamics.net) by violet.siamics.net with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Vqk2R-0005bo-1T for submit@debbugs.gnu.org; Wed, 11 Dec 2013 20:41:19 +0700 From: Ivan Shmakov To: submit@debbugs.gnu.org Subject: (erc-current-logfile buf) behavior differs to with-current-buffer buf Date: Wed, 11 Dec 2013 13:41:18 +0000 Message-ID: <874n6f4i9t.fsf@violet.siamics.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) Package: emacs Severity: minor My guess is that the results of (erc-current-logfile buffer) and (with-current-buffer buffer (erc-current-logfile)) were intended to be the same. However, as the function references the session buffer-local variables (erc-session-server, erc-session-port, and, indirectly, erc-server-current-nick and erc-server-process) /without/ switching to the buffer given, the results are somewhat undefined. (defun erc-current-logfile (&optional buffer) "Return the logfile to use for BUFFER. If BUFFER is nil, the value of `current-buffer' is used. This is determined by `erc-generate-log-file-name-function'. The result is converted to lowercase, as IRC is case-insensitive" (unless buffer (setq buffer (current-buffer))) (let ((target (or (buffer-name buffer) (erc-default-target))) (nick (erc-current-nick)) (server erc-session-server) (port erc-session-port)) =E2=80=A6)) (There, it may make sense to enclose the most part of the code within a with-current-buffer form.) This may show no symptoms as long as erc-save-buffer-in-logs is called in either of the buffers belonging to the same session, but I=E2=80=99m in doubt that erc-log-save-all-buffers (which may run as part of kill-emacs-hook) will behave sensible in general. --=20 FSF associate member #7257 From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 27 16:01:44 2015 Received: (at 16111) by debbugs.gnu.org; 27 Dec 2015 21:01:45 +0000 Received: from localhost ([127.0.0.1]:44928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDIRk-0001rp-Ny for submit@debbugs.gnu.org; Sun, 27 Dec 2015 16:01:44 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:52449) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aDIRj-0001rh-B6 for 16111@debbugs.gnu.org; Sun, 27 Dec 2015 16:01:43 -0500 Received: from 2.150.58.24.tmi.telenormobil.no ([2.150.58.24] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aDIRN-0003mA-GX; Sun, 27 Dec 2015 22:01:21 +0100 From: Lars Ingebrigtsen To: Ivan Shmakov Subject: Re: bug#16111: (erc-current-logfile buf) behavior differs to with-current-buffer buf References: <874n6f4i9t.fsf@violet.siamics.net> Date: Sun, 27 Dec 2015 22:01:20 +0100 In-Reply-To: <874n6f4i9t.fsf@violet.siamics.net> (Ivan Shmakov's message of "Wed, 11 Dec 2013 13:41:18 +0000") Message-ID: <87si2na9nj.fsf@gnus.org> User-Agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable X-MailScanner-ID: 1aDIRN-0003mA-GX X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1451854882.19719@bjJC40f9MJj5owoq5twIOw X-Spam-Status: No X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 16111 Cc: 16111@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Ivan Shmakov writes: > Package: emacs > Severity: minor > > My guess is that the results of (erc-current-logfile buffer) and > (with-current-buffer buffer (erc-current-logfile)) were intended > to be the same. However, as the function references the session > buffer-local variables (erc-session-server, erc-session-port, > and, indirectly, erc-server-current-nick and erc-server-process) > /without/ switching to the buffer given, the results are > somewhat undefined. > > (defun erc-current-logfile (&optional buffer) > "Return the logfile to use for BUFFER. > If BUFFER is nil, the value of `current-buffer' is used. > This is determined by `erc-generate-log-file-name-function'. > The result is converted to lowercase, as IRC is case-insensitive" > (unless buffer (setq buffer (current-buffer))) > (let ((target (or (buffer-name buffer) (erc-default-target))) > (nick (erc-current-nick)) > (server erc-session-server) > (port erc-session-port)) > =85)) > > (There, it may make sense to enclose the most part of the code > within a with-current-buffer form.) Do you have a patch for this? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 14 15:19:24 2018 Received: (at 16111) by debbugs.gnu.org; 14 Apr 2018 19:19:24 +0000 Received: from localhost ([127.0.0.1]:52672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7Qho-0004Bn-H2 for submit@debbugs.gnu.org; Sat, 14 Apr 2018 15:19:24 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:56323) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7Qhm-0004BS-5w for 16111@debbugs.gnu.org; Sat, 14 Apr 2018 15:19:23 -0400 Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f7Qhi-0000Gn-GL; Sat, 14 Apr 2018 21:19:21 +0200 Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f7Qhc-0007LV-Ty; Sat, 14 Apr 2018 21:19:12 +0200 From: Lars Ingebrigtsen To: Ivan Shmakov Subject: Re: bug#16111: (erc-current-logfile buf) behavior differs to with-current-buffer buf References: <874n6f4i9t.fsf@violet.siamics.net> Date: Sat, 14 Apr 2018 21:19:12 +0200 In-Reply-To: <874n6f4i9t.fsf@violet.siamics.net> (Ivan Shmakov's message of "Wed, 11 Dec 2013 13:41:18 +0000") Message-ID: <87in8t38b3.fsf@mouse.gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 16111 Cc: 16111@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Ivan Shmakov writes: > (There, it may make sense to enclose the most part of the code > within a with-current-buffer form.) I've now done this in Emacs 27.1. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 14 15:19:24 2018 Received: (at control) by debbugs.gnu.org; 14 Apr 2018 19:19:24 +0000 Received: from localhost ([127.0.0.1]:52670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7Qho-0004Bl-BL for submit@debbugs.gnu.org; Sat, 14 Apr 2018 15:19:24 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:56325) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1f7Qhm-0004BT-IA for control@debbugs.gnu.org; Sat, 14 Apr 2018 15:19:23 -0400 Received: from 46.67.12.60.tmi.telenormobil.no ([46.67.12.60] helo=corrigan) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1f7Qhk-0000ML-BB for control@debbugs.gnu.org; Sat, 14 Apr 2018 21:19:22 +0200 Received: from larsi by corrigan with local (Exim 4.89) (envelope-from ) id 1f7Qhe-0007LY-JW for control@debbugs.gnu.org; Sat, 14 Apr 2018 21:19:14 +0200 To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #16111 Message-Id: Date: Sat, 14 Apr 2018 21:19:14 +0200 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 16111 fixed close 16111 From unknown Fri Jun 20 05:37:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 13 May 2018 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator