GNU bug report logs - #16099
MinGW build failure when srcdir is absolute and has "wrong" format

Previous Next

Full log

Message #121 received at 16099 <at> debbugs.gnu.org (full text, mbox):

From: Dani Moncayo <dmoncayo <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 16099 <at> debbugs.gnu.org
Subject: Re: bug#16099: 24.3.50; Build failure, undefined function `cl-member'
Date: Sat, 14 Dec 2013 22:56:13 +0100

>> was "../my nice repo", with the current trunk it would be translated
>> to something like "/c/foo/bar/my nice repo".  What breakage might it
>> cause?
>
> You're right, that doesn't work either way.
> But if making srcdir absolute introduces spaces that were not otherwise
> there (eg srcdir was "." but is now "/path/to whatever"), that breaks
> something that otherwise works.

Ah ok, I didn't think about that possibility.  I will commit the patch then.

>> +   if test ${srcdir:0:1} = "/" -o ${srcdir:1:1} = ":"
>
> Is substring syntax portable? Normally I'd use something like:
>
> case $srcdir in
>   /* | .:*) ... ;;
> esac
>
> But maybe MinGW /bin/sh is always /bin/bash, in which case it's
> irrelevant.

MSYS has (a special port of) GNU bash, and it seems to be the only
available shell.  So I think we can assume that shell on any MSYS
environment.

-- 
Dani Moncayo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.