GNU bug report logs - #16099
MinGW build failure when srcdir is absolute and has "wrong" format

Previous Next

Full log

Message #115 received at 16099 <at> debbugs.gnu.org (full text, mbox):

From: Dani Moncayo <dmoncayo <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 16099 <at> debbugs.gnu.org
Subject: Re: bug#16099: 24.3.50; Build failure, undefined function `cl-member'
Date: Sat, 14 Dec 2013 22:32:36 +0100

On Sat, Dec 14, 2013 at 9:08 PM, Glenn Morris <rgm <at> gnu.org> wrote:
>
> The only comment I'd make is: can you restrict doing this to when srcdir
> is absolute to start with? Which must mean the user has specified an
> absolute path to configure's srcdir, which I would imagine to be rare.
> On Unix systems, this would be trivial - just check if srcdir starts
> with "/". I don't know what you need to do for MS.

I think that the patch below would do it.

> Forcing srcdir to be absolute all the time will eg break using a srcdir
> with spaces in.

I don't understand this.  For example if the original value of srcdir
was "../my nice repo", with the current trunk it would be translated
to something like "/c/foo/bar/my nice repo".  What breakage might it
cause?


diff --git a/configure.ac b/configure.ac
index 2e9eee6..0c4b98b 100644
--- a/configure.ac
+++ b/configure.ac
@@ -28,11 +28,14 @@ if test "x$MSYSTEM" = "xMINGW32"
 then
    . $srcdir/nt/mingw-cfg.site

-   # Convert srcdir to an absolute MSYS path of the form "/c/foo/bar"
-   # to simplify later conversions of paths to windows-native format
-   # "c:/foo/bar"
-   srcdir=`cd "${srcdir}" && pwd -W`
-   srcdir="/${srcdir:0:1}${srcdir:2}"
+   if test ${srcdir:0:1} = "/" -o ${srcdir:1:1} = ":"
+   then
+       # srcdir is an absolute path.  In this case, force the format
+       # "/c/foo/bar", to simplify later conversions to native Windows
+       # format ("c:/foo/bar")
+       srcdir=`cd "${srcdir}" && pwd -W`
+       srcdir="/${srcdir:0:1}${srcdir:2}"
+   fi
 fi

 dnl Set emacs_config_options to the options of 'configure', quoted
for the shell,

-- 
Dani Moncayo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.