GNU bug report logs - #16090
24.3.50; [PATCH] error when jumping to a doc-view bookmark

Previous Next

Full log

View this message in rfc822 format

From: Tassilo Horn <tsdh <at> gnu.org>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: 16090 <at> debbugs.gnu.org, Andreas Politz <politza <at> hochschule-trier.de>
Subject: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark
Date: Fri, 04 Apr 2014 15:43:43 +0200

Stefan Monnier <monnier <at> IRO.UMontreal.CA> writes:

> For emacs-24, your patch is too intrusive, so I think a patch along
> the lines of Andreas's might be acceptable, but it should use
> bookmark-after-jump-hook instead of using a timer.

Like so?

(defun doc-view-bookmark-jump (bmk)
  ;; This implements the `handler' function interface for record type
  ;; returned by `doc-view-bookmark-make-record', which see.
  (let ((page (bookmark-prop-get bmk 'page)))
    (add-hook 'bookmark-after-jump-hook
	      (lambda ()
		(setq bookmark-after-jump-hook
		      (cdr bookmark-after-jump-hook))
		(when (not (eq major-mode 'doc-view-mode))
		  (doc-view-toggle-display))
		(with-selected-window
		    (or (get-buffer-window (current-buffer) 0)
			(selected-window))
		  (doc-view-goto-page page))))
    (bookmark-default-handler bmk)))

Bye,
Tassilo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.