From debbugs-submit-bounces@debbugs.gnu.org Sun Dec 08 11:55:04 2013 Received: (at submit) by debbugs.gnu.org; 8 Dec 2013 16:55:04 +0000 Received: from localhost ([127.0.0.1]:38400 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VphdF-0001jG-P8 for submit@debbugs.gnu.org; Sun, 08 Dec 2013 11:55:04 -0500 Received: from eggs.gnu.org ([208.118.235.92]:52320) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VphdB-0001ix-VD for submit@debbugs.gnu.org; Sun, 08 Dec 2013 11:55:00 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vphd5-0000A4-QL for submit@debbugs.gnu.org; Sun, 08 Dec 2013 11:54:57 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:51525) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vphd5-0000A0-MH for submit@debbugs.gnu.org; Sun, 08 Dec 2013 11:54:51 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54014) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vphd0-0001dn-7m for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2013 11:54:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vphcu-000084-3d for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2013 11:54:46 -0500 Received: from gateway-a.fh-trier.de ([143.93.54.181]:48269) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vphct-00007M-Gg for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2013 11:54:40 -0500 X-Virus-Scanned: by Amavisd-new + McAfee uvscan + ClamAV [Rechenzentrum Hochschule Trier] Received: from luca (dslb-188-097-165-182.pools.arcor-ip.net [188.97.165.182]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: politza) by gateway-a.fh-trier.de (Postfix) with ESMTPSA id 753991788AC1 for ; Sun, 8 Dec 2013 17:54:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha1; c=simple/simple; d=hochschule-trier.de; s=default; t=1386521663; bh=DXfid2bMsaOyQBo3oaQolrCYPMk=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type; b=gGdFKZ3ASVB/nmfT82C5f8ipnGkSlTUDc1Ye9szj45V6knlZg4oEBJh2TNjWmuq7a oeM2gEAF8fnh6SN0E2d2RXd4DpWXQZoaKNpiyayQ7qW8b8aGX9o8Ib9y7FBqeEDlfa 7pXKb1RtITPIZieMMpXHV9Kgh8cyGDeHg6vD2OKs= Received: from politza by luca with local (Exim 4.72) (envelope-from ) id 1Vphcb-0008My-Nm for bug-gnu-emacs@gnu.org; Sun, 08 Dec 2013 17:54:21 +0100 From: Andreas Politz To: bug-gnu-emacs@gnu.org Subject: 24.3.50; [PATCH] error when jumping to a doc-view bookmark Date: Sun, 08 Dec 2013 17:54:21 +0100 Message-ID: <87a9gbb7wi.fsf@hochschule-trier.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain $ emacs -Q some.pdf C-x r m RET C-x k RET C-x r b some.pdf RET Debugger entered--Lisp error: (wrong-type-argument listp t) image-mode-winprops(nil) The reason is that the buffer is not yet displayed, when doc-view-bookmark-jump tries to change the page. This results in, for obscure reasons, trying to change the page in which ever window is currently selected. Solution: Defer changing the page after bookmark--jump-via has displayed the page. -ap --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=doc-view.patch Content-Description: Patch === modified file 'lisp/ChangeLog' *** lisp/ChangeLog 2013-12-08 09:18:55 +0000 --- lisp/ChangeLog 2013-12-08 16:11:24 +0000 *************** *** 1,3 **** --- 1,8 ---- + 2013-12-08 Andreas Politz + + * doc-view.el (doc-view-bookmark-jump): Wait for the window to be + displayed before changing the page. + 2013-12-08 Leo Liu * progmodes/flymake.el (flymake-highlight-line): Re-write. === modified file 'lisp/doc-view.el' *** lisp/doc-view.el 2013-11-28 22:43:09 +0000 --- lisp/doc-view.el 2013-12-08 16:11:34 +0000 *************** *** 1870,1879 **** (let ((page (bookmark-prop-get bmk 'page))) (when (not (eq major-mode 'doc-view-mode)) (doc-view-toggle-display)) ! (with-selected-window ! (or (get-buffer-window (current-buffer) 0) ! (selected-window)) ! (doc-view-goto-page page))))) (provide 'doc-view) --- 1870,1882 ---- (let ((page (bookmark-prop-get bmk 'page))) (when (not (eq major-mode 'doc-view-mode)) (doc-view-toggle-display)) ! (run-with-idle-timer 0 nil ! (lambda (buffer page) ! (when (and (buffer-live-p buffer) ! (window-live-p (get-buffer-window buffer 0))) ! (with-selected-window (get-buffer-window buffer 0) ! (doc-view-goto-page page)))) ! (current-buffer) page)))) (provide 'doc-view) --=-=-= Content-Type: application/octet-stream Content-Disposition: attachment; filename=bt Content-Transfer-Encoding: base64 Content-Description: Backtrace RGVidWdnZXIgZW50ZXJlZC0tTGlzcCBlcnJvcjogKHdyb25nLXR5cGUtYXJndW1lbnQgbGlzdHAg dCkKICBpbWFnZS1tb2RlLXdpbnByb3BzKG5pbCkKICBpbWFnZS1tb2RlLXdpbmRvdy1wdXQocGFn ZSAwIG5pbCkKICAocHJvZ24gKGltYWdlLW1vZGUtd2luZG93LXB1dCAocXVvdGUgcGFnZSkgcGFn ZSBuaWwpIChpbWFnZS1tb2RlLXdpbmRvdy1wdXQgKHF1b3RlIGluZm8pIChjb25jYXQgKHByb3Bl cnRpemUgKGZvcm1hdCAiUGFnZSAlZCBvZiAlZC4iIHBhZ2UgbGVuKSAocXVvdGUgZmFjZSkgKHF1 b3RlIGJvbGQpKSAoaWYgZG9jLXZpZXctLWN1cnJlbnQtY29udmVydGVyLXByb2Nlc3NlcyAiIChz dGlsbCBjb252ZXJ0aW5nLi4uKVxuIiAiXG4iKSAoaWYgKGFuZCBkb2Mtdmlldy0tY3VycmVudC1z ZWFyY2gtbWF0Y2hlcyAoYXNzcSBwYWdlIGRvYy12aWV3LS1jdXJyZW50LXNlYXJjaC1tYXRjaGVz KSkgKHByb2duIChjb25jYXQgKHByb3BlcnRpemUgIlNlYXJjaCBtYXRjaGVzOlxuIiAocXVvdGUg ZmFjZSkgKHF1b3RlIGJvbGQpKSAobGV0ICguLi4pIChsZXQgLi4uIC4uLikgY29udGV4dHMpKSkp KSBuaWwpKQogIChsZXQgKChsZW4gKGRvYy12aWV3LWxhc3QtcGFnZS1udW1iZXIpKSkgKGlmICg8 IHBhZ2UgMSkgKHNldHEgcGFnZSAxKSAoaWYgKGFuZCAoPiBwYWdlIGxlbikgKG51bGwgZG9jLXZp ZXctLWN1cnJlbnQtY29udmVydGVyLXByb2Nlc3NlcykpIChwcm9nbiAoc2V0cSBwYWdlIGxlbikp KSkgKGZvcmNlLW1vZGUtbGluZS11cGRhdGUpIChwcm9nbiAoaW1hZ2UtbW9kZS13aW5kb3ctcHV0 IChxdW90ZSBwYWdlKSBwYWdlIG5pbCkgKGltYWdlLW1vZGUtd2luZG93LXB1dCAocXVvdGUgaW5m bykgKGNvbmNhdCAocHJvcGVydGl6ZSAoZm9ybWF0ICJQYWdlICVkIG9mICVkLiIgcGFnZSBsZW4p IChxdW90ZSBmYWNlKSAocXVvdGUgYm9sZCkpIChpZiBkb2Mtdmlldy0tY3VycmVudC1jb252ZXJ0 ZXItcHJvY2Vzc2VzICIgKHN0aWxsIGNvbnZlcnRpbmcuLi4pXG4iICJcbiIpIChpZiAoYW5kIGRv Yy12aWV3LS1jdXJyZW50LXNlYXJjaC1tYXRjaGVzIChhc3NxIHBhZ2UgZG9jLXZpZXctLWN1cnJl bnQtc2VhcmNoLW1hdGNoZXMpKSAocHJvZ24gKGNvbmNhdCAocHJvcGVydGl6ZSAiU2VhcmNoIG1h dGNoZXM6XG4iIC4uLiAuLi4pIChsZXQgLi4uIC4uLiBjb250ZXh0cykpKSkpIG5pbCkpIChsZXQg KChmaWxlIChleHBhbmQtZmlsZS1uYW1lIChmb3JtYXQgZG9jLXZpZXctLWltYWdlLWZpbGUtcGF0 dGVybiBwYWdlKSAoZG9jLXZpZXctLWN1cnJlbnQtY2FjaGUtZGlyKSkpKSAoZG9jLXZpZXctaW5z ZXJ0LWltYWdlIGZpbGUgOnBvaW50ZXIgKHF1b3RlIGFycm93KSkgKGlmIChhbmQgKG5vdCAoZmls ZS1leGlzdHMtcCBmaWxlKSkgZG9jLXZpZXctLWN1cnJlbnQtY29udmVydGVyLXByb2Nlc3Nlcykg KHByb2duIChmdW5jYWxsIGRvYy12aWV3LXNpbmdsZS1wYWdlLWNvbnZlcnRlci1mdW5jdGlvbiBk b2Mtdmlldy0tYnVmZmVyLWZpbGUtbmFtZSBmaWxlIHBhZ2UgKGxldCAoKHdpbiAuLi4pKSAoZnVu Y3Rpb24gKGxhbWJkYSBuaWwgLi4uKSkpKSkpKSAob3ZlcmxheS1wdXQgKGltYWdlLW1vZGUtd2lu ZG93LWdldCAocXVvdGUgb3ZlcmxheSkpIChxdW90ZSBoZWxwLWVjaG8pIChpbWFnZS1tb2RlLXdp bmRvdy1nZXQgKHF1b3RlIGluZm8pKSkpCiAgZG9jLXZpZXctZ290by1wYWdlKDEpCiAgKHByb2du IChzZWxlY3Qtd2luZG93IChjYXIgc2F2ZS1zZWxlY3RlZC13aW5kb3ctLXN0YXRlKSAocXVvdGUg bm9yZWNvcmQpKSAoZG9jLXZpZXctZ290by1wYWdlIHBhZ2UpKQogICh1bndpbmQtcHJvdGVjdCAo cHJvZ24gKHNlbGVjdC13aW5kb3cgKGNhciBzYXZlLXNlbGVjdGVkLXdpbmRvdy0tc3RhdGUpIChx dW90ZSBub3JlY29yZCkpIChkb2Mtdmlldy1nb3RvLXBhZ2UgcGFnZSkpIChpbnRlcm5hbC0tYWZ0 ZXItd2l0aC1zZWxlY3RlZC13aW5kb3cgc2F2ZS1zZWxlY3RlZC13aW5kb3ctLXN0YXRlKSkKICAo c2F2ZS1jdXJyZW50LWJ1ZmZlciAodW53aW5kLXByb3RlY3QgKHByb2duIChzZWxlY3Qtd2luZG93 IChjYXIgc2F2ZS1zZWxlY3RlZC13aW5kb3ctLXN0YXRlKSAocXVvdGUgbm9yZWNvcmQpKSAoZG9j LXZpZXctZ290by1wYWdlIHBhZ2UpKSAoaW50ZXJuYWwtLWFmdGVyLXdpdGgtc2VsZWN0ZWQtd2lu ZG93IHNhdmUtc2VsZWN0ZWQtd2luZG93LS1zdGF0ZSkpKQogIChsZXQgKChzYXZlLXNlbGVjdGVk LXdpbmRvdy0tc3RhdGUgKGludGVybmFsLS1iZWZvcmUtd2l0aC1zZWxlY3RlZC13aW5kb3cgKG9y IChnZXQtYnVmZmVyLXdpbmRvdyAoY3VycmVudC1idWZmZXIpIDApIChzZWxlY3RlZC13aW5kb3cp KSkpKSAoc2F2ZS1jdXJyZW50LWJ1ZmZlciAodW53aW5kLXByb3RlY3QgKHByb2duIChzZWxlY3Qt d2luZG93IChjYXIgc2F2ZS1zZWxlY3RlZC13aW5kb3ctLXN0YXRlKSAocXVvdGUgbm9yZWNvcmQp KSAoZG9jLXZpZXctZ290by1wYWdlIHBhZ2UpKSAoaW50ZXJuYWwtLWFmdGVyLXdpdGgtc2VsZWN0 ZWQtd2luZG93IHNhdmUtc2VsZWN0ZWQtd2luZG93LS1zdGF0ZSkpKSkKICAobGV0ICgocGFnZSAo Ym9va21hcmstcHJvcC1nZXQgYm1rIChxdW90ZSBwYWdlKSkpKSAoaWYgKG5vdCAoZXEgbWFqb3It bW9kZSAocXVvdGUgZG9jLXZpZXctbW9kZSkpKSAocHJvZ24gKGRvYy12aWV3LXRvZ2dsZS1kaXNw bGF5KSkpIChsZXQgKChzYXZlLXNlbGVjdGVkLXdpbmRvdy0tc3RhdGUgKGludGVybmFsLS1iZWZv cmUtd2l0aC1zZWxlY3RlZC13aW5kb3cgKG9yIChnZXQtYnVmZmVyLXdpbmRvdyAoY3VycmVudC1i dWZmZXIpIDApIChzZWxlY3RlZC13aW5kb3cpKSkpKSAoc2F2ZS1jdXJyZW50LWJ1ZmZlciAodW53 aW5kLXByb3RlY3QgKHByb2duIChzZWxlY3Qtd2luZG93IChjYXIgc2F2ZS1zZWxlY3RlZC13aW5k b3ctLXN0YXRlKSAocXVvdGUgbm9yZWNvcmQpKSAoZG9jLXZpZXctZ290by1wYWdlIHBhZ2UpKSAo aW50ZXJuYWwtLWFmdGVyLXdpdGgtc2VsZWN0ZWQtd2luZG93IHNhdmUtc2VsZWN0ZWQtd2luZG93 LS1zdGF0ZSkpKSkpCiAgKHByb2cxIChib29rbWFyay1kZWZhdWx0LWhhbmRsZXIgYm1rKSAobGV0 ICgocGFnZSAoYm9va21hcmstcHJvcC1nZXQgYm1rIChxdW90ZSBwYWdlKSkpKSAoaWYgKG5vdCAo ZXEgbWFqb3ItbW9kZSAocXVvdGUgZG9jLXZpZXctbW9kZSkpKSAocHJvZ24gKGRvYy12aWV3LXRv Z2dsZS1kaXNwbGF5KSkpIChsZXQgKChzYXZlLXNlbGVjdGVkLXdpbmRvdy0tc3RhdGUgKGludGVy bmFsLS1iZWZvcmUtd2l0aC1zZWxlY3RlZC13aW5kb3cgKG9yIChnZXQtYnVmZmVyLXdpbmRvdyAu Li4gMCkgKHNlbGVjdGVkLXdpbmRvdykpKSkpIChzYXZlLWN1cnJlbnQtYnVmZmVyICh1bndpbmQt cHJvdGVjdCAocHJvZ24gKHNlbGVjdC13aW5kb3cgKGNhciBzYXZlLXNlbGVjdGVkLXdpbmRvdy0t c3RhdGUpIChxdW90ZSBub3JlY29yZCkpIChkb2Mtdmlldy1nb3RvLXBhZ2UgcGFnZSkpIChpbnRl cm5hbC0tYWZ0ZXItd2l0aC1zZWxlY3RlZC13aW5kb3cgc2F2ZS1zZWxlY3RlZC13aW5kb3ctLXN0 YXRlKSkpKSkpCiAgZG9jLXZpZXctYm9va21hcmstanVtcCgoInNvbWUucGRmIiAoZmlsZW5hbWUg LiAiL3RtcC9zb21lLnBkZiIpIChmcm9udC1jb250ZXh0LXN0cmluZyAuICIlUERGLTEuM1xuJVwz MDdcMzU0XDIxN1wyNDJcbjUiKSAocmVhci1jb250ZXh0LXN0cmluZykgKHBvc2l0aW9uIC4gMSkg KHBhZ2UgLiAxKSAoaGFuZGxlciAuIGRvYy12aWV3LWJvb2ttYXJrLWp1bXApKSkKICBmdW5jYWxs KGRvYy12aWV3LWJvb2ttYXJrLWp1bXAgKCJzb21lLnBkZiIgKGZpbGVuYW1lIC4gIi90bXAvc29t ZS5wZGYiKSAoZnJvbnQtY29udGV4dC1zdHJpbmcgLiAiJVBERi0xLjNcbiVcMzA3XDM1NFwyMTdc MjQyXG41IikgKHJlYXItY29udGV4dC1zdHJpbmcpIChwb3NpdGlvbiAuIDEpIChwYWdlIC4gMSkg KGhhbmRsZXIgLiBkb2Mtdmlldy1ib29rbWFyay1qdW1wKSkpCiAgKGNvbmRpdGlvbi1jYXNlIGVy ciAoZnVuY2FsbCAob3IgKGJvb2ttYXJrLWdldC1oYW5kbGVyIGJvb2ttYXJrLW5hbWUtb3ItcmVj b3JkKSAocXVvdGUgYm9va21hcmstZGVmYXVsdC1oYW5kbGVyKSkgKGJvb2ttYXJrLWdldC1ib29r bWFyayBib29rbWFyay1uYW1lLW9yLXJlY29yZCkpIChib29rbWFyay1lcnJvci1uby1maWxlbmFt ZSAoaWYgKHN0cmluZ3AgYm9va21hcmstbmFtZS1vci1yZWNvcmQpIChwcm9nbiAobGV0ICgoZmls ZSAoYm9va21hcmstZ2V0LWZpbGVuYW1lIGJvb2ttYXJrLW5hbWUtb3ItcmVjb3JkKSkpIChpZiBm aWxlIChwcm9nbiAobGV0IC4uLiAuLi4gLi4uKSkpKSkpKSkKICBib29rbWFyay1oYW5kbGUtYm9v a21hcmsoInNvbWUucGRmIikKICBib29rbWFyay0tanVtcC12aWEoInNvbWUucGRmIiBzd2l0Y2gt dG8tYnVmZmVyKQogIGJvb2ttYXJrLWp1bXAoInNvbWUucGRmIikKICBjYWxsLWludGVyYWN0aXZl bHkoYm9va21hcmstanVtcCBuaWwgbmlsKQogIGNvbW1hbmQtZXhlY3V0ZShib29rbWFyay1qdW1w KQo= --=-=-= Content-Type: text/plain In GNU Emacs 24.3.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.20.1) of 2013-11-23 on luca Bzr revision: 114436 politza@fh-trier.de-20131123014125-vrsnab4s0vsaw7w6 Windowing system distributor `The X.Org Foundation', version 11.0.10707000 System Description: Debian GNU/Linux 6.0.8 (squeeze) Configured using: `configure -C' Important settings: value of $LC_COLLATE: C value of $LC_MESSAGES: C value of $LANG: de_DE.UTF-8 locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Dired -lAS Minor modes in effect: semantic-minor-modes-format: ((:eval (if (or semantic-highlight-edits-mode semantic-show-unmatched-syntax-mode) S))) ewm-mode-line-mode: t ewm-mode: t ewm-compat-mode: t ewm-compat-calendar-mode: t ewm-compat-calc-mode: t diff-auto-refine-mode: t TeX-source-correlate-mode: t global-semanticdb-minor-mode: t global-semantic-decoration-mode: t global-semantic-idle-scheduler-mode: t semantic-mode: t desktop-save-mode: t mimo-mode: t pc-completion-mode: t ispell-track-input-method: t doc-view-tidy-cache-mode: t recentf-mode: t show-paren-mode: t window-numbering-mode: t shell-dirtrack-mode: t scroll-other-window-mode: t savehist-mode: t eldoc-in-minibuffer-mode: t ekey-mode: t winner-mode: t tooltip-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t column-number-mode: t line-number-mode: t transient-mark-mode: t Recent input: M-b p a M-n M-p C-c C-a C-p C-e M-p C-c C-a C-l C-u C-c C-a C-p C-p C-p C-x o C-p C-p C-M-f C-M-b C-M-SPC M-w C-x o C-x C-q M-f M-f M-b M-f M-f C-; b n C-c C-a C-p C-e l i s p / C h C-x o C-l C-SPC C-n C-n C-n C-n C-n C-w M-< C-y C-s d o c - v i C-l C-s C-s C-s C-l C-s C-s C-s C-g C-s d o c - v i e w - b o C-s C-l M-< C-l C-/ C-x k C-s C-g M-< C-x C-s C-x C-f d o c C-x o M-n C-c C-a C-x o C-l C-x C-s C-u C-x v D C-x o C-u C-g C-x v C-g C-x C-v C-g C-x v D M-n M-p C-c C-c C-n C-n C-n C-n C-n C-n C-n C-n C-p C-p C-p C-p C-p C-p C-p C-p C-M-s C-q C-s C-s C-g C-x o C-M-a C-, L b o o k m C-x v l C-s b o o k C-s C-s C-s C-s C-s C-s C-s C-l C-s C-s C-s C-s C-s C-s C-s C-l C-l C-s C-s C-x o C-x b C-x b d i f C-x C-w / t m p / d o y y C-x b d o C-s C-k C-g g C-x b d o c C-r C-g C-x C-j C-0 w C-x b C-x b e x C-x C-j C-u s S M-> C-p C-p C-p C / t m p / f o o . p d f M-x r e p o r b u g Recent messages: Saving file /tmp/doc-view.patch... Wrote /tmp/doc-view.patch Quit Mark set Quit Directory has changed on disk; type g to update Dired /tmp/doc-view.patch Mark set Copy: 1 of 1 Copy: 1 file Load-path shadows: /home/politza/.emacs.d/elpa/yasnippet-20130907.1855/yasnippet hides /home/politza/.emacs.d/plugins/yasnippet-0.6.1c/yasnippet /home/politza/.emacs.d/plugins/tblc hides /home/politza/.emacs.d/plugins/tblc/tblc /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-sys hides /home/politza/.emacs.d/plugins/helm/helm-sys /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-locate hides /home/politza/.emacs.d/plugins/helm/helm-locate /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-org hides /home/politza/.emacs.d/plugins/helm/helm-org /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-ring hides /home/politza/.emacs.d/plugins/helm/helm-ring /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-imenu hides /home/politza/.emacs.d/plugins/helm/helm-imenu /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-config hides /home/politza/.emacs.d/plugins/helm/helm-config /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-bmkext hides /home/politza/.emacs.d/plugins/helm/helm-bmkext /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-w3m hides /home/politza/.emacs.d/plugins/helm/helm-w3m /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-elscreen hides /home/politza/.emacs.d/plugins/helm/helm-elscreen /home/politza/.emacs.d/elpa/helm-20130926.2236/helm hides /home/politza/.emacs.d/plugins/helm/helm /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-font hides /home/politza/.emacs.d/plugins/helm/helm-font /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-grep hides /home/politza/.emacs.d/plugins/helm/helm-grep /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-semantic hides /home/politza/.emacs.d/plugins/helm/helm-semantic /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-pkg hides /home/politza/.emacs.d/plugins/helm/helm-pkg /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-elisp hides /home/politza/.emacs.d/plugins/helm/helm-elisp /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-misc hides /home/politza/.emacs.d/plugins/helm/helm-misc /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-external hides /home/politza/.emacs.d/plugins/helm/helm-external /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-match-plugin hides /home/politza/.emacs.d/plugins/helm/helm-match-plugin /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-adaptative hides /home/politza/.emacs.d/plugins/helm/helm-adaptative /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-tags hides /home/politza/.emacs.d/plugins/helm/helm-tags /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-bbdb hides /home/politza/.emacs.d/plugins/helm/helm-bbdb /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-eval hides /home/politza/.emacs.d/plugins/helm/helm-eval /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-emms hides /home/politza/.emacs.d/plugins/helm/helm-emms /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-net hides /home/politza/.emacs.d/plugins/helm/helm-net /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-gentoo hides /home/politza/.emacs.d/plugins/helm/helm-gentoo /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-firefox hides /home/politza/.emacs.d/plugins/helm/helm-firefox /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-dabbrev hides /home/politza/.emacs.d/plugins/helm/helm-dabbrev /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-eshell hides /home/politza/.emacs.d/plugins/helm/helm-eshell /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-help hides /home/politza/.emacs.d/plugins/helm/helm-help /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-buffers hides /home/politza/.emacs.d/plugins/helm/helm-buffers /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-color hides /home/politza/.emacs.d/plugins/helm/helm-color /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-aliases hides /home/politza/.emacs.d/plugins/helm/helm-aliases /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-regexp hides /home/politza/.emacs.d/plugins/helm/helm-regexp /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-bookmark hides /home/politza/.emacs.d/plugins/helm/helm-bookmark /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-apt hides /home/politza/.emacs.d/plugins/helm/helm-apt /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-yaoddmuse hides /home/politza/.emacs.d/plugins/helm/helm-yaoddmuse /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-info hides /home/politza/.emacs.d/plugins/helm/helm-info /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-man hides /home/politza/.emacs.d/plugins/helm/helm-man /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-call-tree hides /home/politza/.emacs.d/plugins/helm/helm-call-tree /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-mode hides /home/politza/.emacs.d/plugins/helm/helm-mode /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-utils hides /home/politza/.emacs.d/plugins/helm/helm-utils /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-files hides /home/politza/.emacs.d/plugins/helm/helm-files /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-command hides /home/politza/.emacs.d/plugins/helm/helm-command /home/politza/.emacs.d/elpa/helm-20130926.2236/helm-plugin hides /home/politza/.emacs.d/plugins/helm/helm-plugin /home/politza/.emacs.d/plugins/haskell-mode/haskell-cabal hides /home/politza/.emacs.d/plugins/haskell/haskell-cabal /home/politza/.emacs.d/plugins/haskell-mode/haskell-decl-scan hides /home/politza/.emacs.d/plugins/haskell/haskell-decl-scan /home/politza/.emacs.d/plugins/haskell-mode/haskell-doc hides /home/politza/.emacs.d/plugins/haskell/haskell-doc /home/politza/.emacs.d/plugins/haskell-mode/ghc-core hides /home/politza/.emacs.d/plugins/haskell/ghc-core /home/politza/.emacs.d/plugins/haskell-mode/haskell-mode hides /home/politza/.emacs.d/plugins/haskell/haskell-mode /home/politza/.emacs.d/plugins/haskell-mode/haskell-c hides /home/politza/.emacs.d/plugins/haskell/haskell-c /home/politza/.emacs.d/plugins/haskell-mode/haskell-indentation hides /home/politza/.emacs.d/plugins/haskell/haskell-indentation /home/politza/.emacs.d/plugins/haskell-mode/haskell-site-file hides /home/politza/.emacs.d/plugins/haskell/haskell-site-file /home/politza/.emacs.d/plugins/haskell-mode/haskell-ghci hides /home/politza/.emacs.d/plugins/haskell/haskell-ghci /home/politza/.emacs.d/plugins/haskell-mode/inf-haskell hides /home/politza/.emacs.d/plugins/haskell/inf-haskell /home/politza/.emacs.d/plugins/haskell-mode/haskell-indent hides /home/politza/.emacs.d/plugins/haskell/haskell-indent /home/politza/.emacs.d/plugins/haskell-mode/haskell-hugs hides /home/politza/.emacs.d/plugins/haskell/haskell-hugs /home/politza/.emacs.d/plugins/haskell-mode/haskell-font-lock hides /home/politza/.emacs.d/plugins/haskell/haskell-font-lock /home/politza/.emacs.d/plugins/haskell-mode/haskell-simple-indent hides /home/politza/.emacs.d/plugins/haskell/haskell-simple-indent /home/politza/.emacs.d/plugins/jedi/scratch hides /home/politza/.emacs.d/plugins/ewm/scratch /home/politza/.emacs.d/elpa/company-20130923.513/.dir-locals hides /home/politza/.emacs.d/plugins/el-get/.dir-locals /home/politza/.emacs.d/elpa/pc-1.0/pc hides /home/politza/src/emacs/override-redirect/lisp/pc /home/politza/.emacs.d/elpa/popup-20130708.2245/popup hides /home/politza/src/emacs/override-redirect/lisp/popup /home/politza/.emacs.d/plugins/jedi/scratch hides /home/politza/src/emacs/override-redirect/lisp/scratch /home/politza/.emacs.d/plugins/saveplace hides /home/politza/src/emacs/override-redirect/lisp/saveplace /home/politza/.emacs.d/plugins/imenu hides /home/politza/src/emacs/override-redirect/lisp/imenu /home/politza/.emacs.d/plugins/term hides /home/politza/src/emacs/override-redirect/lisp/term /home/politza/.emacs.d/elpa/company-20130923.513/.dir-locals hides /home/politza/src/emacs/override-redirect/lisp/gnus/.dir-locals /home/politza/.emacs.d/plugins/matlab/matlab hides /usr/share/emacs-snapshot/site-lisp/emacs-goodies-el/matlab /home/politza/.emacs.d/plugins/boxquote hides /usr/share/emacs-snapshot/site-lisp/emacs-goodies-el/boxquote /home/politza/.emacs.d/plugins/bm hides /usr/share/emacs-snapshot/site-lisp/emacs-goodies-el/bm /home/politza/.emacs.d/plugins/haskell-mode/haskell-decl-scan hides /usr/share/emacs-snapshot/site-lisp/haskell-mode/haskell-decl-scan /home/politza/.emacs.d/plugins/haskell-mode/haskell-c hides /usr/share/emacs-snapshot/site-lisp/haskell-mode/haskell-c /home/politza/.emacs.d/plugins/haskell-mode/haskell-ghci hides /usr/share/emacs-snapshot/site-lisp/haskell-mode/haskell-ghci /home/politza/.emacs.d/plugins/haskell-mode/haskell-doc hides /usr/share/emacs-snapshot/site-lisp/haskell-mode/haskell-doc /home/politza/.emacs.d/plugins/haskell-mode/haskell-indent hides /usr/share/emacs-snapshot/site-lisp/haskell-mode/haskell-indent /home/politza/.emacs.d/plugins/haskell-mode/haskell-mode hides /usr/share/emacs-snapshot/site-lisp/haskell-mode/haskell-mode /home/politza/.emacs.d/plugins/haskell-mode/haskell-hugs hides /usr/share/emacs-snapshot/site-lisp/haskell-mode/haskell-hugs /home/politza/.emacs.d/plugins/haskell-mode/haskell-site-file hides /usr/share/emacs-snapshot/site-lisp/haskell-mode/haskell-site-file /home/politza/.emacs.d/plugins/haskell-mode/haskell-cabal hides /usr/share/emacs-snapshot/site-lisp/haskell-mode/haskell-cabal /home/politza/.emacs.d/plugins/haskell-mode/inf-haskell hides /usr/share/emacs-snapshot/site-lisp/haskell-mode/inf-haskell /home/politza/.emacs.d/plugins/haskell-mode/haskell-font-lock hides /usr/share/emacs-snapshot/site-lisp/haskell-mode/haskell-font-lock /home/politza/.emacs.d/plugins/haskell-mode/haskell-simple-indent hides /usr/share/emacs-snapshot/site-lisp/haskell-mode/haskell-simple-indent /home/politza/.emacs.d/plugins/haskell-mode/haskell-indentation hides /usr/share/emacs-snapshot/site-lisp/haskell-mode/haskell-indentation Features: (shadow sort gnus-cite bbdb-message mailalias mail-extr nnir nndraft nnmh bbdb-gnus gnus-agent gnus-srvr gnus-score score-mode nnvirtual nntp gnus-cache gnus-msg gnus-art mm-uu mml2015 epg-config mm-view mml-smime smime dig mailcap emacsbug sendmail log-view log-edit pcvs-util smerge-mode vc-sccs vc-cvs vc-rcs bug-reference add-log whitespace semantic/ia semantic/analyze/refs semantic/senator bookmark cal-move mule-util pp reposition dired-aux misearch multi-isearch holidays hol-loaddefs diary-lib diary-loaddefs ewm ewm-compat ewm-conf ewm-frame ewm-util ewm-window diff-mode latexenc vc-dir ewoc vc preview prv-emacs reftex-dcr reftex-auc tex-buf font-latex vc-bzr vc-git doc-view-fixed-scroll pdf-sync pdf-annot tablist tablist-filter semantic/wisent/comp semantic/wisent semantic/wisent/wisent pdf-outline pdf-links pdf-isearch pdf-misc imenu pdf-info tq pdf-render pdf-history vc-dispatcher vc-svn semantic/db-file data-debug cedet-files cl-font-lock dired-eshell emacs-customizations hypermedia-customizations eww-customizations nogroup-customizations wp-customizations view-customizations tex-customizations reftex-customizations reftex-miscellaneous-configurations-customizations reftex-label-support-customizations reftex-referencing-labels-customizations reftex-defining-label-environments-customizations reftex reftex-vars AUCTeX-customizations preview-customizations preview-latex-customizations preview-appearance-customizations font-latex-customizations TeX-parse-customizations TeX-file-customizations TeX-command-customizations TeX-view-customizations LaTeX-customizations LaTeX-macro-customizations LaTeX-math-customizations LaTeX-indentation-customizations latex tex-style tex dbus xml table-customizations table-hooks-customizations outlines-customizations programming-customizations rnc-customizations tools-customizations vc-customizations log-edit-customizations semantic-customizations pulse-customizations semantic-imenu-customizations semantic/db-mode semantic/decorate/mode semantic/decorate pulse makefile-customizations etags-customizations ediff-customizations diff-customizations diff-mode-customizations languages-customizations elpy-customizations matlab-customizations sh-customizations python-customizations nxml-customizations relax-ng-customizations haskell-customizations c-customizations semantic/bovine/c hideif cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs semantic/db-find semantic/db-ref semantic/bovine/c-by semantic/lex-spp semantic/idle semantic/bovine/gcc semantic/dep semantic/bovine semantic/analyze semantic/sort semantic/scope semantic/analyze/fcn semantic/db eieio-base semantic/ctxt semantic/format ezimage semantic/tag-ls semantic/find semantic/util-modes semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local cedet asm-customizations multimedia-customizations image-customizations pcase help-customizations ekey-customizations info-lookup-customizations info-customizations customize-customizations custom-buffer-customizations apropos-customizations help-mode files-customizations uniquify-customizations uniquify sunrise-customizations recentf-customizations lib-files find-file-customizations backup-customizations faces-customizations highlight-symbol-customizations font-lock-customizations hi-lock-customizations facemenu-customizations external-customizations server-customizations processes-customizations shell-customizations proced-customizations gud-customizations tooltip-customizations grep-customizations compilation-customizations next-error-customizations comint-customizations SQL-customizations man-customizations environment-customizations xterm-customizations windows-customizations winner-customizations minibuffer-customizations savehist-customizations completion-spelling lib-string menu-customizations keyboard-customizations chistory-customizations initialization-customizations frames-customizations ediff-window-customizations desktop-customizations desktop frameset dired-customizations dired-x-customizations dired-x dired-details-customizations editing-customizations paragraphs-customizations matching-customizations paren-matching-customizations paren-showing-customizations isearch-customizations bookmark-customizations killing-customizations indent-customizations fill-customizations comment-customizations emulations-customizations editing-basics-customizations development-customizations lisp-customizations re-builder-customizations inferior-lisp-customizations ielm-customizations ert-customizations edebug-customizations bytecomp-customizations advice-customizations internal-customizations alloc-customizations extensions-customizations widgets-customizations eldoc-customizations eldoc-eval-customizations cust-print-customizations data-customizations save-place-customizations convenience-customizations mimo-customizations mimo diminish-customizations diminish iedit-customizations imenu-tree-customizations tags-tree-customizations company-customizations workgroups-customizations window-numbering-customizations pabbrev-customizations kmacro-customizations imenu-customizations ibuffer-customizations ibuf-macs hl-line-customizations hippie-expand-customizations file-cache-customizations ffap-customizations completion-customizations pc-completion-customizations jedi-customizations iswitchb-customizations auto-complete-customizations pc switch-focus color hl-line browse-kill-ring-customizations auto-revert-customizations auto-insert-customizations Buffer-menu-customizations comm-customizations tramp-customizations browse-url-customizations applications-customizations mediawiki-customizations w3m-customizations package-customizations mail-customizations bbdb-customizations bbdb-sendmail-customizations bbdb-mua-customizations bbdb-mua bbdb-com crm bbdb smtpmail-customizations shr-customizations sendmail-customizations gnus-customizations nnmail-customizations nnmail-split-customizations mail-source-customizations gnus-summary-customizations gnus-thread-customizations gnus-summary-various-customizations gnus-summary-sort-customizations gnus-summary-marks-customizations gnus-summary-maneuvering-customizations gnus-summary-format-customizations parse-time-rfc2822 gnus-summary-exit-customizations gnus-sum gnus-group gnus-undo gnus-start gnus-spec gnus-win gnus-start-customizations gnus-server-customizations gnus-message-customizations message-customizations message-various-customizations message-sending-customizations message-buffers-customizations gnus-group-customizations gnus-group-visual-customizations gnus-nnimap-format nnimap nnmail gnus-int mail-source message rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils mailheader parse-time tls utf7 netrc nnoo gnus gnus-ems nnheader mail-utils gnus-group-various-customizations gnus-group-select-customizations gnus-files-customizations gnus-newsrc-customizations gnus-exit-customizations gnus-article-customizations gnus-article-hiding-customizations ispell-customizations eshell-customizations eshell-module-customizations eshell-smart-customizations eshell-hist-customizations eshell-mode-customizations edebug doc-view-customizations pdf-tools-customizations pdf-sync-customizations pdf-annot-customizations pdf-isearch-customizations pdf-tools pdf-util gnus-range warnings doc-view-tidy-cache doc-view jka-compr image-mode calendar-customizations org-customizations org-structure-customizations org-plain-lists-customizations org-edit-structure-customizations org-startup-customizations org-link-customizations org-latex-customizations org-appearance-customizations holidays-customizations diary-customizations calculator-customizations calc-customizations server tramp-cache tramp-sh recentf tree-widget .autoload paren window-numbering w3m browse-url timezone w3m-hist w3m-e23 w3m-ccl ccl w3m-fsf w3m-favicon w3m-image w3m-proc w3m-util tramp tramp-compat tramp-loaddefs trampver shell track-last-window scroll-other-window saveplace savehist pabbrev derived cl-macs gv org org-macro org-footnote org-pcomplete org-list org-faces org-entities noutline outline easy-mmode org-version ob-emacs-lisp ob ob-tangle org-src ob-ref ob-lob ob-table ob-keys ob-exp ob-comint ob-core ob-eval org-compat org-macs org-loaddefs format-spec find-func cal-menu calendar cal-loaddefs lib-edit hsqldb sql view lib-window lib-isearch lib-buffer reveal iswitchb lib-basic lib-lispext info-look ibuffer hippie-exp grep compile filecache edit-minibuffer eldoc-eval pcomplete esh-var esh-io esh-cmd esh-opt esh-ext esh-proc esh-arg esh-groups eshell esh-module esh-mode esh-util ekey assoc dired-details+ dired dired-details cool-prefix-bindings winner edmacro kmacro lib-kbd comint-history comint ansi-color ring browse-kill-ring advice anticus apropos ffap thingatpt url-parse auth-source eieio byte-opt bytecomp byte-compile cconv eieio-core gnus-util mm-util mail-prsvr password-cache url-vars eldoc help-fns cus-edit cus-start cus-load wid-edit cl cl-loaddefs cl-lib bbdb-loaddefs info easymenu tex-site cl-format-autoloads package time-date tooltip ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list newcomment lisp-mode prog-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process dbusbind gfilenotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty emacs) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 09 04:13:17 2013 Received: (at 16090) by debbugs.gnu.org; 9 Dec 2013 09:13:17 +0000 Received: from localhost ([127.0.0.1]:39399 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vpwtw-0003kO-Gk for submit@debbugs.gnu.org; Mon, 09 Dec 2013 04:13:16 -0500 Received: from deliver.uni-koblenz.de ([141.26.64.15]:57027) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vpwtt-0003k5-Dv for 16090@debbugs.gnu.org; Mon, 09 Dec 2013 04:13:14 -0500 Received: from localhost (localhost [127.0.0.1]) by deliver.uni-koblenz.de (Postfix) with ESMTP id 3C0B33D6004; Mon, 9 Dec 2013 10:13:12 +0100 (CET) X-Virus-Scanned: amavisd-new at uni-koblenz.de Received: from deliver.uni-koblenz.de ([127.0.0.1]) by localhost (deliver.uni-koblenz.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id cx0b1b4JZ1Gk; Mon, 9 Dec 2013 10:13:11 +0100 (CET) X-CHKRCPT: Envelopesender noch tsdh@gnu.org Received: from tsdh.uni-koblenz.de (tsdh.uni-koblenz.de [141.26.67.142]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by deliver.uni-koblenz.de (Postfix) with ESMTPSA id BAABC3D6007; Mon, 9 Dec 2013 10:13:11 +0100 (CET) From: Tassilo Horn To: Andreas Politz Subject: Re: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark References: <87a9gbb7wi.fsf@hochschule-trier.de> Date: Mon, 09 Dec 2013 10:13:11 +0100 In-Reply-To: <87a9gbb7wi.fsf@hochschule-trier.de> (Andreas Politz's message of "Sun, 08 Dec 2013 17:54:21 +0100") Message-ID: <87mwkawfo8.fsf@tsdh.uni-koblenz.de> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 16090 Cc: 16090@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Andreas Politz writes: > $ emacs -Q some.pdf > > C-x r m RET > C-x k RET > C-x r b some.pdf RET > > Debugger entered--Lisp error: (wrong-type-argument listp t) > image-mode-winprops(nil) Indeed. > The reason is that the buffer is not yet displayed, when > doc-view-bookmark-jump tries to change the page. This results in, for > obscure reasons, trying to change the page in which ever window is > currently selected. Solution: Defer changing the page after > bookmark--jump-via has displayed the page. Here's a simpler patch which does also seem to fix the problem by simply using find-file instead of bookmark's default handler without requiring a timer. --8<---------------cut here---------------start------------->8--- === modified file 'lisp/doc-view.el' --- lisp/doc-view.el 2013-01-01 09:11:05 +0000 +++ lisp/doc-view.el 2013-12-09 08:55:30 +0000 @@ -1653,14 +1653,11 @@ (defun doc-view-bookmark-jump (bmk) ;; This implements the `handler' function interface for record type ;; returned by `doc-view-bookmark-make-record', which see. - (prog1 (bookmark-default-handler bmk) + (prog1 (find-file (bookmark-get-filename bmk)) (let ((page (bookmark-prop-get bmk 'page))) (when (not (eq major-mode 'doc-view-mode)) - (doc-view-toggle-display)) - (with-selected-window - (or (get-buffer-window (current-buffer) 0) - (selected-window)) - (doc-view-goto-page page))))) + (doc-view-toggle-display)) + (doc-view-goto-page page)))) --8<---------------cut here---------------end--------------->8--- Could you check if that also fixes the issue for you? And a question concerning the procedure: since this is a fix for a bug relative to emacs 23, should I commit it on the emacs-24 branch? Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 09 07:39:53 2013 Received: (at 16090) by debbugs.gnu.org; 9 Dec 2013 12:39:53 +0000 Received: from localhost ([127.0.0.1]:39580 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vq07s-0001n6-Po for submit@debbugs.gnu.org; Mon, 09 Dec 2013 07:39:53 -0500 Received: from gateway-a.fh-trier.de ([143.93.54.181]:59832) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vq07i-0001mh-9K for 16090@debbugs.gnu.org; Mon, 09 Dec 2013 07:39:47 -0500 X-Virus-Scanned: by Amavisd-new + McAfee uvscan + ClamAV [Rechenzentrum Hochschule Trier] Received: from luca (dslb-178-004-212-017.pools.arcor-ip.net [178.4.212.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: politza) by gateway-a.fh-trier.de (Postfix) with ESMTPSA id C82761761345; Mon, 9 Dec 2013 13:33:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha1; c=simple/simple; d=hochschule-trier.de; s=default; t=1386592423; bh=eeim5P8vNetbWmR2xD27kImyuPc=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=Uoz4be6rxk0twOHw7J0G8ypTwRGzLXU518KY6wOpY9gSj8DN58Y7rYtwgFvbot5tC E+0loUNuQBBwwidVv9s/rZppSdeHfoVlKUKMjmRrRdVaW4hKew9scukJ+LmjkhgoAZ fmpwbqIW3M65ligVgFD7Aj9lYRHqM12iVRcFNL6Y= Received: from politza by luca with local (Exim 4.72) (envelope-from ) id 1Vq01u-0001AK-Ty; Mon, 09 Dec 2013 13:33:42 +0100 From: Andreas Politz To: Tassilo Horn Subject: Re: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark References: <87a9gbb7wi.fsf@hochschule-trier.de> <87mwkawfo8.fsf@tsdh.uni-koblenz.de> Date: Mon, 09 Dec 2013 13:33:42 +0100 In-Reply-To: <87mwkawfo8.fsf@tsdh.uni-koblenz.de> (Tassilo Horn's message of "Mon, 09 Dec 2013 10:13:11 +0100") Message-ID: <87zjoa19w9.fsf@hochschule-trier.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 16090 Cc: 16090@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Tassilo Horn writes: > Here's a simpler patch which does also seem to fix the problem by simply > using find-file instead of bookmark's default handler without requiring > a timer. The timer surely is ugly. But the code displaying the buffer runs after the handler returns and using find-file in it may result in displaying the buffer twice, I guess. E.g. when using bookmark-jump-other-window. -ap From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 09 09:56:30 2013 Received: (at 16090) by debbugs.gnu.org; 9 Dec 2013 14:56:30 +0000 Received: from localhost ([127.0.0.1]:40192 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vq2G3-0005KD-Vu for submit@debbugs.gnu.org; Mon, 09 Dec 2013 09:56:29 -0500 Received: from deliver.uni-koblenz.de ([141.26.64.15]:42023) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vq2Fx-0005K5-9K for 16090@debbugs.gnu.org; Mon, 09 Dec 2013 09:56:23 -0500 Received: from localhost (localhost [127.0.0.1]) by deliver.uni-koblenz.de (Postfix) with ESMTP id B34151A83FF; Mon, 9 Dec 2013 15:56:19 +0100 (CET) X-Virus-Scanned: amavisd-new at uni-koblenz.de Received: from deliver.uni-koblenz.de ([127.0.0.1]) by localhost (deliver.uni-koblenz.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2FEtbiXmlpX7; Mon, 9 Dec 2013 15:56:19 +0100 (CET) X-CHKRCPT: Envelopesender noch tsdh@gnu.org Received: from tsdh.uni-koblenz.de (tsdh.uni-koblenz.de [141.26.67.142]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by deliver.uni-koblenz.de (Postfix) with ESMTPSA id 40AA41A83FA; Mon, 9 Dec 2013 15:56:18 +0100 (CET) From: Tassilo Horn To: Andreas Politz Subject: Re: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark References: <87a9gbb7wi.fsf@hochschule-trier.de> <87mwkawfo8.fsf@tsdh.uni-koblenz.de> <87zjoa19w9.fsf@hochschule-trier.de> Date: Mon, 09 Dec 2013 15:56:17 +0100 In-Reply-To: <87zjoa19w9.fsf@hochschule-trier.de> (Andreas Politz's message of "Mon, 09 Dec 2013 13:33:42 +0100") Message-ID: <87eh5mvzse.fsf@tsdh.uni-koblenz.de> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 16090 Cc: 16090@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Andreas Politz writes: >> Here's a simpler patch which does also seem to fix the problem by >> simply using find-file instead of bookmark's default handler without >> requiring a timer. > > The timer surely is ugly. But the code displaying the buffer runs after > the handler returns and using find-file in it may result in displaying > the buffer twice, I guess. E.g. when using bookmark-jump-other-window. Indeed, you are right. Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 09 11:56:00 2013 Received: (at 16090) by debbugs.gnu.org; 9 Dec 2013 16:56:00 +0000 Received: from localhost ([127.0.0.1]:40374 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vq47k-0008LM-2t for submit@debbugs.gnu.org; Mon, 09 Dec 2013 11:56:00 -0500 Received: from fencepost.gnu.org ([208.118.235.10]:35185) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vq47h-0008LE-Fz for 16090@debbugs.gnu.org; Mon, 09 Dec 2013 11:55:57 -0500 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Vq47e-00029f-Na; Mon, 09 Dec 2013 11:55:54 -0500 From: Glenn Morris To: Tassilo Horn Subject: Re: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark References: <87a9gbb7wi.fsf@hochschule-trier.de> <87mwkawfo8.fsf@tsdh.uni-koblenz.de> X-Spook: George W. Bush secure Afghanistan Juiliett Class X-Ran: "\LqI|.REfv*lk)+qKm1:n90rYg>%4Jz?(Fmp X-Hue: cyan X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 09 Dec 2013 11:55:54 -0500 In-Reply-To: <87mwkawfo8.fsf@tsdh.uni-koblenz.de> (Tassilo Horn's message of "Mon, 09 Dec 2013 10:13:11 +0100") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 16090 Cc: 16090@debbugs.gnu.org, Andreas Politz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Tassilo Horn wrote: > And a question concerning the procedure: since this is a fix for a bug > relative to emacs 23, should I commit it on the emacs-24 branch? If you want to do that and are sure the fix is correct, go ahead. But feel equally free to just commit to trunk instead, since that emacs-24 branch will not be used for any more releases. From debbugs-submit-bounces@debbugs.gnu.org Mon Dec 09 21:51:54 2013 Received: (at 16090) by debbugs.gnu.org; 10 Dec 2013 02:51:54 +0000 Received: from localhost ([127.0.0.1]:41163 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VqDQQ-0007DU-EM for submit@debbugs.gnu.org; Mon, 09 Dec 2013 21:51:54 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:37077) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VqDQO-0007DM-C3 for 16090@debbugs.gnu.org; Mon, 09 Dec 2013 21:51:52 -0500 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id rBA2pnj4019183; Mon, 9 Dec 2013 21:51:50 -0500 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id AF923AE2E5; Mon, 9 Dec 2013 21:51:48 -0500 (EST) From: Stefan Monnier To: Andreas Politz Subject: Re: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark Message-ID: References: <87a9gbb7wi.fsf@hochschule-trier.de> Date: Mon, 09 Dec 2013 21:51:48 -0500 In-Reply-To: <87a9gbb7wi.fsf@hochschule-trier.de> (Andreas Politz's message of "Sun, 08 Dec 2013 17:54:21 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4787=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4787> : inlines <294> : streams <1088219> : uri <1619456> X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 16090 Cc: 16090@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) > The reason is that the buffer is not yet displayed, when > doc-view-bookmark-jump tries to change the page. This results in, for > obscure reasons, trying to change the page in which ever window is > currently selected. Solution: Defer changing the page after > bookmark--jump-via has displayed the page. Thanks for the report. And thanks for the patch, tho it shouldn't be installed as is: using a timer is not a good solution. The code is already equipped to handle non-displayed buffers (it keeps track of the "default current page" which is later used when/if the buffer gets displayed in a window). Apparently, there's a bug in that code, or a bad interaction with that code and something that happens when you use a bookmark to access the document. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 10 02:28:55 2013 Received: (at 16090) by debbugs.gnu.org; 10 Dec 2013 07:28:55 +0000 Received: from localhost ([127.0.0.1]:41303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VqHkV-0005xe-3V for submit@debbugs.gnu.org; Tue, 10 Dec 2013 02:28:55 -0500 Received: from deliver.uni-koblenz.de ([141.26.64.15]:54184) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VqHkR-0005xR-CM for 16090@debbugs.gnu.org; Tue, 10 Dec 2013 02:28:52 -0500 Received: from localhost (localhost [127.0.0.1]) by deliver.uni-koblenz.de (Postfix) with ESMTP id 835CC3D601E; Tue, 10 Dec 2013 08:28:49 +0100 (CET) X-Virus-Scanned: amavisd-new at uni-koblenz.de Received: from deliver.uni-koblenz.de ([127.0.0.1]) by localhost (deliver.uni-koblenz.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id pPnr0CokVU2i; Tue, 10 Dec 2013 08:28:49 +0100 (CET) X-CHKRCPT: Envelopesender noch tsdh@gnu.org Received: from tsdh.uni-koblenz.de (tsdh.uni-koblenz.de [141.26.67.142]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by deliver.uni-koblenz.de (Postfix) with ESMTPSA id 2BF0E3D601D; Tue, 10 Dec 2013 08:28:49 +0100 (CET) From: Tassilo Horn To: Glenn Morris Subject: Re: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark References: <87a9gbb7wi.fsf@hochschule-trier.de> <87mwkawfo8.fsf@tsdh.uni-koblenz.de> Date: Tue, 10 Dec 2013 08:28:48 +0100 In-Reply-To: (Glenn Morris's message of "Mon, 09 Dec 2013 11:55:54 -0500") Message-ID: <87ob4pcggf.fsf@tsdh.uni-koblenz.de> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 16090 Cc: 16090@debbugs.gnu.org, Andreas Politz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Glenn Morris writes: >> And a question concerning the procedure: since this is a fix for a >> bug relative to emacs 23, should I commit it on the emacs-24 branch? > > If you want to do that and are sure the fix is correct, go ahead. But > feel equally free to just commit to trunk instead, since that emacs-24 > branch will not be used for any more releases. Ah, ok. I've thought 24.4 would be made from the emacs-24 branch, and then I'd definitively like to have the fix in there. Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 10 02:53:44 2013 Received: (at 16090) by debbugs.gnu.org; 10 Dec 2013 07:53:44 +0000 Received: from localhost ([127.0.0.1]:41328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VqI8U-0006cU-RA for submit@debbugs.gnu.org; Tue, 10 Dec 2013 02:53:43 -0500 Received: from deliver.uni-koblenz.de ([141.26.64.15]:57755) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VqI8R-0006cL-S3 for 16090@debbugs.gnu.org; Tue, 10 Dec 2013 02:53:40 -0500 Received: from localhost (localhost [127.0.0.1]) by deliver.uni-koblenz.de (Postfix) with ESMTP id 437451A8453; Tue, 10 Dec 2013 08:53:39 +0100 (CET) X-Virus-Scanned: amavisd-new at uni-koblenz.de Received: from deliver.uni-koblenz.de ([127.0.0.1]) by localhost (deliver.uni-koblenz.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o7Q6YNR9vTV1; Tue, 10 Dec 2013 08:53:38 +0100 (CET) X-CHKRCPT: Envelopesender noch tsdh@gnu.org Received: from tsdh.uni-koblenz.de (tsdh.uni-koblenz.de [141.26.67.142]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by deliver.uni-koblenz.de (Postfix) with ESMTPSA id DED9D1A844C; Tue, 10 Dec 2013 08:53:38 +0100 (CET) From: Tassilo Horn To: Stefan Monnier Subject: Re: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark References: <87a9gbb7wi.fsf@hochschule-trier.de> Date: Tue, 10 Dec 2013 08:53:38 +0100 In-Reply-To: (Stefan Monnier's message of "Mon, 09 Dec 2013 21:51:48 -0500") Message-ID: <87k3fdcfb1.fsf@tsdh.uni-koblenz.de> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 16090 Cc: 16090@debbugs.gnu.org, Andreas Politz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Stefan Monnier writes: >> The reason is that the buffer is not yet displayed, when >> doc-view-bookmark-jump tries to change the page. This results in, >> for obscure reasons, trying to change the page in which ever window >> is currently selected. Solution: Defer changing the page after >> bookmark--jump-via has displayed the page. > > Thanks for the report. And thanks for the patch, tho it shouldn't be > installed as is: using a timer is not a good solution. The code is > already equipped to handle non-displayed buffers (it keeps track of > the "default current page" which is later used when/if the buffer gets > displayed in a window). Yes, but I think that doesn't suffice. The problem with bookmarks is that the display window function is run after the bookmark handler, so we have no clue in which window the bookmarked page is going to be shown. It may be the current window, an existing other window (which might already show another page of the doc and thus already has an entry in `image-mode-winprops-alist'), or a completely new window. Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 10 05:20:37 2013 Received: (at 16090) by debbugs.gnu.org; 10 Dec 2013 10:20:37 +0000 Received: from localhost ([127.0.0.1]:41441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VqKQe-0001sY-V7 for submit@debbugs.gnu.org; Tue, 10 Dec 2013 05:20:37 -0500 Received: from gateway-a.fh-trier.de ([143.93.54.181]:54010) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VqKQc-0001sK-67 for 16090@debbugs.gnu.org; Tue, 10 Dec 2013 05:20:36 -0500 X-Virus-Scanned: by Amavisd-new + McAfee uvscan + ClamAV [Rechenzentrum Hochschule Trier] Received: from luca (dslb-178-004-212-017.pools.arcor-ip.net [178.4.212.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: politza) by gateway-a.fh-trier.de (Postfix) with ESMTPSA id 4F0601788BF1; Tue, 10 Dec 2013 11:02:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha1; c=simple/simple; d=hochschule-trier.de; s=default; t=1386669762; bh=kQDy8mEtREIQxDdOlJsjXuxGAEo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=Ae16VtjesMbkV9E1+tVnWo3EAu1k68kTCzqlkIsM8OmIkdvA3TnnyPUu49jjRBjKq BiSlj47nu1vL+vpCkfJqpzNihbXTU1+w0Zb+Q5BewUa7u8nUJ3B3ZTA7dRP+hs20+p oOLoBgqrTsFRGFNHiyOmKAPz+fYKDzTSMWq/hfp4= Received: from politza by luca with local (Exim 4.72) (envelope-from ) id 1VqK9J-0002V1-I7; Tue, 10 Dec 2013 11:02:41 +0100 From: Andreas Politz To: Tassilo Horn Subject: Re: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark References: <87a9gbb7wi.fsf@hochschule-trier.de> <87k3fdcfb1.fsf@tsdh.uni-koblenz.de> Date: Tue, 10 Dec 2013 11:02:41 +0100 In-Reply-To: <87k3fdcfb1.fsf@tsdh.uni-koblenz.de> (Tassilo Horn's message of "Tue, 10 Dec 2013 08:53:38 +0100") Message-ID: <87fvq1t45a.fsf@hochschule-trier.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 16090 Cc: 16090@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Tassilo Horn writes: > Stefan Monnier writes: >> The code is already equipped to handle non-displayed buffers (it >> keeps track of the "default current page" which is later used when/if >> the buffer gets displayed in a window). I see. So the problem is the (with-selected-window (or ... (selected-window))), which most of the times makes the wrong buffer current (having image-mode-winprops-alist eq t). > > Yes, but I think that doesn't suffice. The problem with bookmarks is > that the display window function is run after the bookmark handler, so > we have no clue in which window the bookmarked page is going to be > shown. [...] What about setting an additional property for the page in image-mode-winprops-alist and removing it later in doc-view-new-window-function ? -ap From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 10 06:59:12 2013 Received: (at 16090) by debbugs.gnu.org; 10 Dec 2013 11:59:12 +0000 Received: from localhost ([127.0.0.1]:41482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VqLy2-0004PT-CR for submit@debbugs.gnu.org; Tue, 10 Dec 2013 06:59:10 -0500 Received: from gateway-a.fh-trier.de ([143.93.54.181]:47467) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VqLxy-0004PI-T4 for 16090@debbugs.gnu.org; Tue, 10 Dec 2013 06:59:08 -0500 X-Virus-Scanned: by Amavisd-new + McAfee uvscan + ClamAV [Rechenzentrum Hochschule Trier] Received: from luca (dslb-088-068-095-111.pools.arcor-ip.net [88.68.95.111]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: politza) by gateway-a.fh-trier.de (Postfix) with ESMTPSA id D277F1788B99; Tue, 10 Dec 2013 12:58:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha1; c=simple/simple; d=hochschule-trier.de; s=default; t=1386676726; bh=VeIebiGBU7s5wrzkDIO0LODMy/0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=bjY/YeUi8V3TT5QcAzk/aUH9auf8dEsWUo7Ma+VdQSYe/lpyH55wt5a0IhqRlhECM W+7QAcTNLNrDwpnfPpa0UjidGMQ5GWeYrL18NYi+HOlg9eeeLqsb+AK9A4x+kqO+RL zxDmi4CDl0YcmE6pGyQBwgNJHt8X/dx2m9PkcMt8= Received: from politza by luca with local (Exim 4.72) (envelope-from ) id 1VqLxe-00017D-0s; Tue, 10 Dec 2013 12:58:46 +0100 From: Andreas Politz To: Tassilo Horn Subject: Re: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark References: <87a9gbb7wi.fsf@hochschule-trier.de> <87k3fdcfb1.fsf@tsdh.uni-koblenz.de> <87fvq1t45a.fsf@hochschule-trier.de> Date: Tue, 10 Dec 2013 12:58:46 +0100 In-Reply-To: <87fvq1t45a.fsf@hochschule-trier.de> (Andreas Politz's message of "Tue, 10 Dec 2013 11:02:41 +0100") Message-ID: <87txeg9atl.fsf@hochschule-trier.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 16090 Cc: 16090@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Andreas Politz writes: > What about setting an additional property [...] Never mind this shot from the hip. -ap From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 10 11:56:38 2013 Received: (at 16090) by debbugs.gnu.org; 10 Dec 2013 16:56:38 +0000 Received: from localhost ([127.0.0.1]:41962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VqQbt-0004rN-QU for submit@debbugs.gnu.org; Tue, 10 Dec 2013 11:56:38 -0500 Received: from gateway-b.fh-trier.de ([143.93.54.182]:54267) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VqQbq-0004rD-Mc for 16090@debbugs.gnu.org; Tue, 10 Dec 2013 11:56:35 -0500 X-Virus-Scanned: by Amavisd-new + McAfee uvscan + ClamAV [Rechenzentrum Hochschule Trier] Received: from luca (dslb-188-097-165-019.pools.arcor-ip.net [188.97.165.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: politza) by gateway-b.fh-trier.de (Postfix) with ESMTPSA id DEA8B17B4A4; Tue, 10 Dec 2013 17:56:17 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha1; c=simple/simple; d=hochschule-trier.de; s=default; t=1386694577; bh=e+FbdY3/RDDREpFEWTRyPw2uj1s=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=oGS8dqGF4kg64gkbMx9WEJ1ceD8sGwZbsYa16W1UsmGzaH/+eW90ouhY99gbyl0vo mlSM37PxFUQe54L2pG67+GR9bXz8/e79FJQ9aoAwU54HKMYvP3r0ODlzEwcGFOKWcN WjHs2jq3pVn7POA3sqSUB4p/++pi7dL7peOPIryo= Received: from politza by luca with local (Exim 4.72) (envelope-from ) id 1VqQbZ-0003GD-5l; Tue, 10 Dec 2013 17:56:17 +0100 From: Andreas Politz To: Tassilo Horn Subject: Re: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark References: <87a9gbb7wi.fsf@hochschule-trier.de> <87k3fdcfb1.fsf@tsdh.uni-koblenz.de> Date: Tue, 10 Dec 2013 17:56:17 +0100 In-Reply-To: <87k3fdcfb1.fsf@tsdh.uni-koblenz.de> (Tassilo Horn's message of "Tue, 10 Dec 2013 08:53:38 +0100") Message-ID: <877gbcfxvy.fsf@hochschule-trier.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 16090 Cc: 16090@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Tassilo Horn writes: > Stefan Monnier writes: > >> The code is already equipped to handle non-displayed buffers (it >> keeps track of the "default current page" which is later used when/if >> the buffer gets displayed in a window). Where is this page read and gone to ? doc-view-new-window-function at most switches to the first page and this (with-current-buffer (find-file-noselect "some.pdf") (doc-view-goto-page 2) (pop-to-buffer (current-buffer))) also displays the first page. Is this a mistake in this function, i.e. shouldn't it read the winprop page ? -ap From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 10 15:07:37 2013 Received: (at 16090) by debbugs.gnu.org; 10 Dec 2013 20:07:37 +0000 Received: from localhost ([127.0.0.1]:42183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VqTai-0007Cx-FN for submit@debbugs.gnu.org; Tue, 10 Dec 2013 15:07:36 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:51315) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VqTaf-0007Ck-01 for 16090@debbugs.gnu.org; Tue, 10 Dec 2013 15:07:34 -0500 Received: from compute6.internal (compute6.nyi.mail.srv.osa [10.202.2.46]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 665BD2269A for <16090@debbugs.gnu.org>; Tue, 10 Dec 2013 15:07:27 -0500 (EST) Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Tue, 10 Dec 2013 15:07:29 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:references:date :in-reply-to:message-id:mime-version:content-type; s=smtpout; bh=P62UbWbhxxrPyGYViRZDDEroGT0=; b=SS0i82DVEQQEUdzJ2RlBEnHEZEjH BPMa60cEzQ7NUyl9JrNFjiEzed4YGT6iC70JcnFEuTT+ukhfzuC06BQ/SRlJitJM kvQ4hMhpMR5TeItC1RHWiGhRlBXZANY0nRMvl4JZX5rEAiG/MoQcSbuGZsxSrJDI s0xfy+EOrc9cmN0= X-Sasl-enc: GVAf7qbmLlL8YnGPMvaQq6XtwUee52/owVcZpgXUda1j 1386706047 Received: from thinkpad.tsdh.org (unknown [91.67.164.26]) by mail.messagingengine.com (Postfix) with ESMTPA id 3F192C00E9D; Tue, 10 Dec 2013 15:07:27 -0500 (EST) From: Tassilo Horn To: Andreas Politz Subject: Re: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark References: <87a9gbb7wi.fsf@hochschule-trier.de> <87k3fdcfb1.fsf@tsdh.uni-koblenz.de> <877gbcfxvy.fsf@hochschule-trier.de> Date: Tue, 10 Dec 2013 21:07:25 +0100 In-Reply-To: <877gbcfxvy.fsf@hochschule-trier.de> (Andreas Politz's message of "Tue, 10 Dec 2013 17:56:17 +0100") Message-ID: <87y53sjwqq.fsf@thinkpad.tsdh.org> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 16090 Cc: 16090@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Andreas Politz writes: >>> The code is already equipped to handle non-displayed buffers (it >>> keeps track of the "default current page" which is later used >>> when/if the buffer gets displayed in a window). > > Where is this page read and gone to ? doc-view-new-window-function at > most switches to the first page Comment in the `message' in the first line. You'll see that it's called two times (once with t and once with a window in (car winprops)) if the buffer hasn't been shown in some window already. > and this > > (with-current-buffer (find-file-noselect "some.pdf") > (doc-view-goto-page 2) > (pop-to-buffer (current-buffer))) > > also displays the first page. No, if some.pdf hasn't been open yet, it'll show page 2. In that case, `image-mode-winprops-alist' default entry will look like this: (t (info . #("Page 2 of 6.\n" 0 12 (face bold))) (page . 2) (overlay . #)) > Is this a mistake in this function, i.e. shouldn't it read the winprop > page? That happens during the second time the function is called with a real window by making the overlay showing the image with that window's page visible. Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 10 17:17:12 2013 Received: (at 16090) by debbugs.gnu.org; 10 Dec 2013 22:17:12 +0000 Received: from localhost ([127.0.0.1]:42360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VqVc7-0004Qt-8N for submit@debbugs.gnu.org; Tue, 10 Dec 2013 17:17:11 -0500 Received: from gateway-a.fh-trier.de ([143.93.54.181]:60750) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VqVc5-0004Qk-8S for 16090@debbugs.gnu.org; Tue, 10 Dec 2013 17:17:10 -0500 X-Virus-Scanned: by Amavisd-new + McAfee uvscan + ClamAV [Rechenzentrum Hochschule Trier] Received: from luca (dslb-188-097-165-019.pools.arcor-ip.net [188.97.165.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: politza) by gateway-a.fh-trier.de (Postfix) with ESMTPSA id 4676B1788EAF; Tue, 10 Dec 2013 23:16:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha1; c=simple/simple; d=hochschule-trier.de; s=default; t=1386713813; bh=Xj5UkbDgKpGEg+qf7ap3+alOBEA=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=oU/1eq0iL5D5vEZez+I0lh33mX/iH5uEfkwIhV+PWelxf7h4/f0/YEuF/gGCiHvf+ mNFZrfvqn39KrzoxaUjEPoH5sxcNwODQV+zMr+Cvs33KbICaCrPF65gHWaMblZUf4C JiW6aJRUpeDUQjqiZmPIaoSCQfAWr8RCIb5FotWk= Received: from politza by luca with local (Exim 4.72) (envelope-from ) id 1VqVbo-0005aL-Em; Tue, 10 Dec 2013 23:16:52 +0100 From: Andreas Politz To: Tassilo Horn Subject: Re: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark References: <87a9gbb7wi.fsf@hochschule-trier.de> <87k3fdcfb1.fsf@tsdh.uni-koblenz.de> <877gbcfxvy.fsf@hochschule-trier.de> <87y53sjwqq.fsf@thinkpad.tsdh.org> Date: Tue, 10 Dec 2013 23:16:52 +0100 In-Reply-To: <87y53sjwqq.fsf@thinkpad.tsdh.org> (Tassilo Horn's message of "Tue, 10 Dec 2013 21:07:25 +0100") Message-ID: <8738m0fj1n.fsf@hochschule-trier.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 16090 Cc: 16090@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Tassilo Horn writes: > Andreas Politz writes: >> and this >> >> (with-current-buffer (find-file-noselect "some.pdf") >> (doc-view-goto-page 2) >> (pop-to-buffer (current-buffer))) >> >> also displays the first page. > > No, if some.pdf hasn't been open yet, it'll show page 2. [...] >> [...] shouldn't it read the winprop page? > > That happens during the second time the function is called with a real > window by making the overlay showing the image with that window's page > visible. I am using a non-temporary cache directory and this makes a difference. If the document is not yet converted when opening it, it works as you said. But if it is, the code which would insert the image after the conversion never runs and the winprops for the popped up window look like this: (# (info . #("Page 2 of 4.\n" 0 12 (face bold))) (page . 2) (overlay . #)) ,with overlay properties (shortened) (help-echo "Page 2 of 4." display "Welcome to DocView! ..." window t doc-view t) Then the last sexp in doc-view-new-window-function switches to the first page, without using the page property. -ap From debbugs-submit-bounces@debbugs.gnu.org Tue Dec 10 23:43:46 2013 Received: (at 16090) by debbugs.gnu.org; 11 Dec 2013 04:43:46 +0000 Received: from localhost ([127.0.0.1]:42603 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VqbeD-000724-V1 for submit@debbugs.gnu.org; Tue, 10 Dec 2013 23:43:46 -0500 Received: from chene.dit.umontreal.ca ([132.204.246.20]:51367) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VqbeC-00071x-Dt for 16090@debbugs.gnu.org; Tue, 10 Dec 2013 23:43:45 -0500 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id rBB4heT9004209; Tue, 10 Dec 2013 23:43:41 -0500 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 16ABCAE321; Tue, 10 Dec 2013 23:43:41 -0500 (EST) From: Stefan Monnier To: Tassilo Horn Subject: Re: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark Message-ID: References: <87a9gbb7wi.fsf@hochschule-trier.de> <87k3fdcfb1.fsf@tsdh.uni-koblenz.de> Date: Tue, 10 Dec 2013 23:43:41 -0500 In-Reply-To: <87k3fdcfb1.fsf@tsdh.uni-koblenz.de> (Tassilo Horn's message of "Tue, 10 Dec 2013 08:53:38 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4788=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4788> : inlines <301> : streams <1088871> : uri <1620558> X-Spam-Score: -1.5 (-) X-Debbugs-Envelope-To: 16090 Cc: 16090@debbugs.gnu.org, Andreas Politz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.5 (-) > Yes, but I think that doesn't suffice. The problem with bookmarks is > that the display window function is run after the bookmark handler, so > we have no clue in which window the bookmarked page is going to be > shown. It may be the current window, an existing other window (which > might already show another page of the doc and thus already has an entry > in `image-mode-winprops-alist'), or a completely new window. Why does it matter? Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Dec 11 14:08:31 2013 Received: (at 16090) by debbugs.gnu.org; 11 Dec 2013 19:08:31 +0000 Received: from localhost ([127.0.0.1]:44243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vqp94-0007mj-Kx for submit@debbugs.gnu.org; Wed, 11 Dec 2013 14:08:30 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:57542) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vqp91-0007ma-OE for 16090@debbugs.gnu.org; Wed, 11 Dec 2013 14:08:29 -0500 Received: from compute4.internal (compute4.nyi.mail.srv.osa [10.202.2.44]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 3525420869; Wed, 11 Dec 2013 14:08:27 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute4.internal (MEProxy); Wed, 11 Dec 2013 14:08:27 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:references:date :in-reply-to:message-id:mime-version:content-type; s=smtpout; bh=NY/uP2wvmtZmuxwHtoWTdOF53Bk=; b=Xp2i1s07rShwns3wr1V2mSVDA6W7 n7JYbesUk6ra8zSCAUg1yn8XoCU4+1twA7O3umv0haNdgsfc01z5v+A+rtdABQak 8E8K/iR8xZlolBaosTMT6ABeo3TIbLbA2D6PevOiFWBvzNvHCD8u8YcfWX99ewVr 4TZEeRkfzSoHrxs= X-Sasl-enc: 6nK22aakgEtLLd3dE8kFCN7+SkmKbjDoQGh6apGTpoXL 1386788906 Received: from thinkpad.tsdh.org (unknown [91.67.164.26]) by mail.messagingengine.com (Postfix) with ESMTPA id 829D2680518; Wed, 11 Dec 2013 14:08:26 -0500 (EST) From: Tassilo Horn To: Stefan Monnier Subject: Re: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark References: <87a9gbb7wi.fsf@hochschule-trier.de> <87k3fdcfb1.fsf@tsdh.uni-koblenz.de> Date: Wed, 11 Dec 2013 20:08:25 +0100 In-Reply-To: (Stefan Monnier's message of "Tue, 10 Dec 2013 23:43:41 -0500") Message-ID: <87y53r8aty.fsf@thinkpad.tsdh.org> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 16090 Cc: 16090@debbugs.gnu.org, Andreas Politz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Stefan Monnier writes: >> Yes, but I think that doesn't suffice. The problem with bookmarks is >> that the display window function is run after the bookmark handler, >> so we have no clue in which window the bookmarked page is going to be >> shown. It may be the current window, an existing other window (which >> might already show another page of the doc and thus already has an >> entry in `image-mode-winprops-alist'), or a completely new window. > > Why does it matter? Please correct me if I'm wrong in the following. The winprops alist contains for a doc-view buffer the shown page for any window where the buffer has been shown plus a default entry that's used when the doc-view buffer is going to be shown in a new window. Let's assume I open foo.pdf with find-file and a single window. The default entry will get page 1 assigned and when it gets shown in a window, a new winprops entry for that window is created, also with page 1. Now I switch to page 2, then split and switch to page 3 in the new window, so my layout is as follows (* = selected window): | Window 1 (P2) | *Window 2 (P3) | Let's assume I have a bookmark on page 4 in foo.pdf. Then a) bookmark-jump should change the page in window 2 b) bookmark-jump-other-window should change the page in window 1 However, both first call `doc-view-bookmark-jump' and thereafter either `switch-to-buffer' or `pop-to-buffer'. How could the doc-view bookmark handler cope with this situation? Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 20 03:00:29 2013 Received: (at 16090) by debbugs.gnu.org; 20 Dec 2013 08:00:29 +0000 Received: from localhost ([127.0.0.1]:59414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vtv0V-0006et-Qm for submit@debbugs.gnu.org; Fri, 20 Dec 2013 03:00:28 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:53044) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vtv0O-0006eX-0x for 16090@debbugs.gnu.org; Fri, 20 Dec 2013 03:00:21 -0500 Received: from compute2.internal (compute2.nyi.mail.srv.osa [10.202.2.42]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 4631A20E04; Fri, 20 Dec 2013 03:00:19 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute2.internal (MEProxy); Fri, 20 Dec 2013 03:00:19 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:references:date :in-reply-to:message-id:mime-version:content-type; s=smtpout; bh=O82tAiFeYzfwOXV3LPi3ahAR+zs=; b=GoqmgdQ2UQVREiPl1HR3qA48xuDR 9b+b9LrRudixMgtFJZWbBNgMJVN1bdki97qW0Gz7KKCUrNJ6o+TcIwH5F8yGkHbE N5VO5MnOm2P/p/4bc3KgrqNam3KuNapfY09XsqWq7piDxDSSUStum765OlLe7QEo vgk8o4wtBlJgHMU= X-Sasl-enc: w0uAsNAc4542E79mFfLqYl2Lsp0cl3kEELpuLJ8vI27v 1387526418 Received: from thinkpad.tsdh.org (unknown [91.67.164.26]) by mail.messagingengine.com (Postfix) with ESMTPA id 989666800BA; Fri, 20 Dec 2013 03:00:18 -0500 (EST) From: Tassilo Horn To: Andreas Politz , Stefan Monnier Subject: Re: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark References: <87a9gbb7wi.fsf@hochschule-trier.de> Date: Fri, 20 Dec 2013 09:00:17 +0100 In-Reply-To: <87a9gbb7wi.fsf@hochschule-trier.de> (Andreas Politz's message of "Sun, 08 Dec 2013 17:54:21 +0100") Message-ID: <87txe4j6jy.fsf@thinkpad.tsdh.org> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 16090 Cc: 16090@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Andreas Politz writes: > (let ((page (bookmark-prop-get bmk 'page))) > (when (not (eq major-mode 'doc-view-mode)) > (doc-view-toggle-display)) > ! (run-with-idle-timer 0 nil > ! (lambda (buffer page) > ! (when (and (buffer-live-p buffer) > ! (window-live-p (get-buffer-window buffer 0))) > ! (with-selected-window (get-buffer-window buffer 0) > ! (doc-view-goto-page page)))) > ! (current-buffer) page)))) I just want to mention that even this timer-version acts wrongly when the display-func of `bookmark-jump' doesn't select the window, because `get-buffer-window' prefers the selected window. I don't think that's too much an issue, though, because the provided interactive bookmark functions use as display-functions only pop- and switch-to-buffer which will select the window, and then the patch works fine. So I'm in favor of committing the patch [before 24.4 is released!] cause in any case it's better than not being able to open bookmarks to document files altogether. The only cleaner way to get it right (I can see) was to change bookmark.el so that it determines/creates the window to show the buffer before calling the bookmark handler. But that's a much larger change possibly affecting many people that have their own bookmark-jump functions. Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 20 03:28:44 2013 Received: (at 16090) by debbugs.gnu.org; 20 Dec 2013 08:28:44 +0000 Received: from localhost ([127.0.0.1]:59446 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VtvRs-0007Wt-5b for submit@debbugs.gnu.org; Fri, 20 Dec 2013 03:28:44 -0500 Received: from gateway-a.fh-trier.de ([143.93.54.181]:55995) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VtvRq-0007Wl-6k for 16090@debbugs.gnu.org; Fri, 20 Dec 2013 03:28:43 -0500 X-Virus-Scanned: by Amavisd-new + McAfee uvscan + ClamAV [Rechenzentrum Hochschule Trier] Received: from luca (dslb-178-004-043-163.pools.arcor-ip.net [178.4.43.163]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: politza) by gateway-a.fh-trier.de (Postfix) with ESMTPSA id E9C841752A75; Fri, 20 Dec 2013 09:28:26 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha1; c=simple/simple; d=hochschule-trier.de; s=default; t=1387528107; bh=468/XzLKKxqfna0ysXLuuh7N/Ik=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=MP0TZw0fD6+xLBc1N12PDMpTl1O85Owp3Ilqz7R0wJIMuEdrfvQ5JXvDOny0cSSUb r7fiREAmoCgDl8HyZB8GNTbnJ7OJhm3EEik+FiiO5Bs4m0TuBBkp5vNqBXub3y3nfw m3xno3s03hW8AEIL1Yv8wBVdiINwN/wQTvCRJreE= Received: from politza by luca with local (Exim 4.72) (envelope-from ) id 1VtvRa-0004tG-5r; Fri, 20 Dec 2013 09:28:26 +0100 From: Andreas Politz To: Tassilo Horn Subject: Re: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark References: <87a9gbb7wi.fsf@hochschule-trier.de> <87txe4j6jy.fsf@thinkpad.tsdh.org> Date: Fri, 20 Dec 2013 09:28:26 +0100 In-Reply-To: <87txe4j6jy.fsf@thinkpad.tsdh.org> (Tassilo Horn's message of "Fri, 20 Dec 2013 09:00:17 +0100") Message-ID: <877gb0hqol.fsf@hochschule-trier.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 16090 Cc: 16090@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Do you acknowledge and have an opinion on the cached vs. non-cached behaviour I did mention earlier ? -ap From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 20 08:03:05 2013 Received: (at 16090) by debbugs.gnu.org; 20 Dec 2013 13:03:05 +0000 Received: from localhost ([127.0.0.1]:59734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VtzjM-0000W7-7I for submit@debbugs.gnu.org; Fri, 20 Dec 2013 08:03:04 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:41751) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VtzjI-0000Ve-Ak for 16090@debbugs.gnu.org; Fri, 20 Dec 2013 08:03:01 -0500 Received: from compute1.internal (compute1.nyi.mail.srv.osa [10.202.2.41]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id AB41220D58; Fri, 20 Dec 2013 08:02:59 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 20 Dec 2013 08:02:59 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:references:date :in-reply-to:message-id:mime-version:content-type; s=smtpout; bh=aX6COAeIRPJ/lcJjDllWQF1rcKQ=; b=auwQtyFmuj/RtWF1nlwp6ihAqmyG wgvDH1kAJMrlwFkcwxtcNx8llkyYrspXoAJNQi2yJeaus+JeRhfAJBa6zZzNvL/E IzGjQuXJIH1Z8bG5gs2F/+cKRoQAj287INjRuF9dhpQU6fwESd63HedMPxq/x2j/ ehfNeiExmvKC1lM= X-Sasl-enc: qF5QO+9qrdB79pjzipWGbuETcXM41pn6uZ/Ypen4KPeu 1387544579 Received: from thinkpad.tsdh.org (unknown [91.67.164.26]) by mail.messagingengine.com (Postfix) with ESMTPA id 02C4C6800C2; Fri, 20 Dec 2013 08:02:58 -0500 (EST) From: Tassilo Horn To: Andreas Politz Subject: Re: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark References: <87a9gbb7wi.fsf@hochschule-trier.de> <87txe4j6jy.fsf@thinkpad.tsdh.org> <877gb0hqol.fsf@hochschule-trier.de> Date: Fri, 20 Dec 2013 14:02:58 +0100 In-Reply-To: <877gb0hqol.fsf@hochschule-trier.de> (Andreas Politz's message of "Fri, 20 Dec 2013 09:28:26 +0100") Message-ID: <87lhzfd69p.fsf@thinkpad.tsdh.org> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 16090 Cc: 16090@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Andreas Politz writes: > Do you acknowledge and have an opinion on the cached vs. non-cached > behaviour I did mention earlier ? No, I haven't looked into the differences yet. But I think I've come up with a quite good solution for the general problem right now. The patch below allows bookmark handlers to return a function that accepts the window showing the buffer and then may act on it. When the display-function has been run, that function is called and in the doc-view case sets the page for that window. Until now, return values of handlers where simply ignored. It shouldn't break existing handlers, except if there's some handler that does something like (setq dunno (lambda (...) ...)) or (add-hook 'dunno-hook (lambda (...) ...)) as last expression which seems unlikely. I've grepped the emacs source code and at least all handlers in there (man, woman, image-mode, gnus, help, Info) don't do so. I've tested it with bookmarks to docs that had to be converted anew and bookmarks to docs that were already cached, and it seems to DTRT in all cases. --8<---------------cut here---------------start------------->8--- === modified file 'lisp/bookmark.el' --- lisp/bookmark.el 2013-09-11 03:31:56 +0000 +++ lisp/bookmark.el 2013-12-20 13:01:29 +0000 @@ -997,12 +997,18 @@ After calling DISPLAY-FUNCTION, set window point to the point specified by BOOKMARK-NAME-OR-RECORD, if necessary, run `bookmark-after-jump-hook', -and then show any annotations for this bookmark." - (bookmark-handle-bookmark bookmark-name-or-record) +and then show any annotations for this bookmark. + +If the handler returns a function, this function will be called +with the window showing the bookmark buffer." + (let ((win-fn (bookmark-handle-bookmark bookmark-name-or-record))) (save-current-buffer (funcall display-function (current-buffer))) (let ((win (get-buffer-window (current-buffer) 0))) - (if win (set-window-point win (point)))) + (when win + (set-window-point win (point)) + (when (functionp win-fn) + (funcall win-fn win))))) ;; FIXME: we used to only run bookmark-after-jump-hook in ;; `bookmark-jump' itself, but in none of the other commands. (run-hooks 'bookmark-after-jump-hook) @@ -1061,13 +1067,16 @@ (cons (current-buffer) (point)))) (defun bookmark-handle-bookmark (bookmark-name-or-record) - "Call BOOKMARK-NAME-OR-RECORD's handler or `bookmark-default-handler' -if it has none. This changes current buffer and point and returns nil, -or signals a `file-error'. + "Call BOOKMARK-NAME-OR-RECORD's handler or +`bookmark-default-handler' if it has none. This changes current +buffer and point, or signals a `file-error'. The handler may +return a function with one argument, a window. This function +will be called with the window showing the bookmark's buffer. If BOOKMARK-NAME-OR-RECORD has no file, this is a no-op. If BOOKMARK-NAME-OR-RECORD has a file, but that file no longer exists, then offer interactively to relocate BOOKMARK-NAME-OR-RECORD." + (prog1 (condition-case err (funcall (or (bookmark-get-handler bookmark-name-or-record) 'bookmark-default-handler) @@ -1106,8 +1115,7 @@ (signal (car err) (cdr err)))))))))) ;; Added by db. (when (stringp bookmark-name-or-record) - (setq bookmark-current-bookmark bookmark-name-or-record)) - nil) + (setq bookmark-current-bookmark bookmark-name-or-record)))) (define-error 'bookmark-errors nil) (define-error 'bookmark-error-no-filename === modified file 'lisp/doc-view.el' --- lisp/doc-view.el 2013-11-28 22:43:09 +0000 +++ lisp/doc-view.el 2013-12-20 12:30:55 +0000 @@ -1866,13 +1866,12 @@ (defun doc-view-bookmark-jump (bmk) ;; This implements the `handler' function interface for record type ;; returned by `doc-view-bookmark-make-record', which see. - (prog1 (bookmark-default-handler bmk) + (bookmark-default-handler bmk) (let ((page (bookmark-prop-get bmk 'page))) + (lambda (win) (when (not (eq major-mode 'doc-view-mode)) (doc-view-toggle-display)) - (with-selected-window - (or (get-buffer-window (current-buffer) 0) - (selected-window)) + (with-selected-window win (doc-view-goto-page page))))) --8<---------------cut here---------------end--------------->8--- Good to commit? Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 20 09:34:02 2013 Received: (at 16090) by debbugs.gnu.org; 20 Dec 2013 14:34:02 +0000 Received: from localhost ([127.0.0.1]:59785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vu19N-0003Q7-8M for submit@debbugs.gnu.org; Fri, 20 Dec 2013 09:34:01 -0500 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:58441) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vu19I-0003Pq-OX for 16090@debbugs.gnu.org; Fri, 20 Dec 2013 09:33:57 -0500 Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id rBKEXrRa023540; Fri, 20 Dec 2013 09:33:54 -0500 Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id F3471AE15C; Fri, 20 Dec 2013 09:33:54 -0500 (EST) From: Stefan Monnier To: Tassilo Horn Subject: Re: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark Message-ID: References: <87a9gbb7wi.fsf@hochschule-trier.de> <87txe4j6jy.fsf@thinkpad.tsdh.org> Date: Fri, 20 Dec 2013 09:33:54 -0500 In-Reply-To: <87txe4j6jy.fsf@thinkpad.tsdh.org> (Tassilo Horn's message of "Fri, 20 Dec 2013 09:00:17 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4798=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4798> : inlines <343> : streams <1094033> : uri <1630230> X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 16090 Cc: 16090@debbugs.gnu.org, Andreas Politz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) > So I'm in favor of committing the patch [before 24.4 is released!] cause > in any case it's better than not being able to open bookmarks to > document files altogether. There's still a lot of time before 24.4 is released, so there's no hurry in this respect. I'd like to first understand the underlying problem better. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 20 09:36:17 2013 Received: (at 16090) by debbugs.gnu.org; 20 Dec 2013 14:36:17 +0000 Received: from localhost ([127.0.0.1]:59791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vu1BY-0003VM-FW for submit@debbugs.gnu.org; Fri, 20 Dec 2013 09:36:16 -0500 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:50875) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vu1BU-0003VC-UI for 16090@debbugs.gnu.org; Fri, 20 Dec 2013 09:36:13 -0500 Received: from compute3.internal (compute3.nyi.mail.srv.osa [10.202.2.43]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 3410120F4B; Fri, 20 Dec 2013 09:36:08 -0500 (EST) Received: from frontend2 ([10.202.2.161]) by compute3.internal (MEProxy); Fri, 20 Dec 2013 09:36:10 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:references:date :in-reply-to:message-id:mime-version:content-type; s=smtpout; bh=02Og7QAdoFlO1TvU4XsnLff3i/Q=; b=RR6kz5l+a/0EbEprVj2IvCAemaTd zPeQKWP5LIy0KmnsSR1NDfqIV8RnU5n4YuDI1SNApLRNazO/YOXkTxZuA+bNieqK R9Wc2+vD74GBeLfjY2IfeU9H7+L/a1rmf5QR3AGyGLCZmzWGI9LCrCOYTy8j9zC1 v+TsJ0Ym06UNM3Y= X-Sasl-enc: ZXhf+TLwAFoYhAtkS5HO+dQh7ipu8fgMY2y9ca0RBxFF 1387550166 Received: from thinkpad.tsdh.org (unknown [91.67.164.26]) by mail.messagingengine.com (Postfix) with ESMTPA id C84066804F2; Fri, 20 Dec 2013 09:36:05 -0500 (EST) From: Tassilo Horn To: Stefan Monnier Subject: Re: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark References: <87a9gbb7wi.fsf@hochschule-trier.de> <87txe4j6jy.fsf@thinkpad.tsdh.org> Date: Fri, 20 Dec 2013 15:36:04 +0100 In-Reply-To: (Stefan Monnier's message of "Fri, 20 Dec 2013 09:33:54 -0500") Message-ID: <87a9fvd1yj.fsf@thinkpad.tsdh.org> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 16090 Cc: 16090@debbugs.gnu.org, Andreas Politz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Stefan Monnier writes: >> So I'm in favor of committing the patch [before 24.4 is released!] >> cause in any case it's better than not being able to open bookmarks >> to document files altogether. > > There's still a lot of time before 24.4 is released, so there's no > hurry in this respect. Sure, we just should not forget about it. And have a look at my other patch to bookmark.el & doc-view.el. I think that's a good fix for the issue. Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 02 10:43:39 2014 Received: (at 16090) by debbugs.gnu.org; 2 Apr 2014 14:43:39 +0000 Received: from localhost ([127.0.0.1]:33044 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WVMOA-0002LS-Tu for submit@debbugs.gnu.org; Wed, 02 Apr 2014 10:43:39 -0400 Received: from chene.dit.umontreal.ca ([132.204.246.20]:33823) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WVMO8-0002LK-S1 for 16090@debbugs.gnu.org; Wed, 02 Apr 2014 10:43:37 -0400 Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id s32EhYq6021307; Wed, 2 Apr 2014 10:43:35 -0400 Received: by pastel.home (Postfix, from userid 20848) id BA11660251; Wed, 2 Apr 2014 10:43:34 -0400 (EDT) From: Stefan Monnier To: Tassilo Horn Subject: Re: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark Message-ID: References: <87a9gbb7wi.fsf@hochschule-trier.de> <87txe4j6jy.fsf@thinkpad.tsdh.org> <877gb0hqol.fsf@hochschule-trier.de> <87lhzfd69p.fsf@thinkpad.tsdh.org> Date: Wed, 02 Apr 2014 10:43:34 -0400 In-Reply-To: <87lhzfd69p.fsf@thinkpad.tsdh.org> (Tassilo Horn's message of "Fri, 20 Dec 2013 14:02:58 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4900=0 X-NAI-Spam-Version: 2.3.0.9378 : core <4900> : inlines <684> : streams <1150324> : uri <1718066> X-Spam-Score: -1.9 (-) X-Debbugs-Envelope-To: 16090 Cc: 16090@debbugs.gnu.org, Andreas Politz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) > No, I haven't looked into the differences yet. But I think I've come up > with a quite good solution for the general problem right now. The patch > below allows bookmark handlers to return a function that accepts the > window showing the buffer and then may act on it. When the > display-function has been run, that function is called and in the > doc-view case sets the page for that window. Sounds good. > Until now, return values of handlers where simply ignored. It shouldn't > break existing handlers, except if there's some handler that does > something like If we're worried about such corner cases, we can do the same we do with completion-boundaries and completion-metadata: require that the function return (post-display-function . FUN) instead of just FUN. The probability that some pre-existing bookmark handler returns something of the form (post-display-function . FUN) is sufficiently small. Another option is to use a new bookmark property `post-display-function'. > I've tested it with bookmarks to docs that had to be converted anew and > bookmarks to docs that were already cached, and it seems to DTRT in all > cases. I think the current behavior in the "already cached" case demonstrates that we have a bug in there and I'm not sure that your patch fixes that bug (i.e. maybe it just works around it). I don't have time to dig into it, sadly. For emacs-24, your patch is too intrusive, so I think a patch along the lines of Andreas's might be acceptable, but it should use bookmark-after-jump-hook instead of using a timer. As for trunk, your patch is mostly OK. I think it should be pushed a bit further, tho: make it so that `display-function' returns the window (and fall back on calling get-buffer-window), and make it so that win-fn *replaces* the set-window-point (and receives the bookmark as additional argument, since it's likely that the function may like to use data from the bookmark, such as the page). After all, this get-buffer-window + set-window-point thingy in bookmark--jump-via is a hack to try and solve the same problem we're having (tho for "point in normal buffers", instead of for "current page in doc-view buffers"). Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 04 09:44:27 2014 Received: (at 16090) by debbugs.gnu.org; 4 Apr 2014 13:44:27 +0000 Received: from localhost ([127.0.0.1]:35048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WW4Py-0000kf-Bu for submit@debbugs.gnu.org; Fri, 04 Apr 2014 09:44:26 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:43785) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WW4Pt-0000kR-Od for 16090@debbugs.gnu.org; Fri, 04 Apr 2014 09:44:23 -0400 Received: from compute6.internal (compute6.nyi.mail.srv.osa [10.202.2.46]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 02A4D20C6E; Fri, 4 Apr 2014 09:44:21 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute6.internal (MEProxy); Fri, 04 Apr 2014 09:44:21 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:references:date :in-reply-to:message-id:mime-version:content-type; s=smtpout; bh=oNjFD9oZ34NSJbSq18vsACV8orw=; b=WaE32YYCcsR3uRfMDvv52NAQn3uH xHCqy3TfOQ3s2Hor7W+ucHuVV+2R0yV1IqZfpParHAvo83ZUCnSVc9NAtp039aai H0Lhph59TM9KDPA7JdHhs4IP5FJF8avHxZAY+dDTx/HEqXC1wcN2o/XJupEnkNcE bX+KOZG2sPoZBZs= X-Sasl-enc: 8/oTRXZPlr9sPB70xGcD7+3bFMqW0cfRkxWvOKSlFZaY 1396619060 Received: from thinkpad-t440p.fritz.box (unknown [95.88.165.230]) by mail.messagingengine.com (Postfix) with ESMTPA id C5C9A680125; Fri, 4 Apr 2014 09:44:19 -0400 (EDT) From: Tassilo Horn To: Stefan Monnier Subject: Re: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark References: <87a9gbb7wi.fsf@hochschule-trier.de> <87txe4j6jy.fsf@thinkpad.tsdh.org> <877gb0hqol.fsf@hochschule-trier.de> <87lhzfd69p.fsf@thinkpad.tsdh.org> Date: Fri, 04 Apr 2014 15:43:43 +0200 In-Reply-To: (Stefan Monnier's message of "Wed, 02 Apr 2014 10:43:34 -0400") Message-ID: <878url6whc.fsf@thinkpad-t440p.fritz.box> User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 16090 Cc: 16090@debbugs.gnu.org, Andreas Politz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Stefan Monnier writes: > For emacs-24, your patch is too intrusive, so I think a patch along > the lines of Andreas's might be acceptable, but it should use > bookmark-after-jump-hook instead of using a timer. Like so? (defun doc-view-bookmark-jump (bmk) ;; This implements the `handler' function interface for record type ;; returned by `doc-view-bookmark-make-record', which see. (let ((page (bookmark-prop-get bmk 'page))) (add-hook 'bookmark-after-jump-hook (lambda () (setq bookmark-after-jump-hook (cdr bookmark-after-jump-hook)) (when (not (eq major-mode 'doc-view-mode)) (doc-view-toggle-display)) (with-selected-window (or (get-buffer-window (current-buffer) 0) (selected-window)) (doc-view-goto-page page)))) (bookmark-default-handler bmk))) Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 04 11:15:03 2014 Received: (at 16090) by debbugs.gnu.org; 4 Apr 2014 15:15:03 +0000 Received: from localhost ([127.0.0.1]:35548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WW5pe-0003Ur-Ko for submit@debbugs.gnu.org; Fri, 04 Apr 2014 11:15:03 -0400 Received: from mercure.iro.umontreal.ca ([132.204.24.67]:37195) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WW5pb-0003UC-Il for 16090@debbugs.gnu.org; Fri, 04 Apr 2014 11:15:00 -0400 Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id EA02A84E0A; Fri, 4 Apr 2014 11:14:58 -0400 (EDT) Received: from lechon.iro.umontreal.ca (lechon.iro.umontreal.ca [132.204.27.242]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id 2783E1E5B74; Fri, 4 Apr 2014 11:14:35 -0400 (EDT) Received: by lechon.iro.umontreal.ca (Postfix, from userid 20848) id E5632B4287; Fri, 4 Apr 2014 11:14:34 -0400 (EDT) From: Stefan Monnier To: Tassilo Horn Subject: Re: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark Message-ID: References: <87a9gbb7wi.fsf@hochschule-trier.de> <87txe4j6jy.fsf@thinkpad.tsdh.org> <877gb0hqol.fsf@hochschule-trier.de> <87lhzfd69p.fsf@thinkpad.tsdh.org> <878url6whc.fsf@thinkpad-t440p.fritz.box> Date: Fri, 04 Apr 2014 11:14:34 -0400 In-Reply-To: <878url6whc.fsf@thinkpad-t440p.fritz.box> (Tassilo Horn's message of "Fri, 04 Apr 2014 15:43:43 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82, MC_TSTLAST 0.00) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-Spam-Status: No X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 16090 Cc: 16090@debbugs.gnu.org, Andreas Politz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) >> For emacs-24, your patch is too intrusive, so I think a patch along >> the lines of Andreas's might be acceptable, but it should use >> bookmark-after-jump-hook instead of using a timer. > Like so? Almost: > (defun doc-view-bookmark-jump (bmk) > ;; This implements the `handler' function interface for record type > ;; returned by `doc-view-bookmark-make-record', which see. > (let ((page (bookmark-prop-get bmk 'page))) > (add-hook 'bookmark-after-jump-hook > (lambda () > (setq bookmark-after-jump-hook > (cdr bookmark-after-jump-hook)) Don't use `setq' on hooks. Use remove-hook. Yes I know it's more complicated, you'll have to use `make-symbol' and fset it with the above lambda. But `setq' on hooks really is much too brittle. Stefan From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 04 11:54:01 2014 Received: (at 16090) by debbugs.gnu.org; 4 Apr 2014 15:54:01 +0000 Received: from localhost ([127.0.0.1]:35567 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WW6RL-0004Zn-UI for submit@debbugs.gnu.org; Fri, 04 Apr 2014 11:54:00 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:45230) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WW6RI-0004ZX-5C for 16090@debbugs.gnu.org; Fri, 04 Apr 2014 11:53:58 -0400 Received: from compute1.internal (compute1.nyi.mail.srv.osa [10.202.2.41]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 4559B20F79; Fri, 4 Apr 2014 11:53:52 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 04 Apr 2014 11:53:53 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:references:date :in-reply-to:message-id:mime-version:content-type; s=smtpout; bh=Wdu5F8LuwkP8jSHxGWFBfyIdUIQ=; b=FFa/t6Dsonf2RNwzFrCLU4HEmjfQ J7jxQWdTVQaa4ZM16ulId0coxzs2TkozdYH00FbmL1Nca1osCzMQW+l8MOa836rl Bh/LVY2psCpK/kWguKHJumrioAdas2ZW1guaCB1P5HgZgKYlRBYo/uc8lfTTCqfd 13TyEbAGEjkSjiU= X-Sasl-enc: mVdMyRaMegcDIzG+gC5wJBl41nPbUn3mI+5tOE6vJhWE 1396626831 Received: from thinkpad-t440p.fritz.box (unknown [95.88.165.230]) by mail.messagingengine.com (Postfix) with ESMTPA id A12596801E0; Fri, 4 Apr 2014 11:53:50 -0400 (EDT) From: Tassilo Horn To: Stefan Monnier Subject: Re: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark References: <87a9gbb7wi.fsf@hochschule-trier.de> <87txe4j6jy.fsf@thinkpad.tsdh.org> <877gb0hqol.fsf@hochschule-trier.de> <87lhzfd69p.fsf@thinkpad.tsdh.org> <878url6whc.fsf@thinkpad-t440p.fritz.box> Date: Fri, 04 Apr 2014 17:53:14 +0200 In-Reply-To: (Stefan Monnier's message of "Fri, 04 Apr 2014 11:14:34 -0400") Message-ID: <87siptks5x.fsf@thinkpad-t440p.fritz.box> User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 16090 Cc: 16090@debbugs.gnu.org, Andreas Politz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Stefan Monnier writes: >> (defun doc-view-bookmark-jump (bmk) >> ;; This implements the `handler' function interface for record type >> ;; returned by `doc-view-bookmark-make-record', which see. >> (let ((page (bookmark-prop-get bmk 'page))) >> (add-hook 'bookmark-after-jump-hook >> (lambda () >> (setq bookmark-after-jump-hook >> (cdr bookmark-after-jump-hook)) > > Don't use `setq' on hooks. Use remove-hook. Yes I know it's more > complicated, you'll have to use `make-symbol' and fset it with the > above lambda. But `setq' on hooks really is much too brittle. I knew it wasn't a good idea, but I didn't think of fset-ing an uninterned symbol. Good idea! Hm, but somehow I cannot commit with vc. I always get bzr: ERROR: Unrecognized bug debbugs:16090. Commit refused. But that's the right number! Bye, Tassilo From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 04 12:04:59 2014 Received: (at 16090) by debbugs.gnu.org; 4 Apr 2014 16:04:59 +0000 Received: from localhost ([127.0.0.1]:35573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WW6by-0004tY-TM for submit@debbugs.gnu.org; Fri, 04 Apr 2014 12:04:59 -0400 Received: from fencepost.gnu.org ([208.118.235.10]:43488) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WW6bw-0004tN-8R for 16090@debbugs.gnu.org; Fri, 04 Apr 2014 12:04:57 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1WW6bt-0006tM-Cj; Fri, 04 Apr 2014 12:04:53 -0400 From: Glenn Morris To: Tassilo Horn Subject: Re: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark References: <87a9gbb7wi.fsf@hochschule-trier.de> <87txe4j6jy.fsf@thinkpad.tsdh.org> <877gb0hqol.fsf@hochschule-trier.de> <87lhzfd69p.fsf@thinkpad.tsdh.org> <878url6whc.fsf@thinkpad-t440p.fritz.box> <87siptks5x.fsf@thinkpad-t440p.fritz.box> X-Spook: Leitrim Israel NASA analyzer Roswell wire transfer codes X-Ran: P!E1,>'~i>'xN/uGsDD>(BgL*8vy^&Szs`sgZ,MuBf@_iS2dn>E_2CC5H}[fDbi[m (Tassilo Horn's message of "Fri, 04 Apr 2014 17:53:14 +0200") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: -5.6 (-----) X-Debbugs-Envelope-To: 16090 Cc: 16090@debbugs.gnu.org, Stefan Monnier , Andreas Politz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.6 (-----) Tassilo Horn wrote: > Hm, but somehow I cannot commit with vc. I always get > > bzr: ERROR: Unrecognized bug debbugs:16090. Commit refused. Thanks to Emacs's .dir-locals.el, you MUST add an entry to your ~/.bazaar/bazaar.conf of the form: [DEFAULT] bugtracker_debbugs_url = http://debbugs.gnu.org/{id} Else you get this confusing error when you try to commit something with a Fixes: field. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 04 13:45:22 2014 Received: (at 16090-close) by debbugs.gnu.org; 4 Apr 2014 17:45:22 +0000 Received: from localhost ([127.0.0.1]:35638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WW8B7-0007nc-JL for submit@debbugs.gnu.org; Fri, 04 Apr 2014 13:45:21 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:38769) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WW8B2-0007nM-8c for 16090-close@debbugs.gnu.org; Fri, 04 Apr 2014 13:45:20 -0400 Received: from compute6.internal (compute6.nyi.mail.srv.osa [10.202.2.46]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id D8DCC20DF7 for <16090-close@debbugs.gnu.org>; Fri, 4 Apr 2014 13:45:14 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute6.internal (MEProxy); Fri, 04 Apr 2014 13:45:14 -0400 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:references:date :in-reply-to:message-id:mime-version:content-type; s=smtpout; bh=g/C3Xfvksi3j0rs/zS0yJT4bNDc=; b=F12Q1XILI/GBDVwlhCJAEybS8CfG g7f6VT8LEIHcu0bxxfSgfnDzNHIDY0rpIGDNVTXuQaHhsKRmsYCMpRVVN2sBQVSP iFZpapRE6tGD5sA36edGiTh4zFznJ+X/470817funakgK7wXELoKBNl+rrmCQV6E 40nR3kN4VbyCq00= X-Sasl-enc: g8a5ZajJkgH5QUc/njELnkbHLOS/vXGvqXZy3YELLMl4 1396633514 Received: from thinkpad-t440p.fritz.box (unknown [95.88.165.230]) by mail.messagingengine.com (Postfix) with ESMTPA id 5EFC0C0000C; Fri, 4 Apr 2014 13:45:13 -0400 (EDT) From: Tassilo Horn To: Glenn Morris Subject: Re: bug#16090: 24.3.50; [PATCH] error when jumping to a doc-view bookmark References: <87a9gbb7wi.fsf@hochschule-trier.de> <87txe4j6jy.fsf@thinkpad.tsdh.org> <877gb0hqol.fsf@hochschule-trier.de> <87lhzfd69p.fsf@thinkpad.tsdh.org> <878url6whc.fsf@thinkpad-t440p.fritz.box> <87siptks5x.fsf@thinkpad-t440p.fritz.box> Date: Fri, 04 Apr 2014 19:44:37 +0200 In-Reply-To: (Glenn Morris's message of "Fri, 04 Apr 2014 12:04:53 -0400") Message-ID: <87d2gxvvju.fsf@thinkpad-t440p.fritz.box> User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.4.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 16090-close Cc: 16090-close@debbugs.gnu.org, Stefan Monnier , Andreas Politz X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) Glenn Morris writes: Hi Glenn, >> Hm, but somehow I cannot commit with vc. I always get >> >> bzr: ERROR: Unrecognized bug debbugs:16090. Commit refused. > > Thanks to Emacs's .dir-locals.el, you MUST add an entry to > your ~/.bazaar/bazaar.conf of the form: > > [DEFAULT] > bugtracker_debbugs_url = http://debbugs.gnu.org/{id} > > Else you get this confusing error when you try to commit something > with a Fixes: field. Ah, that did the trick. Ok, the change is committed on the emacs-24 branch. Thanks, Tassilo From unknown Fri Jun 20 19:47:45 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 03 May 2014 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator