Subject: Re: bug#16086: 24.3.50; [PATCH] eww: New command and functions to list the browser histories.

From: Ted Zlatanov <[email-masked]>
Date: Tue, 10 Dec 2013 19:21:15 -0500

On Sun, 08 Dec 2013 14:44:55 +0900 Kenjiro NAKAYAMA <[email-masked]> wrote: 

KN> New command and functions to list the eww browser histories. Since eww quits only "q" command, I think it becomes useful.
KN> Signed-off-by: Kenjiro NAKAYAMA <[email-masked]>

KN> 	* net/eww.el
KN>       (eww-list-histories,eww-list-histories,eww-history-browse,eww-history-quit,eww-history-kill,eww-history-mode-map,eww-history-mode):
KN>       New command and functions to list browser histories.

KN> -
KN> +    (define-key map "H" 'eww-list-histories)
KN> +    

Trailing spaces here and elsewhere, can you please fix?

KN> -  (set (make-local-variable 'eww-history) nil)
KN> -  (set (make-local-variable 'eww-history-position) 0)
KN> +;;  (set (make-local-variable 'eww-history) nil)
KN> +;;  (set (make-local-variable 'eww-history-position) 0)

I'd rather see these removed, IIUC what you mean here.

KN> +\\{eww-history-mode-map}"
KN> +  (buffer-disable-undo)
KN> +  (setq buffer-read-only t
KN> +	truncate-lines t))

Could this also bind `next-error' and `previous-error'?  Actually a
generic "list of items" buffer mode would be useful and perhaps already
exists?

Thanks!
Ted