GNU bug report logs - #16075
ls/stat-free-color.sh fails on AArch64 architecture

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Marcin Juszkiewicz <mjuszkiewicz <at> redhat.com>
Subject: bug#16075: closed (Re: bug#16075: ls/stat-free-color.sh fails on
 AArch64 architecture)
Date: Sat, 07 Dec 2013 15:22:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#16075: ls/stat-free-color.sh fails on AArch64 architecture

which was filed against the coreutils package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 16075 <at> debbugs.gnu.org.

-- 
16075: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16075
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Pádraig Brady <P <at> draigBrady.com>
To: Bernhard Voelker <mail <at> bernhard-voelker.de>
Cc: 16075-done <at> debbugs.gnu.org, Marcin Juszkiewicz <mjuszkiewicz <at> redhat.com>
Subject: Re: bug#16075: ls/stat-free-color.sh fails on AArch64 architecture
Date: Sat, 07 Dec 2013 15:21:11 +0000

[Message part 3 (text/plain, inline)]

On 12/06/2013 09:12 PM, Pádraig Brady wrote:
> On 12/06/2013 08:58 PM, Bernhard Voelker wrote:
>> On 12/06/2013 06:45 PM, Pádraig Brady wrote:
> 
>>> Even at that the test is still brittle,
>>> as the guard only checks that `strace -e stat` works.
>>> Also it's conceivable that on some edge cases there
>>> may be more than one stat call used in this case.
>>
>> I must confess that I don't understand this, i.e. in which circumstances
>> this test would fail as it has been working long enough, and now just
>> is ported to another architecture.
> 
> So I'm worried that the system might have a version
> of strace that doesn't support say newfstatat for example.
> Now my removing of the -e ... above will avoid the immediate:
>   strace: invalid system call `newfstatat'
> But strace may then output something that `grep stat..` doesn't match,
> thuse messing up the counts and failing the test.
> 
> I'll sleep on it as I'm rushing off now.

I going with the attached which should handle everything,
even diagnosis of unhandled "stat" calls.

thanks,
Pádraig.

[newfstatat.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Marcin Juszkiewicz <mjuszkiewicz <at> redhat.com>
To: bug-coreutils <at> gnu.org
Subject: ls/stat-free-color.sh fails on AArch64 architecture
Date: Fri, 06 Dec 2013 16:50:04 +0100

[Message part 6 (text/plain, inline)]

Test checks for use of stat,lstat,stat64,lstat64 syscalls. But on
AArch64 it is using statfs64 and newfstatat calls so test fails.

log and log-help attached

Commands used:
strace -o log ls --color=always >/dev/null
strace -o log-help ls --help >/dev/null

[log-help (text/plain, attachment)]

[log (text/plain, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.