GNU bug report logs - #16071
Erc re-binds [home] even if not beginning-of-line

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 16071 in the body.
You can then email your comments to 16071 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ivan Shmakov <ivan <at> siamics.net>
To: submit <at> debbugs.gnu.org
Subject: Erc re-binds [home] even if not beginning-of-line
Date: Fri, 06 Dec 2013 11:37:23 +0000

Package:  emacs
Severity: minor

	As of 0dd4ebbcf94d, erc-mode-map unconditionally binds both C-a
	and Home to erc-bol.  Which is problematic, as:

	• either (or both) of them may happen to /not/ be bound to
	  beginning-of-line (as, for example, when using an older,
	  Emacs 20-or-so, binding of Home to beginning-of-buffer);

	• the user may’ve previously bound additional key sequences to
	  beginning-of-line, which are not rebound by the current
	  erc-mode-map.

	It’s arguably more semantically correct (and convenient) to
	re-map beginning-of-line to erc-bol, instead of using an
	explicit list of key sequences to be bound to erc-bol.

-- 
FSF associate member #7257

Message #8 received at 16071 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Ivan Shmakov <ivan <at> siamics.net>
Cc: 16071 <at> debbugs.gnu.org
Subject: Re: bug#16071: Erc re-binds [home] even if not beginning-of-line
Date: Fri, 06 Dec 2013 12:59:01 -0500

> 	As of 0dd4ebbcf94d, erc-mode-map unconditionally binds both C-a
> 	and Home to erc-bol.  Which is problematic, as:

Good points.

But please note that doing it with remap is intrusive because the user
may actually like to have a key bound to beginning-of-line.

I guess rebinding with substitute-key-definition is OK.


        Stefan

Message #11 received at 16071 <at> debbugs.gnu.org (full text, mbox):

From: Ivan Shmakov <ivan <at> siamics.net>
To: 16071 <at> debbugs.gnu.org
Subject: Re: bug#16071: Erc re-binds [home] even if not beginning-of-line
Date: Fri, 06 Dec 2013 18:26:11 +0000

>>>>> Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

 >> As of 0dd4ebbcf94d, erc-mode-map unconditionally binds both C-a and
 >> Home to erc-bol.  Which is problematic, as:

 > Good points.

 > But please note that doing it with remap is intrusive because the
 > user may actually like to have a key bound to beginning-of-line.

	Indeed, it’s intrusive either way.

 > I guess rebinding with substitute-key-definition is OK.

	Does that mean binding only to the sequences which are
	beginning-of-line in global-map /and/ also not overridden by the
	user in erc-mode-map, or something like that?  As per my reading
	of substitute-key-definition, it implies more or less the same
	effect as the use of [remap] with define-key.

-- 
FSF associate member #7257

Message #14 received at 16071 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Ivan Shmakov <ivan <at> siamics.net>
Cc: 16071 <at> debbugs.gnu.org
Subject: Re: bug#16071: Erc re-binds [home] even if not beginning-of-line
Date: Fri, 06 Dec 2013 22:17:49 -0500

>> I guess rebinding with substitute-key-definition is OK.
> 	Does that mean binding only to the sequences which are
> 	beginning-of-line in global-map /and/ also not overridden by the
> 	user in erc-mode-map, or something like that?

Yes.

> 	As per my reading of substitute-key-definition, it implies more
> 	or less the same effect as the use of [remap] with define-key.

No: people can still bind a key to beginning-of-line in erc-mode-map and
it won't be remapped.


        Stefan

Message #17 received at 16071 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Ivan Shmakov <ivan <at> siamics.net>
Cc: 16071 <at> debbugs.gnu.org
Subject: Re: bug#16071: Erc re-binds [home] even if not beginning-of-line
Date: Sun, 27 Dec 2015 22:07:27 +0100

Ivan Shmakov <ivan <at> siamics.net> writes:

> As of 0dd4ebbcf94d, erc-mode-map unconditionally binds both C-a
> and Home to erc-bol.  Which is problematic, as:
>
> • either (or both) of them may happen to /not/ be bound to
> beginning-of-line (as, for example, when using an older,
> Emacs 20-or-so, binding of Home to beginning-of-buffer);
>
> • the user may’ve previously bound additional key sequences to
> beginning-of-line, which are not rebound by the current
> erc-mode-map.
>
> It’s arguably more semantically correct (and convenient) to
> re-map beginning-of-line to erc-bol, instead of using an
> explicit list of key sequences to be bound to erc-bol.

Well, I think that users who want to rebind keys in a mode should use
the mode hooks -- there's nothing special about beginning-of-line and
friends.  So I'm closing this report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.