GNU bug report logs - #16058
24.3.50; X protocol error: BadAlloc...

Previous Next

Package: emacs;

Reported by: Thierry Volpiatto <thierry.volpiatto <at> gmail.com>

Date: Thu, 5 Dec 2013 05:53:02 UTC

Severity: normal

Found in version 24.3.50

Fixed in version 24.4

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Dmitry Antipov <dmantipov <at> yandex.ru>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 16058 <at> debbugs.gnu.org, thierry.volpiatto <at> gmail.com
Subject: bug#16058: 24.3.50; X protocol error: BadAlloc...
Date: Mon, 09 Dec 2013 21:11:50 +0400

On 12/09/2013 08:43 PM, Eli Zaretskii wrote:

>> [2:text/x-patch Hide Save:invalidate_desired_row_bug16058.patch (356B)]
>>
>> === modified file 'src/xdisp.c'
>> --- src/xdisp.c	2013-12-04 18:46:47 +0000
>> +++ src/xdisp.c	2013-12-09 08:30:57 +0000
>> @@ -11937,6 +11937,8 @@
>>     int max_x = it->last_visible_x;
>>     struct glyph *last;
>>
>> +  /* Don't extend on a previously drawn tool bar items (Bug#16058).  */
>> +  row->enabled_p = 0;
>>     prepare_desired_row (row);
>>     row->y = it->current_y;
>
> Isn't it better to just call clear_glyph_row explicitly?

Hm...not sure, what about enabling enabled_p and preserving reversed_p?

And, of course, thanks for reviewing it.

Dmitry
This bug report was last modified 11 years and 159 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.