Subject: bug#16058: 24.3.50; X protocol error: BadAlloc...

From: Eli Zaretskii <[email-masked]>
Date: Mon, 09 Dec 2013 20:15:14 +0200

> Date: Mon, 09 Dec 2013 21:11:50 +0400
> From: Dmitry Antipov <[email-masked]>
> CC: [email-masked], [email-masked]
> 
> >> +  /* Don't extend on a previously drawn tool bar items (Bug#16058).  */
> >> +  row->enabled_p = 0;
> >>     prepare_desired_row (row);
> >>     row->y = it->current_y;
> >
> > Isn't it better to just call clear_glyph_row explicitly?
> 
> Hm...not sure, what about enabling enabled_p

You can do that by hand.

> and preserving reversed_p?

We don't support R2L toolbars anyway, there's a comment about that in
the code.

Anyway, if you prefer to do this your way, we should have a comment
there saying that disabling the row ensures prepare_desired_row will
clear it.

> And, of course, thanks for reviewing it.

You are welcome.