GNU bug report logs - #16053
[PATCH 1/2] "-Wall -Wextra -Werror" compilation patches - part 1/2

Previous Next

Full log

Message #17 received at 16053 <at> debbugs.gnu.org (full text, mbox):

From: Doron Tsur <doront <at> mellanox.com>
To: Phillip Susi <psusi <at> ubuntu.com>, "16053 <at> debbugs.gnu.org"
 <16053 <at> debbugs.gnu.org>
Cc: Itai Baz <itaib <at> mellanox.com>
Subject: RE: bug#16053: [PATCH 1/2] "-Wall -Wextra -Werror" compilation
 patches - part 1/2
Date: Mon, 16 Dec 2013 15:32:55 +0000

I personally prefer code compiled with Wextra, but I guess it is open for discussion,

You have my patch available in case you wish to inherit changes from there.


-----Original Message-----
From: Phillip Susi [mailto:psusi <at> ubuntu.com] 
Sent: Monday, December 16, 2013 4:18 PM
To: Doron Tsur; 16053 <at> debbugs.gnu.org
Cc: Itai Baz
Subject: Re: bug#16053: [PATCH 1/2] "-Wall -Wextra -Werror" compilation patches - part 1/2

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 12/15/2013 11:39 PM, Doron Tsur wrote:
> It should allow users to check new code and possible grub extension in 
> a pedantic manner easily.

If you want to compile new code with -Wextra, that could be a nice check I suppose, but I don't think the whole code base needs to compile with -Wextra + -Werror, especially if it means making the code less readable.  I believe the reason there is a -Wextra is because those warnings are considered so silly and annoying to code around that they aren't wanted for -Wall -Werror.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.17 (MingW32)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQEcBAEBAgAGBQJSrwt7AAoJEI5FoCIzSKrw3tAH/2bECOPQmS2PSjSNmGUcE1oh
L3xoIZFajjnEQafVjp8kROK3dYb84OCZq0Fq8ECSrQMq3w/AGHAdzeE3aAB0ENjY
rZEWbbZ3dNbq0oNZg8GNsUQybNt820X2oFHf6JL6z6OKImWXgMUZRtMaRYrmbajg
3UJq0YXHA63NnkpZ2zZcLuEcLDRr4AOFp5IUEGipHtF93EJ9DS8cViUQx1rrjirv
bnyuYp22/z/NtlGXER/V0O2r4svNH8U1rw5nTEeDC7rKYOTmtu0XXDmQzQ26+oG4
aGRXO88IG7Sqm9EB1yWIN1K1uRqxSK7BI4Fam6lTmewxYAVf4km5TehMYC/6ZoA=
=WgS/
-----END PGP SIGNATURE-----

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.