From unknown Fri Jun 20 20:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16023: 24.3; [PATCH] process-live-p tweak Resent-From: Leo Liu Original-Sender: "Debbugs-submit" Resent-CC: larsi@gnus.org, bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Dec 2013 01:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16023 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 16023@debbugs.gnu.org Cc: Lars Magne Ingebrigtsen X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: Lars Magne Ingebrigtsen Received: via spool by submit@debbugs.gnu.org id=B.138594801614025 (code B ref -1); Mon, 02 Dec 2013 01:34:01 +0000 Received: (at submit) by debbugs.gnu.org; 2 Dec 2013 01:33:36 +0000 Received: from localhost ([127.0.0.1]:53703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VnIOF-0003e9-Pp for submit@debbugs.gnu.org; Sun, 01 Dec 2013 20:33:36 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47720) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VnIOD-0003dv-AU for submit@debbugs.gnu.org; Sun, 01 Dec 2013 20:33:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VnINz-0007kX-JZ for submit@debbugs.gnu.org; Sun, 01 Dec 2013 20:33:27 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:32947) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnINz-0007kT-GA for submit@debbugs.gnu.org; Sun, 01 Dec 2013 20:33:19 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49428) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnINq-0003oI-Ta for bug-gnu-emacs@gnu.org; Sun, 01 Dec 2013 20:33:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VnINi-0007jc-Fv for bug-gnu-emacs@gnu.org; Sun, 01 Dec 2013 20:33:10 -0500 Received: from mail-pb0-x22f.google.com ([2607:f8b0:400e:c01::22f]:39163) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnINi-0007jX-7n for bug-gnu-emacs@gnu.org; Sun, 01 Dec 2013 20:33:02 -0500 Received: by mail-pb0-f47.google.com with SMTP id um1so17806573pbc.34 for ; Sun, 01 Dec 2013 17:33:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=xCyLKxEx2ADQicY9rLUwPuy/DoEgo1S7xvxLvnPZDBA=; b=ZVTe1NaL4cICHBgYl39Tm/y/pHbJHV0zHIorolBElY4Hv4uyhfIB89MNESLiHaBCgj k4RVGp3QvGBF1pisHpmV/r6xb9iWFmQxU3f9Af3iXAJBg9cOBbJdw469LOJNGJjUlb1G ZqcC1m+K8hFvCGsrHtYKc0FspTs8e8QqP52duJXtQI5lkUFQRs7Iw0dgH3xMtunTpMIY 8SvE1Fq934m1lE0pOjNaI+9+BxDtAOYeOLAEihR3rTIRmAOKBosHUqz9tFsrYgfA5nze nymuKDW45XsutvM31sZnm9g/OsZ+0IQAlwCU2qeLhXEu/I5Geuwtnk6mN4CMk48g9cAa 05Yg== X-Received: by 10.68.225.9 with SMTP id rg9mr28573345pbc.122.1385947980503; Sun, 01 Dec 2013 17:33:00 -0800 (PST) Received: from Zeuss-MacBook.local ([123.119.93.169]) by mx.google.com with ESMTPSA id ka3sm118304034pbc.32.2013.12.01.17.32.58 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Dec 2013 17:32:59 -0800 (PST) From: Leo Liu Date: Mon, 02 Dec 2013 09:32:54 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) It seems inconvenient for a predicate to throw type error. I have used process-live-p a few times and was always surprised. It seems better to simply return nil for non-process arg. buffer-live-p does something similar. In octave.el, I have to use another one-liner (defun inferior-octave-process-live-p () (and inferior-octave-process (process-live-p inferior-octave-process))) to mitigate this problem which would be redundant if process-live-p doesn't throw error for non-process arg. So I wonder if you object to the following tweak: === modified file 'lisp/subr.el' --- lisp/subr.el 2013-11-24 08:49:44 +0000 +++ lisp/subr.el 2013-12-02 01:30:08 +0000 @@ -1885,9 +1885,11 @@ (defun process-live-p (process) "Returns non-nil if PROCESS is alive. A process is considered alive if its status is `run', `open', -`listen', `connect' or `stop'." - (memq (process-status process) - '(run open listen connect stop))) +`listen', `connect' or `stop'. Value is nil if PROCESS is not a +process." + (and (processp process) + (memq (process-status process) + '(run open listen connect stop)))) ;; compatibility Thanks, Leo From unknown Fri Jun 20 20:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16023: 24.3; [PATCH] process-live-p tweak Resent-From: Lars Magne Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Dec 2013 06:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16023 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Leo Liu Cc: 16023@debbugs.gnu.org Received: via spool by 16023-submit@debbugs.gnu.org id=B16023.138596705812644 (code B ref 16023); Mon, 02 Dec 2013 06:51:02 +0000 Received: (at 16023) by debbugs.gnu.org; 2 Dec 2013 06:50:58 +0000 Received: from localhost ([127.0.0.1]:53835 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VnNLN-0003Hr-79 for submit@debbugs.gnu.org; Mon, 02 Dec 2013 01:50:57 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:45276) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VnNLJ-0003Hd-LI for 16023@debbugs.gnu.org; Mon, 02 Dec 2013 01:50:54 -0500 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1VnNL0-0001Q0-U9; Mon, 02 Dec 2013 07:50:34 +0100 From: Lars Magne Ingebrigtsen References: Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAAFVBMVEX+/fGknKkoM35KUIj+ //Xt5tobJGiFqyDAAAACRklEQVQ4jW2UwbIaIRBFsZzJWoL4AVBhHeDpmleFeyYOs45Y8v+fkNsw o8mr3IWWHLqbbi4y1jWOGZK5ib2UOuSZT2OaeP+ZOQl7J8En4Zss1oNTSmn1RYgZlavFO+19X8I+ U9SBsZ3SUjy8aqBQrJFLB08vT1p7t2YxZ2ELwF493Hn3UMjVk91vWpRjA16n721/LcYY6axQx0CA u8Niqm/Hdj9unp9WYMV5Z9PWrLD8og4EtOX2PYQdItfjGt5BjNTv3vJTBwYA0wlDHCI+bhyZDE61 q/XeQASABOdVUfENtNUhBM5FUWZGcVNrllQhhhgYwKJUP26tT1QdKCQwNiW3AsxSY8hyQGU2HeJn 2SIAElvuKBPy8jt+UxvAPWW2lwkBdOH7DRRHgOUUQzPErw1op0xmY0bxMcXxDehb0kQCA4gd0EjI COc0hDhyjqFkakPNa8QzocFdfQygyxbRrhMgALBhlKe1RgMPcmWudzQuqT8zrMBkXCAX/DDSLUEv cE5wbpP4B6g7Ouvg9AY0TSMbgBFq2ziQr5ot7z2P7ZlUQoR2CKlKYvns7aWDuc8KbtZ24vQyVAfk XQKmajnROhzSwXbcgkckOjDlL0BPZ77hiYkGjCJfqVbb+5+j8FxcTKWIj94HSmD3iJnoS6m1mvIR YWKnDT0bd5j4yftS4ScCn955ygTl6eF9JVAJ4DClgwvWAaByjOzqtdPav4TqHSAioyr+G2Qb14Su cIMAecaLmUNsCvFqMUo/Rxa/Ks/XIcf/gFV/AOP0wHXR/8xvAAAAAElFTkSuQmCC X-Now-Playing: Multiplex's _Mixt_: "Secrete (Isan)" X-Hashcash: 1:23:131202:16023@debbugs.gnu.org::839BVRPj3esY/fvs:0000000000000000000000000000000000000000AJg3 X-Hashcash: 1:23:131202:sdl.web@gmail.com::FMBZI5iBpdCAHfDm:00000000000000000000000000000000000000000000s2M2 Date: Mon, 02 Dec 2013 07:50:34 +0100 In-Reply-To: (Leo Liu's message of "Mon, 02 Dec 2013 09:32:54 +0800") Message-ID: User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1VnNL0-0001Q0-U9 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1386571837.47415@8n1It0EfL2tqdogECOdjbQ X-Spam-Status: No X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Leo Liu writes: > It seems inconvenient for a predicate to throw type error. I have used > process-live-p a few times and was always surprised. It seems better to > simply return nil for non-process arg. buffer-live-p does something > similar. Seems like a good idea to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Fri Jun 20 20:00:17 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Leo Liu Subject: bug#16023: closed (Re: bug#16023: 24.3; [PATCH] process-live-p tweak) Message-ID: References: X-Gnu-PR-Message: they-closed 16023 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 16023@debbugs.gnu.org Date: Mon, 02 Dec 2013 07:48:03 +0000 Content-Type: multipart/mixed; boundary="----------=_1385970483-20651-1" This is a multi-part message in MIME format... ------------=_1385970483-20651-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #16023: 24.3; [PATCH] process-live-p tweak which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 16023@debbugs.gnu.org. --=20 16023: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D16023 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1385970483-20651-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 16023-done) by debbugs.gnu.org; 2 Dec 2013 07:47:23 +0000 Received: from localhost ([127.0.0.1]:53896 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VnODy-0005Lm-7B for submit@debbugs.gnu.org; Mon, 02 Dec 2013 02:47:22 -0500 Received: from mail-pd0-f176.google.com ([209.85.192.176]:37574) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VnODv-0005LU-Py for 16023-done@debbugs.gnu.org; Mon, 02 Dec 2013 02:47:20 -0500 Received: by mail-pd0-f176.google.com with SMTP id w10so17450374pde.21 for <16023-done@debbugs.gnu.org>; Sun, 01 Dec 2013 23:47:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:face:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=OVrxWJHMrPn6ZBYK+xb8YHSGlOxgJJvbN31Sa7K1r1U=; b=UouLmkynkSjJL4+x6X7syX+aJmal9A6DFo9ZQkmM4VBQl3Z0KOQigIb+NLcvxo4tNC 4MDpdNkVBkaibvVCSfuAoEXCAP103ACsAtEVE+AtD6Q1wMLqLxpnp0LNO4cKPfAPceQ4 5XFNXc1kUechr+Z/lNu0melqqZL3mrkf+bgjubq3KM835HJhiKPMIl5DMM5ijm21mETQ 4DsldT3Fx9+DDE5bT3NK8zill7NrT6BJ8kw9RMKtZm/AuIuk5f0/s9ew85BR8lAY/XN3 EFbgDriHWib42Q350auriOWMpxoHHtJkKovEGfLaJcATNi4vLA7EkJjyF2QKQ30l/4wc 6rmw== X-Received: by 10.68.170.66 with SMTP id ak2mr29936537pbc.5.1385970433719; Sun, 01 Dec 2013 23:47:13 -0800 (PST) Received: from Zeuss-MacBook.local (li679-91.members.linode.com. [23.239.1.91]) by mx.google.com with ESMTPSA id yi10sm136577326pab.8.2013.12.01.23.47.11 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Dec 2013 23:47:12 -0800 (PST) From: Leo Liu To: Lars Magne Ingebrigtsen Subject: Re: bug#16023: 24.3; [PATCH] process-live-p tweak References: Face: iVBORw0KGgoAAAANSUhEUgAAACgAAAAoBAMAAAB+0KVeAAAAMFBMVEUaFRZLMy1dTENxVzKQ WiCrXQ97cmO/dSqSh3akjGTApXy5sJ7Sxo/Sz8Xo6eP9//xJbkruAAAAAWJLR0QAiAUdSAAAAAlw SFlzAAACxQAAAsUBidZ/7wAAAAd0SU1FB9cBBwMJOwHXewoAAAIBSURBVCjPVdNBiNNAFADQ6J4F x3hThHZBBC+WCFI8SS0iezRDcMHLHkLAg6gJH/fgYQ9xYlj2sLK4KHgqCgXFhda2Idmr4kkQPZQ0 nkQMbTypbMmMM2m7ZgYSmMef/5OZPwo7HFnx3uKPcmj0Dht1LWZJ+Hvr7dIFZXRUwl9VRTuuKDJ+ U44gjscknK4hhJaCkYRsWjmBtLqXlJAG2wipNe18OZJu1BBq1E8xafl4s6Jq2mUZGftU1y7CCxnp FVUDWJXx4C66BKBnErbuoaYNtoRTu6EZBsCbMn7W+5qOAR6WvxNOby9jHWC9hAf3n304CdiAByXs 3Nh9roLDkyb/sWV712vYwaLSAn8CPMHIAAzOPDKP2COAFm4Y4ODVWc6xG7KXsN7UeUJjjimx2uwd gCgNhr0i8C/xyCD5CiCKAMY3Bf5oDzx//w/fimscdcAZU2jv9sedx6+nYPPFIoWI/GK6QZ+EFGOR ErAjCnV3vPZ7XqlTIMbOLY7fLcvvmT7rXNWaGDexIY44N12TG2PDp7vqyl57dnCeuWwyNpnEURxk fTbDYeBnKRn4oejPYI4sH6WviBumEZ/GxX4X/x6EcURFZ7E071bjQGAxpcOAEOJuTiroDEea5Szv rVWLYfl7ZiQwSUToxrkux7OLixAWGz22+HIyWTRYcVfomOwvzusfjtVIGgLHf3MAAAAASUVORK5C YII= Date: Mon, 02 Dec 2013 15:47:06 +0800 In-Reply-To: (Lars Magne Ingebrigtsen's message of "Mon, 02 Dec 2013 07:50:34 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (OS X 10.9) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 16023-done Cc: 16023-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Fixed in 24.4 On 2013-12-02 14:50 +0800, Lars Magne Ingebrigtsen wrote: [snipped 7 lines] > Seems like a good idea to me. done. Leo ------------=_1385970483-20651-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 2 Dec 2013 01:33:36 +0000 Received: from localhost ([127.0.0.1]:53703 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VnIOF-0003e9-Pp for submit@debbugs.gnu.org; Sun, 01 Dec 2013 20:33:36 -0500 Received: from eggs.gnu.org ([208.118.235.92]:47720) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VnIOD-0003dv-AU for submit@debbugs.gnu.org; Sun, 01 Dec 2013 20:33:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VnINz-0007kX-JZ for submit@debbugs.gnu.org; Sun, 01 Dec 2013 20:33:27 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_40,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:32947) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnINz-0007kT-GA for submit@debbugs.gnu.org; Sun, 01 Dec 2013 20:33:19 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49428) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnINq-0003oI-Ta for bug-gnu-emacs@gnu.org; Sun, 01 Dec 2013 20:33:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VnINi-0007jc-Fv for bug-gnu-emacs@gnu.org; Sun, 01 Dec 2013 20:33:10 -0500 Received: from mail-pb0-x22f.google.com ([2607:f8b0:400e:c01::22f]:39163) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VnINi-0007jX-7n for bug-gnu-emacs@gnu.org; Sun, 01 Dec 2013 20:33:02 -0500 Received: by mail-pb0-f47.google.com with SMTP id um1so17806573pbc.34 for ; Sun, 01 Dec 2013 17:33:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=xCyLKxEx2ADQicY9rLUwPuy/DoEgo1S7xvxLvnPZDBA=; b=ZVTe1NaL4cICHBgYl39Tm/y/pHbJHV0zHIorolBElY4Hv4uyhfIB89MNESLiHaBCgj k4RVGp3QvGBF1pisHpmV/r6xb9iWFmQxU3f9Af3iXAJBg9cOBbJdw469LOJNGJjUlb1G ZqcC1m+K8hFvCGsrHtYKc0FspTs8e8QqP52duJXtQI5lkUFQRs7Iw0dgH3xMtunTpMIY 8SvE1Fq934m1lE0pOjNaI+9+BxDtAOYeOLAEihR3rTIRmAOKBosHUqz9tFsrYgfA5nze nymuKDW45XsutvM31sZnm9g/OsZ+0IQAlwCU2qeLhXEu/I5Geuwtnk6mN4CMk48g9cAa 05Yg== X-Received: by 10.68.225.9 with SMTP id rg9mr28573345pbc.122.1385947980503; Sun, 01 Dec 2013 17:33:00 -0800 (PST) Received: from Zeuss-MacBook.local ([123.119.93.169]) by mx.google.com with ESMTPSA id ka3sm118304034pbc.32.2013.12.01.17.32.58 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 01 Dec 2013 17:32:59 -0800 (PST) From: Leo Liu To: bug-gnu-emacs@gnu.org Subject: 24.3; [PATCH] process-live-p tweak X-Debbugs-CC: Lars Magne Ingebrigtsen Date: Mon, 02 Dec 2013 09:32:54 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) It seems inconvenient for a predicate to throw type error. I have used process-live-p a few times and was always surprised. It seems better to simply return nil for non-process arg. buffer-live-p does something similar. In octave.el, I have to use another one-liner (defun inferior-octave-process-live-p () (and inferior-octave-process (process-live-p inferior-octave-process))) to mitigate this problem which would be redundant if process-live-p doesn't throw error for non-process arg. So I wonder if you object to the following tweak: === modified file 'lisp/subr.el' --- lisp/subr.el 2013-11-24 08:49:44 +0000 +++ lisp/subr.el 2013-12-02 01:30:08 +0000 @@ -1885,9 +1885,11 @@ (defun process-live-p (process) "Returns non-nil if PROCESS is alive. A process is considered alive if its status is `run', `open', -`listen', `connect' or `stop'." - (memq (process-status process) - '(run open listen connect stop))) +`listen', `connect' or `stop'. Value is nil if PROCESS is not a +process." + (and (processp process) + (memq (process-status process) + '(run open listen connect stop)))) ;; compatibility Thanks, Leo ------------=_1385970483-20651-1-- From unknown Fri Jun 20 20:00:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#16023: 24.3; [PATCH] process-live-p tweak Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 Dec 2013 14:34:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16023 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Leo Liu Cc: 16023@debbugs.gnu.org, Lars Magne Ingebrigtsen Received: via spool by 16023-submit@debbugs.gnu.org id=B16023.13859948373217 (code B ref 16023); Mon, 02 Dec 2013 14:34:03 +0000 Received: (at 16023) by debbugs.gnu.org; 2 Dec 2013 14:33:57 +0000 Received: from localhost ([127.0.0.1]:54180 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VnUZQ-0000pp-Ob for submit@debbugs.gnu.org; Mon, 02 Dec 2013 09:33:57 -0500 Received: from ironport2-out.teksavvy.com ([206.248.154.181]:51823) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VnUZK-0000pW-Qo for 16023@debbugs.gnu.org; Mon, 02 Dec 2013 09:33:51 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Av4EABK/CFFFpY5e/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDiGGcGYFegxU X-IPAS-Result: Av4EABK/CFFFpY5e/2dsb2JhbABEvw4Xc4IeAQEEAVYjBQsLDiYSFBgNJIgeBsEtkQoDiGGcGYFegxU X-IronPort-AV: E=Sophos;i="4.84,565,1355115600"; d="scan'208";a="40898222" Received: from 69-165-142-94.dsl.teksavvy.com (HELO pastel.home) ([69.165.142.94]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 02 Dec 2013 09:33:44 -0500 Received: by pastel.home (Postfix, from userid 20848) id 7FA1962D4B; Mon, 2 Dec 2013 09:33:44 -0500 (EST) From: Stefan Monnier Message-ID: References: Date: Mon, 02 Dec 2013 09:33:44 -0500 In-Reply-To: (Leo Liu's message of "Mon, 02 Dec 2013 09:32:54 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.3 (/) > It seems inconvenient for a predicate to throw type error. Generally agreed, and in this particular case as well, please go ahead, thank you, Stefan