From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 30 03:32:01 2013 Received: (at submit) by debbugs.gnu.org; 30 Nov 2013 08:32:01 +0000 Received: from localhost ([127.0.0.1]:51091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vmfy3-0003od-Uq for submit@debbugs.gnu.org; Sat, 30 Nov 2013 03:32:00 -0500 Received: from eggs.gnu.org ([208.118.235.92]:45628) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vmfy0-0003oQ-Cr for submit@debbugs.gnu.org; Sat, 30 Nov 2013 03:31:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vmfxq-0001Hs-3Z for submit@debbugs.gnu.org; Sat, 30 Nov 2013 03:31:51 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42396) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vmfxq-0001Ho-0d for submit@debbugs.gnu.org; Sat, 30 Nov 2013 03:31:46 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47344) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vmfxk-0000z8-QZ for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2013 03:31:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vmfxf-0001FN-Kh for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2013 03:31:40 -0500 Received: from mail-pb0-x22d.google.com ([2607:f8b0:400e:c01::22d]:39284) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vmfxf-0001FG-C8 for bug-gnu-emacs@gnu.org; Sat, 30 Nov 2013 03:31:35 -0500 Received: by mail-pb0-f45.google.com with SMTP id rp16so15638029pbb.4 for ; Sat, 30 Nov 2013 00:31:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version:content-type; bh=Glxd/NWi/+MkDjoDDjIf5yBhAiwBp7ZQmkZgBT1Te0o=; b=hPFZBMpZLHONCBR8eL0osBv+X69/qOVVt3MvgXw3QS0gYeW2S6FH2JblrOTiVwC4/H Z6na0maO24/ium8VnLbsKGUlIIUa1v3xWQaN/TuwWyDLpXkHxcP5F6hwvZ/y1GxHE/t0 EZQFWWerfZVAhv54OY1Y0KZDMz7cVYA2bKZT+uFbwQzEeIHrPap7yMp6UEdFGlw2kWbH 9mtizxN9D68cZL3foNKqeZoogX3JczqtbsOXvfsvnr3EyB+HlJwBjYmyBeHI9cJNkGvH lNlXS5or3DJX0cB77cBnvp+mtiNHP4CD3Jjb+VwGpFXsfsPetw99aMYoI0zURRJTQPWC qeaw== X-Received: by 10.68.196.69 with SMTP id ik5mr20379334pbc.132.1385800293938; Sat, 30 Nov 2013 00:31:33 -0800 (PST) Received: from localhost (cs178-201.anderson.ucla.edu. [164.67.178.201]) by mx.google.com with ESMTPSA id de1sm107350337pbc.7.2013.11.30.00.31.32 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sat, 30 Nov 2013 00:31:32 -0800 (PST) From: Vitalie Spinu To: bug-gnu-emacs@gnu.org Subject: [patch] 24.3.50; Typing in comint buffers inherits prompt text properties Date: Sat, 30 Nov 2013 00:31:31 -0800 Message-ID: <87haaumgt8.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain Hi, If comint-use-prompt-regexp is t typing in comint buffers inherits text properties from the prompt. See this screencast: http://screencast.com/t/xYa9KVWu7 You can also reproduce it by setting comint-use-prompt-regexp to t in shell buffers. Attached is the fix with minor reformatting of the adjacent code for the readability reasons. This was probably recently introduced when eliminating the overlays from comint buffers. Vitalie --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-add-rear-nonsticky-t-to-comint-prompt.patch >From 36dd963f3e7eb3a6775879aa98a24ca2221079bb Mon Sep 17 00:00:00 2001 From: Vitalie Spinu Date: Fri, 29 Nov 2013 23:25:55 -0800 Subject: [PATCH] add rear-nonsticky t to comint prompt make sure typing in comint buffers doesn't inherit comint-highlight-prompt face and other prompt properties. --- lisp/comint.el | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/lisp/comint.el b/lisp/comint.el index 3aff313..ee83918 100644 --- a/lisp/comint.el +++ b/lisp/comint.el @@ -2063,20 +2063,18 @@ Make backspaces delete the previous character." (with-silent-modifications (or (= (point-min) prompt-start) (get-text-property (1- prompt-start) 'read-only) - (put-text-property - (1- prompt-start) prompt-start 'read-only 'fence)) - (add-text-properties - prompt-start (point) - '(read-only t rear-nonsticky t front-sticky (read-only))))) + (put-text-property (1- prompt-start) prompt-start + 'read-only 'fence)) + (add-text-properties prompt-start (point) + '(read-only t front-sticky (read-only))))) (when comint-last-prompt (remove-text-properties (car comint-last-prompt) (cdr comint-last-prompt) '(font-lock-face))) (setq comint-last-prompt (cons (copy-marker prompt-start) (point-marker))) - (add-text-properties (car comint-last-prompt) - (cdr comint-last-prompt) - '(font-lock-face comint-highlight-prompt))) + (add-text-properties prompt-start (point) + '(rear-nonsticky t font-lock-face comint-highlight-prompt))) (goto-char saved-point))))))) (defun comint-preinput-scroll-to-bottom () -- 1.8.1.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Dec 20 01:26:06 2013 Received: (at 16010-done) by debbugs.gnu.org; 20 Dec 2013 06:26:06 +0000 Received: from localhost ([127.0.0.1]:59343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VttX9-0003im-Ed for submit@debbugs.gnu.org; Fri, 20 Dec 2013 01:26:04 -0500 Received: from mail-pd0-f169.google.com ([209.85.192.169]:58449) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VttX4-0003iG-Ei for 16010-done@debbugs.gnu.org; Fri, 20 Dec 2013 01:25:59 -0500 Received: by mail-pd0-f169.google.com with SMTP id v10so2137742pde.0 for <16010-done@debbugs.gnu.org>; Thu, 19 Dec 2013 22:25:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=HClabtkyYcCwvTyZYx3b/Oc9u7inZ15ZtezQA1Tum4Y=; b=DzpwhbMU+LN23Rqlx58aBxVZ/LzvOu+ffTHfQ6ZHZSOgZ2qqaOLXr62ZEDS3grct/9 Ohg7vE3B3DRDRUuQx+2wN4H2II2/eKrh+1oIi/tH/cw0kTJWNFxtLSKHl2YgIJ+sSLpz Mo/3bTH/FODzcC9yFllHyrzhAr3ET1Jj5VzsxAl16pOi4gVFXiyDex4oyl7zXpunhOF6 r89rV+dR2FkF5kgBCtv1rmq5tDnFEJtc0E2ttZj5rm23cVWK4CYsm+Sz7vsU40PeVRNX B3iYV8q7TNJfxGGGlxORijumXPKkaoynfFVqup09E5lFmBxA0WsKSgXL7oD4FewxdCmP 5LPg== X-Received: by 10.66.164.136 with SMTP id yq8mr6549101pab.67.1387520757452; Thu, 19 Dec 2013 22:25:57 -0800 (PST) Received: from tsparkle ([155.69.16.30]) by mx.google.com with ESMTPSA id rz6sm15336540pab.22.2013.12.19.22.25.54 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Dec 2013 22:25:56 -0800 (PST) From: Chong Yidong To: Vitalie Spinu Subject: Re: bug#16010: [patch] 24.3.50; Typing in comint buffers inherits prompt text properties References: <87haaumgt8.fsf@gmail.com> Date: Fri, 20 Dec 2013 14:25:52 +0800 In-Reply-To: <87haaumgt8.fsf@gmail.com> (Vitalie Spinu's message of "Sat, 30 Nov 2013 00:31:31 -0800") Message-ID: <87r49811jj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 16010-done Cc: 16010-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Vitalie Spinu writes: > If comint-use-prompt-regexp is t typing in comint buffers inherits text > properties from the prompt. See this screencast: > http://screencast.com/t/xYa9KVWu7 > > You can also reproduce it by setting comint-use-prompt-regexp to t in > shell buffers. > > Attached is the fix with minor reformatting of the adjacent code for the > readability reasons. Thanks, look correct; committed to trunk. From unknown Thu Sep 11 06:33:52 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 17 Jan 2014 12:24:02 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator