Subject: bug#16001: closed (Re: bug#16001: [5ef95e85] fails to build with --enable-gcc-warnings in some configurations)

From: [email-masked] (GNU bug Tracking System)
Date: Sat, 30 Nov 2013 13:33:02 +0000

Your bug report

#16001: [5ef95e85] fails to build with --enable-gcc-warnings in some configurations

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
16001: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=16001
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#16001: [5ef95e85] fails to build with --enable-gcc-warnings in some configurations
From: Jan Djärv <[email-masked]>
To: Ivan Shmakov <[email-masked]>
Cc: [email-masked]
Date: Sat, 30 Nov 2013 14:32:30 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello.

There are lot of new errors in window.c, xterm.c and xdisp.c after the pixelwise resize checkin, so this report is kind of obsolete.  But I checked in fixes for the issues below.

	Jan D.

29 nov 2013 kl. 18:02 skrev Ivan Shmakov <[email-masked]>:

> 	As of 5ef95e85, building with GCC 4.8.2, --enable-gcc-warnings,
> 	--without-x-toolkit, and GnuTLS 2, fails with:
> 
> ../../src/xfaces.c:914:0: error: macro "NEAR_SAME_COLOR_THRESHOLD" is not used [-Werror=unused-macros]
> #define NEAR_SAME_COLOR_THRESHOLD 30000
> ^
> cc1: all warnings being treated as errors
> 
> ../../src/gnutls.c:266:1: error: 'gnutls_audit_log_function' defined but not used [-Werror=unused-function]
> gnutls_audit_log_function (gnutls_session_t session, const char* string)
> ^
> cc1: all warnings being treated as errors
> 
> 	The causes are:
> 
> 	• the NEAR_SAME_COLOR_THRESHOLD macro’s definition is not
> 	  properly guarded with #ifdef HAVE_WINDOW_SYSTEM;
> 
> 	• both the declaration and the definition of
> 	  gnutls_audit_log_function () are not properly guarded with
> 	  #ifdef HAVE_GNUTLS3.
> 
> 	Adding the respective guards fixes both of the GCC errors.
> 
> 	The issue seem not to be fixed in e7203144, either.
> 
> -- 
> FSF associate member #7257
> 
> 

Subject: [5ef95e85] fails to build with --enable-gcc-warnings in some configurations
From: Ivan Shmakov <[email-masked]>
To: [email-masked]
Cc: Ivan Shmakov <[email-masked]>
Date: Fri, 29 Nov 2013 17:02:24 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

	As of 5ef95e85, building with GCC 4.8.2, --enable-gcc-warnings,
	--without-x-toolkit, and GnuTLS 2, fails with:

../../src/xfaces.c:914:0: error: macro "NEAR_SAME_COLOR_THRESHOLD" is not used [-Werror=unused-macros]
 #define NEAR_SAME_COLOR_THRESHOLD 30000
 ^
cc1: all warnings being treated as errors

../../src/gnutls.c:266:1: error: 'gnutls_audit_log_function' defined but not used [-Werror=unused-function]
 gnutls_audit_log_function (gnutls_session_t session, const char* string)
 ^
cc1: all warnings being treated as errors

	The causes are:

	• the NEAR_SAME_COLOR_THRESHOLD macro’s definition is not
	  properly guarded with #ifdef HAVE_WINDOW_SYSTEM;

	• both the declaration and the definition of
	  gnutls_audit_log_function () are not properly guarded with
	  #ifdef HAVE_GNUTLS3.

	Adding the respective guards fixes both of the GCC errors.

	The issue seem not to be fixed in e7203144, either.

-- 
FSF associate member #7257