GNU bug report logs - #15970
[Bug-tar] Crash in gettext() after fork() on Mac OS X

Previous Next

Full log

Message #11 received at 15970 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Pádraig Brady <P <at> draigBrady.com>
Cc: 15970 <at> debbugs.gnu.org, bug-tar <at> gnu.org
Subject: Re: bug#15970: [Bug-tar] Crash in gettext() after fork() on Mac OS X
Date: Mon, 25 Nov 2013 20:55:29 -0800

Pádraig Brady wrote:

> How about the attached instead that just uses
> a somewhat degraded but simpler error() equivalent.

That looks safe, though it could be simplified:
use inttostr instead of repeating its body,
and since !!p == !!errnum there's no need
to have those duplicate conditions.
Plus, just use STDERR_FILENO rather than
fiddling with fileno (stderr), and async_safe_error
should be _Noreturn and should unconditionally call
_exit.  And, I wouldn't bother looking at dup2's
return value, any more than we look at close's.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.