GNU bug report logs - #15965
24.3.50; [PATCH] eww: ask confirmation before quitting

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ted Zlatanov <tzz <at> lifelogs.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#15965: closed (24.3.50; [PATCH] eww: ask confirmation before
 quitting)
Date: Tue, 26 Nov 2013 20:10:05 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 26 Nov 2013 15:10:31 -0500
with message-id <8761rezzyg.fsf <at> flea.lifelogs.com>
and subject line Re: bug#15966: bug#15967: 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened, bug#15966: 24.3.50; [PATCH] eww: ask confirmation when add bookmarks, bug#15965: 24.3.50; [PATCH] eww: ask confirmation before quitting, bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after ewwstarts.s.
has caused the debbugs.gnu.org bug report #15965,
regarding 24.3.50; [PATCH] eww: ask confirmation before quitting
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
15965: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15965
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Kenjiro NAKAYAMA <knakayam <at> redhat.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; [PATCH] eww: ask confirmation before quitting
Date: Sun, 24 Nov 2013 23:12:47 +0900

eww should ask "yes or no" before quitting, since only "q" key to quit is
easy to mistake.

Signed-off-by: Kenjiro NAKAYAMA <knakayam <at> redhat.com>

        * net/eww.el (eww-quit): ask confirmation before quitting eww

---
 lisp/net/eww.el | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 86e0977..265f6c8 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -403,8 +403,10 @@ word(s) will be searched for via `eww-search-prefix'."
 (defun eww-quit ()
   "Exit the Emacs Web Wowser."
   (interactive)
-  (setq eww-history nil)
-  (kill-buffer (current-buffer)))
+  (if (y-or-n-p "quit eww? ")
+      (progn
+       (setq eww-history nil)
+       (kill-buffer (current-buffer)))))

 (defun eww-back-url ()
   "Go to the previously displayed page."
-- 
1.8.3.1

[Message part 3 (message/rfc822, inline)]

From: Ted Zlatanov <tzz <at> lifelogs.com>
To: Kenjiro NAKAYAMA <knakayam <at> redhat.com>
Cc: 15965-done <at> debbugs.gnu.org, Kenjiro NAKAYAMA <nakayamakenjiro <at> gmail.com>,
 15966-done <at> debbugs.gnu.org, 15910-done <at> debbugs.gnu.org,
 15967-done <at> debbugs.gnu.org
Subject: Re: bug#15966: bug#15967: 24.3.50;
 [PATCH] eww: use eww-browse-url, when url in bookmark list is opened,
 bug#15966: 24.3.50;
 [PATCH] eww: ask confirmation when add bookmarks, bug#15965: 24.3.50;
 [PATCH] eww: ask confirmation before quitting, bug#15910: 24.3.50;
 [PATCH] eww: Current URL is not entered automatically, after ewwstarts.s.
Date: Tue, 26 Nov 2013 15:10:31 -0500

On Tue, 26 Nov 2013 20:51:49 +0900 Kenjiro NAKAYAMA <knakayam <at> redhat.com> wrote: 

KN> I consolidated the patches, please include the patch if appreciated.

OK; done.  I changed "add bookmark this page?" to "bookmark this page?"
but otherwise had no issues.

Thanks!
Ted

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.