Subject: bug#15965: closed (Re: bug#15966: bug#15967: 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened, bug#15966: 24.3.50; [PATCH] eww: ask confirmation when add bookmarks, bug#15965: 24.3.50; [PATCH] eww: ask confirmation before quitting, bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after ewwstarts.s.)

From: [email-masked] (GNU bug Tracking System)
Date: Tue, 26 Nov 2013 20:10:06 +0000

Your bug report

#15965: 24.3.50; [PATCH] eww: ask confirmation before quitting

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
15965: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15965
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#15966: bug#15967: 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened, bug#15966: 24.3.50; [PATCH] eww: ask confirmation when add bookmarks, bug#15965: 24.3.50; [PATCH] eww: ask confirmation before quitting, bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after ewwstarts.s.
From: Ted Zlatanov <[email-masked]>
To: Kenjiro NAKAYAMA <[email-masked]>
Cc: [email-masked], Kenjiro NAKAYAMA <[email-masked]>, [email-masked], [email-masked], [email-masked]
Date: Tue, 26 Nov 2013 15:10:31 -0500
List-Id: <debbugs-submit.debbugs.gnu.org>

On Tue, 26 Nov 2013 20:51:49 +0900 Kenjiro NAKAYAMA <[email-masked]> wrote: 

KN> I consolidated the patches, please include the patch if appreciated.

OK; done.  I changed "add bookmark this page?" to "bookmark this page?"
but otherwise had no issues.

Thanks!
Ted

Subject: 24.3.50; [PATCH] eww: ask confirmation before quitting
From: Kenjiro NAKAYAMA <[email-masked]>
To: [email-masked]
Date: Sun, 24 Nov 2013 23:12:47 +0900
List-Id: <debbugs-submit.debbugs.gnu.org>

eww should ask "yes or no" before quitting, since only "q" key to quit is
easy to mistake.

Signed-off-by: Kenjiro NAKAYAMA <[email-masked]>

        * net/eww.el (eww-quit): ask confirmation before quitting eww

---
 lisp/net/eww.el | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 86e0977..265f6c8 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -403,8 +403,10 @@ word(s) will be searched for via `eww-search-prefix'."
 (defun eww-quit ()
   "Exit the Emacs Web Wowser."
   (interactive)
-  (setq eww-history nil)
-  (kill-buffer (current-buffer)))
+  (if (y-or-n-p "quit eww? ")
+      (progn
+       (setq eww-history nil)
+       (kill-buffer (current-buffer)))))

 (defun eww-back-url ()
   "Go to the previously displayed page."
-- 
1.8.3.1