From unknown Sat Aug 16 21:17:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#15965: 24.3.50; [PATCH] eww: ask confirmation before quitting Resent-From: Kenjiro NAKAYAMA Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 24 Nov 2013 15:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 15965 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 15965@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.138530749513482 (code B ref -1); Sun, 24 Nov 2013 15:39:01 +0000 Received: (at submit) by debbugs.gnu.org; 24 Nov 2013 15:38:15 +0000 Received: from localhost ([127.0.0.1]:42247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VkblF-0003VM-Ir for submit@debbugs.gnu.org; Sun, 24 Nov 2013 10:38:14 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41280) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VkaR7-0001NA-S6 for submit@debbugs.gnu.org; Sun, 24 Nov 2013 09:13:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VkaQt-0003Yy-UR for submit@debbugs.gnu.org; Sun, 24 Nov 2013 09:13:16 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:38225) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkaQt-0003Yu-RW for submit@debbugs.gnu.org; Sun, 24 Nov 2013 09:13:07 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42972) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkaQn-0001J8-Q2 for bug-gnu-emacs@gnu.org; Sun, 24 Nov 2013 09:13:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VkaQh-0003WY-8R for bug-gnu-emacs@gnu.org; Sun, 24 Nov 2013 09:13:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49023) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkaQh-0003WT-0K for bug-gnu-emacs@gnu.org; Sun, 24 Nov 2013 09:12:55 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAOECriM019549 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 24 Nov 2013 09:12:54 -0500 Received: from dhcp-193-97.nrt.redhat.com (ovpn-116-17.sin2.redhat.com [10.67.116.17]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rAOECmDO021656 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) for ; Sun, 24 Nov 2013 09:12:52 -0500 User-agent: mu4e 0.9.9.6pre2; emacs 24.3.50.2 From: Kenjiro NAKAYAMA Date: Sun, 24 Nov 2013 23:12:47 +0900 Message-ID: <87hab1riqo.fsf@dhcp-193-97.nrt.redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Mailman-Approved-At: Sun, 24 Nov 2013 10:38:11 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) eww should ask "yes or no" before quitting, since only "q" key to quit is easy to mistake. Signed-off-by: Kenjiro NAKAYAMA * net/eww.el (eww-quit): ask confirmation before quitting eww --- lisp/net/eww.el | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 86e0977..265f6c8 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -403,8 +403,10 @@ word(s) will be searched for via `eww-search-prefix'." (defun eww-quit () "Exit the Emacs Web Wowser." (interactive) - (setq eww-history nil) - (kill-buffer (current-buffer))) + (if (y-or-n-p "quit eww? ") + (progn + (setq eww-history nil) + (kill-buffer (current-buffer))))) (defun eww-back-url () "Go to the previously displayed page." -- 1.8.3.1 From unknown Sat Aug 16 21:17:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#15965: bug#15967: 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened, bug#15966: 24.3.50; [PATCH] eww: ask confirmation when add bookmarks, bug#15965: 24.3.50; [PATCH] eww: ask confirmation before quitting, bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after ewwstarts.s. Resent-From: Ted Zlatanov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 25 Nov 2013 14:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15965 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Kenjiro NAKAYAMA Cc: 15910@debbugs.gnu.org, Kenjiro NAKAYAMA , 15966@debbugs.gnu.org, 15967@debbugs.gnu.org, 15965@debbugs.gnu.org Received: via spool by 15965-submit@debbugs.gnu.org id=B15965.138539123228917 (code B ref 15965); Mon, 25 Nov 2013 14:54:02 +0000 Received: (at 15965) by debbugs.gnu.org; 25 Nov 2013 14:53:52 +0000 Received: from localhost ([127.0.0.1]:43908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VkxXr-0007WF-CB for submit@debbugs.gnu.org; Mon, 25 Nov 2013 09:53:51 -0500 Received: from mail-qa0-f54.google.com ([209.85.216.54]:58973) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VkxXk-0007VV-Ih for 15965@debbugs.gnu.org; Mon, 25 Nov 2013 09:53:45 -0500 Received: by mail-qa0-f54.google.com with SMTP id f11so7636741qae.6 for <15965@debbugs.gnu.org>; Mon, 25 Nov 2013 06:53:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=qWUNK7tujuvY1LeWael8BAImYMcDGKq1z4bF0sqq/HQ=; b=K+ruOlrRhxTtrsMfUMCmYSr6vdZxEl19MxXAaluBAvrXrfowd3t4mSU77UWUkhd3la qaIVtTCRbdrZMWqZA7iYZkhq6FbrlWrWhUdCusgW74ZAMwnY29uDu8qyS657txjexA9a EHKigiWVus+rMKNfk2P8DUBrCYX0tUcoPsMrs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=qWUNK7tujuvY1LeWael8BAImYMcDGKq1z4bF0sqq/HQ=; b=HRm5d6KhCJcDmNxAXX4MLv+d8Xx57qEo30Gcps982J7caBgVNjxpAUyPqp6YBllA9J 1INXiODQcqR3ObZhN9qJ93WsdUz9wtgRPYnw2gADKMIyAJkptsSvie8DLI/N5aVsm3fm 8QqKgN+aJH6RIbtMPuA3IGaFjz+LT7X2iAuylJOyd58LMrKfCh87/e7LGSM94qBHwlRO WPp7lc/LJo63nPauknqucHdBV7K62N0au4ddvvnLht6vtHdurfgX9ulk2NuMjZTZ7kfe e/LmuQlq9wCrD8Uma+L1EqfjbLLX1Fooo8XuvCB7+9HsDBT2YMZ/gJyHSwTG7fU+ckwa k4tA== X-Gm-Message-State: ALoCoQka4GuZ+c9L1jqcRxHfnLBbIoSn0KiYHrFclxsNOkT+EciC9DVQQbhHDG9TVoCHLeIF2ZVM X-Received: by 10.229.182.69 with SMTP id cb5mr46240214qcb.19.1385391218892; Mon, 25 Nov 2013 06:53:38 -0800 (PST) Received: from flea.lifelogs.com (c-98-229-61-72.hsd1.ma.comcast.net. [98.229.61.72]) by mx.google.com with ESMTPSA id b4sm8193641qai.7.2013.11.25.06.53.37 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Nov 2013 06:53:38 -0800 (PST) From: Ted Zlatanov Organization: =?UTF-8?Q?=D0=A2=D0=B5=D0=BE=D0=B4=D0=BE=D1=80_?= =?UTF-8?Q?=D0=97=D0=BB=D0=B0=D1=82=D0=B0=D0=BD=D0=BE=D0=B2?= @ Cienfuegos References: <87ppq0txqo.fsf@dhcp-193-97.nrt.redhat.com> <20131122.122659.378621581576481664.yamato@redhat.com> <87r4a88lbf.fsf@flea.lifelogs.com> <87txf1j0ev.fsf@dhcp-193-97.nrt.redhat.com> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Mon, 25 Nov 2013 09:54:32 -0500 In-Reply-To: <87txf1j0ev.fsf@dhcp-193-97.nrt.redhat.com> (Kenjiro NAKAYAMA's message of "Mon, 25 Nov 2013 00:15:52 +0900, Sun, 24 Nov 2013 23:41:44 +0900, Sun, 24 Nov 2013 23:12:47 +0900, Mon, 25 Nov 2013 00:57:33 +0900") Message-ID: <87bo18351z.fsf@flea.lifelogs.com> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Thank you for the patches. All of them are OK to go in IMO (and tiny changes). Could you consolidate them in a single patch with a ChangeLog please? It can wait for your eww history stack changes or can be submitted sooner. Thanks Ted On Mon, 25 Nov 2013 00:15:52 +0900 Kenjiro NAKAYAMA wrote: KN> Since eww-bookmark-browse doesn't use eww-browse-url to open its url, it KN> doesn't save current URL in eww-history. KN> Signed-off-by: Kenjiro NAKAYAMA KN> * net/eww.el (eww-bookmark-browse): Use 'eww-browse-url'. On Sun, 24 Nov 2013 23:41:44 +0900 Kenjiro NAKAYAMA wrote: KN> eww should ask "yes or no" when add current page to bookmarks, since KN> only "b" key to add bookmarks is easy to mistake. KN> (My bookmarklist has amazingly increased.) KN> Signed-off-by: Kenjiro NAKAYAMA KN> * net/eww.el (eww-add-bookmark): ask confirmation when add to bookmarks On Sun, 24 Nov 2013 23:12:47 +0900 Kenjiro NAKAYAMA wrote: KN> eww should ask "yes or no" before quitting, since only "q" key to quit is KN> easy to mistake. KN> Signed-off-by: Kenjiro NAKAYAMA KN> * net/eww.el (eww-quit): ask confirmation before quitting eww On Mon, 25 Nov 2013 00:57:33 +0900 Kenjiro NAKAYAMA wrote: KN> Thank you for your review, Ted, Masatake. KN> OK, I try to revise the patch to add eww own history stack. KN> And I put ChangeLog entry to my report next time. From unknown Sat Aug 16 21:17:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#15965: bug#15967: 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened, bug#15966: 24.3.50; [PATCH] eww: ask confirmation when add bookmarks, bug#15965: 24.3.50; [PATCH] eww: ask confirmation before quitting, bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after ewwstarts.s. Resent-From: Kenjiro NAKAYAMA Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 26 Nov 2013 11:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15965 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Ted Zlatanov Cc: Kenjiro NAKAYAMA , 15966@debbugs.gnu.org, 15967@debbugs.gnu.org, 15965@debbugs.gnu.org, 15910@debbugs.gnu.org, Kenjiro NAKAYAMA Received: via spool by 15965-submit@debbugs.gnu.org id=B15965.13854667293909 (code B ref 15965); Tue, 26 Nov 2013 11:53:02 +0000 Received: (at 15965) by debbugs.gnu.org; 26 Nov 2013 11:52:09 +0000 Received: from localhost ([127.0.0.1]:45471 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlHBY-00010x-Pc for submit@debbugs.gnu.org; Tue, 26 Nov 2013 06:52:09 -0500 Received: from mx1.redhat.com ([209.132.183.28]:28909) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlHBT-00010D-90; Tue, 26 Nov 2013 06:52:04 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAQBq0r8023039 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 26 Nov 2013 06:52:00 -0500 Received: from dhcp-193-97.nrt.redhat.com (ovpn-116-21.sin2.redhat.com [10.67.116.21]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rAQBpoPU016999 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Tue, 26 Nov 2013 06:51:57 -0500 References: <87ppq0txqo.fsf@dhcp-193-97.nrt.redhat.com> <20131122.122659.378621581576481664.yamato@redhat.com> <87r4a88lbf.fsf@flea.lifelogs.com> <87txf1j0ev.fsf@dhcp-193-97.nrt.redhat.com> <87bo18351z.fsf@flea.lifelogs.com> User-agent: mu4e 0.9.9.6pre2; emacs 24.3.50.3 From: Kenjiro NAKAYAMA In-reply-to: <87bo18351z.fsf@flea.lifelogs.com> Date: Tue, 26 Nov 2013 20:51:49 +0900 Message-ID: <87haazxtwq.fsf@dhcp-193-97.nrt.redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Thanks, Ted. I consolidated the patches, please include the patch if appreciated. Signed-off-by: Kenjiro NAKAYAMA * net/eww.el (eww-bookmark-browse): Use 'eww-browse-url'. (eww-add-bookmark): ask confirmation when add to bookmarks (eww-quit): ask confirmation before quitting eww --- lisp/net/eww.el | 26 +++++++++++++++----------- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 86e0977..4b8b067 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -403,8 +403,10 @@ word(s) will be searched for via `eww-search-prefix'." (defun eww-quit () "Exit the Emacs Web Wowser." (interactive) - (setq eww-history nil) - (kill-buffer (current-buffer))) + (if (y-or-n-p "quit eww? ") + (progn + (setq eww-history nil) + (kill-buffer (current-buffer))))) (defun eww-back-url () "Go to the previously displayed page." @@ -964,14 +966,16 @@ The browser to used is specified by the `shr-external-browser' variable." (when (equal eww-current-url (plist-get bookmark :url)) (error "Already bookmarked"))) - (let ((title (replace-regexp-in-string "[\n\t\r]" " " eww-current-title))) - (setq title (replace-regexp-in-string "\\` +\\| +\\'" "" title)) - (push (list :url eww-current-url - :title title - :time (current-time-string)) - eww-bookmarks)) - (eww-write-bookmarks) - (message "Bookmarked %s (%s)" eww-current-url eww-current-title)) + (if (y-or-n-p "add bookmark this page? ") + (progn + (let ((title (replace-regexp-in-string "[\n\t\r]" " " eww-current-title))) + (setq title (replace-regexp-in-string "\\` +\\| +\\'" "" title)) + (push (list :url eww-current-url + :title title + :time (current-time-string)) + eww-bookmarks)) + (eww-write-bookmarks) + (message "Bookmarked %s (%s)" eww-current-url eww-current-title)))) (defun eww-write-bookmarks () (with-temp-file (expand-file-name "eww-bookmarks" user-emacs-directory) @@ -1063,7 +1067,7 @@ The browser to used is specified by the `shr-external-browser' variable." ;; just let it remain. (ignore-errors (delete-window)) - (eww (plist-get bookmark :url)))) + (eww-browse-url (plist-get bookmark :url)))) (defun eww-next-bookmark () "Go to the next bookmark in the list." -- 1.8.3.1 Thanks, Kenjiro Nakayama tzz@lifelogs.com writes: > Thank you for the patches. All of them are OK to go in IMO (and tiny > changes). Could you consolidate them in a single patch with a ChangeLog > please? It can wait for your eww history stack changes or can be > submitted sooner. > > Thanks > Ted > > On Mon, 25 Nov 2013 00:15:52 +0900 Kenjiro NAKAYAMA wrote: > > KN> Since eww-bookmark-browse doesn't use eww-browse-url to open its url, it > KN> doesn't save current URL in eww-history. > > KN> Signed-off-by: Kenjiro NAKAYAMA > > KN> * net/eww.el (eww-bookmark-browse): Use 'eww-browse-url'. > > On Sun, 24 Nov 2013 23:41:44 +0900 Kenjiro NAKAYAMA wrote: > > KN> eww should ask "yes or no" when add current page to bookmarks, since > KN> only "b" key to add bookmarks is easy to mistake. > KN> (My bookmarklist has amazingly increased.) > > KN> Signed-off-by: Kenjiro NAKAYAMA > > KN> * net/eww.el (eww-add-bookmark): ask confirmation when add to bookmarks > > On Sun, 24 Nov 2013 23:12:47 +0900 Kenjiro NAKAYAMA wrote: > > KN> eww should ask "yes or no" before quitting, since only "q" key to quit is > KN> easy to mistake. > > KN> Signed-off-by: Kenjiro NAKAYAMA > > KN> * net/eww.el (eww-quit): ask confirmation before quitting eww > > On Mon, 25 Nov 2013 00:57:33 +0900 Kenjiro NAKAYAMA wrote: > > KN> Thank you for your review, Ted, Masatake. > > KN> OK, I try to revise the patch to add eww own history stack. > KN> And I put ChangeLog entry to my report next time. From unknown Sat Aug 16 21:17:45 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.503 (Entity 5.503) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Kenjiro NAKAYAMA Subject: bug#15965: closed (Re: bug#15966: bug#15967: 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened, bug#15966: 24.3.50; [PATCH] eww: ask confirmation when add bookmarks, bug#15965: 24.3.50; [PATCH] eww: ask confirmation before quitting, bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after ewwstarts.s.) Message-ID: References: <8761rezzyg.fsf@flea.lifelogs.com> <87hab1riqo.fsf@dhcp-193-97.nrt.redhat.com> X-Gnu-PR-Message: they-closed 15965 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 15965@debbugs.gnu.org Date: Tue, 26 Nov 2013 20:10:06 +0000 Content-Type: multipart/mixed; boundary="----------=_1385496606-29356-1" This is a multi-part message in MIME format... ------------=_1385496606-29356-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #15965: 24.3.50; [PATCH] eww: ask confirmation before quitting which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 15965@debbugs.gnu.org. --=20 15965: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D15965 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1385496606-29356-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 15965-done) by debbugs.gnu.org; 26 Nov 2013 20:09:44 +0000 Received: from localhost ([127.0.0.1]:46404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlOx5-0007cC-NB for submit@debbugs.gnu.org; Tue, 26 Nov 2013 15:09:44 -0500 Received: from mail-qa0-f42.google.com ([209.85.216.42]:49928) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VlOx3-0007bd-7n for 15965-done@debbugs.gnu.org; Tue, 26 Nov 2013 15:09:41 -0500 Received: by mail-qa0-f42.google.com with SMTP id k4so4865078qaq.15 for <15965-done@debbugs.gnu.org>; Tue, 26 Nov 2013 12:09:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lifelogs.com; s=google; h=from:to:cc:subject:organization:references:mail-copies-to :gmane-reply-to-list:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=lbS17yWHObDqu32QyHYDdVN/OFwbTByvzNzVziwMtAY=; b=Hkb6PKwxO57q0L8wnH6hCAY9qabknhoGuYsxUeddCYb4tZQL/IR5MzsFt60OXyTTcx E+e6jlKR4EGptjbPqv/uIygBPGvVoue7h1szabW6LfF6dXnukieihEpVt3i6fWFet8Cz SUeK17WED0r6cnEWcunPD87sAlgi7v8DDG4xU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:organization:references :mail-copies-to:gmane-reply-to-list:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=lbS17yWHObDqu32QyHYDdVN/OFwbTByvzNzVziwMtAY=; b=TUUoYu1ff98xGnow8ua5ebvRpkCVfQfQc2G760BaTx+ZkHjKDxwXqYjBI10vMf8dn3 fowz44lacGmv9TZAbmsh2smHq8kwcmZjEfiFMZUyoDkxA6oPhXNhHeofsprZChCAAnDQ 0iKj88ft7rrrgoOiqCoRzr+IVrafT6rdk56RlWuzsCUVBpqututVqY8QZZGqOIR6OMTG jE5V5dVylRrqtfVRMokuhAn4QfkfckHhbl3fMmpQiNH1bMmrE7dVGceiGfXj51KEgfOa gvW5oswrX+JGC7tR/WwoxA8DpjShAC1cond0jz8wxC4W5S2GSKck8sPCnHOZR/HbNqa6 ooBA== X-Gm-Message-State: ALoCoQkGEe5tEASwAy5UmxNmVeeWg+C7xt26k7vbof7EOgnZ0ylRmnUNTjINocv4WzUqcpdV+ECA X-Received: by 10.224.72.15 with SMTP id k15mr59681105qaj.58.1385496575754; Tue, 26 Nov 2013 12:09:35 -0800 (PST) Received: from flea.lifelogs.com (c-98-229-61-72.hsd1.ma.comcast.net. [98.229.61.72]) by mx.google.com with ESMTPSA id m7sm25993436qax.8.2013.11.26.12.09.34 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Nov 2013 12:09:35 -0800 (PST) From: Ted Zlatanov To: Kenjiro NAKAYAMA Subject: Re: bug#15966: bug#15967: 24.3.50; [PATCH] eww: use eww-browse-url, when url in bookmark list is opened, bug#15966: 24.3.50; [PATCH] eww: ask confirmation when add bookmarks, bug#15965: 24.3.50; [PATCH] eww: ask confirmation before quitting, bug#15910: 24.3.50; [PATCH] eww: Current URL is not entered automatically, after ewwstarts.s. Organization: =?utf-8?B?0KLQtdC+0LTQvtGAINCX0LvQsNGC0LDQvdC+0LI=?= @ Cienfuegos References: <87ppq0txqo.fsf@dhcp-193-97.nrt.redhat.com> <20131122.122659.378621581576481664.yamato@redhat.com> <87r4a88lbf.fsf@flea.lifelogs.com> <87txf1j0ev.fsf@dhcp-193-97.nrt.redhat.com> <87bo18351z.fsf@flea.lifelogs.com> <87haazxtwq.fsf@dhcp-193-97.nrt.redhat.com> X-Face: bd.DQ~'29fIs`T_%O%C\g%6jW)yi[zuz6; d4V0`@y-~$#3P_Ng{@m+e4o<4P'#(_GJQ%TT= D}[Ep*b!\e,fBZ'j_+#"Ps?s2!4H2-Y"sx" Mail-Copies-To: never Gmane-Reply-To-List: yes Date: Tue, 26 Nov 2013 15:10:31 -0500 In-Reply-To: <87haazxtwq.fsf@dhcp-193-97.nrt.redhat.com> (Kenjiro NAKAYAMA's message of "Tue, 26 Nov 2013 20:51:49 +0900") Message-ID: <8761rezzyg.fsf@flea.lifelogs.com> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 15965-done Cc: 15965-done@debbugs.gnu.org, Kenjiro NAKAYAMA , 15966-done@debbugs.gnu.org, 15910-done@debbugs.gnu.org, 15967-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) On Tue, 26 Nov 2013 20:51:49 +0900 Kenjiro NAKAYAMA wrote: KN> I consolidated the patches, please include the patch if appreciated. OK; done. I changed "add bookmark this page?" to "bookmark this page?" but otherwise had no issues. Thanks! Ted ------------=_1385496606-29356-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 24 Nov 2013 15:38:15 +0000 Received: from localhost ([127.0.0.1]:42247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VkblF-0003VM-Ir for submit@debbugs.gnu.org; Sun, 24 Nov 2013 10:38:14 -0500 Received: from eggs.gnu.org ([208.118.235.92]:41280) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1VkaR7-0001NA-S6 for submit@debbugs.gnu.org; Sun, 24 Nov 2013 09:13:23 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VkaQt-0003Yy-UR for submit@debbugs.gnu.org; Sun, 24 Nov 2013 09:13:16 -0500 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:38225) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkaQt-0003Yu-RW for submit@debbugs.gnu.org; Sun, 24 Nov 2013 09:13:07 -0500 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42972) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkaQn-0001J8-Q2 for bug-gnu-emacs@gnu.org; Sun, 24 Nov 2013 09:13:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1VkaQh-0003WY-8R for bug-gnu-emacs@gnu.org; Sun, 24 Nov 2013 09:13:01 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49023) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1VkaQh-0003WT-0K for bug-gnu-emacs@gnu.org; Sun, 24 Nov 2013 09:12:55 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAOECriM019549 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Sun, 24 Nov 2013 09:12:54 -0500 Received: from dhcp-193-97.nrt.redhat.com (ovpn-116-17.sin2.redhat.com [10.67.116.17]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id rAOECmDO021656 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) for ; Sun, 24 Nov 2013 09:12:52 -0500 User-agent: mu4e 0.9.9.6pre2; emacs 24.3.50.2 From: Kenjiro NAKAYAMA To: bug-gnu-emacs@gnu.org Subject: 24.3.50; [PATCH] eww: ask confirmation before quitting Date: Sun, 24 Nov 2013 23:12:47 +0900 Message-ID: <87hab1riqo.fsf@dhcp-193-97.nrt.redhat.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sun, 24 Nov 2013 10:38:11 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) eww should ask "yes or no" before quitting, since only "q" key to quit is easy to mistake. Signed-off-by: Kenjiro NAKAYAMA * net/eww.el (eww-quit): ask confirmation before quitting eww --- lisp/net/eww.el | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lisp/net/eww.el b/lisp/net/eww.el index 86e0977..265f6c8 100644 --- a/lisp/net/eww.el +++ b/lisp/net/eww.el @@ -403,8 +403,10 @@ word(s) will be searched for via `eww-search-prefix'." (defun eww-quit () "Exit the Emacs Web Wowser." (interactive) - (setq eww-history nil) - (kill-buffer (current-buffer))) + (if (y-or-n-p "quit eww? ") + (progn + (setq eww-history nil) + (kill-buffer (current-buffer))))) (defun eww-back-url () "Go to the previously displayed page." -- 1.8.3.1 ------------=_1385496606-29356-1-- From unknown Sat Aug 16 21:17:45 2025 X-Loop: help-debbugs@gnu.org Subject: bug#15965: 24.3.50; [PATCH] eww: ask confirmation before quitting Resent-From: Lars Magne Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Dec 2013 14:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15965 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Kenjiro NAKAYAMA Cc: 15965@debbugs.gnu.org Received: via spool by 15965-submit@debbugs.gnu.org id=B15965.13859076793317 (code B ref 15965); Sun, 01 Dec 2013 14:22:02 +0000 Received: (at 15965) by debbugs.gnu.org; 1 Dec 2013 14:21:19 +0000 Received: from localhost ([127.0.0.1]:52780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vn7te-0000rR-Qt for submit@debbugs.gnu.org; Sun, 01 Dec 2013 09:21:19 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:52325) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vn7tc-0000rH-Bf for 15965@debbugs.gnu.org; Sun, 01 Dec 2013 09:21:16 -0500 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1Vn7tP-00033J-0z; Sun, 01 Dec 2013 15:21:03 +0100 From: Lars Magne Ingebrigtsen References: <87hab1riqo.fsf@dhcp-193-97.nrt.redhat.com> X-Now-Playing: The Knife's _Silent Shout_: "From Off to On" X-Hashcash: 1:23:131201:knakayam@redhat.com::QOF99EAIWGFTiVzs:000000000000000000000000000000000000000000AwVH X-Hashcash: 1:23:131201:15965@debbugs.gnu.org::8isykayjYKh7yynN:0000000000000000000000000000000000000000LMVQ Date: Sun, 01 Dec 2013 15:21:02 +0100 In-Reply-To: <87hab1riqo.fsf@dhcp-193-97.nrt.redhat.com> (Kenjiro NAKAYAMA's message of "Sun, 24 Nov 2013 23:12:47 +0900") Message-ID: User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1Vn7tP-00033J-0z X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1386512463.13067@RlhuAbrtNsze9nGNxQIlJg X-Spam-Status: No X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Kenjiro NAKAYAMA writes: > eww should ask "yes or no" before quitting, since only "q" key to quit is > easy to mistake. > > Signed-off-by: Kenjiro NAKAYAMA > > * net/eww.el (eww-quit): ask confirmation before quitting eww After some discussion on emacs-devel, this patch has been reverted. Special mode buffers (like dired and eww) shouldn't query the user before exiting. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no