GNU bug report logs - #15961
24.3.50; display-buffer-at-bottom not at bottom

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 15961 in the body.
You can then email your comments to 15961 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.3.50; display-buffer-at-bottom not at bottom
Date: Sun, 24 Nov 2013 01:39:47 +0200

This bug report is followup from
http://lists.gnu.org/archive/html/emacs-devel/2013-11/msg00773.html

In emacs -Q that is wide enough to contain two side-by-side windows
in the *scratch* buffer evaluate:

(add-to-list 'display-buffer-alist '("\\*Completions\\*" display-buffer-at-bottom (nil)))

(display-buffer (get-buffer-create "*Completions*"))

The *Completions* window is displayed to the right from the *scratch* window,
not below.

Message #8 received at 15961 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Juri Linkov <juri <at> jurta.org>
Cc: 15961 <at> debbugs.gnu.org
Subject: Re: bug#15961: 24.3.50; display-buffer-at-bottom not at bottom
Date: Sun, 24 Nov 2013 11:10:56 +0100

> In emacs -Q that is wide enough to contain two side-by-side windows
> in the *scratch* buffer evaluate:
>
> (add-to-list 'display-buffer-alist '("\\*Completions\\*" display-buffer-at-bottom (nil)))
>
> (display-buffer (get-buffer-create "*Completions*"))
>
> The *Completions* window is displayed to the right from the *scratch* window,
> not below.

Strictly spoken, the new window also appears at the bottom of the frame ;-)

An obvious solution to do what you mean is to bind
`split-width-threshold' to nil in `display-buffer-at-bottom' as

	     (let (split-width-threshold)
	       (setq window (window--try-to-split-window bottom-window alist)))

But this should be better done _around_ calling `display-buffer'.  There
an application should also bind `split-height-threshold' and
`window-min-height' appropriately as well as a specify a `window-height'
alist entry.  Otherwise, Emacs will often refuse to make a new window
which is probably not what we want when displaying *Completions*.

martin

Message #11 received at 15961 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Juri Linkov <juri <at> jurta.org>, 15961 <at> debbugs.gnu.org
Subject: Re: bug#15961: 24.3.50; display-buffer-at-bottom not at bottom
Date: Sun, 24 Nov 2013 11:42:20 -0500

> But this should be better done _around_ calling `display-buffer'.

I don't think so.  Those things should be overridable by the user in
display-buffer-alist, so at most they can be passed to display-buffer
via its ACTION argument.


        Stefan

Message #14 received at 15961 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Juri Linkov <juri <at> jurta.org>, 15961 <at> debbugs.gnu.org
Subject: Re: bug#15961: 24.3.50; display-buffer-at-bottom not at bottom
Date: Sun, 24 Nov 2013 18:35:24 +0100

>> But this should be better done _around_ calling `display-buffer'.
>
> I don't think so.  Those things should be overridable by the user in
> display-buffer-alist, so at most they can be passed to display-buffer
> via its ACTION argument.

If I bind `split-width-threshold' in `display-buffer-at-bottom', the
user won't be able to override it either.  So our user has only one
option - provide her own action that handles `split-width-threshold' in
an appropriate way.  And thus she will be able to handle the case where
`display-buffer-at-bottom' binds the variable and the case where the
application binds it.  Or am I missing something?

The underlying problem is IMO that we never made things like
`split-height-threshold' or `split-window-preferred-function' amenable
to `display-buffer-alist'.

martin

Message #17 received at 15961 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Juri Linkov <juri <at> jurta.org>, 15961 <at> debbugs.gnu.org
Subject: Re: bug#15961: 24.3.50; display-buffer-at-bottom not at bottom
Date: Sun, 24 Nov 2013 22:22:34 -0500

> If I bind `split-width-threshold' in `display-buffer-at-bottom', the
> user won't be able to override it either.

Of course, she can, because she can set her display-buffer-alist such
that she doesn't go through display-buffer-at-bottom but through another
function of her own choosing instead.

> The underlying problem is IMO that we never made things like
> `split-height-threshold' or `split-window-preferred-function' amenable
> to `display-buffer-alist'.

Agreed.


        Stefan

Message #20 received at 15961 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Juri Linkov <juri <at> jurta.org>, 15961 <at> debbugs.gnu.org
Subject: Re: bug#15961: 24.3.50; display-buffer-at-bottom not at bottom
Date: Mon, 25 Nov 2013 08:28:14 +0100

>> If I bind `split-width-threshold' in `display-buffer-at-bottom', the
>> user won't be able to override it either.
>
> Of course, she can, because she can set her display-buffer-alist such
> that she doesn't go through display-buffer-at-bottom but through another
> function of her own choosing instead.

So the only viable choice is to not set `split-width-threshold' anywhere
and tell the user that if she wants a window below via
`display-buffer-at-bottom' she has to customize `split-width-threshold'.

martin

Message #23 received at 15961 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Juri Linkov <juri <at> jurta.org>, 15961 <at> debbugs.gnu.org
Subject: Re: bug#15961: 24.3.50; display-buffer-at-bottom not at bottom
Date: Mon, 25 Nov 2013 10:01:41 -0500

> So the only viable choice is to not set `split-width-threshold' anywhere
> and tell the user that if she wants a window below via
> `display-buffer-at-bottom' she has to customize `split-width-threshold'.

I think we're miscommunicating.  I was pointing out that binding
split-width-threshold in display-buffer-at-bottom is OK because it can
still be overridden by the user.


        Stefan

Message #26 received at 15961 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Juri Linkov <juri <at> jurta.org>, 15961 <at> debbugs.gnu.org
Subject: Re: bug#15961: 24.3.50; display-buffer-at-bottom not at bottom
Date: Mon, 25 Nov 2013 17:42:01 +0100

> I think we're miscommunicating.  I was pointing out that binding
> split-width-threshold in display-buffer-at-bottom is OK because it can
> still be overridden by the user.

OK.  Committed as revision 115229 on trunk.

martin

Message #31 received at 15961-done <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> jurta.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 15961-done <at> debbugs.gnu.org
Subject: Re: bug#15961: 24.3.50; display-buffer-at-bottom not at bottom
Date: Thu, 28 Nov 2013 02:55:48 +0200

>> I think we're miscommunicating.  I was pointing out that binding
>> split-width-threshold in display-buffer-at-bottom is OK because it can
>> still be overridden by the user.
>
> OK.  Committed as revision 115229 on trunk.

Thank you.  I confirm that display-buffer-at-bottom works now
exactly like its name suggests in all window configurations.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.